[PATCH 7/9] drm/rockchip: dw_hdmi: allow including external phys

2018-02-05 Thread Heiko Stuebner
Some variants of the dw-hdmi on Rockchip socs use a separate phy block accessed via the generic phy framework, so allow them to be included if such a phy reference is found. Signed-off-by: Heiko Stuebner <he...@sntech.de> --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 10 ++

[PATCH 9/9] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-02-05 Thread Heiko Stuebner
The rk3328 uses an external hdmi phy from Innosilicon which uses the generic phy framework for access. Add the necessary data and the compatible for it. Signed-off-by: Heiko Stuebner <he...@sntech.de> --- .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 1 + drivers/gpu/drm/ro

[PATCH 8/9] drm/rockchip: dw_hdmi: store rockchip_hdmi reference in phy_data object

2018-02-05 Thread Heiko Stuebner
to how meson-hdmi does it for example. Signed-off-by: Heiko Stuebner <he...@sntech.de> --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/d

[PATCH 1/9] dt-bindings: add binding for Rockchip hdmi phy using an Innosilicon IP

2018-02-05 Thread Heiko Stuebner
From: Zheng Yang <zhengy...@rock-chips.com> The phy is used so far in two Rockchip socs the rk3228 and the rk3328. Signed-off-by: Zheng Yang <zhengy...@rock-chips.com> Signed-off-by: Heiko Stuebner <he...@sntech.de> --- .../bindings/phy/phy-rockchip-inno-hd

Re: [2/9] phy: add Rockchip Innosilicon hdmi phy

2018-02-09 Thread Heiko Stuebner
Am Freitag, 9. Februar 2018, 11:06:49 CET schrieb Andrzej Hajda: > On 09.02.2018 10:24, Heiko Stuebner wrote: > > Hi Martin, > > > > Am Montag, 5. Februar 2018, 22:32:08 CET schrieb Martin Cerveny: > >> On Mon, 5 Feb 2018, Heiko Stuebner wrote: > >>>

Re: [2/9] phy: add Rockchip Innosilicon hdmi phy

2018-02-09 Thread Heiko Stuebner
Hi Martin, Am Montag, 5. Februar 2018, 22:32:08 CET schrieb Martin Cerveny: > On Mon, 5 Feb 2018, Heiko Stuebner wrote: > > From: Zheng Yang <zhengy...@rock-chips.com> > > > > Add a driver for the Innosilicon hdmi phy used on rk3228/rk3229 > > and rk3328 socs

Re: [PATCH] drm/rockchip: Don't use spin_lock_irqsave in interrupt context

2018-02-10 Thread Heiko Stuebner
Hi Marc, Am Samstag, 10. Februar 2018, 15:35:01 CET schrieb Marc Zyngier: > The rockchip DRM driver is quite careful to disable interrupts > when taking a lock that is also taken in interrupt context, > which is a good thing. > > What is a bit over the top is to use spin_lock_irqsave when >

Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata

2018-02-15 Thread Heiko Stuebner
ips.com > Cc: he...@sntech.de > Acked-by: Neil Armstrong <narmstr...@baylibre.com> > Signed-off-by: Jernej Skrabec <jernej.skra...@siol.net> For the Rockchip-part Tested-by: Heiko Stuebner <he...@sntech.de> Acked-by: Heiko Stuebner <he...@sntech.de> _

Re: [PATCH v2 4/8] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching

2018-02-19 Thread Heiko Stuebner
Hi Robin, Am Montag, 19. Februar 2018, 12:43:11 CET schrieb Robin Murphy: > Hi Heiko, > > On 16/02/18 20:41, Heiko Stuebner wrote: > > So far we always encountered socs with 2 output crtcs needing the driver > > to tell the hdmi block which output to connect to. But ther

[PATCH v2 6/8] drm/rockchip: dw_hdmi: allow including external phys

2018-02-16 Thread Heiko Stuebner
Some variants of the dw-hdmi on Rockchip socs use a separate phy block accessed via the generic phy framework, so allow them to be included if such a phy reference is found. Signed-off-by: Heiko Stuebner <he...@sntech.de> --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 10 ++

[PATCH v2 2/8] phy: add Rockchip Innosilicon hdmi phy

2018-02-16 Thread Heiko Stuebner
From: Zheng Yang <zhengy...@rock-chips.com> Add a driver for the Innosilicon hdmi phy used on rk3228/rk3229 and rk3328 socs from Rockchip. Signed-off-by: Zheng Yang <zhengy...@rock-chips.com> Signed-off-by: Heiko Stuebner <he...@sntech.de> --- Patches 1+2 expected to go th

[PATCH v2 5/8] dt-bindings: allow optional phys in Rockchip dw_hdmi binding

2018-02-16 Thread Heiko Stuebner
Some newer Rockchip SoCs use an Innosilicon hdmiphy accessed via general mmio, so allow these to be referenced via the regular phy interfaces and therefore add optional phy-related properties to the binding. Signed-off-by: Heiko Stuebner <he...@sntech.de> --- Documentation/devicetree/bi

[PATCH v2 8/8] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-02-16 Thread Heiko Stuebner
The rk3328 uses an external hdmi phy from Innosilicon which uses the generic phy framework for access. Add the necessary data and the compatible for it. Signed-off-by: Heiko Stuebner <he...@sntech.de> --- .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 1 + drivers/gpu/drm/ro

[PATCH v2 1/8] dt-bindings: add binding for Rockchip hdmi phy using an Innosilicon IP

2018-02-16 Thread Heiko Stuebner
From: Zheng Yang <zhengy...@rock-chips.com> The phy is used so far in two Rockchip socs the rk3228 and the rk3328. Signed-off-by: Zheng Yang <zhengy...@rock-chips.com> Signed-off-by: Heiko Stuebner <he...@sntech.de> --- .../bindings/phy/phy-rockchip-inno-hd

[PATCH v2 7/8] drm/rockchip: dw_hdmi: store rockchip_hdmi reference in phy_data object

2018-02-16 Thread Heiko Stuebner
to how meson-hdmi does it for example. Signed-off-by: Heiko Stuebner <he...@sntech.de> --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/d

[PATCH v2 4/8] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching

2018-02-16 Thread Heiko Stuebner
-switching is necessary. Signed-off-by: Heiko Stuebner <he...@sntech.de> --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index 3574b0

Re: [PATCH v2 1/8] dt-bindings: add binding for Rockchip hdmi phy using an Innosilicon IP

2018-02-16 Thread Heiko Stuebner
Am Freitag, 16. Februar 2018, 21:41:51 CET schrieb Heiko Stuebner: > From: Zheng Yang <zhengy...@rock-chips.com> > > The phy is used so far in two Rockchip socs the rk3228 and the rk3328. > > Signed-off-by: Zheng Yang <zhengy...@rock-chips.com> > Signed-off-by: H

[PATCH v2 3/8] drm/bridge: dw-hdmi: allow overriding of phy-type reading

2018-02-16 Thread Heiko Stuebner
-off-by: Heiko Stuebner <he...@sntech.de> --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 +++- include/drm/bridge/dw_hdmi.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

[PATCH v2 0/8] drm/rockchip: hdmi support for rk3328

2018-02-16 Thread Heiko Stuebner
patch exporting some dw-hdmi phy functions as a similar patch entered drm-misc already Heiko Stuebner (6): drm/bridge: dw-hdmi: allow overriding of phy-type reading drm/rockchip: dw_hdmi: Allow outputs that don't need output switching dt-bindings: allow optional phys in Rockchip dw_hdmi binding

Re: [PATCH v2 3/8] drm/bridge: dw-hdmi: allow overriding of phy-type reading

2018-02-21 Thread Heiko Stuebner
Hi Laurent, Am Montag, 19. Februar 2018, 20:06:40 CET schrieb Laurent Pinchart: > On Monday, 19 February 2018 20:46:46 EET Heiko Stuebner wrote: > > Am Montag, 19. Februar 2018, 17:59:02 CET schrieb Laurent Pinchart: > > > On Friday, 16 February 2018 22:41:53 EET He

Re: [PATCH v5] drm/rockchip: Add device links for master and components

2018-02-18 Thread Heiko Stuebner
t; the suspend/resume and shutdown ordering. > > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> > Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> looks good to me right now. So if anybody else wants to apply it, Reviewed-by: Heiko Stuebner <he...@sntec

Re: [PATCH 4/7] drm/rockchip: inno_hdmi: Remove unnecessary platform_get_resource() error check

2018-02-18 Thread Heiko Stuebner
Am Montag, 18. Dezember 2017, 14:02:27 CET schrieb Fabio Estevam: > From: Fabio Estevam > > devm_ioremap_resource() already checks if the resource is NULL, so > remove the unnecessary platform_get_resource() error check. > > Cc: Heiko Stübner >

Re: [PATCH 3/7] drm/rockchip: dsi: Remove unnecessary platform_get_resource() error check

2018-02-18 Thread Heiko Stuebner
Am Montag, 18. Dezember 2017, 14:02:26 CET schrieb Fabio Estevam: > From: Fabio Estevam > > devm_ioremap_resource() already checks if the resource is NULL, so > remove the unnecessary platform_get_resource() error check. > > Cc: Heiko Stübner >

Re: [PATCH v3 01/43] drm/rockchip: Get rid of unnecessary struct fields

2018-02-18 Thread Heiko Stuebner
Am Dienstag, 30. Januar 2018, 21:28:31 CET schrieb Thierry Escande: > From: Tomasz Figa > > This patch removes unused fields from vop structure. > > Signed-off-by: Tomasz Figa > Signed-off-by: Sean Paul > Signed-off-by: Thierry

Re: [PATCH v3 02/43] drm/rockchip: support prime import sg table

2018-02-18 Thread Heiko Stuebner
(e.g. zero-copy video decode, camera). > > Signed-off-by: Haixia Shi <h...@chromium.org> > Signed-off-by: Sean Paul <seanp...@chromium.org> > Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> > Tested-by: Heiko Stuebner

Re: [PATCH v3 03/43] drm/rockchip: Respect page offset for PRIME mmap calls

2018-02-18 Thread Heiko Stuebner
t the PRIME path > retains the original offset. > > Cc: Daniel Kurtz <djku...@chromium.org> > Signed-off-by: Ørjan Eide <orjan.e...@arm.com> > Signed-off-by: Tomasz Figa <tf...@chromium.org> > Signed-off-by: Sean Paul <seanp...@chromium.org> > Signed-off

Re: [PATCH v2 3/8] drm/bridge: dw-hdmi: allow overriding of phy-type reading

2018-02-19 Thread Heiko Stuebner
Hi Laurent, Am Montag, 19. Februar 2018, 17:59:02 CET schrieb Laurent Pinchart: > On Friday, 16 February 2018 22:41:53 EET Heiko Stuebner wrote: > > In some IP implementations the reading of the phy-type may be broken. > > One example are the Rockchip rk3228 and rk3328 socs that

Re: [PATCH v2 8/8] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-02-19 Thread Heiko Stuebner
Hi Rob, Am Montag, 19. Februar 2018, 21:28:53 CET schrieb Rob Herring: > On Fri, Feb 16, 2018 at 09:41:58PM +0100, Heiko Stuebner wrote: > > The rk3328 uses an external hdmi phy from Innosilicon which uses > > the generic phy framework for access. Add the necessary data > &g

Re: [PATCH] drm/rockchip: Convert drm_atomic_helper_suspend/resume()

2018-08-01 Thread Heiko Stuebner
Am Mittwoch, 1. August 2018, 15:14:24 CEST schrieb Souptick Joarder: > On Wed, Aug 1, 2018 at 6:40 PM, Heiko Stuebner wrote: > > Am Mittwoch, 1. August 2018, 14:43:47 CEST schrieb Souptick Joarder: > >> On Wed, Aug 1, 2018 at 6:03 PM, Heiko Stuebner wrote: > >> >

Re: [PATCH 0/2] add support rockchip px30 VOP

2018-08-02 Thread Heiko Stuebner
Hi Sandy, Am Dienstag, 26. Juni 2018, 10:53:33 CEST schrieb Sandy Huang: > The following patches add support rockchip px30 VOP, there are two seperate > VOP we call VOP big and VOP lite. > > vop big support win0,win1 and win2; > vop lit support win1(same with vop big win1); > > the max input

Re: [PATCH] drm/rockchip: Convert drm_atomic_helper_suspend/resume()

2018-08-01 Thread Heiko Stuebner
Hi Souptick, Am Dienstag, 31. Juli 2018, 22:34:30 CEST schrieb Souptick Joarder: > convert drm_atomic_helper_suspend/resume() to use > drm_mode_config_helper_suspend/resume(). > > With this conversion, rockchip_drm_fb_resume() and > rockchip_drm_fb_suspend() will not be used anymore. > Both of

Re: [PATCH] drm/rockchip: Convert drm_atomic_helper_suspend/resume()

2018-08-01 Thread Heiko Stuebner
Am Mittwoch, 1. August 2018, 14:43:47 CEST schrieb Souptick Joarder: > On Wed, Aug 1, 2018 at 6:03 PM, Heiko Stuebner wrote: > > Hi Souptick, > > > > Am Dienstag, 31. Juli 2018, 22:34:30 CEST schrieb Souptick Joarder: > >> convert drm_atomic_

Re: [PATCH v3 3/8] drm/bridge/synopsys: dsi: add ability to check dsi-device attachment

2018-08-14 Thread Heiko Stuebner
Hi Andrzej, Am Montag, 13. August 2018, 12:23:21 CEST schrieb Andrzej Hajda: > On 13.08.2018 10:44, Heiko Stuebner wrote: > > Am Montag, 13. August 2018, 10:28:39 CEST schrieb Andrzej Hajda: > >> On 09.07.2018 15:48, Heiko Stuebner wrote: > >>> +bool dw_mipi_dsi_devi

[PATCH v4 8/8] drm/rockchip: dsi: add dual mipi support

2018-08-14 Thread Heiko Stuebner
to determine the dual-dsi state and get access to both controller instances. Signed-off-by: Heiko Stuebner v4: add component directly in probe when adding empty dsi slave controller --- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 93 +++ drivers/gpu/drm/rockchip

[PATCH v4 7/8] drm/bridge/synopsys: dsi: add dual-dsi support

2018-08-14 Thread Heiko Stuebner
settings - disable slave before master - lane-sum calculation comments Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner Tested-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 80 +-- include/drm/bridge/dw_mipi_dsi.h | 1 + 2 files

[PATCH v4 2/8] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind

2018-08-14 Thread Heiko Stuebner
dw_mipi_dsi instead of the platform-device. Signed-off-by: Heiko Stuebner Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 15 +++ include/drm/bridge/dw_mipi_dsi.h | 5 + 2 files changed, 4 insertions(+), 16 deletions(-) diff --git

[PATCH v4 0/8] drm/rockchip: migrate to common dw-mipi-dsi bridge and dual-dsi

2018-08-14 Thread Heiko Stuebner
- kept dual-dsi handling that mimicks tegra Heiko Stuebner (5): drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind drm/bridge/synopsys: dsi: add ability to have glue-specific

[PATCH v4 6/8] drm/dsi: add helper function to find the second host in a dual-dsi setup

2018-08-14 Thread Heiko Stuebner
From a specified output port of one dsi controller this function allows to iterate over the list of registered dsi controllers trying to find a second instance connected to the same display, like it is used in dual-dsi setups. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/drm_mipi_dsi.c

[PATCH v4 5/8] drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver

2018-08-14 Thread Heiko Stuebner
changes move to call component_add in the new glue host-attach Signed-off-by: Nickey Yang Signed-off-by: Brian Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul Reviewed-by: Archit Taneja Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/Kconfig |2 +- drivers/

[PATCH v4 3/8] drm/bridge/synopsys: dsi: add ability to have glue-specific attach and detach

2018-08-14 Thread Heiko Stuebner
drivers, add a new struct for host_ops so that glue drivers can tell the bridge to call specific functions after the common host-attach and before the common host-detach run. Suggested-by: Andrzej Hajda Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 15

[PATCH v4 1/8] drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove

2018-08-14 Thread Heiko Stuebner
-by: Heiko Stuebner Reviewed-by: Andrzej Hajda Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge

[PATCH v4 4/8] dt-bindings: display: rockchip: update DSI controller

2018-08-14 Thread Heiko Stuebner
Herring Signed-off-by: Heiko Stuebner --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display

[PATCH] drm/panel: p079zca: unconditionally remove the panel on removal

2018-08-16 Thread Heiko Stuebner
There is no need to check innolux->base.dev when trying to remove the panel, as that variable is always set directly before the panel gets added and will still be available on panel_remove. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 3 +-- 1 file chan

[PATCH v3] drm/panel: add Kingdisplay kd097d04 panel driver

2018-08-16 Thread Heiko Stuebner
cking seems something all panels do - document origins of the init sequence - lanes per dsi interface to 4 (two interfaces). Matches how tegra and pending rockchip dual-dsi handle (dual-)dsi lanes - spdx header instead of license boilerplate Signed-off-by: Nickey Yang Signed-off-by: Heiko Stu

[PATCH v4] drm/panel: add Kingdisplay kd097d04 panel driver

2018-08-17 Thread Heiko Stuebner
r dsi interface to 4 (two interfaces). Matches how tegra and pending rockchip dual-dsi handle (dual-)dsi lanes - spdx header instead of license boilerplate Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Mak

Re: [PATCH] drm/rockchip: update cursors asynchronously through atomic.

2018-08-13 Thread Heiko Stuebner
Am Montag, 13. August 2018, 09:11:07 CEST schrieb Tomasz Figa: > Hi Enric, > > On Tue, Aug 7, 2018 at 12:53 AM Enric Balletbo i Serra > wrote: > > > > Add support to async updates of cursors by using the new atomic > > interface for that. > > > > Signed-off-by: Enric Balletbo i Serra > > --- >

Re: [PATCH v3 3/8] drm/bridge/synopsys: dsi: add ability to check dsi-device attachment

2018-08-13 Thread Heiko Stuebner
Hi Andrzej, Am Montag, 13. August 2018, 10:28:39 CEST schrieb Andrzej Hajda: > On 09.07.2018 15:48, Heiko Stuebner wrote: > > When the panel-driver is build as a module it currently fails hard as the > > panel cannot be probed directly: > > > > dw_mipi_dsi_bind(

Re: [PATCH v3] backlight: pwm_bl: switch to using "atomic" PWM API

2018-08-21 Thread Heiko Stuebner
xes a potential bug where pwm_get_state > can be called before pwm_init_state. > > Signed-off-by: Enric Balletbo i Serra On a Rockchip rk3399-scarlet tablet Tested-by: Heiko Stuebner This patch also _fixes_ the kernel bug below. Scarlet is not yet submitted upstream, but when I remove

Re: [PATCH v4 3/8] drm/bridge/synopsys: dsi: add ability to have glue-specific attach and detach

2018-08-21 Thread Heiko Stuebner
Hi, Am Montag, 20. August 2018, 12:34:37 CEST schrieb Andrzej Hajda: > On 14.08.2018 12:26, Heiko Stuebner wrote: > > With the regular means of adding the dsi-component in probe it creates > > a race condition with the panel probing, as the panel device only gets > > created

[PATCH v5 3/7] drm/bridge/synopsys: dsi: add ability to have glue-specific attach and detach

2018-08-21 Thread Heiko Stuebner
drivers, add a new struct for host_ops so that glue drivers can tell the bridge to call specific functions after the common host-attach and before the common host-detach run. Suggested-by: Andrzej Hajda Reviewed-by: Andrzej Hajda Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw

Re: [PATCH v4 6/8] drm/dsi: add helper function to find the second host in a dual-dsi setup

2018-08-21 Thread Heiko Stuebner
Hi Andrzej, Am Montag, 20. August 2018, 13:37:24 CEST schrieb Andrzej Hajda: > On 14.08.2018 12:26, Heiko Stuebner wrote: > > >From a specified output port of one dsi controller this function allows to > > iterate over the list of registered dsi controllers trying to find a s

[PATCH v5 7/7] drm/rockchip: dsi: add dual mipi support

2018-08-21 Thread Heiko Stuebner
to determine the dual-dsi state and get access to both controller instances. Signed-off-by: Heiko Stuebner v4: add component directly in probe when adding empty dsi slave controller v5: use driver-internal mechanism to find dual dsi slave --- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 105

[PATCH v5 1/7] drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove

2018-08-21 Thread Heiko Stuebner
-by: Heiko Stuebner Reviewed-by: Andrzej Hajda Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge

[PATCH v5 2/7] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind

2018-08-21 Thread Heiko Stuebner
dw_mipi_dsi instead of the platform-device. Signed-off-by: Heiko Stuebner Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 15 +++ include/drm/bridge/dw_mipi_dsi.h | 5 + 2 files changed, 4 insertions(+), 16 deletions(-) diff --git

Re: [PATCH v5 2/2] drm/rockchip: Add support for Rockchip Soc RGB output interface

2018-08-28 Thread Heiko Stuebner
you are using. I see your reply to my mail, but I guess you didn't see the alternative approach I described a bit below in that mail? Actual (unfinished) code included below. (2 patches) Heiko 8< - From: Heiko Stuebner Date: Sat, 25 Aug 2018 19:05:21 +0200 Subject: [PATCH 1/2] drm/t

Re: [PATCH v4 1/2] devicetree/bindings: display: Add document for rockchip RGB output

2018-08-27 Thread Heiko Stuebner
Hi Sandy, trying to move this forward a bit :-) Am Mittwoch, 4. Juli 2018, 14:09:56 CEST schrieb Sandy Huang: > Hi Rob Herring, > Thanks for your review. > > 在 2018/7/4 2:25, Rob Herring 写道: > > On Tue, Jun 26, 2018 at 03:15:39PM +0800, Sandy Huang wrote: > >> This path add support rv1108 and

[PATCH v5 5/7] drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver

2018-08-21 Thread Heiko Stuebner
changes move to call component_add in the new glue host-attach Signed-off-by: Nickey Yang Signed-off-by: Brian Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul Reviewed-by: Archit Taneja Reviewed-by: Andrzej Hajda Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/

[PATCH v5 4/7] dt-bindings: display: rockchip: update DSI controller

2018-08-21 Thread Heiko Stuebner
Herring Signed-off-by: Heiko Stuebner --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display

[PATCH v5 6/7] drm/bridge/synopsys: dsi: add dual-dsi support

2018-08-21 Thread Heiko Stuebner
settings - disable slave before master - lane-sum calculation comments Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner Tested-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 80 +-- include/drm/bridge/dw_mipi_dsi.h | 1 + 2 files

[PATCH v5 0/8] drm/rockchip: migrate to common dw-mipi-dsi bridge and dual-dsi

2018-08-21 Thread Heiko Stuebner
m glue drivers - kept dual-dsi handling that mimicks tegra Heiko Stuebner (4): drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind drm/bridge/synopsys: dsi: add ability to hav

Re: [PATCH] drm/rockchip: Use struct_size() in devm_kzalloc()

2018-08-29 Thread Heiko Stuebner
Am Sonntag, 26. August 2018, 20:47:12 CEST schrieb Gustavo A. R. Silva: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > >

Re: [PATCH] drm/rockchip: vop: fix some register define error for px30

2018-08-29 Thread Heiko Stuebner
Am Dienstag, 28. August 2018, 10:32:30 CEST schrieb Sandy Huang: > 1. interrupt register define error lead to enable interrupt failed; > 2. px30 unsupport hdmi output; > 3. there are some hardware designed bug, we must swap win2 gate and >enable offset, otherwise will appear vop iommu

Re: [PATCH v5 1/2] devicetree/bindings: display: Add document for rockchip RGB output

2018-08-29 Thread Heiko Stuebner
Hi Michal, Am Dienstag, 28. August 2018, 10:31:15 CEST schrieb Michal Vokáč: > On 28.8.2018 10:12, Sandy Huang wrote: > > This path add support rv1108 and px30 rgb output interface driver. > > Hi Sandy, > Seems like you forgot to address Rob's comment regarding the "driver" word. > Also fix the

Re: [PATCH v2] drm/rockchip: fix coding style and incorrect description

2018-08-29 Thread Heiko Stuebner
Am Dienstag, 28. August 2018, 09:44:55 CEST schrieb Sandy Huang: > Align with other drivers, tab + 2 space key for description. > and edp/hdmi/dsi can be used on both rk3288 and rk3399. > > Signed-off-by: Sandy Huang applied to drm-misc ___

Re: [PATCH] drm/rockchip: Replace drm_dev_unref with drm_dev_put

2018-07-23 Thread Heiko Stuebner
Hi Thomas, Am Dienstag, 17. Juli 2018, 13:09:27 CEST schrieb Thomas Zimmermann: > This patch unifies the naming of DRM functions for reference counting > of struct drm_device. The resulting code is more aligned with the rest > of the Linux kernel interfaces. > > Signed-off-by: Thomas Zimmermann

[PATCH v8 2/3] drm/rockchip: Add support for Rockchip Soc RGB output interface

2018-08-30 Thread Heiko Stuebner
panels. Changes in v7: 1. forget to delete rockchip_rgb_driver and delete it. Changes in v6: 1. Update according to Heiko Stuebner' implemention, rgb output is part of vop's feature, should not register as a independent driver. Changes in v5: 1. add SPDX-License-Identifier tag

[PATCH v8 0/3] Add support rockchip RGB output interface

2018-08-30 Thread Heiko Stuebner
. So if you have time, please take a final look at it. Thanks Heiko Heiko Stuebner (1): drm/rockchip: add function to check if endpoint is a subdriver Sandy Huang (2): drm/rockchip: Add support for Rockchip Soc RGB output interface drm/rockchip: Add directly output rgb feature for px30

[PATCH v8 1/3] drm/rockchip: add function to check if endpoint is a subdriver

2018-08-30 Thread Heiko Stuebner
to check subdriver vs. bridge Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 48 + drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + 2 files changed, 49 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm

[PATCH v8 3/3] drm/rockchip: Add directly output rgb feature for px30

2018-08-30 Thread Heiko Stuebner
From: Sandy Huang Add this feature bit indicate px30 vop can directly output parallel or serial rgb data. Signed-off-by: Sandy Huang Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/rockchip

[PATCH] drm/rockchip: rgb: add stub functions when rgb encoder is disabled

2018-09-05 Thread Heiko Stuebner
The newly added internal rgb encoder for Rockchip vops is missing stubs for the case that the rgb output part is not enabled in the kernel config. So add these. Fixes: 1f0f01515172 ("drm/rockchip: Add support for Rockchip Soc RGB output interface") Signed-off-by: Heiko Stuebner --- d

Re: [PATCH] drm: Update todo.rst

2018-09-06 Thread Heiko Stuebner
Padovan > Cc: Maarten Lankhorst > Cc: Sean Paul > Cc: David Airlie I've read through the text changes and didn't spot any glaring typos [beware non-native speaker], so fwiw Reviewed-by: Heiko Stuebner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 5/7] drm/atomic: trim driver interface/docs

2018-09-06 Thread Heiko Stuebner
a forward decl. > > Signed-off-by: Daniel Vetter > Cc: David Airlie > Cc: Gustavo Padovan > Cc: Maarten Lankhorst > Cc: Sean Paul checked that the two moved functions keep identical content from old to new location, so Acked-by: Heiko Stuebner

[PATCH v4 2/6] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching

2018-09-10 Thread Heiko Stuebner
-switching is necessary. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy changes in v3: - fixed wording issue found by Robin Murphy --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

[PATCH v4 4/6] drm/rockchip: dw_hdmi: allow including external phys

2018-09-10 Thread Heiko Stuebner
Some variants of the dw-hdmi on Rockchip socs use a separate phy block accessed via the generic phy framework, so allow them to be included if such a phy reference is found. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 10 ++ 1

[PATCH v4 3/6] dt-bindings: allow optional phys in Rockchip dw_hdmi binding

2018-09-10 Thread Heiko Stuebner
Some newer Rockchip SoCs use an Innosilicon hdmiphy accessed via general mmio, so allow these to be referenced via the regular phy interfaces and therefore add optional phy-related properties to the binding. Signed-off-by: Heiko Stuebner Reviewed-by: Rob Herring --- .../devicetree/bindings

[PATCH v4 5/6] drm/rockchip: dw_hdmi: store rockchip_hdmi reference in phy_data object

2018-09-10 Thread Heiko Stuebner
and use this reference later on. Inspiration for this comes from meson and sunxi dw-hdmi, which are using the same method. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy changes in v3: - reword commit message --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 9 +++-- 1 file changed, 7

[PATCH v4 0/6] drm/rockchip: hdmi support for rk3328

2018-09-10 Thread Heiko Stuebner
Heiko Stuebner (6): drm/bridge: dw-hdmi: allow forcing vendor phy-type drm/rockchip: dw_hdmi: Allow outputs that don't need output switching dt-bindings: allow optional phys in Rockchip dw_hdmi binding drm/rockchip: dw_hdmi: allow including external phys drm/rockchip: dw_hdmi: store

[PATCH v4 6/6] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-09-10 Thread Heiko Stuebner
The rk3328 uses a dw-hdmi controller with an external hdmi phy from Innosilicon which uses the generic phy framework for access. Add the necessary data and the compatible for the rk3328 to the rockchip dw-hdmi driver. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy Acked-by: Rob Herring

[PATCH v4 1/6] drm/bridge: dw-hdmi: allow forcing vendor phy-type

2018-09-10 Thread Heiko Stuebner
it may be necessary to allow forcing other types, but for now we'll keep it simply to the case actually seen in the wild. changes in v3: - only allow forcing vendor type, as suggested by Laurent Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4

Re: [PATCH] drm/rockchip: Allow driver to be shutdown on reboot/kexec

2018-09-10 Thread Heiko Stuebner
Am Sonntag, 5. August 2018, 14:48:07 CEST schrieb Marc Zyngier: > Leaving the DRM driver enabled on reboot or kexec has the annoying > effect of leaving the display generating transactions whilst the > IOMMU has been shut down. > > In turn, the IOMMU driver (which shares its interrupt line with >

Re: [PATCH] drm/rockchip: vop: add rk3188 vop definitions

2018-09-05 Thread Heiko Stuebner
Am Donnerstag, 30. August 2018, 13:09:37 CEST schrieb Heiko Stuebner: > The rk3188 has 2 vops not using iommus which only output directly > to a rgb interface per vop. So all other output modes like hdmi > are provided by external brige chips. > > Signed-off-by: Heiko Stuebner

Re: [PATCH v8 0/3] Add support rockchip RGB output interface

2018-09-05 Thread Heiko Stuebner
Am Donnerstag, 30. August 2018, 23:12:04 CEST schrieb Heiko Stuebner: > This patches add support rockchip RGB output, Some Rockchip CRTCs, like > rv1108 and px30 can directly output parallel and serial RGB data to panel > or to conversion chip. > So add a feature-bit for vops to mark

Re: [PATCH v7 0/3] Add support rockchip RGB output interface

2018-08-30 Thread Heiko Stuebner
Am Mittwoch, 29. August 2018, 05:12:41 CEST schrieb Sandy Huang: > This patches add support rockchip RGB output, Some Rockchip CRTCs, like > rv1108 and px30 can directly output parallel and serial RGB data to panel > or to conversion chip. > So add a feature-bit for vops to mark the ability for

[PATCH] drm/rockchip: vop: add rk3188 vop definitions

2018-08-30 Thread Heiko Stuebner
The rk3188 has 2 vops not using iommus which only output directly to a rgb interface per vop. So all other output modes like hdmi are provided by external brige chips. Signed-off-by: Heiko Stuebner --- This depends on Sandy's + mine recent series enabling direct rgb outputs of specific vops

Re: [PATCH v2 3/8] drm/bridge/synopsys: dsi: defer probing if panel not available in bridge-attach

2018-07-04 Thread Heiko Stuebner
Am Dienstag, 3. Juli 2018, 14:42:49 CEST schrieb Andrzej Hajda: > On 18.06.2018 12:28, Heiko Stuebner wrote: > > When the panel-driver is build as a module it currently fails hard as the > > panel cannot be probed directly: > > > > dw_mipi_dsi_bind() > > __dw_mip

Re: [PATCH v2 2/8] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind

2018-07-04 Thread Heiko Stuebner
Am Dienstag, 3. Juli 2018, 14:16:28 CEST schrieb Andrzej Hajda: > On 18.06.2018 12:28, Heiko Stuebner wrote: > > __dw_mipi_dsi_probe() does all the grabbing of resources and does it using > > devm-helpers. So this is happening on each try of master bringup possibly > > slow

Re: [PATCH v2 6/8] drm/dsi: add helper function to find the second host in a dual-dsi setup

2018-07-04 Thread Heiko Stuebner
Am Dienstag, 3. Juli 2018, 17:06:48 CEST schrieb Andrzej Hajda: > On 18.06.2018 12:28, Heiko Stuebner wrote: > > >From a specified output port of one dsi controller this function allows to > > iterate over the list of registered dsi controllers trying to find a second >

Re: [PATCH] drm/panel: innolux-p079zca: Use of_device_get_match_data()

2018-07-10 Thread Heiko Stuebner
Am Dienstag, 10. Juli 2018, 13:01:27 CEST schrieb Thierry Reding: > From: Thierry Reding > > Use this helper to get rid of some extra boilerplate code. > > Signed-off-by: Thierry Reding Reviewed-by: Heiko Stuebner ___ dri-devel m

[PATCH v3 6/8] drm/dsi: add helper function to find the second host in a dual-dsi setup

2018-07-09 Thread Heiko Stuebner
From a specified output port of one dsi controller this function allows to iterate over the list of registered dsi controllers trying to find a second instance connected to the same display, like it is used in dual-dsi setups. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/drm_mipi_dsi.c

[PATCH v3 5/8] drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver

2018-07-09 Thread Heiko Stuebner
Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul Reviewed-by: Archit Taneja Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/Kconfig |2 +- drivers/gpu/drm/rockchip/Makefile |2 +- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 933

[PATCH v3 3/8] drm/bridge/synopsys: dsi: add ability to check dsi-device attachment

2018-07-09 Thread Heiko Stuebner
if a dsi device was actually attached and also protects the attach part to prevent concurrency issues from panel-assignment and drm_bridge_create. Using that check glue drivers are able to for example defer probe/bind in the case that the panel is not completely set up yet. Signed-off-by: Heiko

[PATCH v3 0/8] drm/rockchip: migrate to common dw-mipi-dsi bridge and dual-dsi

2018-07-09 Thread Heiko Stuebner
purposes it is possible to just pick half the series (till patch 5) to get the migration to the bridge driver first, so that we can get rid of the dw-dsi copy in the Rockchip driver. But of course Acks / Reviews of the dsi-bridge changes would be needed. [0] https://patchwork.kernel.org/patch/1017

[PATCH v3 4/8] dt-bindings: display: rockchip: update DSI controller

2018-07-09 Thread Heiko Stuebner
Herring Signed-off-by: Heiko Stuebner --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display

[PATCH v3 1/8] drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove

2018-07-09 Thread Heiko Stuebner
-by: Heiko Stuebner Reviewed-by: Andrzej Hajda Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge

[PATCH v3 2/8] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind

2018-07-09 Thread Heiko Stuebner
dw_mipi_dsi instead of the platform-device. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 15 +++ include/drm/bridge/dw_mipi_dsi.h | 5 + 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw

[PATCH v3 7/8] drm/bridge/synopsys: dsi: add dual-dsi support

2018-07-09 Thread Heiko Stuebner
settings - disable slave before master - lane-sum calculation comments Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner Tested-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 80 +-- include/drm/bridge/dw_mipi_dsi.h | 1 + 2 files

[PATCH v3 8/8] drm/rockchip: dsi: add dual mipi support

2018-07-09 Thread Heiko Stuebner
to determine the dual-dsi state and get access to both controller instances. Signed-off-by: Heiko Stuebner --- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 76 ++- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 + drivers/gpu

Re: [PATCH v2 7/8] drm/bridge/synopsys: dsi: add dual-dsi support

2018-07-09 Thread Heiko Stuebner
Am Dienstag, 3. Juli 2018, 19:07:02 CEST schrieb Andrzej Hajda: > On 18.06.2018 12:28, Heiko Stuebner wrote: > > From: Nickey Yang > > > > Allow to also drive a slave dw-mipi-dsi controller in a dual-dsi > > setup. This will require additional implementation-specific &g

[PATCH] drm/rockchip: analogix_dp: reorder psr_unregister call in unbind

2018-03-01 Thread Heiko Stuebner
scande <thierry.esca...@collabora.com> Signed-off-by: Heiko Stuebner <he...@sntech.de> --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/ro

Re: [PATCH v4 02/38] drm/rockchip: Don't use atomic constructs for psr

2018-03-08 Thread Heiko Stuebner
Am Montag, 5. März 2018, 23:22:54 CET schrieb Enric Balletbo i Serra: > From: Sean Paul > > Instead of using timer and spinlocks, use delayed_work and > mutexes for rockchip psr. This allows us to make blocking > calls when enabling/disabling psr (which is sort of

<    1   2   3   4   5   6   7   8   >