[PATCH v4 0/8] iommu/rockchip: Fix bugs and enable on ARM64

2016-06-21 Thread Tomasz Figa
rk_iommu_ops iommu/rockchip: Enable Rockchip IOMMU on ARM64 Tomasz Figa (1): drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 100 ++-- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 3 + drivers/gpu/drm/rockchip

[PATCH v4 1/8] iommu/rockchip: Fix devm_{request,free}_irq parameter

2016-06-21 Thread Tomasz Figa
ff-by: Simon Xue Signed-off-by: Shunqian Zheng Reviewed-on: https://chromium-review.googlesource.com/346325 Reviewed-by: Douglas Anderson Signed-off-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/rockchip-iomm

[PATCH v4 3/8] iommu/rockchip: Fix allocation of bases array in driver probe

2016-06-21 Thread Tomasz Figa
econstruct to support multi slaves") Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c index 53fa0d9..8a5ba

[PATCH v4 6/8] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

2016-06-21 Thread Tomasz Figa
not introduce any functional changes until the driver is made to attach subdevices into an IOMMU domain with the generic IOMMU API, which will happen in following patch. Based heavily on GEM implementation of Tegra DRM driver. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip

[PATCH v4 4/8] iommu/rockchip: Use DMA API to manage coherency

2016-06-21 Thread Tomasz Figa
, a simple platform device is registered for each allocated IOMMU domain. With this patch, this driver can be used on both ARM and ARM64 platforms, such as RK3288 and RK3399 respectively. Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 161

[PATCH v4 7/8] drm/rockchip: Use common IOMMU API to attach devices

2016-06-21 Thread Tomasz Figa
anymore and this patch wires things to use the new method. Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 100 +++- 1 file changed, 53 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/rockchip

[PATCH v4 8/8] iommu/rockchip: Enable Rockchip IOMMU on ARM64

2016-06-21 Thread Tomasz Figa
From: Simon Xue This patch makes it possible to compile the rockchip-iommu driver on ARM64, so that it can be used with 64-bit SoCs equipped with this type of IOMMU. Signed-off-by: Simon Xue Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/iommu/Kconfig | 2 +- 1 file

[PATCH v4 2/8] iommu/rockchip: Add map_sg callback for rk_iommu_ops

2016-06-21 Thread Tomasz Figa
-review.googlesource.com/346326 Reviewed-by: Douglas Anderson Signed-off-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c index 5a9659a..53fa0d9 100644 --- a/drivers/iommu/rockchip-iommu.c +++ b

[PATCH v4 5/8] iommu/rockchip: Prepare to support generic DMA mapping

2016-06-21 Thread Tomasz Figa
From: Shunqian Zheng Set geometry for allocated domains and fix .domain_alloc() callback to work with IOMMU_DOMAIN_DMA domain type, which is used for implicit domains on ARM64. Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 16

[PATCH v4 0/8] iommu/rockchip: Fix bugs and enable on ARM64

2016-06-21 Thread Tomasz Figa
Hi Joerg, On Tue, Jun 21, 2016 at 6:17 PM, Joerg Roedel wrote: > > On Tue, Jun 21, 2016 at 01:34:33PM +0900, Tomasz Figa wrote: > > This series intends mostly to enable support for ARM64 architecture > > in the rockchip-iommu driver. On the way to do so, some bugs are also >

next-20160707 build: 1 failures 6 warnings (next-20160707)

2016-07-07 Thread Tomasz Figa
Hi Mark, On Thu, Jul 7, 2016 at 9:22 PM, Mark Brown wrote: > On Thu, Jul 07, 2016 at 10:23:56AM +0100, Build bot for Mark Brown wrote: > > Today's -next fails to build an arm64 allmodconfig due to: > >> arm64-allmodconfig >> ../drivers/gpu/drm/rockchip/rockchip_drm_drv.c:17:27: fatal error:

[PATCH v3 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-13 Thread Tomasz Figa
On Tue, Jul 12, 2016 at 9:38 PM, Daniel Vetter wrote: > On Fri, Jul 01, 2016 at 02:00:00PM -0400, Sean Paul wrote: >> On Fri, Jul 1, 2016 at 5:19 AM, Yakir Yang wrote: >> > The PSR driver have exported four symbols for specific device driver: >> > - rockchip_drm_psr_register() >> > - rockchip_drm

[PATCH] drm/exynos: remove hardware overlays disable from fimd probe

2014-06-02 Thread Tomasz Figa
Hi Rahul, Andrzej, On 02.06.2014 11:42, Rahul Sharma wrote: > On 2 June 2014 14:41, Andrzej Hajda wrote: >> Hi Rahul, >> >> On 05/28/2014 08:11 AM, Rahul Sharma wrote: >>> System hangs when FIMD registers are accessed to disable >>> hardware overlays. This is because of the clocks which are >>> n

[PATCH] drm/exynos: dpi: Fix NULL pointer dereference with legacy bindings

2014-06-10 Thread Tomasz Figa
ces ctx->panel without a check, causing a NULL pointer derefrence. This patch fixes the issue by adding necessary NULL pointer check. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/

[PATCH] drm/exynos: dpi: Fix NULL pointer dereference with legacy bindings

2014-06-18 Thread Tomasz Figa
On 10.06.2014 22:57, Tomasz Figa wrote: > If there is no panel node in DT and instead display timings are provided > directly in FIMD node, there is no panel object created and ctx->panel > becomes NULL. However during Exynos DRM initialization > drm_helper_hpd_irq_event() is c

[PATCH V4 00/10] drm: exynos: few patches to enhance bridge chip support

2014-06-23 Thread Tomasz Figa
Hi Rahul, On 23.06.2014 15:58, Rahul Sharma wrote: > Hi Ajay, Inki, > > I tested this series for Exynos5420 based peach-pit board, > Exynos5800 based Peach-pi board and Exynos5250 based > Snow board. I verified with the chrome test environment and > able to see upto Login Screen. DPMS on/off func

Re: [PATCH] drm/exynos: Add check for IOMMU while passing physically continous memory flag

2013-08-01 Thread Tomasz Figa
Hi Vikas, On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote: > While trying to get boot-logo up on exynos5420 SMDK which has eDP panel > connected with resolution 2560x1600, following error occured even with > IOMMU enabled: > [0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to all

Re: [PATCH] drm/exynos: Add check for IOMMU while passing physically continous memory flag

2013-08-02 Thread Tomasz Figa
Hi Vikas, On Friday 02 of August 2013 12:08:52 Vikas Sajjan wrote: > Hi Rob, > > On 2 August 2013 06:03, Rob Clark wrote: > > On Thu, Aug 1, 2013 at 7:20 PM, Tomasz Figa wrote: > >> Hi Vikas, > >> > >> On Thursday 01 of August 2013 16:49:32 Vikas Sa

Re: [PATCH V2] drm/exynos: Add fallback option to get non physically continous memory for fb

2013-08-05 Thread Tomasz Figa
CONTIG > memory allocation fails. > > Signed-off-by: Vikas Sajjan > Signed-off-by: Arun Kumar > --- > changes since v1: >- Modified to add the fallback patch if CONTIG alloc fails as suggested > by Rob Clark robdcl...@gmail.com and Tomasz Figa > . > >

Re: [PATCHv2 1/5] drm/exynos: add device tree support for rotator

2013-08-09 Thread Tomasz Figa
Hi Chanho, On Friday 09 of August 2013 16:40:49 Chanho Park wrote: > The exynos4 platform is only dt-based since 3.10, we should convert > driver data and ids to dt-based parsing methods. The rotator driver has > a limit table to get size limit of input picture. Each SoCs has slightly > different

Re: [PATCHv2 2/5] ARM: dts: Add rotator node for exynos4210

2013-08-09 Thread Tomasz Figa
On Friday 09 of August 2013 16:40:50 Chanho Park wrote: > This patch adds a rotator node for exynos4210. The exynos4210 has > different limitation of image size compared with later chips. > > Signed-off-by: Chanho Park > Cc: Thomas Abraham > Cc: Kukjin Kim > Cc: Inki Dae > Signed-off-by: Kyung

Re: [PATCHv2 5/5] ARM: dts: Add dt binding documentation for exynos rotator

2013-08-09 Thread Tomasz Figa
Hi Chanho, On Friday 09 of August 2013 16:40:53 Chanho Park wrote: > This patch describes each nodes of rotator and specifies a example how to > bind it. > > Signed-off-by: Chanho Park > Cc: Thomas Abraham > Cc: Kukjin Kim > Cc: Inki Dae > Signed-off-by: Kyungmin Park > --- > .../devicetree

Re: [PATCHv2 5/5] ARM: dts: Add dt binding documentation for exynos rotator

2013-08-09 Thread Tomasz Figa
On Friday 09 of August 2013 10:38:30 Stephen Warren wrote: > On 08/09/2013 07:15 AM, Tomasz Figa wrote: > > Hi Chanho, > > > > On Friday 09 of August 2013 16:40:53 Chanho Park wrote: > >> This patch describes each nodes of rotator and specifies a example how > >

Re: [PATCH 0/3] Add dt support for exynos hdmiphy settings

2013-08-14 Thread Tomasz Figa
Hi Shirish, On Tuesday 13 of August 2013 12:39:27 Shirish S wrote: > For various revision of chipset if the signal pattern is changed for > every board, then the phy setting need to be updated correspondingly by > measuring the signal. > With the hdmiphy settings fixed in the driver the only way c

Re: [PATCH 0/2] update pixel format setting to fimd driver

2013-08-20 Thread Tomasz Figa
setting > drm/exynos: check a pixel format to a particular window layer > > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 45 > -- 1 files changed, 24 insertions(+), 21 > deletions(-) For the whole series: Reviewed-

Re: [PATCH 6/6] drm/exynos: Make Exynos DRM drivers depend on OF

2013-08-22 Thread Tomasz Figa
Hi Sachin, On Thursday 22 of August 2013 11:15:23 Sachin Kamat wrote: > Exynos is a DT-only platform. Add this info to Kconfig. > > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/exynos/Kconfig |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm

Re: [PATCH 1/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-29 Thread Tomasz Figa
On Monday 30 of September 2013 00:08:46 Sylwester Nawrocki wrote: > On 09/28/2013 06:10 PM, Inki Dae wrote: > >> Any opinion from Device-Tree folks? > >> > >> IMO, we should have same consensus on Shirish patches before > >> proceeding.> > > Rahul, it seems that DT people have no interest in this

[PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Tomasz Figa
On 15.05.2014 06:01, Rahul Sharma wrote: > Thanks Tomasz, > > On 15 May 2014 01:31, Tomasz Figa wrote: >> Hi Rahul, Tomasz, > [snip] >>> + simplephys: simple-phys at 1004 { >>> + compatible = "samsung,exynos5250-simple-phy"; &

[PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Tomasz Figa
On 16.05.2014 12:35, Rahul Sharma wrote: > On 16 May 2014 15:12, Rahul Sharma wrote: >> On 16 May 2014 03:14, Tomasz Figa wrote: >>> On 15.05.2014 06:01, Rahul Sharma wrote: > [snip] >>>>> the PHY provider. >>>>> >>>> >>

[PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Tomasz Figa
On 16.05.2014 16:30, Rahul Sharma wrote: > On 16 May 2014 16:20, Tomasz Figa wrote: >> On 16.05.2014 12:35, Rahul Sharma wrote: >>> On 16 May 2014 15:12, Rahul Sharma wrote: >>>> On 16 May 2014 03:14, Tomasz Figa wrote: >>>>> On 15.05.2014 06:01, R

[PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-19 Thread Tomasz Figa
On 19.05.2014 09:10, Rahul Sharma wrote: > On 16 May 2014 20:19, Tomasz Figa wrote: >> On 16.05.2014 16:30, Rahul Sharma wrote: >>> On 16 May 2014 16:20, Tomasz Figa wrote: >>>> On 16.05.2014 12:35, Rahul Sharma wrote: >>>>> On 16 May 2014 15:12, Rah

[PATCH] drm/exynos: hdmi: remove the i2c drivers and use devtree - continued

2014-05-29 Thread Tomasz Figa
/exynos_hdmiphy.c > Obviously there is nothing to review, but still: Reviewed-by: Tomasz Figa Thanks for the patch. Best regards, Tomasz

[PATCH 2/3] exynos: fix G2D_DOUBLE_TO_FIXED

2014-06-01 Thread Tomasz Figa
Hi Tobias, First of all, thanks for spotting those issues and sending patches. However looking at libdrm repo history, your patches don't seem to follow formatting guidelines used there: they lack commit messages (which should say what is changed and why) and your signed-off-by tags. Also it is

[PATCH 2/3] exynos: fix G2D_DOUBLE_TO_FIXED

2014-06-01 Thread Tomasz Figa
On 01.06.2014 03:14, Tobias Jakobi wrote: > Hello Tomasz! > > > Tomasz Figa wrote: >> However looking at libdrm repo history, your patches don't seem to >> follow formatting guidelines used there: they lack commit messages >> (which should say what is changed a

Re: [RFC v4 03/18] vb2: Move cache synchronisation from buffer done to dqbuf handler

2018-10-05 Thread Tomasz Figa
Hi Sakari, Hans, On Tue, May 9, 2017 at 12:05 AM Sakari Ailus wrote: > > The cache synchronisation may be a time consuming operation and thus not > best performed in an interrupt which is a typical context for > vb2_buffer_done() calls. This may consume up to tens of ms on some > machines, depend

Re: [PATCH] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-05-24 Thread Tomasz Figa
Hi Heiko, Sandy, On Fri, May 25, 2018 at 7:07 AM Heiko Stübner wrote: > From: Sandy Huang > The vop irq is shared between vop and iommu and irq probing in the > iommu driver moved to the probe function recently. This can in some > cases lead to a stall if the irq is triggered while the vop dri

minigbm/cros_gralloc handle struct (Was: Re: [drm_hwc] PSA: drm_hwc submissions via gitlab)

2018-05-06 Thread Tomasz Figa
[Really taking this to another thread. Leaving CC as is for the time being.] On Sat, May 5, 2018 at 4:16 AM Mauro Rossi wrote: > > Il 04 mag 2018 19:51, "Alistair Strachan" ha > scritto: > > On Fri, May 4, 2018 at 10:35 AM Sean Paul wrote: > >> On Fri, May 04, 2018 at 05:19:50PM +, Mauro R

Re: [PATCH v2] drm/rockchip: update cursors asynchronously through atomic.

2018-11-14 Thread Tomasz Figa
Hi Enric, On Fri, Sep 28, 2018 at 5:27 PM Enric Balletbo i Serra wrote: > > Add support to async updates of cursors by using the new atomic > interface for that. > > Signed-off-by: Enric Balletbo i Serra > --- > Hi, > > This is a second version of the patch to add async-plane update support > to

Re: [PATCH v3] drm/rockchip: update cursors asynchronously through atomic.

2018-11-19 Thread Tomasz Figa
Hi Helen, On Tue, Nov 20, 2018 at 4:08 AM Helen Koike wrote: > > From: Enric Balletbo i Serra > > Add support to async updates of cursors by using the new atomic > interface for that. > > Signed-off-by: Enric Balletbo i Serra > [updated for upstream] > Signed-off-by: Helen Koike > > --- > Hell

Re: [PATCH 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-20 Thread Tomasz Figa
non-dma type. Using dma mapping APIs with that domain is bad. > > > > Replace dma_map_sg() calls with dma_sync_sg_for_device{|cpu}() > > to do the cache maintenance. > > > > Signed-off-by: Vivek Gautam > > Suggested-by: Tomasz Figa > > --- > > >

Re: [PATCH v3] drm/rockchip: update cursors asynchronously through atomic.

2018-11-22 Thread Tomasz Figa
Hi Helen, On Fri, Nov 23, 2018 at 8:31 AM Helen Koike wrote: > > Hi Tomasz, > > On 11/20/18 4:48 AM, Tomasz Figa wrote: > > Hi Helen, > > > > On Tue, Nov 20, 2018 at 4:08 AM Helen Koike > > wrote: > >> > >> From: Enric Balletbo i Serra

Re: [PATCH v3] drm/rockchip: update cursors asynchronously through atomic.

2018-11-22 Thread Tomasz Figa
Hi Michael, On Fri, Nov 23, 2018 at 1:58 PM Michael Zoran wrote: > > On Fri, 2018-11-23 at 11:27 +0900, Tomasz Figa wrote: > > > > The point here is not about setting and resetting the plane->fb > > pointer. It's about what happens inside > > drm_atomi

Re: [PATCH v3] drm/rockchip: update cursors asynchronously through atomic.

2018-11-26 Thread Tomasz Figa
Hi Gustavo, On Tue, Nov 27, 2018 at 8:54 AM Gustavo Padovan wrote: > > Hi Tomasz, > > On 11/23/18 12:27 AM, Tomasz Figa wrote: > > Hi Helen, > > > > On Fri, Nov 23, 2018 at 8:31 AM Helen Koike > > wrote: > >> Hi Tomasz, > >> >

Re: [BUG] drm_rockchip: rk3066_hdmi: No driver support for vblank timestamp query.

2018-11-27 Thread Tomasz Figa
Hi Johan, Adding the dri-devel mailing lists and some maintainers. On Sun, Nov 25, 2018 at 12:53 AM Johan Jonker wrote: > > For a TV stick called MK808 with rk3066 processor I would like to enable > the VOP and HDMI. > With boot logo and console enabled I can see 2 pinguins and a cursor for > a

Re: [BUG] drm_rockchip: rk3066_hdmi: No driver support for vblank timestamp query.

2018-11-27 Thread Tomasz Figa
On Tue, Nov 27, 2018 at 6:11 PM Tomasz Figa wrote: > > Hi Johan, > > Adding the dri-devel mailing lists and some maintainers. > > On Sun, Nov 25, 2018 at 12:53 AM Johan Jonker wrote: > > > > For a TV stick called MK808 with rk3066 processor I would like to enable

Re: [PATCH v2 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-27 Thread Tomasz Figa
ap_sg() calls with dma_sync_sg_for_device{|cpu}() > to do the cache maintenance. > > Signed-off-by: Vivek Gautam > Suggested-by: Tomasz Figa > Cc: Rob Clark > Cc: Jordan Crouse > Cc: Sean Paul > --- > > Changes since v1: > - Addressed Jordan's and Tomasz's c

Re: [PATCH] drm/rockchip: update cursors asynchronously through atomic.

2018-08-13 Thread Tomasz Figa
Hi Enric, On Tue, Aug 7, 2018 at 12:53 AM Enric Balletbo i Serra wrote: > > Add support to async updates of cursors by using the new atomic > interface for that. > > Signed-off-by: Enric Balletbo i Serra > --- > Hi, > > This first version is slightly different from the RFC, note that I did > not

Re: [PATCH] drm/rockchip: update cursors asynchronously through atomic.

2018-08-13 Thread Tomasz Figa
On Mon, Aug 13, 2018 at 4:26 PM Heiko Stuebner wrote: > > Am Montag, 13. August 2018, 09:11:07 CEST schrieb Tomasz Figa: > > Hi Enric, > > > > On Tue, Aug 7, 2018 at 12:53 AM Enric Balletbo i Serra > > wrote: > > > > > > Add support to

Re: [PATCH v3 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-06-18 Thread Tomasz Figa
s: %#02x\n", > active_irqs); > > + vop_core_clks_disable(vop); > + > +out: > + pm_runtime_put(vop->dev); > return ret; > } Other than that: Reviewed-by: Tomasz Figa Best regards, Tomasz ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 1/2] drm/rockchip: vop: split out core clock enablement into separate functions

2018-06-18 Thread Tomasz Figa
31 insertions(+), 13 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-29 Thread Tomasz Figa
[CC Marek] On Thu, Nov 29, 2018 at 9:09 AM Daniel Vetter wrote: > > On Thu, Nov 29, 2018 at 5:57 PM Christoph Hellwig wrote: > > On Thu, Nov 29, 2018 at 05:28:07PM +0100, Daniel Vetter wrote: > > > Just spend a bit of time reading through the implementations already > > > merged. Is the struct d

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-29 Thread Tomasz Figa
On Thu, Nov 29, 2018 at 11:40 AM Jordan Crouse wrote: > > On Thu, Nov 29, 2018 at 01:48:15PM -0500, Rob Clark wrote: > > On Thu, Nov 29, 2018 at 10:54 AM Christoph Hellwig wrote: > > > > > > On Thu, Nov 29, 2018 at 09:42:50AM -0500, Rob Clark wrote: > > > > Maybe the thing we need to do is just i

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-29 Thread Tomasz Figa
On Thu, Nov 29, 2018 at 12:03 PM Robin Murphy wrote: > > On 29/11/2018 19:57, Tomasz Figa wrote: > > On Thu, Nov 29, 2018 at 11:40 AM Jordan Crouse > > wrote: > >> > >> On Thu, Nov 29, 2018 at 01:48:15PM -0500, Rob Clark wrote: > >>> On Thu, N

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-30 Thread Tomasz Figa
On Thu, Nov 29, 2018 at 4:23 PM Tomasz Figa wrote: > > On Thu, Nov 29, 2018 at 12:03 PM Robin Murphy wrote: > > > > On 29/11/2018 19:57, Tomasz Figa wrote: > > > On Thu, Nov 29, 2018 at 11:40 AM Jordan Crouse > > > wrote: > > >> > > >&g

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-12-02 Thread Tomasz Figa
On Sat, Dec 1, 2018 at 3:47 AM Rob Clark wrote: > > On Fri, Nov 30, 2018 at 9:05 PM Tomasz Figa wrote: > > > > On Thu, Nov 29, 2018 at 4:23 PM Tomasz Figa wrote: > > > > > > On Thu, Nov 29, 2018 at 12:03 PM Robin Murphy > > > wrote: > >

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2018-12-02 Thread Tomasz Figa
nce we don't currently have a better > +* solution, and this code runs before the driver is probed and > +* has a chance to intervene, use a simple blacklist to avoid > +* ending up with iommu dma_ops: > +*/ > + if (of_match_device(iommu_blacklist, de

Re: [BUG] drm_rockchip: rk3066_hdmi: No driver support for vblank timestamp query.

2018-12-09 Thread Tomasz Figa
Hi Johan, It looks like VOP on RK3066 is not officially supported by upstream, so what you're seeing is not a bug, it's just expected behavior, because nobody had the time (or need) to enable support for your hardware yet. I added all the people that may be potentially thinking to add support for

Re: [PATCH] drm: add capability DRM_CAP_ASYNC_UPDATE

2018-12-12 Thread Tomasz Figa
On Thu, Dec 6, 2018 at 1:12 AM Helen Koike wrote: > > Hi Ville > > On 11/27/18 11:34 AM, Ville Syrjälä wrote: > > On Fri, Nov 23, 2018 at 07:53:26PM -0200, Helen Koike wrote: > >> Allow userspace to identify if the driver supports async update. > > > > And what exactly is an "async update"? > > I

Re: [PATCH v2] drm/atomic: add ATOMIC_AMEND flag to the Atomic IOCTL.

2018-12-12 Thread Tomasz Figa
Hi Helen, On Sat, Nov 24, 2018 at 6:54 AM Helen Koike wrote: > > This flag tells core to jump ahead the queued update if the conditions > in drm_atomic_async_check() are met. That means we are only able to do an > async update if no modeset is pending and update for the same plane is > not queued

Re: [BUG] drm_rockchip: rk3066_hdmi: No driver support for vblank timestamp query.

2018-12-13 Thread Tomasz Figa
Hi Johan, On Fri, Dec 14, 2018 at 2:32 AM Johan Jonker wrote: > > Bug fix? (PART 7) > > A little bit of success here. > Penguins and other colors are on the screen. > DRM and FB old style seems to work with DVI-D. > Pure HDMI and sound not tested. > I think 'someone' forgot to add HCLK_HDMI to th

Re: [PATCH] dts: rockchip: rk3066: add qos_hdmi and HCLK_HDMI to pmu node

2018-12-16 Thread Tomasz Figa
Hi Johan, On Sun, Dec 16, 2018 at 12:03 AM Johan Jonker wrote: > > A MK808 TV stick with rk3066 processor boots normal with logo and console. > After the boot the monitor remains black. > This patch fixes a vblank timeout crash by adding qos_hdmi and > HCLK_HDMI to the pmu node. > The HCLK_HDMI c

[PATCH 0/3] Add dt support for exynos hdmiphy settings

2013-08-14 Thread Tomasz Figa
Hi Shirish, On Tuesday 13 of August 2013 12:39:27 Shirish S wrote: > For various revision of chipset if the signal pattern is changed for > every board, then the phy setting need to be updated correspondingly by > measuring the signal. > With the hdmiphy settings fixed in the driver the only way c

[PATCH 0/2] update pixel format setting to fimd driver

2013-08-21 Thread Tomasz Figa
setting > drm/exynos: check a pixel format to a particular window layer > > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 45 > -- 1 files changed, 24 insertions(+), 21 > deletions(-) For the whole series: Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH 6/6] drm/exynos: Make Exynos DRM drivers depend on OF

2013-08-22 Thread Tomasz Figa
Hi Sachin, On Thursday 22 of August 2013 11:15:23 Sachin Kamat wrote: > Exynos is a DT-only platform. Add this info to Kconfig. > > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/exynos/Kconfig |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm

[PATCH v3 28/32] drm/exynos: Implement drm_connector in hdmi directly

2013-12-02 Thread Tomasz Figa
On Monday 02 of December 2013 10:46:37 Thierry Reding wrote: > On Fri, Nov 29, 2013 at 04:58:46PM +0100, Tomasz Figa wrote: > > On Tuesday 29 of October 2013 12:13:14 Sean Paul wrote: > [...] > > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c > > > b/driver

[PATCH] of: Add MIPI DSI bus device tree bindings

2013-12-02 Thread Tomasz Figa
... > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + peripheral at 0 { > + compatible = "..."; > + reg = <0>; > + }; > + > + ... > + }; > In general, this looks good to me as a starter, so we could have support for DSI bus merged. IMHO we should consider adding some generic bus properties in future, though. Anyway, have my Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH 4/4] drm: exynos: hdmi: Add dt support for hdmiphy settings

2013-12-19 Thread Tomasz Figa
On Thursday 19 of December 2013 17:42:28 Shirish S wrote: > This patch adds dt support to hdmiphy config settings > as it is board specific and depends on the signal pattern > of board. > > Signed-off-by: Shirish S > --- > .../devicetree/bindings/video/exynos_hdmi.txt | 34 > dri

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-07-11 Thread Tomasz Figa
On Thu, Jun 20, 2024 at 3:52 PM Hans Verkuil wrote: > > On 19/06/2024 06:19, Tomasz Figa wrote: > > On Wed, Jun 19, 2024 at 1:24 AM Nicolas Dufresne > > wrote: > >> > >> Le mardi 18 juin 2024 à 16:47 +0900, Tomasz Figa a écrit : > >>> Hi TaoJi

Re: [PATCH v6,12/24] media: mediatek: vcodec: add interface to allocate/free secure memory

2024-06-17 Thread Tomasz Figa
On Mon, Jun 17, 2024 at 3:53 PM Yong Wu (吴勇) wrote: > > On Wed, 2024-06-12 at 14:22 +0900, Tomasz Figa wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > On Thu, May 16, 2024 at

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread Tomasz Figa
Hi TaoJiang, On Tue, Jun 18, 2024 at 4:30 PM TaoJiang wrote: > > From: Ming Qian > > When the memory type is VB2_MEMORY_DMABUF, the v4l2 device can't know > whether the dma buffer is coherent or synchronized. > > The videobuf2-core will skip cache syncs as it think the DMA exporter > should take

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread Tomasz Figa
On Wed, Jun 19, 2024 at 1:24 AM Nicolas Dufresne wrote: > > Le mardi 18 juin 2024 à 16:47 +0900, Tomasz Figa a écrit : > > Hi TaoJiang, > > > > On Tue, Jun 18, 2024 at 4:30 PM TaoJiang wrote: > > > > > > From: Ming Qian > > > > > >

Re: [RFC 0/1] DRM Node Probing functionality

2018-04-15 Thread Tomasz Figa
Hi Rob, On Thu, Apr 12, 2018 at 12:56 PM Robert Foss wrote: > *Resend the whole actual series* > This patch implements a simple function for matching DRM device FDs against > the desired properties of a device that you are looking for. > The properties that are possible to look for are the ele

Re: [PATCH v6 28/30] drm/rockchip: Disable PSR from reboot notifier

2018-04-16 Thread Tomasz Figa
Hi Andrzej, On Mon, Apr 16, 2018 at 6:57 PM Andrzej Hajda wrote: > On 05.04.2018 11:49, Enric Balletbo i Serra wrote: > > From: Tomasz Figa > > > > It looks like the driver subsystem detaches devices from power domains > > at shutdown without consent of the drive

Re: [PATCH libdrm 1/2] intel: Do not use libpciaccess on Android

2018-03-27 Thread Tomasz Figa
On Wed, Mar 21, 2018 at 2:36 AM, Emil Velikov wrote: > From: Tomasz Figa > > This patch makes the code not rely anymore on libpciaccess when compiled > for Android to eliminate ioperm() and iopl() syscalls required by that > library. As a side effect, the mappable aperture size

Re: [PATCH v7 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers

2018-02-12 Thread Tomasz Figa
Hi Vivek, On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam wrote: > The device link allows the pm framework to tie the supplier and > consumer. So, whenever the consumer is powered-on the supplier > is powered-on first. > > There are however cases in which the consumer wants to power-on > the supplie

Re: [PATCH v7 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-02-13 Thread Tomasz Figa
Hi Vivek, Thanks for the patch. Please see some comments inline. On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam wrote: > From: Sricharan R > > The smmu needs to be functional only when the respective > master's using it are active. The device_link feature > helps to track such functional dependen

Re: [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-13 Thread Tomasz Figa
Hi Vivek, Thanks for the patch. Please see my comments inline. On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam wrote: > From: Sricharan R > > The smmu device probe/remove and add/remove master device callbacks > gets called when the smmu is not linked to its master, that is without > the context o

Re: [PATCH v7 4/6] iommu/arm-smmu: Add the device_link between masters and smmu

2018-02-13 Thread Tomasz Figa
Hi Vivek, Thanks for the patch. Please see my comments inline. On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam wrote: > From: Sricharan R > > Finally add the device link between the master device and > smmu, so that the smmu gets runtime enabled/disabled only when the > master needs it. This is do

Re: [PATCH v8 5/6] iommu/arm-smmu: Add support for qcom, smmu-v2 variant

2018-02-13 Thread Tomasz Figa
Hi Vivek, Thanks for the patch. Please see my comments inline. On Fri, Feb 9, 2018 at 7:57 PM, Vivek Gautam wrote: > qcom,smmu-v2 is an arm,smmu-v2 implementation with specific > clock and power requirements. This smmu core is used with > multiple masters on msm8996, viz. mdss, video, etc. > Add

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-13 Thread Tomasz Figa
Hi Vivek, Thanks for the patch. Please see my comments inline. On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam wrote: > While handling the concerned iommu, there should not be a > need to power control the drm devices from iommu interface. > If these drm devices need to be powered around this time,

Re: [PATCH v7 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers

2018-02-13 Thread Tomasz Figa
On Tue, Feb 13, 2018 at 9:00 PM, Robin Murphy wrote: > On 13/02/18 07:44, Tomasz Figa wrote: >> >> Hi Vivek, >> >> On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam >> wrote: >>> >>> The device link allows the pm framework to tie the supplier and &g

Re: [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-13 Thread Tomasz Figa
On Tue, Feb 13, 2018 at 9:57 PM, Robin Murphy wrote: > On 13/02/18 08:24, Tomasz Figa wrote: >> >> Hi Vivek, >> >> Thanks for the patch. Please see my comments inline. >> >> On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam >> wrote: >>> >>&

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-13 Thread Tomasz Figa
On Wed, Feb 14, 2018 at 3:03 AM, Rob Clark wrote: > On Tue, Feb 13, 2018 at 4:10 AM, Tomasz Figa wrote: >> Hi Vivek, >> >> Thanks for the patch. Please see my comments inline. >> >> On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam >> wrote: >>> Whil

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-13 Thread Tomasz Figa
On Wed, Feb 14, 2018 at 11:13 AM, Rob Clark wrote: > On Tue, Feb 13, 2018 at 8:59 PM, Tomasz Figa wrote: >> On Wed, Feb 14, 2018 at 3:03 AM, Rob Clark wrote: >>> On Tue, Feb 13, 2018 at 4:10 AM, Tomasz Figa wrote: >>>> Hi Vivek, >>>> >>>&g

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-13 Thread Tomasz Figa
Hi Jordan, On Wed, Feb 14, 2018 at 1:42 AM, Jordan Crouse wrote: > On Tue, Feb 13, 2018 at 06:10:38PM +0900, Tomasz Figa wrote: >> Hi Vivek, >> >> Thanks for the patch. Please see my comments inline. >> >> On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam >> w

Re: [PATCH v7 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-02-13 Thread Tomasz Figa
On Tue, Feb 13, 2018 at 7:25 PM, Vivek Gautam wrote: >>> +static int arm_smmu_init_clks(struct arm_smmu_device *smmu) >>> +{ >>> + int i; >>> + int num = smmu->num_clks; >>> + const struct arm_smmu_match_data *data; >>> + >>> + if (num < 1) >>> + return 0; >>>

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-13 Thread Tomasz Figa
On Wed, Feb 14, 2018 at 1:17 PM, Vivek Gautam wrote: > Hi Tomasz, > > On Wed, Feb 14, 2018 at 8:31 AM, Tomasz Figa wrote: >> On Wed, Feb 14, 2018 at 11:13 AM, Rob Clark wrote: >>> On Tue, Feb 13, 2018 at 8:59 PM, Tomasz Figa wrote: >>>> On Wed, Feb 1

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-14 Thread Tomasz Figa
On Wed, Feb 14, 2018 at 6:13 PM, Vivek Gautam wrote: > Hi Tomasz, > > On Wed, Feb 14, 2018 at 11:08 AM, Tomasz Figa wrote: >> On Wed, Feb 14, 2018 at 1:17 PM, Vivek Gautam >> wrote: >>> Hi Tomasz, >>> >>> On Wed, Feb 14, 2018 at 8:31 AM, Tomasz Fi

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-14 Thread Tomasz Figa
On Thu, Feb 15, 2018 at 1:03 AM, Robin Murphy wrote: > On 14/02/18 10:33, Vivek Gautam wrote: >> >> On Wed, Feb 14, 2018 at 2:46 PM, Tomasz Figa wrote: >> >> Adding Jordan to this thread as well. >> >>> On Wed, Feb 14, 2018 at 6:13 PM, Vivek Gautam >

Re: [Freedreno] [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-14 Thread Tomasz Figa
On Thu, Feb 15, 2018 at 1:12 AM, Rob Clark wrote: > On Wed, Feb 14, 2018 at 10:48 AM, Jordan Crouse > wrote: >> On Wed, Feb 14, 2018 at 12:31:29PM +0900, Tomasz Figa wrote: >>> >>> - When submitting commands to the GPU, the GPU driver will >>> pm_runtime_g

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-14 Thread Tomasz Figa
On Thu, Feb 15, 2018 at 12:17 PM, Tomasz Figa wrote: > On Thu, Feb 15, 2018 at 1:03 AM, Robin Murphy wrote: >> On 14/02/18 10:33, Vivek Gautam wrote: >>> >>> On Wed, Feb 14, 2018 at 2:46 PM, Tomasz Figa wrote: >>> >>> Adding Jordan to this thread a

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-15 Thread Tomasz Figa
On Fri, Feb 16, 2018 at 2:14 AM, Robin Murphy wrote: > On 15/02/18 04:17, Tomasz Figa wrote: > [...] >>> >>> Could you elaborate on what kind of locking you are concerned about? >>> As I explained before, the normally happening fast path would lock >>> de

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-22 Thread Tomasz Figa
On Fri, Feb 16, 2018 at 9:13 AM, Tomasz Figa wrote: > On Fri, Feb 16, 2018 at 2:14 AM, Robin Murphy wrote: >> On 15/02/18 04:17, Tomasz Figa wrote: >> [...] >>>> >>>> Could you elaborate on what kind of locking you are concerned about? >>>> As I

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-22 Thread Tomasz Figa
On Thu, Feb 22, 2018 at 10:45 PM, Robin Murphy wrote: > [sorry, I had intended to reply sooner but clearly forgot] > > > On 16/02/18 00:13, Tomasz Figa wrote: >> >> On Fri, Feb 16, 2018 at 2:14 AM, Robin Murphy >> wrote: >>> &

Re: [PATCH 39/40] drm/rockchip: analogix_dp: Fix invalid implementation of unbind

2018-01-15 Thread Tomasz Figa
Hi Thierry, On Tue, Jan 16, 2018 at 2:16 AM, Thierry Escande wrote: > From: Tomasz Figa > > Current implementation of unbind dereferences the drvdata pointer > assuming that it's its own data, however the ownership belongs to the > analogix code, which means that the poi

Re: [PATCH 01/40] drm/rockchip: Get rid of some unnecessary code

2018-01-15 Thread Tomasz Figa
Hi Thierry, On Tue, Jan 16, 2018 at 2:15 AM, Thierry Escande wrote: > From: Tomasz Figa > > Current code implements prepare_fb and cleanup_fb callbacks only to > grab/release fb references, which is already done by atomic framework > when creating/destryoing plane state. AFAICT

Re: [PATCH 30/40] drm/rockchip: Flush PSR before committing modeset disables/enables

2018-01-15 Thread Tomasz Figa
Hi Thierry, On Tue, Jan 16, 2018 at 2:16 AM, Thierry Escande wrote: > From: Tomasz Figa > > Currently PSR flush is triggered from CRTC's .atomic_begin() callback, > which is executed after modeset disables and enables and before plane > updates are committed. Since PSR flu

Re: [PATCH v6,03/24] v4l2: verify restricted dmabufs are used in restricted queue

2024-06-11 Thread Tomasz Figa
On Thu, May 16, 2024 at 08:20:41PM +0800, Yunfei Dong wrote: > From: Jeffrey Kardatzke > > Verfies in the dmabuf implementations that if the restricted memory > flag is set for a queue that the dmabuf submitted to the queue is > unmappable. > > Signed-off-by: Jeffrey Kardatzke > Signed-off-by:

Re: [PATCH v6,04/24] v4l: add documentation for restricted memory flag

2024-06-11 Thread Tomasz Figa
On Wed, May 22, 2024 at 02:16:22PM +0300, Laurent Pinchart wrote: > Hi Jefrey, > > Thank you for the patch. > > On Thu, May 16, 2024 at 08:20:42PM +0800, Yunfei Dong wrote: > > From: Jeffrey Kardatzke > > > > Adds documentation for V4L2_MEMORY_FLAG_RESTRICTED. > > > > Signed-off-by: Jeffrey Ka

Re: [PATCH v6,12/24] media: mediatek: vcodec: add interface to allocate/free secure memory

2024-06-11 Thread Tomasz Figa
On Thu, May 16, 2024 at 08:20:50PM +0800, Yunfei Dong wrote: > Need to call dma heap interface to allocate/free secure memory when playing > secure video. > > Signed-off-by: Yunfei Dong > --- > .../media/platform/mediatek/vcodec/Kconfig| 1 + > .../mediatek/vcodec/common/mtk_vcodec_util.c

<    1   2   3   4   5   >