On 24/11/16 14:03, Jyri Sarha wrote:
>> The suspend/resume you're talking there is the system suspend/resume.
>> That's quite different than the runtime suspend/resume, and they should
>> do very different things.
>>
>> The current system suspend/resume in tilcdc looks fine.
>>
>
> I don't
On 28/11/16 07:24, Sekhar Nori wrote:
> On Friday 25 November 2016 09:07 PM, Bartosz Golaszewski wrote:
>> It has been determined that the maximum resolution supported correctly
>> by tilcdc rev1 on da850 SoCs is 800x600 at 60. Due to memory throughput
>> constraints we must filter out higher
and planes, and how it connects those to display outputs.
So, this patch fixes the problem the easy way, and sets the
possible_crtcs for primary planes only to the crtc in question, which in
practice should cover all normal use cases.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapd
for clocks starting from high M and N values, instead of
low values. This should not cause any functional change, and only
reduces the jitter.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/pll.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
detection
drm/omap: displays: connector-hdmi: Support for hot plug detection
drm/omap: displays: encoder-tpd12s015: Support for hot plug detection
drm/omap: displays: panel-dpi: Support for handling backlight devices
Tomi Valkeinen (24):
drm/omap: work-around for errata i886
drm/omap
can be removed.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/dpi.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c
b/drivers/gpu/drm/omapdrm/dss/dpi.c
index e75162d26ac0..e0b0c5c24c55 100644
--- a/drivers/gpu/drm/omapdrm/dss/dpi.c
++
is rather
tricky.
This patch improves the situation a bit by checking if the PLL about to
be used exists, and if not, tries another one.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/dpi.c | 47 ++-
1 file changed, 37 insertions(+), 10 deletions
Peter Ujfalusi
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/display.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/display.c
b/drivers/gpu/drm/omapdrm/dss/display.c
index 94c012e0584b..26cb59be045e 100644
--- a/drive
uld
always be set, as there's no practical reason to disable it. This patch
removes the option to disable it from omapdrm, and always sets it to
enabled in dispc.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 7 ---
drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 +--
drive
-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/dispc.c| 18 ++
drivers/gpu/drm/omapdrm/dss/dss_features.c | 3 ---
drivers/gpu/drm/omapdrm/dss/dss_features.h | 4
drivers/gpu/drm/omapdrm/dss/omapdss.h | 5 +
drivers/gpu/drm/omapdrm/omap_drv.c
with a common base module and function
pointers.
This patch adds a skeleton omapdss-base.ko module, to which we'll be
moving common dss functionality like registration of the panels.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/Kconfig | 4
drivers/gpu/drm/omapdrm/dss/Makefile
change.
Signed-off-by: Peter Ujfalusi
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/omapdss.h| 13 +
drivers/gpu/drm/omapdrm/omap_connector.c | 30 +-
2 files changed, 42 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapd
Instead of printing 0/1 for display flags like vsync high/low, use a
tri-state print (-1/0/1) to indicate the "undefined" state.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
We don't have omapdss's custom error printing functions in the common
omapdss-base module, to which we want to move output.c.
This patch changes output.c to use dev_err instead of DSSERR so that it
doesn't depend on DSSERR.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/output.c
.
We can also make dsi_get_pixel_size() static as it's no longer used
outside dsi.c.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/display.c | 6 +++---
drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +-
drivers/gpu/drm/omapdrm/dss/dss.h | 8
3 files changed, 4 insertions
Based on this information, omapdrm can defer probe in case when
the omapdss stack is not ready yet.
Signed-off-by: Peter Ujfalusi
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/base.c| 107 ++
drivers/gpu/drm/omapdrm/dss/dss.c | 1 +
drivers/gpu/drm/o
This patch changes the current omapdss driver to fill a dispc_ops struct
and set it to omapdss-base.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 40 +
1 file changed, 40 insertions(+)
diff --git a/drivers/gpu/drm/omapdrm/dss
omapdrm now uses dispc_ops instead of direct function calls so we can
remove all EXPORT_SYMBOLs from dispc. Most of the functions can also be
made static, but a few are used outside dispc.c.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 87
Add DRM property for crtc background color property. Background
color is shown on areas where there are no planes.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 60 ++---
drivers/gpu/drm/omapdrm/omap_drv.c | 9 ++
drivers/gpu/drm
mode.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/hdmi_wp.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_wp.c
b/drivers/gpu/drm/omapdrm/dss/hdmi_wp.c
index b783d5a0750e..597ec9d87d1d 100644
--- a/drivers/gpu/drm
Add omapdss_of_get_endpoint() helper function to get the endpoint node
for the given port index and endpoint index.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/dss-of.c | 61 +++
drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 ++
2 files changed
Remove two unused WB functions.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 10 --
drivers/gpu/drm/omapdrm/dss/dss.h | 2 --
2 files changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c
b/drivers/gpu/drm/omapdrm/dss/dispc.c
index
This patch moves the common parts of omapdss to omapdss-base so that
both the current omapdss driver and the new omapdss6 driver can use
them.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/Makefile | 6 +++---
drivers/gpu/drm/omapdrm/dss/display.c | 2 --
drivers/gpu/drm
Hi Tony,
On 01/06/16 11:35, Peter Ujfalusi wrote:
> Hi,
>
> Changes since v1:
> - patches (2) added to remove the inclusion of video/omap-panel-data.h when it
> is not needed
> - Transitional patch to create the video/omapfb_dss.h has been changed to copy
> the content of the omapdss.h in
On 02/06/16 18:23, Tony Lindgren wrote:
> * Tomi Valkeinen [160602 05:28]:
>>
>> Tony, can you have a look at the arch/arm parts here and give your ack
>> if they're fine? They should be quite small and display specific, so I
>> don't see much chance for conflict t
Signed-off-by: Tomi Valkeinen
---
Hi Dave,
The "omapdrm fixes for 4.7" pull req left three unused variables, of which one
you fixed in the drm-fixes branch. This removes the remaining two.
Tomi
drivers/gpu/drm/omapdrm/dss/dsi.c | 1 -
drivers/gpu/drm/omapdrm/dss/hdmi5.c | 1
On 06/06/16 04:14, Laurent Pinchart wrote:
>>> If the DRM core doesn't track whether a CRTC HW is enabled at the
>>> moment, maybe omapdrm should? I guess the above works, but that if()
>>> makes me a bit uneasy, as it's not really obvious, and the logic behind
>>> it could possibly change
On 06/06/16 02:21, Laurent Pinchart wrote:
>> Also, I do like it that we deal with crtc or plane interrupts in
>> omap_crtc or omap_plane. Would similar approach here work as you use in
>> the following patches, i.e. just call underflow-handler func in
>> omap_plane.c directly, instead of using
On 07/06/16 02:33, Laurent Pinchart wrote:
> +/**
> + * struct drm_format_info - information about a DRM format
> + * @format: 4CC format identifier (DRM_FORMAT_*)
> + * @depth: color depth (number of bits per pixel excluding padding bits)
> + * @bpp: number of bits per pixel including padding
>
On 07/06/16 02:33, Laurent Pinchart wrote:
> Various pieces of information about DRM formats (number of planes, color
> depth, chroma subsampling, ...) are scattered across different helper
> functions in the DRM core. Callers of those functions often need to
> access more than a single parameter
On 07/06/16 15:09, Jyri Sarha wrote:
> Add drm_crtc_enable_color_mgmt(), remove drm_helper_crtc_enable_color_mgmt()
> and update drm/i915-driver (the only user of the old function).
>
> The new function is more flexible. It allows driver to enable only the
> features it has without forcing to
eichel (1):
drm: omapdrm: add DSI mapping
Tomi Valkeinen (33):
drm/omap: remove unused enum omap_hdmi_flags
drm/omap: remove unused enum omap_overlay_manager_caps
drm/omap: fix wrong variable type
drm/omap: video-pll: add missing data for clkout2 & 3
drm/om
On 10/06/16 01:14, Daniel Vetter wrote:
> It's a legacy helper function which won't do good with atomic helpers.
>
> Cc: Tomi Valkeinen
> Cc: Laurent Pinchart
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/omapdrm/omap_fbdev.c | 3 ---
> 1 file changed, 3 dele
On 10/06/16 09:24, Tomi Valkeinen wrote:
> On 10/06/16 01:14, Daniel Vetter wrote:
>> It's a legacy helper function which won't do good with atomic helpers.
>>
>> Cc: Tomi Valkeinen
>> Cc: Laurent Pinchart
>> Signed-off-by: Daniel Vetter
>> ---
>&
to verify if the setup is correct.
This patch makes omap_plane_atomic_check() return 0 if the crtc is
disabled.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_plane.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c
b/drivers/gpu/drm
Clean up omap_plane_atomic_check() with:
- Check state->fb first. If no fb, return 0.
- use drm_atomic_get_existing_crtc_state() instead of
drm_atomic_get_crtc_state()
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_plane.c | 21 -
1 file changed,
in atomic_check, instead of only noticing the problem when
programming dispc.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_plane.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c
b/drivers/gpu/drm/omapdrm/omap_plane.c
index
On 09/06/16 02:32, Laurent Pinchart wrote:
> The driver needs the number of bytes per pixel, not the bpp and depth
> info meant for fbdev compatibility. Use the right API.
>
> In the tilcdc_crtc_mode_set() function compute the hardware register
> value directly from the pixel format instead of
t omap_framebuffer {
> struct drm_framebuffer base;
> int pin_count;
> const struct format *format;
> - struct plane planes[4];
> + struct plane planes[2];
> /* lock for pinning (pin_count and planes.paddr) */
> struct mutex lock;
> }
On 10/06/16 15:05, Ville Syrjälä wrote:
>> I'm not sure what's the common way, but tilcdc doesn't support alpha.
>> ARGB works, of course, by ignoring A, but... If an userspace app creates
>> ARGB buffer, does the app expect alpha to work?
>
> I think what we decided a while ago (at least for
case 24:
> + case DRM_FORMAT_RGB888:
> reg |= LCDC_V2_TFT_24BPP_MODE;
> break;
> default:
>
I think it's better to keep ARGB allowed for now. If we want to disallow
it, it's better to be done in
On 10/06/16 15:23, Ville Syrjälä wrote:
> On Fri, Jun 10, 2016 at 03:08:18PM +0300, Tomi Valkeinen wrote:
>> On 10/06/16 15:05, Ville Syrjälä wrote:
>>
>>>> I'm not sure what's the common way, but tilcdc doesn't support alpha.
>>>> ARGB works, of course
On 10/06/16 15:29, Ville Syrjälä wrote:
>> The HW does not support any kind of blending to black
>> or to anything else.
>
> Right. Then formats with alpha shouldn't be advertized.
I don't think tilcdc does. It comes from the DRM core. With universal
planes this will be fixed as the driver
On 10/06/16 15:48, Tomi Valkeinen wrote:
> On 10/06/16 15:29, Ville Syrjälä wrote:
>
>>> The HW does not support any kind of blending to black
>>> or to anything else.
>>
>> Right. Then formats with alpha shouldn't be advertized.
>
> I don't thi
On 14/06/16 14:45, Jyri Sarha wrote:
> Restore old dpms state in pm_resume(). The dpms is turned off in
> pm_suspend() and it should be restored to its original state in
> pm_resume().
>
> Fixes commit 614b3cfeb8d2 ("drm/tilcdc: disable the lcd controller/dma
> engine when suspend invoked")
On 15/06/16 11:39, Jyri Sarha wrote:
> Restore old dpms state in pm_resume(). The dpms is turned off in
> pm_suspend() and it should be restored to its original state in
> pm_resume().
>
> Fixes commit 614b3cfeb8d2 ("drm/tilcdc: disable the lcd controller/dma
> engine when suspend invoked")
This
On 15/06/16 11:39, Jyri Sarha wrote:
> Reorder the IRQ function so that the write to LCDC_END_OF_INT_IND_REG
> is done last. The write to LCDC_END_OF_INT_IND_REG indicates to LCDC
> that the interrupt service routine has completed (see section
> 13.3.6.1.6 in AM335x TRM). This is needed if
On 15/06/16 11:39, Jyri Sarha wrote:
> Move wait queue waiting of LCDC_FRAME_DONE IRQ from tilcdc_crtc_dpms()
> into stop() function.
You could mention the reason for this, which is just a cleanup here (I
presume).
> Signed-off-by: Jyri Sarha
> ---
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 31
_drv.h| 2 +
> drivers/gpu/drm/tilcdc/tilcdc_external.c | 13 -
> 5 files changed, 62 insertions(+), 26 deletions(-)
>
Beside the minor comments I had, looks fine to me.
Reviewed-by: Tomi Valkeinen
Tomi
-- next part --
A non-text a
On 17/06/16 12:22, Jyri Sarha wrote:
> Some fixes and cleanups that should get merged to tilcdc even if my
> atomic changes are still a work in progress.
>
> Yet one more round, sorry for spamming.
I think these look fine:
Reviewed-by: Tomi Valkeinen
Tomi
Hi Thierry,
On 21/06/16 16:56, Thierry Reding wrote:
> From: Thierry Reding
>
> Commit 973999aa0140 ("drm/omap: Remove regulator API abuse") removed the
> only user of the local 'r' variable, which thus became unused.
>
> Signed-off-by: Thierry Reding
> ---
>
move unused variable
Tomi Valkeinen (29):
OMAPDSS: DISPC: always set ALIGN when available
OMAPDSS: fix DISPC_MFLAG_THRESHOLD_OFFSET for WB
OMAPDSS: add WB to register dump
OMAPDSS: add num_wbs=1 to omap5 dss features
OMAPDSS: add 'has_writeback' flag
OMAPDSS:
Hi Dan,
omapdrm crashes on v4.5-rc1, and I bisected the problem to:
01c8f1c44b83a0825b573e7c723b033cece37b86 ("mm, dax, gpu: convert
vm_insert_mixed to pfn_t").
Below is the crash dump. Any ideas?
Tomi
[ 22.428741] Unable to handle kernel NULL pointer dereference at virtual
address
re the pfn_t flags in the !pfn_t_devmap() case
> and fallback to trusting pfn_valid().
>
> Fixes: 01c8f1c44b83 ("mm, dax, gpu: convert vm_insert_mixed to pfn_t")
Thanks, this fixes the crash with omapdrm.
Tested-by: Tomi Valkeinen
Tomi
-- next part -
On 15/01/16 12:52, Arnd Bergmann wrote:
> The omapdrm dss driver currently fails to build in some configurations when
> the pinctrl and seq_print declarations are not visible:
>
> omapdrm/dss/dss.c:1268:2: error: implicit declaration of function
> 'pinctrl_pm_select_sleep_state'
Hi,
On 12/08/16 14:14, Sean Paul wrote:
> On Thu, Aug 11, 2016 at 7:00 AM, Tomi Valkeinen
> wrote:
>> On 11/08/16 13:56, Sean Paul wrote:
>>> On Thu, Aug 11, 2016 at 5:44 AM, Peter Chen wrote:
>>>> This reverts commit 2ab9f5879162499e1c4e48613287e3f59e593c4f.
On 26/08/16 20:44, Jyri Sarha wrote:
> On 08/26/16 15:51, Rob Herring wrote:
>>> --- a/Documentation/devicetree/bindings/display/tilcdc/tilcdc.txt
+++ b/Documentation/devicetree/bindings/display/tilcdc/tilcdc.txt
@@ -17,6 +17,8 @@ Optional properties:
the lcd controller.
On 30/11/16 16:36, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Wednesday 30 Nov 2016 12:38:51 Tomi Valkeinen wrote:
>> We set the possible_crtc for all planes to "(1 << priv->num_crtcs) - 1",
>> which is fine as the HW p
drm_universal_plane_init() and drm_plane_init() take "unsigned long
possible_crtcs" parameter, but then stuff it into uint32_t. Change the
parameter to uint32_t.
Signed-off-by: Tomi Valkeinen
Cc: Ville Syrjälä
---
drivers/gpu/drm/drm_plane.c | 4 ++--
include/drm/drm_plane.h |
planes.
This patch passes a possible_crtcs mask to plane init function so that
we get correct possible_crtc.
Signed-off-by: Tomi Valkeinen
---
v2: use correct possible_crtcs value
drivers/gpu/drm/omapdrm/omap_drv.c | 17 -
drivers/gpu/drm/omapdrm/omap_drv.h | 3 ++-
driv
On 02/12/16 16:16, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Friday 02 Dec 2016 16:07:11 Tomi Valkeinen wrote:
>> We set the possible_crtc for all planes to "(1 << priv->num_crtcs) - 1",
>> which is fine as the HW p
On 02/12/16 17:42, Laurent Pinchart wrote:
> I can understand that (even if I'm not sure it's really an issue, and we
> should really clean up the CRTC creation code at some point), but how about
> adding a possible_crtcs field to the priv structure then ? I don't really
> like
> having to
On 29/11/16 13:57, Bartosz Golaszewski wrote:
> Add the dumb-vga-dac node to the board DT together with corresponding
> ports and vga connector. This allows to retrieve the edid info from
> the display automatically.
>
> Signed-off-by: Bartosz Golaszewski
> ---
>
On 08/12/16 03:01, Benjamin Herrenschmidt wrote:
> On Wed, 2016-11-23 at 10:03 +0200, Tomi Valkeinen wrote:
>> Hi,
>>
>> Since the fbdev framework is in maintenance mode and all new display drivers
>> should be made with the DRM framework, remove the fbdev drive
Remove Tomi Valkeinen from fbdev maintainer and mark fbdev as orphan.
Signed-off-by: Tomi Valkeinen
---
I just don't have time to even pretend I maintain fbdev, so mark it as Orphan.
Anyone want to pick fbdev maintainership?
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions
On 02/12/16 17:56, Laurent Pinchart wrote:
> Hi Tomi,
>
> On Friday 02 Dec 2016 17:55:10 Tomi Valkeinen wrote:
>> On 02/12/16 17:42, Laurent Pinchart wrote:
>>> I can understand that (even if I'm not sure it's really an issue, and we
>>> should really clean up the
)
omapdrm fixes for v4.10
* fix tpd12s015's error handling, which causes omap5 uevm HDMI to fail
* fix omapdrm primary plane allocation bug, which makes the display to fail to
come up
Tomi Valkeinen (3
On 30/11/16 15:32, Daniel Vetter wrote:
> On Wed, Nov 30, 2016 at 01:17:05PM +0200, Tomi Valkeinen wrote:
>> Add DRM property for crtc background color property. Background
>> color is shown on areas where there are no planes.
>>
>> Signed-off-by: Tomi Valkeinen
On 30/11/16 15:46, Daniel Vetter wrote:
> On Wed, Nov 30, 2016 at 01:17:09PM +0200, Tomi Valkeinen wrote:
>> From: Peter Ujfalusi
>>
>> Do not try to init the fbdev if either num_crtcs or num_connectors is 0.
>> In this case we do not have display so the fb
rm.h
> header-y += nouveau_drm.h
> +header-y += omap_drm.h
> header-y += qxl_drm.h
> header-y += r128_drm.h
> header-y += radeon_drm.h
Reviewed-by: Tomi Valkeinen
It's a bit late for 4.10, shall I pick this up to my 4.11 branch?
Tomi
-- next part --
A
On 19/09/16 15:27, Laurent Pinchart wrote:
> The function is only used in omap_irq.c, move it there and make it
> static.
>
> Signed-off-by: Laurent Pinchart
> ---
> drivers/gpu/drm/omapdrm/omap_crtc.c | 7 ---
> drivers/gpu/drm/omapdrm/omap_drv.h | 1 -
>
On 13/12/16 00:53, Laurent Pinchart wrote:
> Hi Tomi,
>
> On Tuesday 20 Sep 2016 16:51:11 Tomi Valkeinen wrote:
>> On 19/09/16 15:27, Laurent Pinchart wrote:
>>> The DRM core supports skipping plane update for inactive CRTCs for
>>> hardware that don't need it
On 13/12/16 01:07, Laurent Pinchart wrote:
> Hi Tomi,
>
> On Tuesday 20 Sep 2016 16:57:59 Tomi Valkeinen wrote:
>> On 19/09/16 15:27, Laurent Pinchart wrote:
>>> The omapdrm DSS manager enable/disable operations check the DSS manager
>>> state to avoid double e
)
fbdev changes for 4.10
* Remove current fbdev maintainer
Tomi Valkeinen (1):
fbdev: remove current maintainer
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
-- next part
Hi,
On 12/12/16 15:05, Bartosz Golaszewski wrote:
> + {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <_pins>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + lcdc_out: port at 1 {
> +
On 14/12/16 01:38, Laurent Pinchart wrote:
> The omapdrm platform device is a virtual device created for the sole
> purpose of handling the omapdss/omapdrm driver split. It should
> eventually be removed. As a first step to ease refactoring move its
> registration from platform code to driver
On 13/12/16 19:35, Laurent Pinchart wrote:
> Hi Sebastian,
>
> Thank you for the patch.
>
> On Tuesday 08 Mar 2016 17:39:44 Sebastian Reichel wrote:
>> This is a workaround for a hardware bug occuring
>> on OMAP3 with manually updated panels.
>
> Could you please explain what the bug is and how
On 14/12/16 02:27, Laurent Pinchart wrote:
> Hello,
>
> Here's the fourth version of my current stack of pending patches for the
> omapdrm driver.
>
> All comments received for v3 have been considered and patches updated where
> applicable. Patches 21/22 and 22/22 have been added, individual
On 14/12/16 11:10, Laurent Pinchart wrote:
> Hi Tomi,
>
> On Wednesday 14 Dec 2016 10:43:18 Tomi Valkeinen wrote:
>> On 13/12/16 19:35, Laurent Pinchart wrote:
>>> On Tuesday 08 Mar 2016 17:39:44 Sebastian Reichel wrote:
>>>> This is a workaround for a
: Laurent Pinchart
> ---
> arch/arm/boot/dts/da850-lcdk.dts | 51
>
> 1 file changed, 51 insertions(+)
Reviewed-by: Tomi Valkeinen
Tomi
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: appli
58,7 +458,7 @@
> dma-names = "tx", "rx";
> };
>
> - display: display at 213000 {
> + lcdc: display at 213000 {
> compatible = "ti,da850-tilcdc";
>
aurent Pinchart
> ---
> Changes since v3:
>
> - Fix subsampling computation by checking the plane number correctly
> ---
> drivers/gpu/drm/omapdrm/omap_fb.c | 91
> ---
> 1 file changed, 46 insertions(+), 45 deletions(-)
Reviewed-by: Tomi Valk
aurent Pinchart
> Reviewed-by: Tomi Valkeinen
> ---
> +static void omap_irq_fifo_underflow(struct omap_drm_private *priv,
> + u32 irqstatus)
> +{
> + static DEFINE_RATELIMIT_STATE(_rs, DEFAULT_RATELIMIT_INTERVAL,
> +
= DISPC_IRQ_OCP_ERR;
> -
> - /* for now ignore DISPC_IRQ_SYNC_LOST_DIGIT.. really I think
> - * we just need to ignore it while enabling tv-out
> - */
> - error_handler->irqmask &= ~DISPC_IRQ_SYNC_LOST_DIGIT;
> -
> - omap_irq_register(dev, error_handler);
&
moved the pipe2vbl function completely
> ---
Reviewed-by: Tomi Valkeinen
Tomi
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL:
<https://lists.freedesktop.o
es since v2:
>
> - Use enabled field in struct omap_crtc instead of CRTC atomic state
> ---
> drivers/gpu/drm/omapdrm/omap_crtc.c | 22 +-----
> 1 file changed, 13 insertions(+), 9 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
-- next part -
per_commit_planes(dev, old_state, 0);
> + drm_atomic_helper_commit_planes(dev, old_state,
> + DRM_PLANE_COMMIT_ACTIVE_ONLY);
> drm_atomic_helper_commit_modeset_enables(dev, old_state);
Just to make sure. "ACTIVE" in this context m
aranteed to be called after drivers shut
> down the device.
>
> Suggested-by: Daniel Vetter
> Signed-off-by: Laurent Pinchart
Tested-by: Tomi Valkeinen
Tomi
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-
On 14/12/16 13:48, Laurent Pinchart wrote:
> Hi Tomi,
>
> On Wednesday 14 Dec 2016 12:22:29 Tomi Valkeinen wrote:
>> On 14/12/16 02:27, Laurent Pinchart wrote:
>>> As the FIFO underflow IRQ handler just prints an error message to the
>>> kernel log, simplify th
SPC_MGR_FLD_ENABLE);
> -}
> -EXPORT_SYMBOL(dispc_mgr_is_enabled);
> -
dispc_mgr_is_enabled() is only used in a WARN, so we could even drop the
function, and then no moving is needed. But I'd rather leave that WARN
at least for now. It's quite good at catching bad SW. So:
Reviewed-by: Tomi Va
On 14/12/16 23:32, Laurent Pinchart wrote:
> Hi Peter,
>
> On Thursday 01 Sep 2016 14:22:54 Peter Ujfalusi wrote:
>> Hi,
>>
>> The following series will convert the omapdrm stack to use the generic
>> videmode instead of the private omap_video_timings struct for the panel
>> information.
>>
>>
On 14/12/16 17:05, Tony Lindgren wrote:
> * Laurent Pinchart [161213 15:38]:
>> The series will be annoying to merge given how interleaved the ARM and driver
>> patches are. The easiest solution would be to merge everything through the
>> ARM
>> tree (as the risk of conflict on the DRM side is
On 14/12/16 23:36, Laurent Pinchart wrote:
>> I guess a first step is Peter Ujfalusi's series:
>> https://lkml.org/lkml/2016/9/1/267
>
> Peter, do you plan to respin that patch series ?
That series has been merged already.
Tomi
-- next part --
A non-text attachment
On 14/12/16 13:48, Laurent Pinchart wrote:
> Hi Tomi,
>
> On Wednesday 14 Dec 2016 12:22:29 Tomi Valkeinen wrote:
>> On 14/12/16 02:27, Laurent Pinchart wrote:
>>> As the FIFO underflow IRQ handler just prints an error message to the
>>> kernel log, simplify th
On 15/12/16 12:07, Laurent Pinchart wrote:
>> Or do you have any other ideas how to pass flags to the driver based on
>> the SoC revision?
>
> Or retrieve the SoC revision in the driver. I know this is a bad thing to do
> in general, but when handling errata that are specific to certain ES
>
dler
> ---
> drivers/gpu/drm/omapdrm/omap_crtc.c | 23 +++
> 1 file changed, 15 insertions(+), 8 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signatu
On 14/12/16 02:27, Laurent Pinchart wrote:
> Instead of going through a complicated private IRQ registration
> mechanism, handle the vblank interrupt activation with the standard
> drm_crtc_vblank_get() and drm_crtc_vblank_put() mechanism. This will let
> the DRM core keep the vblank interrupt
5 insertions(+), 22 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20161215/54eba3d3/attachment.sig>
rv.h | 2 +-
> drivers/gpu/drm/omapdrm/omap_irq.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
> drivers/gpu/drm/omapdrm/omap_irq.c | 4
> 1 file changed, 4 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digita
301 - 400 of 3394 matches
Mail list logo
