Dänzer daen...@vmware.com
Signed-off-by: Wolfram Sang w.s...@pengutronix.de
Cc: Dave Airlie airl...@redhat.com
---
stable-candidate, 2.6.39 is affected, too.
drivers/gpu/drm/drm_pci.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm
? And/or
a warning in the else-block? It seems to happen to users...
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Thu, Jun 16, 2011 at 04:47:53PM +0100, Chris Wilson wrote:
On Thu, 16 Jun 2011 08:15:57 -0700, Jesse Barnes jbar...@virtuousgeek.org
wrote:
On Thu, 16 Jun 2011 15:28:46 +0200
Wolfram Sang w.s...@pengutronix.de wrote:
How about BUG_ON(!ptr) in the init-routine for a bit more grace
.
Signed-off-by: Wolfram Sang w.s...@pengutronix.de
Cc: Jesse Barnes jbar...@virtuousgeek.org
Cc: Chris Wilson ch...@chris-wilson.co.uk
---
This is my take on the sugessted solution.
drivers/gpu/drm/i915/i915_dma.c |4 +++-
drivers/gpu/drm/i915/i915_drv.h |2 +-
drivers/gpu/drm/i915
-by: Wolfram Sang w.s...@pengutronix.de
Cc: Jesse Barnes jbar...@virtuousgeek.org
Cc: Chris Wilson ch...@chris-wilson.co.uk
---
Change since V1: changed error-message per Chris' suggestion.
Note: used %04x instead of %lx to fix compile warning.
drivers/gpu/drm/i915/i915_dma.c |4
On Mon, Jun 20, 2011 at 10:38:54AM -0700, Jesse Barnes wrote:
On Mon, 20 Jun 2011 19:36:11 +0200
Wolfram Sang w.s...@pengutronix.de wrote:
Commit 6067aa (drm/i915: split clock gating init into per-chipset
functions) introduces an init_clock_gating-pointer. There is one case,
however
-by: Wolfram Sang w.s...@pengutronix.de
Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org
Cc: Keith Packard kei...@keithp.com
---
Based on v3.0-rc5.
Change since V1: changed error-message per Chris' suggestion.
Note: used %04x instead of %lx to fix compile warning.
drivers/gpu/drm/i915/i915_dma.c
/archives/dri-devel/2011-July/012741.html
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
Sorry for not pinging you when I didn't hear back.
No problem! Will fix it.
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital
accepted, I'd suggest I rerun my scripts again when rc1 is out and
ask Linus to pull this branch [1] directly? This series is merely to show what
I am up to.
Thanks,
Wolfram
[1] git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
devm_no_resource_check
Wolfram Sang (42):
drivers/ata
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/gpu/drm/exynos/exynos_hdmi.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b
this won't cause any conflicts.
Looking forward to comments.
Thanks,
Wolfram
[1] git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
devm_no_resource_check
Wolfram Sang (33):
drivers/ata: don't check resource with devm_ioremap_resource
drivers/char/hw_random: don't check resource
I need a defconfig which would have this driver enabled.
My wish would be a minimal config. Right now, I try to build the driver
with the current config and when that fails I grep through the
(uncompressed) defconfigs for the symbol needed. Gives me 45/57 success
rate on this series. Not
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij linus.wall...@linaro.org (personally at LCE13)
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/gpu/drm
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
Please apply via the subsystem-tree.
drivers/gpu/host1x/drm/hdmi.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu
,
there is still my proposal to rename INIT_COMPLETION to reinit_completion, that
probably needs some more persistence... Yay, so much to clean up \o/
Regards,
Wolfram
Wolfram Sang (27):
arch/mips/lantiq/xway: don't check resource with
devm_ioremap_resource
drivers/amba: don't check resource
. So, fix the drivers and documentation, too.
Acked-by: Rob Herring rob.herr...@calxeda.com
Reviewed-by: Felipe Balbi ba...@ti.com
Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com
Tested-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
V2-V3
On Thu, Aug 22, 2013 at 06:00:14PM +0200, Wolfram Sang wrote:
I2C of helpers used to live in of_i2c.c but experience (from SPI) shows
that it is much cleaner to have this in the core. This also removes a
circular dependency between the helpers and the core, and so we can
finally register child
On Sun, Sep 29, 2013 at 10:50:58AM +0200, Lars-Peter Clausen wrote:
This series removes the redundant driver field from the i2c_client struct. The
field is redundant since the same pointer can be accessed through
to_i2c_driver(client-dev.driver). The commit log suggests that the field has
On Sun, Sep 29, 2013 at 10:50:58AM +0200, Lars-Peter Clausen wrote:
Hi,
This series removes the redundant driver field from the i2c_client struct. The
field is redundant since the same pointer can be accessed through
to_i2c_driver(client-dev.driver). The commit log suggests that the field
> So the plan (again with Wolfram's ack) is for all these patches
> including the i2c-designware ones to go upstream through the drm-intel
> tree, to avoid an intermediate state were things don't work.
Yes. I'd just like to pull in an immutable branch into my i2c/for-next
once this series is
This change will also make Coverity happy by avoiding a theoretical NULL
pointer dereference; yet another reason is to use the above helper function
to tighten the code and make it more readable.
Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
Acked-by: Geert Uytterhoeven
> > IMO it would be better to use id->driver_data unconditionally and save a
> > call to of_device_get_match_data()
> > What would you suggest to move ahead?
>
> I'd suggest using id->driver_data unconditionally, but I'd like Wolfram's
> opinion on this (CC'ed).
IIUC: I'd suggest to leave it
> Should we leave as it is, redundant if-else code block also, or fix it as
> posted in patch v2
Leave it.
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL:
The core will do this for us now.
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c
b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c
index de9007e72f4e85..73e20219d431a7 100644
Since v4.8-rc1, the I2C core will print detailed information when adding an I2C
adapter fails. So, drivers can skip this now.
Should go via subsystem tree, I'd think.
Wolfram Sang (5):
gpu: drm: amd: amdgpu: amdgpu_i2c: don't print error when adding
adapter fails
gpu: drm: mediatek
The core will do this for us now.
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c
b/drivers/gpu/drm/rockchip/inno_hdmi.c
index 006260de9dbd22..566b5634644f82 100644
--- a/drivers/gpu
The core will do this for us now.
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
index 31a676376d732a
The core will do this for us now.
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/radeon/radeon_i2c.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c
b/drivers/gpu/drm/radeon/radeon_i2c.c
index 9590bcd321c09a..021aa005623f80
The core will do this for us now.
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
index 33c9e1bdb114b8
. The drivers still need to call i2c_add_adapter() (or
> i2c_add_number_adapter()) as per normal to complete their registration.
>
> Signed-off-by: Chris Wilson
> Cc: Ville Syrjälä
> Cc: Wolfram Sang
> Cc: linux-i2c at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
>
On Thu, Aug 25, 2016 at 11:07:01PM +0200, Peter Rosin wrote:
> This makes it trivial to constify them, so do that.
>
> Signed-off-by: Peter Rosin
Applied to for-next, thanks! Thanks for the quick ack, Daniel!
-- next part --
A non-text attachment was scrubbed...
Name:
From: Wolfram Sang <wsa+rene...@sang-engineering.com>
Fix this typo, consequently used over both files :)
Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
---
drivers/gpu/drm/i2c/adv7511.c | 22 +++---
drivers/gpu/drm/i2c/adv7511.h | 12 ++---
From: Wolfram Sang <wsa+rene...@sang-engineering.com>
The interrupts for EDID_READY or DDC_ERROR were never enabled in this
driver, so reading EDID always timed out when chip was powered down and
interrupts were used. Fix this and remove clearing the interrupt flags,
they are c
From: Wolfram Sang <wsa+rene...@sang-engineering.com>
This register includes a counter which is decremented by the chip on I2C
failures. Also, it is reset when powering down.
Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
---
drivers/gpu/drm/i2c/adv7511.c |
> A small note though, even though the patch is correct, it will be of limited
> use as the EDID_READ_CTRL register is never accessed by the driver.
It was useful to me when debugging and looking at the register set in
debugfs.
-- next part --
A non-text attachment was
On Mon, Jan 04, 2016 at 04:37:44PM +0200, Laurent Pinchart wrote:
> Hi Wolfram,
>
> Thank you for the patch.
>
> On Monday 04 January 2016 03:33:45 Wolfram Sang wrote:
> > From: Wolfram Sang <wsa+renesas at sang-engineering.com>
> >
> > The interrupts
So, here is my V2 of this series. Changes:
* Added tags. Thanks to Laurent and Lars-Peter for review and to Archit for
testing. Much appreciated!
* rephrased the comment and commit message in patch 1 to be hopefully less
confusing :)
No code changes!
Thanks,
Wolfram
Wolfram Sang (3
From: Wolfram Sang <wsa+rene...@sang-engineering.com>
The interrupts for EDID_READY or DDC_ERROR were never enabled in this
driver, so reading EDID always timed out when chip was powered down and
interrupts were used. Fix this and also remove clearing the interrupt
flags, they are c
From: Wolfram Sang <wsa+rene...@sang-engineering.com>
This register includes a counter which is decremented by the chip on I2C
failures. Also, it is reset when powering down.
Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
Reviewed-by: Laurent Pinchart
Tested-by: A
From: Wolfram Sang <wsa+rene...@sang-engineering.com>
Fix this typo, consequently used over both files :)
Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
Acked-by: Lars-Peter Clausen
Reviewed-by: Laurent Pinchart
Tested-by: Archit Taneja
---
drivers/gpu/drm/i
On Fri, Jan 08, 2016 at 10:56:48PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas at sang-engineering.com>
>
> The interrupts for EDID_READY or DDC_ERROR were never enabled in this
> driver, so reading EDID always timed out when chip was powered down and
> inte
On Fri, Jan 08, 2016 at 10:56:47PM +0100, Wolfram Sang wrote:
> So, here is my V2 of this series. Changes:
>
> * Added tags. Thanks to Laurent and Lars-Peter for review and to Archit for
> testing. Much appreciated!
> * rephrased the comment and commit message in patch 1 to be
to 29ce4ed441d04a8931150f291c0f7d961690ab81:
drm: adv7511: it's HPD, not HDP (2016-02-02 15:37:55 +0100)
Wolfram Sang (3):
drm: adv7511: really enable interrupts for EDID detection
drm: adv7511: mark ADV7511_REG_EDID_READ_CTRL volatile
drm: adv7511
> Would you be okay if I take this patch along with the device tree
> binding change into a stable branch and provide a tag for you to pull
> into the I2C tree?
Yes, once my comments to the previous patch are addressed, we can do
that. For this patch already:
Acked-by: Wol
> For
> example some Tegra devices have an I2C interface which may share its
> pins with other devices and to share these pins subnodes for
> representing these pins so they have be shared via the pinctrl framework
> are needed.
I think the above sentence is hard to grasp. Can you split it into
d under this
> subnode.
>
> Signed-off-by: Jon Hunter
> Acked-by: Thierry Reding
> Acked-by: Rob Herring
Acked-by: Wolfram Sang
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
De
From: Wolfram Sang <wsa+rene...@sang-engineering.com>
This change will also make Coverity happy by avoiding a theoretical NULL
pointer dereference; yet another reason is to use the above helper function
to tighten the code and make it more readable.
Signed-off-by: Wolfram Sang <ws
On Tue, Mar 15, 2016 at 09:30:29AM +0900, Sergey Senozhatsky wrote:
> On (03/14/16 17:40), Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20160311:
> >
> > The vfs tree gained a conflict against Linus' tree. I also applied a
> > patch for a known runtime bug.
> >
> > The tip tree
> Once I've a patch-set everyone likes I will start talking to people
> to coordinate the merging, I believe it is probably best for all this
> to be merged through the drm-intel tree. But we'll see about that
> when the patch-set is ready.
Agreed.
signature.asc
Description: PGP signature
Hi Hans,
> So Wolfram, what is the plan with these ? As said they are necessary
> for the 2 i2c patches in this patch-set, so do you want the
> entire set of 8 i2c patches to go through an other tree to avoid
> inter tree dependencies ?
Thanks for the heads up. So, my plan was that I send a pull
On Thu, Sep 25, 2014 at 09:22:01AM -0500, Felipe Balbi wrote:
> On Thu, Sep 25, 2014 at 01:27:18PM +0530, Vinod Koul wrote:
> > On Wed, Sep 24, 2014 at 03:32:19PM -0500, Felipe Balbi wrote:
> > > > > > OK, I guess this is as good as it gets.
> > > > > >
> > > > > > What tree would you like it go
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang
Reviewed-by: Terje Bergstrom
---
Should go via subsystem tree
drivers/gpu/drm/tegra/hdmi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu
interested
in picking it up?
Wolfram
Tushar Behera (2):
DRM: Armada: Use devm_ioremap_resource
lib: devres: Remove deprecated devm_request_and_ioremap
Wolfram Sang (1):
bus: brcmstb_gisb: Use devm_ioremap_resource
Documentation/driver-model/devres.txt | 1 -
drivers/bus/brcmstb_gisb.c
From: Tushar Behera <tushar.beh...@linaro.org>
While at it, propagate the error code.
Signed-off-by: Tushar Behera
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/armada/armada_crtc.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/
On Thu, Jun 19, 2014 at 08:48:58PM +0200, Wolfram Sang wrote:
> Pretty much a year ago, Tushar cleaned up a lot of deprecated uses of
> devm_request_and_ioremap, yet some remains are still left. Remove the last two
> users, and let the function rest in peace. I'd suggest that th
On Thu, Jun 19, 2014 at 07:59:57PM -0700, 'Greg Kroah-Hartman' wrote:
> On Fri, Jun 20, 2014 at 11:36:03AM +0900, Jingoo Han wrote:
> > On Friday, June 20, 2014 3:49 AM, Wolfram Sang wrote:
> > >
> > > Pretty much a year ago, Tushar cleaned
> > I already sent the same patch as one single patch to Greg Kroah-Hartman. [1]
> > Also, it was accepted by Greg Kroah-Hartman. [2] Thank you.
> >
> > [1] https://lkml.org/lkml/2014/6/11/26
> > [2] https://lkml.org/lkml/2014/6/11/649
>
> Yeah, I'll go apply that right now while I'm remembering
This platform_driver does not need to set an owner, it will be populated by the
driver core.
Signed-off-by: Wolfram Sang
---
Generated with coccinelle. SmPL file is in the introductory msg. The big
cleanup was pulled in this merge window. This series catches the bits fallen
through. The patches
a coccinelle bug on
the way :)
Wolfram Sang (28):
ARM: mach-exynos: drop owner assignment from platform_drivers
mips: lantiq: xway: drop owner assignment from platform_drivers
mips: pci: drop owner assignment from platform_drivers
char: ipmi: drop owner assignment from platform_drivers
c
Since commit ab78029ecc34 (drivers/pinctrl: grab default handles from device
core), we can rely on device core for setting the default pins.
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 7 ---
drivers/gpu/drm/tilcdc/tilcdc_slave.c | 7 ---
drivers/gpu/drm
The core does this automatically, no need to do this explicitly in drivers.
Those patchces should go via the respective subtrees. Thanks!
Wolfram Sang (4):
drivers/gpu/drm/tilcdc: don't use devm_pinctrl_get_select_default() in
probe
drivers/mmc/host: don't use
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 --
drivers
accepted, I'd suggest I rerun my scripts again when rc1 is out and
ask Linus to pull this branch [1] directly? This series is merely to show what
I am up to.
Thanks,
Wolfram
[1] git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
devm_no_resource_check
Wolfram Sang (42):
drivers/ata
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/exynos/exynos_hdmi.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/exynos/exynos_hdmi.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos
this won't cause any conflicts.
Looking forward to comments.
Thanks,
Wolfram
[1] git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
devm_no_resource_check
Wolfram Sang (33):
drivers/ata: don't check resource with devm_ioremap_resource
drivers/char/hw_random: don't check resource
> I need a defconfig which would have this driver enabled.
My wish would be a minimal config. Right now, I try to build the driver
with the current config and when that fails I grep through the
(uncompressed) defconfigs for the symbol needed. Gives me 45/57 success
rate on this series. Not
. So, fix the drivers and documentation, too.
Acked-by: Rob Herring
Reviewed-by: Felipe Balbi
Acked-by: Rafael J. Wysocki
Tested-by: Sylwester Nawrocki
Signed-off-by: Wolfram Sang
---
V2->V3: Was trying to be too smart by only fixing includes needed.
Took a more general appro
On Thu, Aug 22, 2013 at 06:00:14PM +0200, Wolfram Sang wrote:
> I2C of helpers used to live in of_i2c.c but experience (from SPI) shows
> that it is much cleaner to have this in the core. This also removes a
> circular dependency between the helpers and the core, and so we can
> fina
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c |6
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang
---
Please apply via the subsystem-tree.
drivers/gpu/host1x/drm/hdmi.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/host1x/drm/hdmi.c b
,
there is still my proposal to rename INIT_COMPLETION to reinit_completion, that
probably needs some more persistence... Yay, so much to clean up \o/
Regards,
Wolfram
Wolfram Sang (27):
arch/mips/lantiq/xway: don't check resource with
devm_ioremap_resource
drivers/amba: don't check resource
> Wolfram, do you know of any cases where adapter->dev.of_node would not
> be the same as adapter->dev.parent->of_node?
i2c-muxes, I'd say. dev.parent is the device of the parent I2C adapter,
while the devices get populated from the of_node of the muxing device.
-- next part
> Note that I could not yet read EDID with Magnus' Koelsch.
This has been tackled as well now. The clock for the GPIO controller was
off, so no interrupt was passed through.
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type:
From: Wolfram Sang <wsa+rene...@sang-engineering.com>
This register includes a counter which is decremented by the chip on I2C
failures. Also, it is reset when powering down.
Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
---
drivers/gpu/drm/i2c/adv7511.c |
From: Wolfram Sang <wsa+rene...@sang-engineering.com>
The interrupts for EDID_READY or DDC_ERROR were never enabled in this
driver, so reading EDID always timed out when the chip was powered down
and interrupts were used. Fix this and remove clearing the interrupt flags,
since they are c
From: Wolfram Sang <wsa+rene...@sang-engineering.com>
Fix this typo, consequently used over both files :)
Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
---
drivers/gpu/drm/i2c/adv7511.c | 22 +++---
drivers/gpu/drm/i2c/adv7511.h | 12 ++---
> > This has been tackled as well now. The clock for the GPIO controller was
> > off, so no interrupt was passed through.
>
> Thanks a lot for your efforts! When you have time, can you please show
> me the patch that fixes that GPIO interrupt problem? I'm asking
> because I may have ran into a
> I guess you mean that the GPIO callbacks include Runtime PM handling
> however for irq_chip Runtime PM may not be hooked up so the GPIO block
> is in such case is not powered on / get clock enabled?
Yes. There is another drawback when GPIOs are not properly requested. It
is still possible to
On Thu, Nov 26, 2015 at 01:43:33PM +0100, Lars-Peter Clausen wrote:
> On 11/25/2015 09:27 AM, Wolfram Sang wrote:
> >
> >> I guess you mean that the GPIO callbacks include Runtime PM handling
> >> however for irq_chip Runtime PM may not be hooked up so the GPIO
he direction, but having a rule of thumb
here is definately a good thing. Thanks for the pointer!
So, for the I2C part:
Acked-by: Wolfram Sang
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digit
On Mon, Jun 20, 2011 at 10:38:54AM -0700, Jesse Barnes wrote:
> On Mon, 20 Jun 2011 19:36:11 +0200
> Wolfram Sang wrote:
>
> > Commit 6067aa (drm/i915: split clock gating init into per-chipset
> > functions) introduces an init_clock_gating-pointer. There is one case,
>
-by: Wolfram Sang
Reviewed-by: Jesse Barnes
Cc: Keith Packard
---
Based on v3.0-rc5.
Change since V1: changed error-message per Chris' suggestion.
Note: used %04x instead of %lx to fix compile warning.
drivers/gpu/drm/i915/i915_dma.c |4 +++-
drivers/gpu/drm/i915/i915_drv.h |2
op.org/archives/dri-devel/2011-July/012741.html
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
-- next part --
A non-text attachment was scrubbed..
> Sorry for not pinging you when I didn't hear back.
No problem! Will fix it.
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
-- next p
?nzer
Signed-off-by: Wolfram Sang
Cc: Dave Airlie
---
stable-candidate, 2.6.39 is affected, too.
drivers/gpu/drm/drm_pci.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
index e1aee4f..e4e7fde 100644
--- a/drivers/gpu
_wm = NULL;
}
This can lead to a NULL-pointer exception as in
https://bugzilla.kernel.org/show_bug.cgi?id=37252
Fix it by checking if the pointer is valid before using it.
Signed-off-by: Wolfram Sang
Cc: Jesse Barnes
Cc: Keith Packard
---
Compile tested only, due to no hardware. I was go
y do during bringup).
How about BUG_ON(!ptr) in the init-routine for a bit more grace? And/or
a warning in the else-block? It seems to happen to users...
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengu
On Thu, Jun 16, 2011 at 04:47:53PM +0100, Chris Wilson wrote:
> On Thu, 16 Jun 2011 08:15:57 -0700, Jesse Barnes virtuousgeek.org> wrote:
> > On Thu, 16 Jun 2011 15:28:46 +0200
> > Wolfram Sang wrote:
> > > How about BUG_ON(!ptr) in the init-routine for a bit more gr
.
Signed-off-by: Wolfram Sang
Cc: Jesse Barnes
Cc: Chris Wilson
---
This is my take on the sugessted solution.
drivers/gpu/drm/i915/i915_dma.c |4 +++-
drivers/gpu/drm/i915/i915_drv.h |2 +-
drivers/gpu/drm/i915/intel_display.c | 20 ++--
3 files changed, 18
One helper checks if DMA is suitable and optionally creates a bounce
buffer, if not. The other function returns the bounce buffer and makes
sure the data is properly copied back to the message.
Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
---
drivers/i2c/i2c-core-base.
This ensures that we fall back to PIO if the message length is too small
for DMA being useful. Otherwise, we use DMA. A bounce buffer might be
applied by the helper if the original message buffer is not DMA safe.
Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
---
drive
this work, thank you very much!
Regards,
Wolfram
Changes since v3:
* completely redesigned
Wolfram Sang (6):
i2c: add a message flag for DMA safe buffers
i2c: add helpers to ease DMA handling
i2c: add docs to clarify DMA handling
i2c: sh_mobile: use helper to decide if DMA is useful
This HW is prone to races, so it needs to setup new messages in irq
context. That means we can't alloc bounce buffers if a message buffer is
not DMA safe. So, in that case, simply fall back to PIO.
Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
---
drivers/i2c/busses/i2c-
I2C has no requirement that the buffer of a message needs to be DMA
safe. In case it is, it can now be flagged, so drivers wishing to
do DMA can use the buffer directly.
Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
---
include/uapi/linux/i2c.h | 3 +++
1 file chan
Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
---
Documentation/i2c/DMA-considerations | 50
1 file changed, 50 insertions(+)
create mode 100644 Documentation/i2c/DMA-considerations
diff --git a/Documentation/i2c/DMA-considerati
Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
---
drivers/i2c/i2c-dev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
index 6f638bbc922db4..bbc7aadb4c899d 100644
--- a/drivers/i2c/i2c-dev.c
+++ b/drivers/i2c/i2c
with this series at
least. A branch can be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/platform_data
Thanks and kind regards,
Wolfram
Wolfram Sang (1):
gpu: drm: tc35876x: move header file out of I2C realm
arch/x86/platform/intel-mid/device_libs
include/linux/i2c is not for client devices. Move the header file to a
more appropriate location.
Signed-off-by: Wolfram Sang <w...@the-dreams.de>
---
arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c | 2 +-
drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c | 2 +-
i
1 - 100 of 284 matches
Mail list logo
