Re: [v7 3/7] arm64: defconfig: Enable HIMAX_HX83102 panel

2024-05-17 Thread Arnd Bergmann
On Thu, May 16, 2024, at 14:09, Doug Anderson wrote: > On Thu, May 16, 2024 at 6:43 AM Doug Anderson wrote: >> On Wed, May 15, 2024 at 11:55 PM wrote: >> > On 16/05/2024 08:43, cong yang wrote: >> > >> > Yeah we usually don't mess with arch specific defconfig from drm tree >> >> In general I

Re: [PATCH v2 1/1] video: Handle HAS_IOPORT dependencies

2024-05-15 Thread Arnd Bergmann
conveniently all those functions with the vga_io_* prefix. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle > --- > Note: This patch does not depend any not-yet-mainline HAS_IOPORT changes > and may be merged via subsyste

Re: [PATCH v2 5/5] misc: add ge-addon-connector driver

2024-05-10 Thread Arnd Bergmann
On Fri, May 10, 2024, at 12:54, Luca Ceresoli wrote: > On Fri, 10 May 2024 12:24:06 +0200 "Arnd Bergmann" wrote: >> On Fri, May 10, 2024, at 09:55, Greg Kroah-Hartman wrote: >> > On Fri, May 10, 2024 at 09:10:41AM +0200, Luca Ceresoli wrote: >> &g

Re: [PATCH v2 5/5] misc: add ge-addon-connector driver

2024-05-10 Thread Arnd Bergmann
On Fri, May 10, 2024, at 09:55, Greg Kroah-Hartman wrote: > On Fri, May 10, 2024 at 09:10:41AM +0200, Luca Ceresoli wrote: >> >> +config GE_SUNH_CONNECTOR >> +tristate "GE SUNH hotplug add-on connector" >> +depends on OF >> +select OF_OVERLAY >> +select FW_LOADER >> +select

Re: [PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate

2024-05-08 Thread Arnd Bergmann
On Wed, May 8, 2024, at 22:36, Sam Ravnborg wrote: >> >> I think if you want to do a new version, that is likely to run >> into new problems, given that this part of fbdev is particularly >> fragile and partly wrong. On the other hand, it would be nice to >> have a patch to limit the use of the

Re: [PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate

2024-05-08 Thread Arnd Bergmann
On Wed, May 8, 2024, at 20:37, Florian Fainelli wrote: > On 5/7/24 04:44, Arnd Bergmann wrote: >> On Tue, May 7, 2024, at 13:10, Daniel Vetter wrote: >>> On Mon, May 06, 2024 at 04:53:47PM +0200, Arnd Bergmann wrote: >> Right, let's wait for Florian to reply. From what h

Re: [PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate

2024-05-07 Thread Arnd Bergmann
On Tue, May 7, 2024, at 13:10, Daniel Vetter wrote: > On Mon, May 06, 2024 at 04:53:47PM +0200, Arnd Bergmann wrote: >> On Mon, May 6, 2024, at 15:14, Daniel Vetter wrote: >> > On Fri, May 03, 2024 at 01:22:10PM -0700, Florian Fainelli wrote: >> >> On 5/3

Re: [PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate

2024-05-06 Thread Arnd Bergmann
On Mon, May 6, 2024, at 16:53, Arnd Bergmann wrote: > On Mon, May 6, 2024, at 15:14, Daniel Vetter wrote: >> >> This one is. And it doesn't need to be simpledrm, just a drm kms driver >> with fbdev emulation. Heck even if you have an fbdev driver you should >> control

Re: [PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate

2024-05-06 Thread Arnd Bergmann
On Mon, May 6, 2024, at 15:14, Daniel Vetter wrote: > On Fri, May 03, 2024 at 01:22:10PM -0700, Florian Fainelli wrote: >> On 5/3/24 12:45, Arnd Bergmann wrote: >> > On Fri, May 3, 2024, at 21:28, Florian Fainelli wrote: >> > > Android devices in recovery mode ma

Re: [PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate

2024-05-03 Thread Arnd Bergmann
On Fri, May 3, 2024, at 21:28, Florian Fainelli wrote: > Android devices in recovery mode make use of a framebuffer device to > provide an user interface. In a GKI configuration that has CONFIG_FB=m, > but CONFIG_FB_NOTIFY=y, loading the fb.ko module will fail with: > > fb: Unknown symbol

Re: [PATCH v3 0/3] arch: Remove fbdev dependency from video helpers

2024-05-03 Thread Arnd Bergmann
On Fri, Apr 5, 2024, at 11:04, Thomas Zimmermann wrote: > Hi, > > if there are no further comments, can this series be merged through > asm-generic? Sorry for the delay, I've merged these for asm-generic now. Arnd

Re: nouveau: r535.c:1266:3: error: label at end of compound statement default: with gcc-8

2024-04-29 Thread Arnd Bergmann
On Mon, Apr 29, 2024, at 19:08, Timur Tabi wrote: > On Mon, 2024-04-29 at 17:30 +0200, Linux regression tracking (Thorsten > Leemhuis) wrote: >> TWIMC, there is another report about this in this thread (sadly some of >> its post did not make it to lore): >> >>

Re: [PATCH] drm: move DRM-related CONFIG options into DRM submenu

2024-04-23 Thread Arnd Bergmann
k this is a useful cleanup. Acked-by: Arnd Bergmann

Re: [PATCH 00/11] drm: Restore helper usability

2024-04-22 Thread Arnd Bergmann
On Mon, Apr 22, 2024, at 21:42, Masahiro Yamada wrote: > On Tue, Apr 23, 2024 at 3:24 AM Arnd Bergmann wrote: >> On Mon, Apr 22, 2024, at 18:58, Geert Uytterhoeven wrote: >> > On Mon, Apr 22, 2024 at 3:55 PM Arnd Bergmann wrote: >> >> On Mon, Apr 22, 2024, at 15:

Re: [PATCH 1/1] video: Handle HAS_IOPORT dependencies

2024-04-22 Thread Arnd Bergmann
On Mon, Apr 22, 2024, at 10:34, Niklas Schnelle wrote: > On Thu, 2024-04-11 at 16:00 +0200, Helge Deller wrote: >> * Niklas Schnelle : >> > In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at >> > compile time. We thus need to #ifdef functions and their callsites which >> >

Re: [PATCH 00/11] drm: Restore helper usability

2024-04-22 Thread Arnd Bergmann
On Mon, Apr 22, 2024, at 18:58, Geert Uytterhoeven wrote: > On Mon, Apr 22, 2024 at 3:55 PM Arnd Bergmann wrote: >> On Mon, Apr 22, 2024, at 15:28, Jani Nikula wrote: >> Whereas this one is broken: >> >> config FEATURE_A >>tristate "user visible if I2

Re: [PATCH 00/11] drm: Restore helper usability

2024-04-22 Thread Arnd Bergmann
On Mon, Apr 22, 2024, at 15:28, Jani Nikula wrote: > On Mon, 22 Apr 2024, "Arnd Bergmann" wrote: >> On Mon, Apr 22, 2024, at 13:50, Jani Nikula wrote: >> >>> I still disagree with this, because fundamentally the source symbol >>> really should not have t

Re: [PATCH 00/11] drm: Restore helper usability

2024-04-22 Thread Arnd Bergmann
ivers selected the >> helpers (and any of their dependencies, if they can be met) they need. >> In general, when a symbol selects another symbol, it should just make >> sure the dependencies of the target symbol are met, which may mean >> adding dependencies to the source symbol. Than

[PATCH 2/2] drm/amd/display: fix graphics_object_id size

2024-04-18 Thread Arnd Bergmann
From: Arnd Bergmann The graphics_object_id structure is meant to fit into 32 bits, as it's passed by value in and out of functions. A recent change increased the size to 128 bits, so it's now always passed by reference, which is clearly not intended and ends up producing a compile-time warning

[PATCH 1/2] drm/amd/display: dynamically allocate dml2_configuration_options structures

2024-04-18 Thread Arnd Bergmann
From: Arnd Bergmann This structure is too large to fit on a stack, as shown by the newly introduced warnings from a recent code change: drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn32/dcn32_resource.c: In function 'dcn32_update_bw_bounding_box': drivers/gpu/drm/amd/amdgpu/../display/dc

[PATCH] accel/qaic: mark debugfs stub functions as static inline

2024-04-09 Thread Arnd Bergmann
From: Arnd Bergmann The alternative stub functions are listed as global, which produces a build failure in some configs: In file included from drivers/accel/qaic/qaic_drv.c:31: drivers/accel/qaic/qaic_debugfs.h:16:5: error: no previous prototype for 'qaic_bootlog_register' [-Werror=missing

[PATCH] drm/msm: remove an unused-but-set variable

2024-04-05 Thread Arnd Bergmann
From: Arnd Bergmann The modification to a6xx_get_shader_block() had no effect other than causing a warning: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used [-Werror,-Wunused-but-set-variable] u64 out = dumper->iova + A6XX_CD_DATA_OFF

Re: [PATCH 1/1] vgacon: add HAS_IOPORT dependencies

2024-04-05 Thread Arnd Bergmann
On Fri, Apr 5, 2024, at 17:43, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at > compile time. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Arnd

[PATCH] drm: fix DRM_DISPLAY_DP_HELPER dependencies, part 2

2024-04-05 Thread Arnd Bergmann
From: Arnd Bergmann After my fix yesterday, I ran into another problem of the same kind: aarch64-linux-ld: drivers/gpu/drm/bridge/analogix/analogix_dp_core.o: in function `drm_dp_dpcd_readb': analogix_dp_core.c:(.text+0x194): undefined reference to `drm_dp_dpcd_read' aarch64-linux-ld: drivers

[PATCH] [v2] nouveau: fix function cast warning

2024-04-04 Thread Arnd Bergmann
From: Arnd Bergmann Calling a function through an incompatible pointer type causes breaks kcfi, so clang warns about the assignment: drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowof.c:73:10: error: cast from 'void (*)(const void *)' to 'void (*)(void *)' converts to incompatible function

[PATCH] drm: fix DRM_DISPLAY_DP_HELPER dependencies

2024-04-04 Thread Arnd Bergmann
From: Arnd Bergmann Both the exynos and rockchip drivers ran into link failures after a Kconfig cleanup: aarch64-linux-ld: drivers/gpu/drm/exynos/exynos_dp.o: in function `exynos_dp_resume': exynos_dp.c:(.text+0xc0): undefined reference to `analogix_dp_resume' aarch64-linux-ld: drivers/gpu/drm

[PATCH 00/34] address all -Wunused-const warnings

2024-04-03 Thread Arnd Bergmann
From: Arnd Bergmann Compilers traditionally warn for unused 'static' variables, but not if they are constant. The reason here is a custom for C++ programmers to define named constants as 'static const' variables in header files instead of using macros or enums. In W=1 builds, we get warnings

[PATCH 22/34] drm/komeda: don't warn for unused debugfs files

2024-04-03 Thread Arnd Bergmann
From: Arnd Bergmann With debugfs disabled, the komeda_register debugfs file is unused: drivers/gpu/drm/arm/display/komeda/komeda_dev.c:44:1: error: unused variable 'komeda_register_fops' [-Werror,-Wunused-const-variable] DEFINE_SHOW_ATTRIBUTE(komeda_register); The komeda_debugfs_init

[PATCH 13/34] sisfb: hide unused variables

2024-04-03 Thread Arnd Bergmann
From: Arnd Bergmann Building with W=1 shows that a couple of variables in this driver are only used in certain configurations: drivers/video/fbdev/sis/init301.c:239:28: error: 'SiS_Part2CLVX_6' defined but not used [-Werror=unused-const-variable=] 239 | static const unsigned char

Re: [PATCH v2 3/3] arch: Rename fbdev header and source files

2024-03-28 Thread Arnd Bergmann
On Thu, Mar 28, 2024, at 13:46, Helge Deller wrote: > On 3/27/24 21:41, Thomas Zimmermann wrote: >> +++ b/arch/arc/include/asm/video.h >> @@ -0,0 +1,8 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> + >> +#ifndef _ASM_VIDEO_H_ >> +#define _ASM_VIDEO_H_ >> + >> +#include >> + >> +#endif /*

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-27 Thread Arnd Bergmann
On Wed, Mar 27, 2024, at 08:50, Jani Nikula wrote: > On Tue, 26 Mar 2024, "Arnd Bergmann" wrote: >> On Tue, Mar 26, 2024, at 21:24, Jani Nikula wrote: >>> On Tue, 26 Mar 2024, Arnd Bergmann wrote: >> >> It works now. >> >> The original

[PATCH 1/9] fbdev: shmobile: fix snprintf truncation

2024-03-26 Thread Arnd Bergmann
From: Arnd Bergmann The name of the overlay does not fit into the fixed-length field: drivers/video/fbdev/sh_mobile_lcdcfb.c:1577:2: error: 'snprintf' will always be truncated; specified size is 16, but format string expands to at least 25 Make it short enough by changing the string. Fixes

[PATCH 0/9] enabled -Wformat-truncation for clang

2024-03-26 Thread Arnd Bergmann
From: Arnd Bergmann With randconfig build testing, I found only eight files that produce warnings with clang when -Wformat-truncation is enabled. This means we can just turn it on by default rather than only enabling it for "make W=1". Unfortunately, gcc produces a lot more war

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-26 Thread Arnd Bergmann
On Tue, Mar 26, 2024, at 21:24, Jani Nikula wrote: > On Tue, 26 Mar 2024, Arnd Bergmann wrote: >> From: Arnd Bergmann >> index 475e1e8c1d35..0786eb0da391 100644 >> --- a/drivers/net/ethernet/renesas/sh_eth.c >> +++ b/drivers/net/ethernet/renesas/sh_eth.c >> @@

Re: [PATCH 06/12] nouveau: fix function cast warning

2024-03-26 Thread Arnd Bergmann
On Tue, Mar 26, 2024, at 16:20, Timur Tabi wrote: > On Tue, 2024-03-26 at 15:51 +0100, Arnd Bergmann wrote: >> Calling a function through an incompatible pointer type causes breaks >> kcfi, so clang warns about the assignment: >> > > ... > >> +static void of_f

[PATCH 06/12] nouveau: fix function cast warning

2024-03-26 Thread Arnd Bergmann
From: Arnd Bergmann Calling a function through an incompatible pointer type causes breaks kcfi, so clang warns about the assignment: drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowof.c:73:10: error: cast from 'void (*)(const void *)' to 'void (*)(void *)' converts to incompatible function

[PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-26 Thread Arnd Bergmann
From: Arnd Bergmann The -Woverride-init warn about code that may be intentional or not, but the inintentional ones tend to be real bugs, so there is a bit of disagreement on whether this warning option should be enabled by default and we have multiple settings in scripts/Makefile.extrawarn

[PATCH 00/12] kbuild: enable some -Wextra warnings by default

2024-03-26 Thread Arnd Bergmann
From: Arnd Bergmann This is a follow-up on a couple of patch series I sent in the past, enabling -Wextra (aside from stuff that is explicitly disabled), -Wcast-function-pointer-strict and -Wrestrict. I have tested these on 'defconfig' and 'allmodconfig' builds across all architectures, as well

[PATCH] [RESEND] drm/imagination: avoid -Woverflow warning

2024-03-22 Thread Arnd Bergmann
From: Arnd Bergmann The array size calculation in pvr_vm_mips_fini() appears to be incorrect based on taking the size of the pointer rather than the size of the array, which manifests as a warning about signed integer overflow: In file included from include/linux/kernel.h:16

[PATCH] drm/i915: add intel_opregion_vbt_present() stub function

2024-03-13 Thread Arnd Bergmann
From: Arnd Bergmann The newly added function is not available without CONFIG_ACPI, causing a build failure: drivers/gpu/drm/i915/display/intel_bios.c:3424:24: error: implicit declaration of function 'intel_opregion_vbt_present'; did you mean 'intel_opregion_asle_present'? [-Werror=implicit

Re: [PATCH v2 28/28] fbdev/p9100: Drop now unused driver p9100

2024-03-11 Thread Arnd Bergmann
On Sat, Mar 9, 2024, at 19:15, Sam Ravnborg via B4 Relay wrote: > From: Sam Ravnborg > > The p9100 driver is only relevant for the Sparcbook 3 machine, > and with sun4m support removed this driver is no longer relevant. > > Signed-off-by: Sam Ravnborg > Acked-by: A

Re: [RFC PATCH net-next v6 05/15] netdev: support binding dma-buf to netdevice

2024-03-05 Thread Arnd Bergmann
On Tue, Mar 5, 2024, at 21:00, Mina Almasry wrote: > On Tue, Mar 5, 2024 at 1:05 AM Arnd Bergmann wrote: >> On Tue, Mar 5, 2024, at 03:01, Mina Almasry wrote: > > A key goal of this patch series is that the kernel does not try to > parse the skb frags that reside in the dma-bu

Re: [RFC PATCH net-next v6 12/15] tcp: RX path for devmem TCP

2024-03-05 Thread Arnd Bergmann
On Tue, Mar 5, 2024, at 20:22, Mina Almasry wrote: > On Tue, Mar 5, 2024 at 12:42 AM Arnd Bergmann wrote: >> On Tue, Mar 5, 2024, at 03:01, Mina Almasry wrote: >> >> This structure requires a special compat handler to run >> x86-32 binaries on x86-64 because

Re: [net-next v1 04/16] gve: implement queue api

2024-03-05 Thread Arnd Bergmann
On Fri, Dec 8, 2023, at 01:52, Mina Almasry wrote: > +static void *gve_rx_queue_mem_alloc(struct net_device *dev, int idx) > +{ > + struct gve_per_rx_queue_mem_dqo *gve_q_mem; ... > + > + gve_q_mem = kvcalloc(1, sizeof(*gve_q_mem), GFP_KERNEL); > + if (!gve_q_mem) > + goto

Re: [RFC PATCH net-next v6 05/15] netdev: support binding dma-buf to netdevice

2024-03-05 Thread Arnd Bergmann
On Tue, Mar 5, 2024, at 03:01, Mina Almasry wrote: > +int netdev_bind_dmabuf(struct net_device *dev, unsigned int dmabuf_fd, > +struct netdev_dmabuf_binding **out) > +{ > + struct netdev_dmabuf_binding *binding; > + static u32 id_alloc_next; > + struct scatterlist

Re: [RFC PATCH net-next v6 12/15] tcp: RX path for devmem TCP

2024-03-05 Thread Arnd Bergmann
On Tue, Mar 5, 2024, at 03:01, Mina Almasry wrote: > --- a/arch/alpha/include/uapi/asm/socket.h > +++ b/arch/alpha/include/uapi/asm/socket.h > #define SO_PEERPIDFD 77 > +#define SO_DEVMEM_LINEAR 79 > +#define SO_DEVMEM_DMABUF 80 > --- a/arch/mips/include/uapi/asm/socket.h > +++

Re: arm: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined!

2024-03-04 Thread Arnd Bergmann
On Mon, Mar 4, 2024, at 14:01, Ard Biesheuvel wrote: > On Mon, 4 Mar 2024 at 13:35, Arnd Bergmann wrote: >> On Mon, Mar 4, 2024, at 12:45, Andre Przywara wrote: >> It's not critical if this is called infrequently, and as Maxime >> just replied, the 64-bit division is

Re: arm: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined!

2024-03-04 Thread Arnd Bergmann
On Mon, Mar 4, 2024, at 12:45, Andre Przywara wrote: > On Mon, 04 Mar 2024 12:26:46 +0100 > "Arnd Bergmann" wrote: > >> On Mon, Mar 4, 2024, at 12:24, Andre Przywara wrote: >> > On Mon, 04 Mar 2024 12:11:36 +0100 "Arnd Bergmann" wrote: >> >&

Re: arm: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined!

2024-03-04 Thread Arnd Bergmann
On Mon, Mar 4, 2024, at 12:24, Andre Przywara wrote: > On Mon, 04 Mar 2024 12:11:36 +0100 "Arnd Bergmann" wrote: >> >> This used to be a 32-bit division. If the rate is never more than >> 4.2GHz, clock could be turned back into 'unsigned long' to avoid >>

Re: arm: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined!

2024-03-04 Thread Arnd Bergmann
On Mon, Mar 4, 2024, at 09:07, Naresh Kamboju wrote: > The arm defconfig builds failed on today's Linux next tag next-20240304. > > Build log: > - > ERROR: modpost: "__aeabi_uldivmod" > [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined! > Apparently caused by the 64-bit division in

Re: [PATCH 1/2] drm/buddy: stop using PAGE_SIZE

2024-02-29 Thread Arnd Bergmann
; Cc: Christian König > Cc: Arnd Bergmann Acked-by: Arnd Bergmann

[PATCH] xe: avoid using writeq() on 32-bit

2024-02-28 Thread Arnd Bergmann
From: Arnd Bergmann 32-bit kernels do not provide a writeq(), failing the build: drivers/gpu/drm/xe/xe_ggtt.c:78:2: error: use of undeclared identifier 'writeq' 78 | writeq(pte, >gsm[addr >> XE_PTE_SHIFT]); Using lo_hi_writeq() instead will write the lower 32 bits to th

Re: [PATCH 3/3] [v2] drm/xe/xe2: fix 64-bit division in pte_update_size

2024-02-28 Thread Arnd Bergmann
On Mon, Feb 26, 2024, at 17:40, Lucas De Marchi wrote: > On Mon, Feb 26, 2024 at 01:46:38PM +0100, Arnd Bergmann wrote: >> >>Fixes: 237412e45390 ("drm/xe: Enable 32bits build") >>Signed-off-by: Arnd Bergmann >>--- >>v2: use correct Fixes tag >

[PATCH 3/3] [v2] drm/xe/xe2: fix 64-bit division in pte_update_size

2024-02-26 Thread Arnd Bergmann
From: Arnd Bergmann This function does not build on 32-bit targets when the compiler fails to reduce DIV_ROUND_UP() into a shift: ld.lld: error: undefined symbol: __aeabi_uldivmod >>> referenced by xe_migrate.c >>> drivers/gpu/drm/xe/xe_migrate.o:(pte_updat

[PATCH 2/3] [v2] drm/xe/mmio: fix build warning for BAR resize on 32-bit

2024-02-26 Thread Arnd Bergmann
From: Arnd Bergmann clang complains about a nonsensical test on builds with a 32-bit phys_addr_t, which means resizing will always fail: drivers/gpu/drm/xe/xe_mmio.c:109:23: error: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int

[PATCH 1/3] [v2] drm/xe/kunit: fix link failure with built-in xe

2024-02-26 Thread Arnd Bergmann
From: Arnd Bergmann When the driver is built-in but the tests are in loadable modules, the helpers don't actually get put into the driver: ERROR: modpost: "xe_kunit_helper_alloc_xe_device" [drivers/gpu/drm/xe/tests/xe_test.ko] undefined! Change the Makefile to ensure they are a

Re: [PATCH 1/3] drm/xe/kunit: fix link failure with built-in xe

2024-02-26 Thread Arnd Bergmann
On Mon, Feb 26, 2024, at 04:42, Lucas De Marchi wrote: > On Sat, Feb 24, 2024 at 01:14:59PM +0100, Arnd Bergmann wrote: >>From: Arnd Bergmann >> >>When the driver is built-in but the tests are in loadable modules, >>the helpers don't actually get put into the

[PATCH 3/3] drm/xe/xe2: fix 64-bit division in pte_update_size

2024-02-24 Thread Arnd Bergmann
From: Arnd Bergmann This function does not build on 32-bit targets when the compiler fails to reduce DIV_ROUND_UP() into a shift: ld.lld: error: undefined symbol: __aeabi_uldivmod >>> referenced by xe_migrate.c >>> drivers/gpu/drm/xe/xe_migrate.o:(pte_updat

[PATCH 2/3] drm/xe/mmio: fix build warning for BAR resize on 32-bit

2024-02-24 Thread Arnd Bergmann
From: Arnd Bergmann clang complains about a nonsensical test on builds with a 32-bit phys_addr_t, which means resizing will always fail: drivers/gpu/drm/xe/xe_mmio.c:109:23: error: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int

[PATCH 1/3] drm/xe/kunit: fix link failure with built-in xe

2024-02-24 Thread Arnd Bergmann
From: Arnd Bergmann When the driver is built-in but the tests are in loadable modules, the helpers don't actually get put into the driver: ERROR: modpost: "xe_kunit_helper_alloc_xe_device" [drivers/gpu/drm/xe/tests/xe_test.ko] undefined! Change the Makefile to ensure they are a

Re: [PATCH] drm/tests/drm_buddy: avoid 64-bit calculation

2024-02-19 Thread Arnd Bergmann
On Mon, Feb 19, 2024, at 12:22, Christian König wrote: > Am 17.02.24 um 02:31 schrieb Randy Dunlap: >> On 2/16/24 12:24, Arnd Bergmann wrote: >>> From: Arnd Bergmann >>> >>> The newly added drm_test_buddy_alloc_contiguous() test fails to link on >>>

[PATCH] drm/tests/drm_buddy: avoid 64-bit calculation

2024-02-16 Thread Arnd Bergmann
From: Arnd Bergmann The newly added drm_test_buddy_alloc_contiguous() test fails to link on 32-bit targets because of inadvertent 64-bit calculations: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/tests/drm_buddy_test.ko] undefined! ERROR: modpost: "__aeabi_ldivmod&qu

Re: [PATCH] drm/xe: avoid function cast warnings

2024-02-14 Thread Arnd Bergmann
On Wed, Feb 14, 2024, at 11:10, Thomas Hellström wrote: > On Tue, 2024-02-13 at 10:56 +0100, Arnd Bergmann wrote: >>   >> +static void xe_range_fence_free(struct xe_range_fence * rfence) > > There's a checkpatch.pl style error above: s/* rfence/*rfence/. I can > fix that up

Re: [PATCH] drm/xe: skip building debugfs code for CONFIG_DEBUG_FS=n

2024-02-13 Thread Arnd Bergmann
On Tue, Feb 13, 2024, at 15:55, Jani Nikula wrote: > On Tue, 13 Feb 2024, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> Some of the debugfs functions are stubbed out in these configurations, >> so trying to build the .c file with the definition fails: >> >

[PATCH] drm/xe: skip building debugfs code for CONFIG_DEBUG_FS=n

2024-02-13 Thread Arnd Bergmann
From: Arnd Bergmann Some of the debugfs functions are stubbed out in these configurations, so trying to build the .c file with the definition fails: In file included from include/uapi/linux/posix_types.h:5, from drivers/gpu/drm/i915/display/intel_pipe_crc.c:27: drivers/gpu/drm

[PATCH] nouveau: fix function cast warnings

2024-02-13 Thread Arnd Bergmann
From: Arnd Bergmann clang-16 warns about casting between incompatible function types: drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c:161:10: error: cast from 'void (*)(const struct firmware *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type

[PATCH] drm/xe: avoid function cast warnings

2024-02-13 Thread Arnd Bergmann
From: Arnd Bergmann clang-16 warns about a cast between incompatible function types: drivers/gpu/drm/xe/xe_range_fence.c:155:10: error: cast from 'void (*)(const void *)' to 'void (*)(struct xe_range_fence *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict] 155

Re: [PATCH] backlight: ktd2801: fix LED dependency

2024-02-12 Thread Arnd Bergmann
On Mon, Feb 12, 2024, at 15:31, Duje Mihanović wrote: > On Monday, February 12, 2024 1:44:28 PM CET Daniel Thompson wrote: >> On Mon, Feb 12, 2024 at 12:18:12PM +0100, Arnd Bergmann wrote: > I believe this would be the best thing to do here. Making LEDS_EXPRESSWIRE > user selectab

[PATCH] nouveau/svm: fix kvcalloc() argument order

2024-02-12 Thread Arnd Bergmann
From: Arnd Bergmann The conversion to kvcalloc() mixed up the object size and count arguments, causing a warning: drivers/gpu/drm/nouveau/nouveau_svm.c: In function 'nouveau_svm_fault_buffer_ctor': drivers/gpu/drm/nouveau/nouveau_svm.c:1010:40: error: 'kvcalloc' sizes specified with 'sizeof

[PATCH] backlight: ktd2801: fix LED dependency

2024-02-12 Thread Arnd Bergmann
From: Arnd Bergmann The new backlight driver unconditionally selects LEDS_EXPRESSWIRE, which is in a different subsystem that may be disabled here: WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=y] Select

Re: [PATCH] ARM: multi_v7_defconfig: Enable BACKLIGHT_CLASS_DEVICE

2024-02-02 Thread Arnd Bergmann
On Fri, Feb 2, 2024, at 11:07, Geert Uytterhoeven wrote: > On Fri, Feb 2, 2024 at 10:51 AM Marek Szyprowski > wrote: >> core, because the DRM core is set to be compiled-in in this defconfig. >> This leaves all DRM display panels without integrated backlight control, >> even if the needed modules

Re: Build regressions/improvements in v6.8-rc1

2024-01-23 Thread Arnd Bergmann
On Tue, Jan 23, 2024, at 12:45, Geert Uytterhoeven wrote: >> 68 error regressions: > >> + /kisskb/src/arch/powerpc/sysdev/udbg_memcons.c: error: no previous >> prototype for 'memcons_getc' [-Werror=missing-prototypes]: => 80:5 >> + /kisskb/src/arch/powerpc/sysdev/udbg_memcons.c: error: no

Re: [PATCH] drm: apple: mark local functions static

2024-01-22 Thread Arnd Bergmann
On Mon, Jan 22, 2024, at 21:50, Janne Grunau wrote: > On Wed, Jan 17, 2024, at 11:44, Arnd Bergmann wrote: >> >> -int parse_sample_rate_bit(struct dcp_parse_ctx *handle, unsigned int >> *ratebit) >> +static int parse_sample_rate_bit(struct dcp_parse_ctx *handle

[PATCH] drm: apple: use strscpy() in place of strlcpy()

2024-01-22 Thread Arnd Bergmann
From: Arnd Bergmann Since commit d26270061ae6 ("string: Remove strlcpy()"), the strlcpy() function causes a build failure. Since the return value is ignored, changing it to the strscpy() causes no change in behavior but fixes the build failure. Fixes: f237c83e4302 ("drm: appl

[PATCH] drm: apple: mark local functions static

2024-01-17 Thread Arnd Bergmann
From: Arnd Bergmann With linux-6.8, the kernel warns about functions that have no extern declaration, so mark both of these static. Fixes: 2d782b0d007d ("gpu: drm: apple: Add sound mode parsing") Signed-off-by: Arnd Bergmann --- This is for the bits/200-dcp branch in https://

Re: [PATCH 08/22] [v2] arch: consolidate arch_irq_work_raise prototypes

2024-01-10 Thread Arnd Bergmann
On Wed, Jan 10, 2024, at 10:03, Geert Uytterhoeven wrote: > On Wed, Nov 8, 2023 at 2:01 PM Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> The prototype was hidden in an #ifdef on x86, which causes a warning: >> >> kernel/irq_work.c:72

[PATCH] drm/xe: circumvent bogus stringop-overflow warning

2024-01-03 Thread Arnd Bergmann
From: Arnd Bergmann gcc-13 warns about an array overflow that it sees but that is prevented by the "asid % NUM_PF_QUEUE" calculation: drivers/gpu/drm/xe/xe_gt_pagefault.c: In function 'xe_guc_pagefault_handler': include/linux/fortify-string.h:57:33: error: writing 16 bytes int

Re: [PATCH 00/27] sparc32: sunset sun4m and sun4d

2023-12-20 Thread Arnd Bergmann
On Wed, Dec 20, 2023, at 09:54, John Paul Adrian Glaubitz wrote: > On Wed, 2023-12-20 at 08:36 +0000, Arnd Bergmann wrote: >> All of these were found through inspection rather than testing, >> so there is a good chance that other fatal kernel bugs prevent >> testing in

Re: [PATCH 00/27] sparc32: sunset sun4m and sun4d

2023-12-20 Thread Arnd Bergmann
On Wed, Dec 20, 2023, at 09:34, David Laight wrote: > From: Arnd Bergmann >> Sent: 20 December 2023 08:37 >> >> On Tue, Dec 19, 2023, at 22:03, Sam Ravnborg via B4 Relay wrote: >> > TODO before this can be applied: >> > - Ack from davem - as he is the p

Re: [PATCH 01/27] sparc32: Update defconfig to LEON SMP

2023-12-20 Thread Arnd Bergmann
On Wed, Dec 20, 2023, at 06:43, Sam Ravnborg wrote: > On Tue, Dec 19, 2023 at 10:23:05PM +0000, Arnd Bergmann wrote: >> On Tue, Dec 19, 2023, at 22:03, Sam Ravnborg via B4 Relay wrote: >> > From: Sam Ravnborg >> > >> > This is a copy of the leon_smp defco

Re: [PATCH 00/27] sparc32: sunset sun4m and sun4d

2023-12-20 Thread Arnd Bergmann
On Tue, Dec 19, 2023, at 22:03, Sam Ravnborg via B4 Relay wrote: > TODO before this can be applied: > - Ack from davem - as he is the principal sparc maintainer > - Tested-by: preferably on a target or QEMU (see above) > I expect bugs as there are some involved changes! > > Ideas for the future

Re: [PATCH 01/27] sparc32: Update defconfig to LEON SMP

2023-12-19 Thread Arnd Bergmann
On Tue, Dec 19, 2023, at 22:03, Sam Ravnborg via B4 Relay wrote: > From: Sam Ravnborg > > This is a copy of the leon_smp defconfig found in > gaisler-buildroot-2023.02-1.0. > > Signed-off-by: Sam Ravnborg > Cc: "David S. Miller" > Cc: Arnd Bergmann > Cc: An

[PATCH] drm/exynos: fix accidental on-stack copy of exynos_drm_plane

2023-12-14 Thread Arnd Bergmann
From: Arnd Bergmann gcc rightfully complains about excessive stack usage in the fimd_win_set_pixfmt() function: drivers/gpu/drm/exynos/exynos_drm_fimd.c: In function 'fimd_win_set_pixfmt': drivers/gpu/drm/exynos/exynos_drm_fimd.c:750:1: error: the frame size of 1032 bytes is larger than 1024

Re: [PATCH 3/3] drm/amd/display: Support DRM_AMD_DC_FP on RISC-V

2023-12-09 Thread Arnd Bergmann
On Sat, Dec 9, 2023, at 22:29, Samuel Holland wrote: > On 2023-12-09 2:38 PM, Arnd Bergmann wrote: >> On Fri, Dec 8, 2023, at 06:04, Samuel Holland wrote: >>> On 2023-11-29 6:42 PM, Nathan Chancellor wrote: >>>> >>>> https://lore.kernel.org/20231019205117

Re: [PATCH 3/3] drm/amd/display: Support DRM_AMD_DC_FP on RISC-V

2023-12-09 Thread Arnd Bergmann
On Fri, Dec 8, 2023, at 06:04, Samuel Holland wrote: > On 2023-11-29 6:42 PM, Nathan Chancellor wrote: >> On Thu, Nov 23, 2023 at 02:23:01PM +, Conor Dooley wrote: >>> On Tue, Nov 21, 2023 at 07:05:15PM -0800, Samuel Holland wrote: RISC-V uses kernel_fpu_begin()/kernel_fpu_end() like

Re: [DO NOT MERGE v5 22/37] dt-bindings: display: smi, sm501: SMI SM501 binding json-schema

2023-12-05 Thread Arnd Bergmann
On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote: > Define SM501 functions and modes. > > Signed-off-by: Yoshinori Sato > --- > .../bindings/display/smi,sm501.yaml | 134 ++ > include/dt-bindings/display/sm501.h | 25 It looks like we already have a

Re: [DO NOT MERGE v5 11/37] pci: pci-sh7751: Add SH7751 PCI driver

2023-12-05 Thread Arnd Bergmann
On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote: > +#include > +#include "pci-sh7751.h" > + > +#define pcic_writel(val, base, reg) __raw_writel(val, base + (reg)) > +#define pcic_readl(base, reg) __raw_readl(base + (reg)) __raw_writel()/__raw_readl() has a number of problems with atomicity

Re: [DO NOT MERGE v5 06/37] sh: kernel/setup Update DT support.

2023-12-05 Thread Arnd Bergmann
On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote: > Fix extrnal fdt initialize and bootargs. > > Signed-off-by: Yoshinori Sato > --- > arch/sh/kernel/setup.c | 51 -- > 1 file changed, 34 insertions(+), 17 deletions(-) > > diff --git

Re: [DO NOT MERGE v5 10/37] sh: Common PCI Framework driver support.

2023-12-05 Thread Arnd Bergmann
On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote: > + > +#if defined(CONFIG_PCI) && !defined(CONFIG_GENERIC_IOMAP) > +void pci_iounmap(struct pci_dev *dev, void __iomem *addr) > +{ > + iounmap(addr); > +} > +EXPORT_SYMBOL(pci_iounmap); This definition does not work for addresses that are

Re: [DO NOT MERGE v5 35/37] sh: RTS7751R2D Plus OF defconfig

2023-12-05 Thread Arnd Bergmann
On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > arch/sh/configs/rts7751r2dplus-of_defconfig | 93 + This is very similar to the landisk config, so it may be easier to just have one of them that works for both, as well as future

[PATCH] drm/imagination: move update_logtype() into ifdef section

2023-12-03 Thread Arnd Bergmann
From: Arnd Bergmann This function is only used when debugfs is enabled, and otherwise causes a build warning: drivers/gpu/drm/imagination/pvr_fw_trace.c:135:1: error: 'update_logtype' defined but not used [-Werror=unused-function] Move the #ifdef check to include this function as well. Fixes

[PATCH] drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS

2023-12-03 Thread Arnd Bergmann
From: Arnd Bergmann A dependency on this feature was recently introduced: x86_64-linux-ld: vmlinux.o: in function `tc358768_bridge_pre_enable': tc358768.c:(.text+0xbe3dae): undefined reference to `drm_display_mode_to_videomode' Make sure this is always enabled. Fixes: e5fb21678136 (&quo

Re: [PATCH 1/2] drm/imagination: avoid -Wmissing-prototype warnings

2023-11-29 Thread Arnd Bergmann
few additional fixes, I think we should > probably use that > one. Sure, that's fine. If you don't mind rebasing, just add a "Reported-by: Arnd Bergmann " line as well. I tend to create a bug fix for any build regressions I see as part of building randconfig kernels, but it's no

Re: [PATCH 2/2] drm/imagination: avoid -Woverflow warning

2023-11-29 Thread Arnd Bergmann
On Wed, Nov 29, 2023, at 13:01, Donald Robson wrote: > Hello Arnd, > > Thanks for the patch. I'm slightly concerned that we've not seen this > warning when > building here. I guess we need to check our CI settings... > > Reviewed-by: Donald Robson This was previously enabled only when

[PATCH 2/2] drm/imagination: avoid -Woverflow warning

2023-11-29 Thread Arnd Bergmann
From: Arnd Bergmann The array size calculation in pvr_vm_mips_fini() appears to be incorrect based on taking the size of the pointer rather than the size of the array, which manifests as a warning about signed integer overflow: In file included from include/linux/kernel.h:16

[PATCH 1/2] drm/imagination: avoid -Wmissing-prototype warnings

2023-11-29 Thread Arnd Bergmann
From: Arnd Bergmann This warning option is now enabled by default, causing a few build regressions in combination with the newly added pvr driver: drivers/gpu/drm/imagination/pvr_device.c:130:6: error: no previous prototype for 'pvr_device_process_active_queues' [-Werror=missing-prototypes

[PATCH] drm/rockchip: rk3066_hdmi: include drm/drm_atomic.h

2023-11-22 Thread Arnd Bergmann
From: Arnd Bergmann Without this header, the newly added code fails to build: drivers/gpu/drm/rockchip/rk3066_hdmi.c: In function 'rk3066_hdmi_encoder_enable': drivers/gpu/drm/rockchip/rk3066_hdmi.c:397:22: error: implicit declaration of function 'drm_atomic_get_new_connector_state'; did you

[PATCH] drm/amd/display: avoid stringop-overflow warnings for dp_decide_lane_settings()

2023-11-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc prints a warning about a possible array overflow for a couple of callers of dp_decide_lane_settings() after commit 1b56c90018f0 ("Makefile: Enable -Wstringop-overflow globally"): drivers/gpu/drm/amd/amdgpu/../display/dc/link

Re: [PATCH] vgacon: drop IA64 reference in VGA_CONSOLE dependency list

2023-11-10 Thread Arnd Bergmann
> removed in commit cf8e8658100d ("arch: Remove Itanium (IA-64) > architecture"). > > Drop the reference to IA64 architecture in the dependency list of the > VGA_CONSOLE config definition. > > Signed-off-by: Lukas Bulwahn Thanks for the cleanup, Acked-by: Arnd Bergm

Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype

2023-11-08 Thread Arnd Bergmann
On Wed, Nov 8, 2023, at 21:42, Geert Uytterhoeven wrote: > > On Wed, Nov 8, 2023 at 2:01 PM Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> Microblaze runs into a single -Wmissing-prototypes warning when that is >> enabled: >> >> arch/microblaze

  1   2   3   4   5   6   7   8   9   10   >