Re: [PATCH 1/2] drm/buddy: stop using PAGE_SIZE

2024-05-16 Thread Dave Airlie
On Thu, 29 Feb 2024 at 23:48, Arnd Bergmann wrote: > > On Thu, Feb 29, 2024, at 11:51, Matthew Auld wrote: > > The drm_buddy minimum page-size requirements should be distinct from the > > CPU PAGE_SIZE. Only restriction is that the minimum page-size is at > > least 4K. > > > > Signed-off-by:

Re: [git pull] drm urgent for 6.10-rc1

2024-05-16 Thread Dave Airlie
> >> > >> (And that kernel version of "6.9.0-08295-gfd39ab3b5289" that is quoted > >> in the WARN isn't some official kernel, I have about ten private > >> patches that I keep testing in my tree, so if you wondered what the > >> heck that git version is, it's not going to match anything you see, >

[git pull] drm urgent for 6.10-rc1

2024-05-15 Thread Dave Airlie
Hi Linus, Here is the buddy allocator fix I picked up from the list, please apply. Dave. drm-next-2024-05-16: drm urgent for 6.10-rc1 merge: buddy: - fix breakage in buddy allocator. The following changes since commit 275654c02f0ba09d409c36d71dc238e470741e30: Merge tag

Re: [git pull] drm for 6.10-rc1

2024-05-15 Thread Dave Airlie
On Thu, 16 May 2024 at 10:06, Dave Airlie wrote: > > On Thu, 16 May 2024 at 09:50, Dave Airlie wrote: > > > > On Thu, 16 May 2024 at 06:29, Linus Torvalds > > wrote: > > > > > > On Wed, 15 May 2024 at 13:24, Linus Torvalds > >

Re: [git pull] drm for 6.10-rc1

2024-05-15 Thread Dave Airlie
On Thu, 16 May 2024 at 09:50, Dave Airlie wrote: > > On Thu, 16 May 2024 at 06:29, Linus Torvalds > wrote: > > > > On Wed, 15 May 2024 at 13:24, Linus Torvalds > > wrote: > > > > > > I have to revert both > > > > > &g

Re: [git pull] drm for 6.10-rc1

2024-05-15 Thread Dave Airlie
On Thu, 16 May 2024 at 06:29, Linus Torvalds wrote: > > On Wed, 15 May 2024 at 13:24, Linus Torvalds > wrote: > > > > I have to revert both > > > > a68c7eaa7a8f ("drm/amdgpu: Enable clear page functionality") > > e362b7c8f8c7 ("drm/amdgpu: Modify the contiguous flags behaviour") > > > > to

Re: [git pull] drm for 6.10-rc1

2024-05-15 Thread Dave Airlie
only problem? If so perhaps we need to discuss moving amdgpu more into drm-tip to catch this sort of problem. Dave. From 085b89278f296c40e86f5d1e1bcc1017c39f4002 Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Thu, 16 May 2024 09:46:37 +1000 Subject: [PATCH] drm/buddy: convert WARN_ON to an if + continue This WARN

Re: [git pull] drm for 6.10-rc1

2024-05-15 Thread Dave Airlie
On Thu, 16 May 2024 at 08:56, Linus Torvalds wrote: > > On Wed, 15 May 2024 at 15:45, Dave Airlie wrote: > > > > The drm subsystem enables more warnings than the kernel default, > > so > > this config option is disabled by default. &g

Re: [git pull] drm for 6.10-rc1

2024-05-15 Thread Dave Airlie
On Thu, 16 May 2024 at 06:43, Linus Torvalds wrote: > > On Tue, 14 May 2024 at 23:21, Dave Airlie wrote: > > > > This is the main pull request for the drm subsystems for 6.10. > > .. and now that I look more at this pull request, I find other things wrong. > > W

[PATCH] nouveau: set placement to original placement on uvmm validate.

2024-05-14 Thread Dave Airlie
From: Dave Airlie When a buffer is evicted for memory pressure or TTM evict all, the placement is set to the eviction domain, this means the buffer never gets revalidated on the next exec to the correct domain. I think this should be fine to use the initial domain from the object creation

[PATCH] nouveau/firmware: using dma non-coherent interfaces for fw loading.

2024-05-13 Thread Dave Airlie
From: Dave Airlie Currently, enabling SG_DEBUG in the kernel will cause nouveau to hit a BUG() on startup, when the iommu is enabled: kernel BUG at include/linux/scatterlist.h:187! invalid opcode: [#1] PREEMPT SMP NOPTI CPU: 7 PID: 930 Comm: (udev-worker) Not tainted 6.9.0-rc3Lyude-Test

[git pull] drm fixes for 6.9 final

2024-05-10 Thread Dave Airlie
rogramming for DP Daniele Ceraolo Spurio (1): drm/xe/guc: Check error code when initializing the CT mutex Dave Airlie (5): Merge tag 'drm-intel-fixes-2024-05-08' of https://anongit.freedesktop.org/git/drm/drm-intel into drm-fixes Merge tag 'drm-xe-fixes-2024-05-09

Re: [pull] amdgpu, amdkfd drm-fixes-6.9

2024-05-09 Thread Dave Airlie
On Thu, 9 May 2024 at 09:00, Alex Deucher wrote: > > Hi Dave, Sima, > > Fixes for 6.9. > > The following changes since commit dd5a440a31fae6e459c0d627162825505361: > > Linux 6.9-rc7 (2024-05-05 14:06:01 -0700) > > are available in the Git repository at: > >

Re: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-05-03 Thread Dave Airlie
> Let me know if this understanding is correct. > > Or what would you like to do in such situation? > > > > > Not sure how it is really a good idea. > > > > Adaptive locality of memory is still an unsolved problem in Linux, > > sadly. > > > > > > However, the migration stuff should really not be

[git pull] drm fixes for 6.9-rc7

2024-05-02 Thread Dave Airlie
fix the call oder in amdgpu_ttm_move() v2 Dave Airlie (3): Merge tag 'amd-drm-fixes-6.9-2024-05-01' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes Merge tag 'drm-xe-fixes-2024-05-02' of https://gitlab.freedesktop.org/drm/xe/kernel into drm-fixes Merge tag 'drm-misc

Re: [PATCH 2/2] drm/nouveau/gsp: Use the sg allocator for level 2 of radix3

2024-04-29 Thread Dave Airlie
> Currently, this can result in runtime PM issues on systems where memory > Luckily, we don't actually need to allocate coherent memory for the page > table thanks to being able to pass the GPU a radix3 page table for > suspend/resume data. So, let's rewrite nvkm_gsp_radix3_sg() to use the sg >

Re: [RFC] drm/nouveau: use tile_mode and pte_kind for VM_BIND bo allocations

2024-04-28 Thread Dave Airlie
This looks like a good start, though I wonder can we just refactor out the common code from the vma and non-vma paths easier. Also I wonder should we add a new GETPARAM so userspace can know this change is available. Of course we also need a pointer to the userspace implementation to move

[git pull] drm fixes for 6.8-rc6

2024-04-25 Thread Dave Airlie
allocations - Fix PF/VF relay messages Alex Deucher (1): drm/amdgpu/sdma5.2: use legacy HDP flush for SDMA2/3 Christian Gmeiner (1): Revert "drm/etnaviv: Expose a few more chipspecs to userspace" Dave Airlie (4):

[git pull] drm fixes for 6.9-rc5

2024-04-18 Thread Dave Airlie
: remove invalid resource->start check v2 drm/amdgpu: fix visible VRAM handling during faults Dave Airlie (4): nouveau: fix instmem race condition around ptr stores Merge tag 'amd-drm-fixes-6.9-2024-04-17' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes Merge tag '

[PATCH] nouveau: rip out busy fence waits

2024-04-16 Thread Dave Airlie
From: Dave Airlie I'm pretty sure this optimisation is actually not a great idea, and is racy with other things waiting for fences. Just nuke it, there should be no need to do fence waits in a busy CPU loop. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_bo.c| 2

[git pull] drm fixes for 6.9-rc4

2024-04-11 Thread Dave Airlie
path in panfrost_mmu_map_fault_addr() Dave Airlie (6): Merge tag 'drm-intel-fixes-2024-04-10' of https://anongit.freedesktop.org/git/drm/drm-intel into drm-fixes Merge tag 'amd-drm-fixes-6.9-2024-04-10' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes Merge tag

[PATCH] nouveau: fix instmem race condition around ptr stores

2024-04-10 Thread Dave Airlie
From: Dave Airlie Running a lot of VK CTS in parallel against nouveau, once every few hours you might see something like this crash. BUG: kernel NULL pointer dereference, address: 0008 PGD 800114e6e067 P4D 800114e6e067 PUD 109046067 PMD 0 Oops: [#1] PREEMPT SMP PTI CPU

Re: [PATCH] nouveau: fix instmem race condition around ptr stores

2024-04-09 Thread Dave Airlie
On Tue, 9 Apr 2024 at 21:33, Danilo Krummrich wrote: > > On 4/9/24 10:27, Lucas Stach wrote: > > Am Dienstag, dem 09.04.2024 um 10:34 +1000 schrieb Dave Airlie: > >> From: Dave Airlie > >> > >> Running a lot of VK CTS in parallel against nouveau, once every

[git pull] drm urgent fix for 6.9-rc4

2024-04-08 Thread Dave Airlie
for 6.9-rc4 nouveau: - regression fix for GSP display enable. Dave Airlie (1): nouveau: fix devinit paths to only handle display on GSP. drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gm107.c | 12 drivers/gpu/drm

Re: [PATCH] nouveau: fix devinit paths to only handle display on GSP.

2024-04-08 Thread Dave Airlie
On Mon, 8 Apr 2024 at 23:05, Timur Tabi wrote: > > On Mon, 2024-04-08 at 16:42 +1000, Dave Airlie wrote: > > This reverts: > > nouveau/gsp: don't check devinit disable on GSP. > > and applies a further fix. > > > > It turns out the open gpu driver, checks thi

[PATCH] nouveau: fix instmem race condition around ptr stores

2024-04-08 Thread Dave Airlie
From: Dave Airlie Running a lot of VK CTS in parallel against nouveau, once every few hours you might see something like this crash. BUG: kernel NULL pointer dereference, address: 0008 PGD 800114e6e067 P4D 800114e6e067 PUD 109046067 PMD 0 Oops: [#1] PREEMPT SMP PTI CPU

Re: [PATCH 1/2] drm/nouveau/kms/nv50-: Disable AUX bus for disconnected DP ports

2024-04-08 Thread Dave Airlie
d of quite of a lot of GSP error spam in dmesg. > > Signed-off-by: Lyude Paul For the two patches, Reviewed-by: Dave Airlie > --- > drivers/gpu/drm/nouveau/nouveau_dp.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/nouve

[PATCH] nouveau: fix devinit paths to only handle display on GSP.

2024-04-08 Thread Dave Airlie
sable on GSP.") Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gm107.c | 12 drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c | 1 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gm107.c b/d

Re: [PATCH] drm/msm: fix the `CRASHDUMP_READ` target of `a6xx_get_shader_block()`

2024-04-04 Thread Dave Airlie
On Sat, 30 Mar 2024 at 04:39, Abhinav Kumar wrote: > > > > On 3/26/2024 2:23 PM, Miguel Ojeda wrote: > > Clang 14 in an (essentially) defconfig arm64 build for next-20240326 > > reports [1]: > > > > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: > > variable 'out' set but not

[git pull] drm fixes for 6.9-rc3

2024-04-04 Thread Dave Airlie
the computation for compressed_bpp for DISPLAY < 13 Arun R Murthy (1): drm/i915/dp: Remove support for UHBR13.5 Christian Hewitt (1): drm/panfrost: fix power transition timeout warnings Colin Ian King (1): drm/nouveau/gr/gf100: Remove second semicolon Dave Airlie (4): nouv

Re: Cross-device and cross-driver HMM support

2024-04-02 Thread Dave Airlie
On Wed, 27 Mar 2024 at 19:52, Thomas Hellström wrote: > > Hi! > > With our SVM mirror work we'll soon start looking at HMM cross-device > support. The identified needs are > > 1) Instead of migrating foreign device memory to system when the > current device is faulting, leave it in place... > 1a)

[git pull] drm fixes for 6.9-rc2

2024-03-29 Thread Dave Airlie
: Fix divide-by-zero regression on DP MST unplug with nouveau Chris Park (1): drm/amd/display: Prevent crash when disable stream Chris Wilson (1): drm/i915/gt: Reset queue_priority_hint on parking Dave Airlie (5): Merge tag 'drm-xe-fixes-2024-03-26' of https

[PATCH] nouveau/uvmm: fix addr/range calcs for remap operations

2024-03-27 Thread Dave Airlie
From: Dave Airlie dEQP-VK.sparse_resources.image_rebind.2d_array.r64i.128_128_8 was causing a remap operation like the below. op_remap: prev: 003fffed 000f a5abd18a op_remap: next: op_remap: unmap: 003fffed 0010 0 op_map: map

[git pull] drm fixes for 6.9-rc1

2024-03-21 Thread Dave Airlie
NULL check in dc_state_release Arthur Grillo (1): drm: Fix drm_fixp2int_round() making it add 0.5 Aurabindo Pillai (1): drm/amd/display: Enable DML2 debug flags ChunTao Tso (1): drm/amd/display: Amend coasting vtotal for replay low hz Dave Airlie (6): nouveau: reset

Re: [git pull] drm for 6.9-rc1

2024-03-13 Thread Dave Airlie
On Thu, 14 Mar 2024 at 11:49, Linus Torvalds wrote: > > On Tue, 12 Mar 2024 at 21:07, Dave Airlie wrote: > > > > I've done a trial merge into your tree from a few hours ago, there > > are definitely some slighty messy conflicts, I've pushed a sample > > branch here

[PATCH] nouveau/gsp: don't check devinit disable on GSP.

2024-03-13 Thread Dave Airlie
From: Dave Airlie GSP should be handling this and I can see no evidence in opengpu driver that this register should be touched. Fixed acceleration on 2080 Ti GPUs. Fixes: 15740541e8f0 ("drm/nouveau/devinit/tu102-: prepare for GSP-RM") Signed-off-by: Dave Airlie --- drivers/gpu/d

[PATCH] nouveau: reset the bo resource bus info after an eviction

2024-03-11 Thread Dave Airlie
From: Dave Airlie Later attempts to refault the bo won't happen and the whole GPU does to lunch. I think Christian's refactoring of this code out to the driver broke this not very well tested path. Fixes: 141b15e59175 ("drm/nouveau: move io_reserve_lru handling into the driver v5

[git pull] drm fixes for 6.8 final

2024-03-07 Thread Dave Airlie
-intel-fixes-2024-03-01' of https://anongit.freedesktop.org/git/drm/drm-intel into drm-fixes Dave Airlie (5): Merge tag 'drm-intel-fixes-2024-03-07' of https://anongit.freedesktop.org/git/drm/drm-intel into drm-fixes Merge tag 'drm-xe-fixes-2024-03-07' of https://gitlab.freedesktop.org

[git pull] drm fixes for 6.8-rc7

2024-02-29 Thread Dave Airlie
rm/xe/mmio: fix build warning for BAR resize on 32-bit Christian König (1): drm/ttm/tests: depend on UML || COMPILE_TEST Dave Airlie (5): Merge tag 'drm-misc-fixes-2024-02-29' of https://anongit.freedesktop.org/git/drm/drm-misc into drm-fixes Merge tag 'drm-xe-fixes-2024-02-29

[PATCH 2/2] nouveau/umem: rename nvkm client lock to umem_lock

2024-02-29 Thread Dave Airlie
From: Dave Airlie This lock is just protecting the umem list so name it as such. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/include/nvkm/core/client.h | 2 +- drivers/gpu/drm/nouveau/nvkm/core/client.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/mmu/umem.c | 12

[PATCH 1/2] nouveau: lock the client object tree.

2024-02-29 Thread Dave Airlie
From: Dave Airlie It appears the client object tree has no locking unless I've missed something else. Fix races around adding/removing client objects, mostly vram bar mappings. 4562.099306] general protection fault, probably for non-canonical address 0x6677ed422bceb80c: [#1] PREEMPT SMP

[PATCH] nouveau: report byte usage in VRAM usage.

2024-02-25 Thread Dave Airlie
From: Dave Airlie Turns out usage is always in bytes not shifted. Fixes: 72fa02fdf833 ("nouveau: add an ioctl to report vram usage") Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

ttm usage inconsistency

2024-02-25 Thread Dave Airlie
This is probably something I knew about and forgot, but I'll ask if anyone has considered cleaning it up (or maybe I should fix nouveau). nouveau sets up the resource manager using vram_size >> PAGE_SHIFT as the bounds, but the bo sizes are in bytes, hence usage ends up being accounted in bytes,

Re: [PATCH] drm/nouveau: use dedicated wq for fence uevents work

2024-02-25 Thread Dave Airlie
On Sat, 24 Feb 2024 at 03:01, Danilo Krummrich wrote: > > On Fri, Feb 23, 2024 at 10:14:53AM +1000, Dave Airlie wrote: > > On Fri, 23 Feb 2024 at 00:45, Danilo Krummrich wrote: > > > > > > Using the kernel global workqueue to signal fences can lead to > > >

Re: [PATCH next v2 08/11] minmax: Add min_const() and max_const()

2024-02-25 Thread Dave Airlie
On Mon, 26 Feb 2024 at 07:26, David Laight wrote: > > ... > > Yes, yes, that may end up requiring getting rid of some current users of > > > > #define MIN(a,b) ((a)<(b) ? (a):(b)) > > > > but dammit, we don't actually have _that_ many of them, and why should > > we have random drivers doing

[git pull] drm fixes for 6.8-rc6

2024-02-22 Thread Dave Airlie
): drm/buddy: Modify duplicate list_splice_tail call Ashutosh Dixit (2): drm/xe/xe_gt_idle: Drop redundant newline in name drm/xe: Fix modpost warning on xe_mocs kunit module Dan Carpenter (1): drm/nouveau/mmu/r535: uninitialized variable in r535_bar_new_() Dave Airlie (7

Re: [PATCH] drm/nouveau: use dedicated wq for fence uevents work

2024-02-22 Thread Dave Airlie
AX_ACTIVE limit is reached by waiters, this can > prevent the work signaling the fence from running. > > While this seems fairly unlikely, it's potentially exploitable. LGTM Reviewed-by: Dave Airlie probably should go into drm-misc-fixes? > > Fixes: 39126abc5e20 ("

Re: [PATCH v2 1/3] drm/syncobj: call drm_syncobj_fence_add_wait when WAIT_AVAILABLE flag is set

2024-02-21 Thread Dave Airlie
Can someone pick these up into misc? Dave. On Thu, 22 Feb 2024 at 04:48, Erik Kurzinger wrote: > > It looks these these patches have still not been merged after one month, is > there anything more that needs to be done for this to happen? > > On 1/25/24 10:12, Daniel Vetter wrote: > > On Fri,

[git pull] drm fixes for 6.8-rc5

2024-02-15 Thread Dave Airlie
vam (1): drm/buddy: Fix alloc_range() error handling code Dan Carpenter (1): drm/amd/display: Fix && vs || typos Danilo Krummrich (2): drm/nouveau: don't fini scheduler if not initialized drm/nouveau: omit to create schedulers using the legacy uAPI Dave Airlie (5

Re: [PULL] drm-intel-gt-next

2024-02-15 Thread Dave Airlie
On Thu, 15 Feb 2024 at 20:06, Tvrtko Ursulin wrote: > > Hi Dave, Daniel, > > First pull request for 6.9 with probably one more coming in one to two > weeks. > > Nothing to interesting in this one, mostly a sprinkle of small fixes in > GuC, HuC, Perf/OA, a tiny bit of prep work for future

Re: [PATCH] nouveau/gsp: add kconfig option to enable GSP paths by default

2024-02-13 Thread Dave Airlie
(ignore this one, sent another just after) On Wed, 14 Feb 2024 at 13:40, Dave Airlie wrote: > > From: Dave Airlie > > Turing and Ampere will continue to use the old paths by default, > but we should allow distros to decide what the policy is. > > Signed-off-by: Dave Airlie

[PATCH] nouveau/gsp: add kconfig option to enable GSP paths by default

2024-02-13 Thread Dave Airlie
From: Dave Airlie Turing and Ampere will continue to use the old paths by default, but we should allow distros to decide what the policy is. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/Kconfig| 8 drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 6 +- 2

[PATCH] nouveau/gsp: add kconfig option to enable GSP paths by default

2024-02-13 Thread Dave Airlie
From: Dave Airlie Turing and Ampere will continue to use the old paths by default, but we should allow distros to decide what the policy is. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/Kconfig| 8 drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 3 +++ 2

Re: [PATCH 1/2] drm/nouveau: don't fini scheduler if not initialized

2024-02-09 Thread Dave Airlie
t; It makes sense to allocate struct nouveau_sched separately anyway, since > in a subsequent commit we can also avoid to allocate a struct > nouveau_sched in nouveau_abi16_ioctl_channel_alloc() at all, if the > VM_BIND uAPI has been disabled due to the legacy uAPI being used. Looks good, for th

[git pull] drm fixes for 6.8-rc4

2024-02-08 Thread Dave Airlie
): drm/xe: circumvent bogus stringop-overflow warning Dan Carpenter (1): drm/i915/gvt: Fix uninitialized variable in handle_mmio() Dave Airlie (6): nouveau/gsp: use correct size for registry rpc. Merge tag 'drm-misc-fixes-2024-02-08' of git://anongit.freedesktop.org/drm/drm-misc

Re: xe vs amdgpu userptr handling

2024-02-07 Thread Dave Airlie
> Best Regards, > - Maíra > > On 2/7/24 03:56, Dave Airlie wrote: > > I'm just looking over the userptr handling in both drivers, and of > > course they've chosen different ways to represent things. Again this > > is a divergence that is just going to get more annoying over

xe vs amdgpu userptr handling

2024-02-06 Thread Dave Airlie
I'm just looking over the userptr handling in both drivers, and of course they've chosen different ways to represent things. Again this is a divergence that is just going to get more annoying over time and eventually I'd like to make hmm/userptr driver independent as much as possible, so we get

Re: [PATCH] drm/sched: Re-queue run job worker when drm_sched_entity_pop_job() returns NULL

2024-02-05 Thread Dave Airlie
>> NULL. > >>>>> > >>>>> Fixes: 6dbd9004a55 ("drm/sched: Drain all entities in DRM sched run job > >>>>> worker") > >>> First of all there's a small typo in this Fixes tag that needs to be > >>> fixed. > >

Re: [PATCH] nouveau: offload fence uevents work to workqueue

2024-02-05 Thread Dave Airlie
On Tue, 6 Feb 2024 at 02:22, Danilo Krummrich wrote: > > On 1/29/24 02:50, Dave Airlie wrote: > > From: Dave Airlie > > > > This should break the deadlock between the fctx lock and the irq lock. > > > > This offloads the processing off the work from the irq

Re: [PATCH] drm/mgag200: Flush the cache to improve latency

2024-02-04 Thread Dave Airlie
On Mon, 6 Nov 2023 at 20:47, Jocelyn Falempe wrote: > > On 23/10/2023 10:30, Jocelyn Falempe wrote: > > On 20/10/2023 14:06, Thomas Zimmermann wrote: > >> (cc'ing lkml for feedback) > >> > >> Hi Jocelyn > >> > >> Am 19.10.23 um 15:55 schrieb Jocelyn Falempe: > >>> We found a regression in v5.10

[git pull] drm fixes for 6.8-rc3

2024-02-02 Thread Dave Airlie
md/display: fix USB-C flag update after enc10 feature init Dave Airlie (5): Merge tag 'drm-misc-fixes-2024-02-01' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes Merge tag 'drm-xe-fixes-2024-02-01' of https://gitlab.freedesktop.org/drm/xe/kernel into drm-fixes Merge ta

[PATCH] nouveau/gsp: use correct size for registry rpc.

2024-01-29 Thread Dave Airlie
From: Dave Airlie Timur pointed this out before, and it just slipped my mind, but this might help some things work better, around pcie power management. Fixes: 8d55b0a940bb ("nouveau/gsp: add some basic registry entries.") Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/

[PATCH] nouveau: offload fence uevents work to workqueue

2024-01-28 Thread Dave Airlie
From: Dave Airlie This should break the deadlock between the fctx lock and the irq lock. This offloads the processing off the work from the irq into a workqueue. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_fence.c | 24 ++-- drivers/gpu/drm/nouveau

[git pull] drm fixes for 6.8-rc2

2024-01-26 Thread Dave Airlie
/panel: samsung-s6d7aa0: drop DRM_BUS_FLAG_DE_HIGH for lsl080al02 Bagas Sanjaya (1): drm/dp_mst: Separate @failing_port list in drm_dp_mst_atomic_check_mgr() comment ChunTao Tso (1): drm/amd/display: Replay + IPS + ABM in Full Screen VPB Dave Airlie (9): Merge tag 'drm-intel-next

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2024-01-26 Thread Dave Airlie
Just FYI this conflictted pretty heavily with drm-misc-next changes in the same area, someone should check drm-tip has the correct resolution, I'm not really sure what is definitely should be. Dave. On Fri, 19 Jan 2024 at 16:37, Inki Dae wrote: > > Really sorry for late. Will pick it up. > >

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-25 Thread Dave Airlie
Just FYI I'm pulling this into drm-fixes straight as is, since if fixes the regression and avoids the revert, however please keep discussing until we are sure things are right, and we can deal with any fixes in a follow-up patch. Dave. On Fri, 26 Jan 2024 at 03:32, Matthew Brost wrote: > > On

Re: [PATCH] nouveau: rip out fence irq allow/block sequences.

2024-01-25 Thread Dave Airlie
On Fri, 26 Jan 2024 at 04:28, Daniel Vetter wrote: > > On Tue, Jan 23, 2024 at 05:25:38PM +1000, Dave Airlie wrote: > > From: Dave Airlie > > > > fences are signalled on nvidia hw using non-stall interrupts. > > > > non-stall interrupts are not latched from my

[PATCH] nouveau: rip out fence irq allow/block sequences.

2024-01-22 Thread Dave Airlie
From: Dave Airlie fences are signalled on nvidia hw using non-stall interrupts. non-stall interrupts are not latched from my reading. When nouveau emits a fence, it requests a NON_STALL signalling, but it only calls the interface to allow the non-stall irq to happen after it has already

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Dave Airlie
On Tue, 23 Jan 2024 at 12:21, Dave Airlie wrote: > > On Tue, 23 Jan 2024 at 12:15, Steven Rostedt wrote: > > > > On Mon, 22 Jan 2024 19:56:08 -0500 > > "Bhardwaj, Rajneesh" wrote: > > > > > > > > On 1/22/2024 7:43 PM, Linus Torvalds w

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Dave Airlie
On Tue, 23 Jan 2024 at 12:15, Steven Rostedt wrote: > > On Mon, 22 Jan 2024 19:56:08 -0500 > "Bhardwaj, Rajneesh" wrote: > > > > > On 1/22/2024 7:43 PM, Linus Torvalds wrote: > > > On Mon, 22 Jan 2024 at 15:17, Steven Rostedt wrote: > > >> Perhaps this is the real fix? > > > If you send a

[PATCH] drm/qxl: pass a device into ttm init.

2024-01-22 Thread Dave Airlie
From: Dave Airlie ttm init was changed to look at numa node, but that needed a device. Only qxl appears to not hand in a device, so just fix that. Fixes: b0a7ce53d494 ("drm/ttm: Schedule delayed_delete worker closer") Reported-by: Steven Rostedt Cc: Rajneesh Bhardwaj Signed-of

[PATCH] drm/qxl: pass a device into ttm init.

2024-01-22 Thread Dave Airlie
From: Dave Airlie ttm init was changed to look at numa node, but that needed a device. Only qxl appears to not hand in a device, so just fix that. Fixes: b0a7ce53d494 ("drm/ttm: Schedule delayed_delete worker closer") Reported-by: Steven Rostedt Cc: Rajneesh Bhardwaj Signed-of

[git pull] drm fixes for 6.8-rc1 (part two)

2024-01-18 Thread Dave Airlie
l Miess (1): Revert "drm/amd/display: Fix conversions between bytes and KB" Dave Airlie (3): Merge tag 'amd-drm-fixes-6.8-2024-01-18' of https://gitlab.freedesktop.org/agd5f/linux into drm-next nouveau/vmm: don't set addr on the fail path to avoid warning Merge ta

[PATCH] nouveau/vmm: don't set addr on the fail path to avoid warning

2024-01-17 Thread Dave Airlie
From: Dave Airlie nvif_vmm_put gets called if addr is set, but if the allocation fails we don't need to call put, otherwise we get a warning like [523232.435671] [ cut here ] [523232.435674] WARNING: CPU: 8 PID: 1505697 at drivers/gpu/drm/nouveau/nvif/vmm.c:68

[git pull] drm fixes for 6.8-rc1

2024-01-14 Thread Dave Airlie
Ankit Nautiyal (1): drm/i915/dp: Fix the max DSC bpc supported by source Cristian Ciocaltea (2): drm/rockchip: vop2: Drop superfluous include drm/rockchip: vop2: Drop unused if_dclk_rate variable Dave Airlie (3): Merge tag 'drm-intel-next-fixes-2024-01-11' of git

Re: [pull] amdgpu, amdkfd drm-fixes-6.8

2024-01-14 Thread Dave Airlie
/home/airlied/devel/kernel/dim/src/drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_dpia_bw.c:548:24: error: arithmetic between different enumeration types ('const enum dc_link_rate' and 'const enum dc_lane_count') [-Werror,-Wenum-enum-conversion]

Re: [git pull] drm for 6.8

2024-01-14 Thread Dave Airlie
On Sat, 13 Jan 2024 at 05:33, Linus Torvalds wrote: > > On Wed, 10 Jan 2024 at 11:49, Dave Airlie wrote: > > > > Let me know if there are any issues, > > Your testing is seriously lacking. > > This doesn't even build. The reason seems to be that commit > b49e89

[PATCH] nouveau/gsp: handle engines in runl without nonstall interrupts.

2024-01-09 Thread Dave Airlie
From: Dave Airlie It appears on TU106 GPUs (2070), that some of the nvdec engines are in the runlist but have no valid nonstall interrupt, nouveau didn't handle that too well. This should let nouveau/gsp work on those. Cc: sta...@vger.kernel.org # v6.7+ --- drivers/gpu/drm/nouveau/nvkm/engine

[git pull] drm fixes (part2) for 6.7 final

2024-01-04 Thread Dave Airlie
table for jpeg/vcn data drm/amd/pm: Add mem_busy_percent for GCv9.4.3 apu drm/amd/pm: Add gpu_metrics_v1_5 drm/amd/pm: Use gpu_metrics_v1_5 for SMUv13.0.6 Dave Airlie (10): Merge tag 'amd-drm-fixes-6.7-2024-01-04' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes

Re: [git pull] drm fixes for 6.8

2024-01-04 Thread Dave Airlie
On Fri, 5 Jan 2024 at 04:50, Linus Torvalds wrote: > > On Wed, 3 Jan 2024 at 18:30, Dave Airlie wrote: > > > > These were from over the holiday period, mainly i915, a couple of > > qaic, bridge and an mgag200. > > > > I have a set of nouveau fixes that I'll se

[git pull] drm fixes for 6.8

2024-01-03 Thread Dave Airlie
: - parade-ps8640, ti-sn65dsi86: fix aux reads bounds mgag200: - fix gamma LUT init i915: - Fix bogus DPCD rev usage for DP phy test pattern setup - Fix handling of MMIO triggered reports in the OA buffer Dave Airlie (2): Merge tag

Re: [PATCH 08/11] nouveau/gsp: don't free ctrl messages on errors

2024-01-03 Thread Dave Airlie
On Thu, 4 Jan 2024 at 00:47, Dan Carpenter wrote: > > Hi Dave, > > kernel test robot noticed the following build warnings: > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: > https://github.com/intel-lab-lkp/linux/commits/Dave-Airlie

[git pull] drm fixes for 6.7-rc7

2023-12-21 Thread Dave Airlie
info from integration info table Dave Airlie (2): Merge tag 'amd-drm-fixes-6.7-2023-12-20' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes Merge tag 'drm-intel-fixes-2023-12-21' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes Hamza Mahfooz (1): drm/a

[PATCH 09/11] nouveau/gsp: always free the alloc messages on r535

2023-12-21 Thread Dave Airlie
Fixes a memory leak seen with kmemleak. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c index

[PATCH 08/11] nouveau/gsp: don't free ctrl messages on errors

2023-12-21 Thread Dave Airlie
It looks like for some messages the upper layers need to get access to the results of the message so we can interpret it. Rework the ctrl push interface to not free things and cleanup properly whereever it errors out. Requested-by: Lyude Signed-off-by: Dave Airlie --- .../gpu/drm/nouveau

[PATCH 11/11] drm/nouveau/dp: Honor GSP link training retry timeouts

2023-12-21 Thread Dave Airlie
the timeout if link training fails - and retry up to 3 times. The "3 times" bit comes from OpenRM's link training code. [airlied: this fixes the panel on one of my laptops] Signed-off-by: Lyude Paul Signed-off-by: Dave Airlie --- .../gpu/drm/nouveau/nvkm/engine/disp/r535.c | 62

[PATCH 07/11] nouveau/gsp: convert gsp errors to generic errors

2023-12-21 Thread Dave Airlie
This should let the upper layers retry as needed on EAGAIN. There may be other values we will care about in the future, but this covers our present needs. Signed-off-by: Dave Airlie --- .../gpu/drm/nouveau/nvkm/subdev/gsp/r535.c| 26 +++ 1 file changed, 21 insertions(+), 5

[PATCH 06/11] drm/nouveau/gsp: Fix ACPI MXDM/MXDS method invocations

2023-12-21 Thread Dave Airlie
in nvidia's driver. So, let's add that - which doesn't get eDP displays to power on quite yet, but gets rid of the argument warning at least. Signed-off-by: Lyude Paul Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 10 -- 1 file changed, 8 insertions(+), 2

[PATCH 10/11] nouveau: push event block/allowing out of the fence context

2023-12-21 Thread Dave Airlie
nouveau gsp with i915 primary GPU. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_fence.c | 28 - drivers/gpu/drm/nouveau/nouveau_fence.h | 5 - 2 files changed, 27 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b

[PATCH 05/11] nouveau/gsp: free userd allocation.

2023-12-21 Thread Dave Airlie
This was being leaked. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/engine/fifo/r535.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/r535.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/r535.c index d088e636edc3..b903785056b5 100644

[PATCH 04/11] nouveau/gsp: free acpi object after use

2023-12-21 Thread Dave Airlie
This fixes a memory leak for the acpi dod object. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c index 365dda6c002a

[PATCH 03/11] nouveau: fix disp disabling with GSP

2023-12-21 Thread Dave Airlie
This func ptr here is normally static allocation, but gsp r535 uses a dynamic pointer, so we need to handle that better. This fixes a crash with GSP when you use config=disp=0 to avoid disp problems. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/engine/disp/base.c | 6 -- 1

[PATCH 02/11] nouveau/gsp: drop some acpi related debug

2023-12-21 Thread Dave Airlie
These were leftover debug, if we need to bring them back do so for debugging later. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/engine/disp/r535.c | 7 --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 9 - 2 files changed, 16 deletions(-) diff --git a/drivers

[PATCH 01/11] nouveau/gsp: add three notifier callbacks that we see in normal operation (v2)

2023-12-21 Thread Dave Airlie
Add NULL callbacks for some things GSP calls that we don't handle, but know about so we avoid the logging. v2: Timur suggested allowing null fn. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

nouveau GSP fixes

2023-12-21 Thread Dave Airlie
This is a collection of nouveau debug prints, memory leak, a very annoying race condition causing system hangs with prime scenarios, and a fix from Lyude to get the panel on my laptop working. I'd like to get these into 6.7, Dave.

[git pull] drm fixes for 6.7-rc6

2023-12-14 Thread Dave Airlie
drm/amdgpu: warn when there are still mappings when a BO is destroyed v2 Dave Airlie (4): Merge tag 'mediatek-drm-fixes-20231211' of https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux into drm-fixes Merge tag 'drm-intel-fixes-2023-12-13' of git://anongit.freedesktop.org

Re: [PATCH] drm/nouveau: Fixup gk20a instobj hierarchy

2023-12-14 Thread Dave Airlie
On Thu, 14 Dec 2023 at 19:26, Jon Hunter wrote: > > > > On 08/12/2023 10:46, Thierry Reding wrote: > > From: Thierry Reding > > > > Commit 12c9b05da918 ("drm/nouveau/imem: support allocations not > > preserved across suspend") uses container_of() to cast from struct > > nvkm_memory to struct

[git pull] drm fixes for 6.7-rc5

2023-12-07 Thread Dave Airlie
(1): drm/amd/display: Use channel_width = 2 for vram table 3.0 Arnd Bergmann (1): drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS Dave Airlie (6): nouveau/tu102: flush all pdbs on vmm flush Merge tag 'drm-intel-fixes-2023-12-01-1' of git://anongit.freedesktop.org/drm

Re: [Bug 218221] Nouveau GSP fail on command cli:0xc1d0000

2023-12-05 Thread Dave Airlie
Yes I'd file that against mesa, I don't think we are quite there with zink support yet, trying to push on it a bit. On Tue, 5 Dec 2023 at 21:42, wrote: > > https://bugzilla.kernel.org/show_bug.cgi?id=218221 > > --- Comment #3 from marc barbier (mmarc...@gmail.com) --- > (In reply to airlied from

[PATCH] nouveau/gsp: drop some acpi related debug

2023-12-04 Thread Dave Airlie
These were leftover debug, if we need to bring them back do so for debugging later. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c b/drivers/gpu/drm/nouveau

  1   2   3   4   5   6   7   8   9   10   >