panel"), we want to remove needless code from
panel drivers that was storing and double-checking the
prepared/enabled state. Even if someone was relying on the
double-check before, that double-check is now in the core and not
needed in individual drivers.
Cc: "Heiko Stübner"
Cc: Quenti
/20230901234015.566018-1-diand...@chromium.org
[2] https://lore.kernel.org/r/20230901234202.566951-1-diand...@chromium.org
[3] https://lore.kernel.org/r/20230921192749.1542462-1-diand...@chromium.org
Cc: "Heiko Stübner"
Cc: Quentin Schulz
Signed-off-by: Douglas Anderson
I get:
"&
err(vop2->drm, "MIPI dclk out of range, dclk_out_rate:
%ld KHZ\n",
Ditto.
Otherwise,
Reviewed-by: Quentin Schulz
Thanks!
Quentin
; so we don't
necessarily need it in this specific location and can group it with the
others. Cosmetic suggestion though.
Otherwise, the change itself makes sense to me, so:
Reviewed-by: Quentin Schulz
Thanks!
Quentin
the duplicates.
Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek
LTK050H3148W-CTA6 variant")
Signed-off-by: Heiko Stuebner
Reviewed-by: Quentin Schulz
Thanks!
Quentin
set.
Other DSI drivers might handle this differently, so add the flag.
Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek
LTK050H3148W-CTA6 variant")
Signed-off-by: Heiko Stuebner
Reviewed-by: Quentin Schulz
Thanks!
Quentin
drm/panel: ltk500hd1829: add panel type for ltk101b4029w
For the whole series:
Reviewed-by: Quentin Schulz
Thanks,
Quentin
From: Quentin Schulz
This is only a cosmetic change.
This replaces a hand-crafted EPROBE_DEFER handling for deciding to print
an error message with dev_err_probe.
A side-effect is that dev_err_probe also adds a debug message when it's
not EPROBE_DEFER, but this is seen as an improvement.
Cc
From: Quentin Schulz
devm_gpiod_get_optional may return EPROBE_DEFER in case the GPIO
controller isn't yet probed when the panel driver is being probed.
In that case, a spurious and confusing error message about not being
able to get the reset GPIO is printed even though later on the device
This hides an error message if EPROBE_DEFER was returned when trying to
get the reset GPIO.
This also makes use of dev_err_probe in lieu of hand-crafted logic
inside the driver.
Thanks,
Quentin
Signed-off-by: Quentin Schulz
---
Quentin Schulz (2):
drm/panel: ltk050h3146w: only print
Hi Fabio,
On 11/17/23 20:27, Fabio Estevam wrote:
Hi Quentin,
On Fri, Nov 17, 2023 at 3:31 PM Quentin Schulz wrote:
From: Quentin Schulz
This scary message may happen if the panel or bridge is not probed
before the LVDS controller is, resulting in some head scratching because
the LVDS
From: Quentin Schulz
This scary message can misled the user into thinking something bad has
happened and needs to be fixed, however it could simply be part of a
normal boot process where EPROBE_DEFER is taken into account. Therefore,
let's use dev_err_probe so that this message doesn't get shown
From: Quentin Schulz
ret variable stores the return value of drm_of_find_panel_or_bridge
which can return error codes different from EPROBE_DEFER. Therefore,
let's just return that error code instead of forcing it to EPROBE_DEFER.
Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchi
-off-by: Quentin Schulz
---
Changes in v2:
- add a patch for not overwriting return code with EPROBE_DEFER
- use dev_err_probe instead of DRM_DEV_DEBUG
- Link to v1:
https://lore.kernel.org/r/20231117-rk-lvds-defer-msg-v1-1-1e6894cf9...@theobroma-systems.com
---
Quentin Schulz (2):
drm
From: Quentin Schulz
This scary message may happen if the panel or bridge is not probed
before the LVDS controller is, resulting in some head scratching because
the LVDS panel is actually working, since a later try will eventually
find the panel or bridge.
Therefore let's demote this error
Hi all,
Seems I'm not the only one who forgot about this patch series, so,
kindly pinging :)
Thanks!
Quentin
On 1/31/22 17:47, quentin.sch...@theobroma-systems.com wrote:
From: Quentin Schulz
To prepare for a new display to be supported by this driver which has a
slightly different set
From: Quentin Schulz
The LTK050H3148W-CTA6 is a 5.0" 720x1280 DSI display, whose driving
controller is a Himax HX8394-F, slightly different from LTK050H3146W by
its init sequence, mode details and mode flags.
Cc: Quentin Schulz
Signed-off-by: Quentin Schulz
---
.../devicetree/bin
From: Klaus Goger
The LTK050H3148W-CTA6 is a 5.0" 720x1280 DSI display, whose driving
controller is a Himax HX8394-F, slightly different from LTK050H3146W by
its init sequence, mode details and mode flags.
Cc: Quentin Schulz
Signed-off-by: Klaus Goger
Signed-off-by: Quentin S
From: Quentin Schulz
Heiko does not work at Theobroma Systems anymore and the boards using
those panels are downstream, maintained internally by the company, so
let's relieve Heiko of maintainership duties.
Cc: Heiko Stuebner
Cc: Quentin Schulz
Signed-off-by: Quentin Schulz
From: Quentin Schulz
To prepare for a new display to be supported by this driver which has a
slightly different set of DSI mode related flags, let's move the
currently hardcoded mode flags to the .data field of of_device_id
structure.
Cc: Quentin Schulz
Signed-off-by: Quentin Schulz
rg/patch/249400/
>
If I'm not mistaken, you could get rid of the patch in the Intel driver
when we have this one merged. Is there any reason not to, have I missed
something?
Thanks,
Quentin
> Reviewed-by: Manasi Navare
>
> Manasi
>
>
> On Thu, Sep 20, 2018 at 03:54:37PM +0100,
21 matches
Mail list logo
