Re: (subset) [PATCH 00/34] address all -Wunused-const warnings

2024-04-10 Thread Sebastian Reichel
in header files > instead of using macros or enums. > > [...] Applied, thanks! [09/34] power: rt9455: hide unused rt9455_boost_voltage_values commit: 452d8950db3e839aba1bb13bc5378f4bac11fa04 Best regards, -- Sebastian Reichel

Re: [PATCH v2 1/2] dt-bindings: backlight: Add Texas Instruments LM3509

2024-03-09 Thread Sebastian Reichel
Hi, On Sat, Mar 09, 2024 at 01:22:28PM +0100, Krzysztof Kozlowski wrote: > LED strings are true in case of... well, LED strings, but I just > wonder if such setup is applicable for backlight. Anyway, if you > think it is, I don't mind. LED strings are being used as backlight. Either from the

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-16 Thread Sebastian Reichel
Hi, On Thu, Nov 16, 2023 at 06:39:40PM +0800, Andy Yan wrote: > > > vop2->sys_grf = syscon_regmap_lookup_by_phandle(dev->of_node, > > > "rockchip,grf"); > > This already lacks an error check, shame on me... > > > > > + vop2->vop_grf = syscon_regmap_lookup_by_phandle(dev->of_node, > >

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-09-21 Thread Sebastian Reichel
eading to > a crash. And probably the driver will crash if it happens, for some > reason, to try to send a message via the DSI bus. > > But that's another topic. > > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/drm_mipi

Re: [PATCH] omap: dsi: do not WARN on detach if dsidev was never attached

2023-09-20 Thread Sebastian Reichel
ach() was never called before. > > This happens if the panel driver asks for an EPROBE_DEFER. > > So let's suppress the WARN() in this special case. ... > Signed-off-by: H. Nikolaus Schaller > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/d

Re: [PATCH v2 3/3] dt-bindings: display: add rotation property to sitronix,st7789v

2023-08-03 Thread Sebastian Reichel
Hi, On Thu, Aug 03, 2023 at 10:13:50PM +0200, Michael Riesch wrote: > The sitronix-st7789v driver now considers the rotation property. > Add the property to the documentation. > > Acked-by: Conor Dooley > Signed-off-by: Michael Riesch > --- Reviewed-by: Sebastian Reic

Re: [PATCH v2 2/3] drm/panel: sitronix-st7789v: add panel orientation support

2023-08-03 Thread Sebastian Reichel
Hi, On Thu, Aug 03, 2023 at 10:13:49PM +0200, Michael Riesch wrote: > Determine the orientation of the display based on the device tree and > propagate it. > > Reviewed-by: Neil Armstrong > Signed-off-by: Michael Riesch > --- Reviewed-by: Sebastian Reichel -- Sebastian

Re: [PATCH v2 1/3] drm/panel: sitronix-st7789v: fix indentation in drm_panel_funcs

2023-08-03 Thread Sebastian Reichel
Hi, On Thu, Aug 03, 2023 at 10:13:48PM +0200, Michael Riesch wrote: > Fix indentation of the callbacks in struct drm_panel_funcs. > No functional changes. > > Signed-off-by: Michael Riesch > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/panel/panel-

Re: [PATCH v3 00/19] Sitronix ST7789V improvements

2023-07-31 Thread Sebastian Reichel
Hi, Each patch in the series has at least one Reviewed-by tag and the DT binding changes have an Acked-by from at least one of the DT binding maintainers. It has been pending on the mailing list for two weeks now, so can it be applied? P.S.: Looks like I missed Neil in the original recipients

[PATCH v3 02/19] dt-bindings: display: st7789v: add Inanbo T28CP45TN89

2023-07-13 Thread Sebastian Reichel
Add compatible value for Inanbo t28cp45tn89 and make reset GPIO non mandatory, since it might not be connected to the CPU. Reviewed-by: Michael Riesch Acked-by: Rob Herring Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/display/panel/sitronix,st7789v.yaml | 5 +++-- 1 file

[PATCH v3 15/19] dt-bindings: display: st7789v: bound the number of Rx data lines

2023-07-13 Thread Sebastian Reichel
-off-by: Miquel Raynal Acked-by: Krzysztof Kozlowski Reviewed-by: Sebastian Reichel Tested-by: Sebastian Reichel Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/display/panel/sitronix,st7789v.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree

[PATCH v3 08/19] drm/panel: sitronix-st7789v: avoid hardcoding mode info

2023-07-13 Thread Sebastian Reichel
Avoid hard-coding the default_mode and supply it from match data. One additional layer of abstraction has been introduced, which will be needed for specifying other panel information (e.g. bus flags) in the next steps. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- .../gpu

[PATCH v3 19/19] drm/panel: sitronix-st7789v: Check display ID

2023-07-13 Thread Sebastian Reichel
but just warn the user, in case the DT description would be lacking the Rx bus width (which is likely on old descriptions) in order to avoid breaking existing devices. Signed-off-by: Miquel Raynal Acked-by: Sam Ravnborg Acked-by: Maxime Ripard Reviewed-by: Sebastian Reichel Tested-by: Sebastian

[PATCH v3 12/19] drm/panel: sitronix-st7789v: avoid hardcoding polarity info

2023-07-13 Thread Sebastian Reichel
Add polarity information via mode and bus flags, so that they are no longer hardcoded and forward the information to the DRM stack. This is required for adding panels with different settings. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix

[PATCH v3 11/19] drm/panel: sitronix-st7789v: avoid hardcoding invert mode

2023-07-13 Thread Sebastian Reichel
While the default panel uses invert mode, some panels require non-invert mode instead. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH v3 10/19] drm/panel: sitronix-st7789v: add media bus format

2023-07-13 Thread Sebastian Reichel
Add support for describing the media bus format in the panel configuration and expose that to userspace. Since both supported formats (RGB565 and RGB666) are using 6 bits per color also hardcode that information. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- .../gpu/drm

[PATCH v3 03/19] drm/panel: sitronix-st7789v: add SPI ID table

2023-07-13 Thread Sebastian Reichel
SPI device drivers should also have a SPI ID table. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel

[PATCH v3 07/19] drm/panel: sitronix-st7789v: improve error handling

2023-07-13 Thread Sebastian Reichel
Improve error handling in the probe routine, so that probe defer errors are captured in /sys/kernel/debug/devices_deferred Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 23 ++- 1 file changed, 12 insertions

[PATCH v3 05/19] drm/panel: sitronix-st7789v: make reset GPIO optional

2023-07-13 Thread Sebastian Reichel
The reset pin might not be software controllable from the SoC, so make it optional. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel

[PATCH v3 14/19] dt-bindings: display: st7789v: Add the edt, et028013dma panel compatible

2023-07-13 Thread Sebastian Reichel
From: Miquel Raynal The ST7789V LCD controller is also embedded in the ET028013DMA panel. Add a compatible string to describe this other panel. Signed-off-by: Miquel Raynal Acked-by: Krzysztof Kozlowski Acked-by: Maxime Ripard Reviewed-by: Sebastian Reichel Signed-off-by: Sebastian Reichel

[PATCH v3 13/19] drm/panel: sitronix-st7789v: add Inanbo T28CP45TN89 support

2023-07-13 Thread Sebastian Reichel
has been seen on the device. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 25 +++ 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel

[PATCH v3 06/19] drm/panel: sitronix-st7789v: simplify st7789v_spi_write

2023-07-13 Thread Sebastian Reichel
st7789v_spi_write initializes a message with just a single transfer, spi_sync_transfer can be used for that. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH v3 04/19] drm/panel: sitronix-st7789v: remove unused constants

2023-07-13 Thread Sebastian Reichel
ST7789V_COLMOD_RGB_FMT_18BITS and ST7789V_COLMOD_CTRL_FMT_18BITS are unused in favour of MIPI_DCS_PIXEL_FMT_18BIT, remove them. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH v3 09/19] drm/panel: sitronix-st7789v: avoid hardcoding panel size

2023-07-13 Thread Sebastian Reichel
Move the panel size information to the mode struct, so that different panel sizes can be specified depending on the panel type. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH v3 18/19] drm/panel: sitronix-st7789v: Add EDT ET028013DMA panel support

2023-07-13 Thread Sebastian Reichel
will malfunction if any of the following situation occurs: * Pixel clock is above 3MHz * Pixel clock is not inverted I could not properly identify the reasons behind these failures, scope captures show valid input signals. Signed-off-by: Miquel Raynal Acked-by: Maxime Ripard Reviewed-by: Sebastian Reichel

[PATCH v3 17/19] drm/panel: sitronix-st7789v: Clarify a definition

2023-07-13 Thread Sebastian Reichel
and not a high state. Correct the definition to ease the comparison with the datasheet. Signed-off-by: Miquel Raynal Acked-by: Maxime Ripard Reviewed-by: Sebastian Reichel Tested-by: Sebastian Reichel Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 4 ++-- 1

[PATCH v3 16/19] drm/panel: sitronix-st7789v: Use 9 bits per spi word by default

2023-07-13 Thread Sebastian Reichel
From: Miquel Raynal The Sitronix controller expects 9-bit words, provide this as default at probe time rather than specifying this in each and every access. Signed-off-by: Miquel Raynal Reviewed-by: Sam Ravnborg Acked-by: Maxime Ripard Reviewed-by: Sebastian Reichel Tested-by: Sebastian

[PATCH v3 01/19] dt-bindings: vendor-prefixes: add Inanbo

2023-07-13 Thread Sebastian Reichel
Shenzhen INANBO Electronic Technology Co., Ltd. manufacturers TFT/OLED LCD panels. Reviewed-by: Michael Riesch Acked-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v3 00/19] Sitronix ST7789V improvements

2023-07-13 Thread Sebastian Reichel
ines drm/panel: sitronix-st7789v: Use 9 bits per spi word by default drm/panel: sitronix-st7789v: Clarify a definition drm/panel: sitronix-st7789v: Add EDT ET028013DMA panel support drm/panel: sitronix-st7789v: Check display ID Sebastian Reichel (13): dt-bindings: vendor-prefixes: add I

Re: [PATCH 7/7] drm/panel: sitronix-st7789v: Check display ID

2023-06-16 Thread Sebastian Reichel
Hi, On Fri, Jun 16, 2023 at 12:13:45PM +0200, Miquel Raynal wrote: > s...@kernel.org wrote on Thu, 15 Jun 2023 01:27:24 +0200: > > On Sat, Jun 10, 2023 at 10:45:25PM +0200, Sam Ravnborg wrote: > > > On Fri, Jun 09, 2023 at 04:59:51PM +0200, Miquel Raynal wrote: > > > > A very basic debugging

Re: [PATCH 1/7] drm/panel: sitronix-st7789v: Prevent core spi warnings

2023-06-15 Thread Sebastian Reichel
Hi Sam, On Thu, Jun 15, 2023 at 07:43:46AM +0200, Sam Ravnborg wrote: > On Thu, Jun 15, 2023 at 01:22:17AM +0200, Sebastian Reichel wrote: > > > > May I point to you Sebastian Reichel's series that features a partial > > > > overlap with your work? [0] > > &g

Re: [PATCH 7/7] drm/panel: sitronix-st7789v: Check display ID

2023-06-14 Thread Sebastian Reichel
Hi, On Sat, Jun 10, 2023 at 10:45:25PM +0200, Sam Ravnborg wrote: > Hi Miquel, > > On Fri, Jun 09, 2023 at 04:59:51PM +0200, Miquel Raynal wrote: > > A very basic debugging rule when a device is connected for the first > > time is to access a read-only register which contains known data in > >

Re: [PATCH 1/7] drm/panel: sitronix-st7789v: Prevent core spi warnings

2023-06-14 Thread Sebastian Reichel
Hi, On Tue, Jun 13, 2023 at 08:56:30AM +0200, Miquel Raynal wrote: > Hi Michael, > > michael.rie...@wolfvision.net wrote on Tue, 13 Jun 2023 08:15:26 +0200: > > > Hi Miquel, > > > > On 6/9/23 16:59, Miquel Raynal wrote: > > > The spi core warns us about using an of_device_id table without a

[PATCH v2 09/13] drm/panel: sitronix-st7789v: avoid hardcoding panel size

2023-04-22 Thread Sebastian Reichel
Move the panel size information to the mode struct, so that different panel sizes can be specified depending on the panel type. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 12/13] drm/panel: sitronix-st7789v: avoid hardcoding polarity info

2023-04-22 Thread Sebastian Reichel
Add polarity information via mode and bus flags, so that they are no longer hardcoded and forward the information to the DRM stack. This is required for adding panels with different settings. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 22

[PATCH v2 06/13] drm/panel: sitronix-st7789v: simplify st7789v_spi_write

2023-04-22 Thread Sebastian Reichel
st7789v_spi_write initializes a message with just a single transfer, spi_sync_transfer can be used for that. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panel/panel

[PATCH v2 07/13] drm/panel: sitronix-st7789v: improve error handling

2023-04-22 Thread Sebastian Reichel
Improve error handling in the probe routine, so that probe defer errors are captured in /sys/kernel/debug/devices_deferred Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 23 ++- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git

[PATCH v2 05/13] drm/panel: sitronix-st7789v: make reset GPIO optional

2023-04-22 Thread Sebastian Reichel
The reset pin might not be software controllable from the SoC, so make it optional. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers

[PATCH v2 10/13] drm/panel: sitronix-st7789v: add media bus format

2023-04-22 Thread Sebastian Reichel
Add support for describing the media bus format in the panel configuration and expose that to userspace. Since both supported formats (RGB565 and RGB666) are using 6 bits per color also hardcode that information. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c

[PATCH v2 11/13] drm/panel: sitronix-st7789v: avoid hardcoding invert mode

2023-04-22 Thread Sebastian Reichel
While the default panel uses invert mode, some panels require non-invert mode instead. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c

[PATCH v2 02/13] dt-bindings: display: st7789v: add Inanbo T28CP45TN89

2023-04-22 Thread Sebastian Reichel
Add compatible value for Inanbo t28cp45tn89 and make reset GPIO non mandatory, since it might not be connected to the CPU. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/display/panel/sitronix,st7789v.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v2 13/13] drm/panel: sitronix-st7789v: add Inanbo T28CP45TN89 support

2023-04-22 Thread Sebastian Reichel
has been seen on the device. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 25 +++ 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index

[PATCH v2 08/13] drm/panel: sitronix-st7789v: avoid hardcoding mode info

2023-04-22 Thread Sebastian Reichel
Avoid hard-coding the default_mode and supply it from match data. One additional layer of abstraction has been introduced, which will be needed for specifying other panel information (e.g. bus flags) in the next steps. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix

[PATCH v2 04/13] drm/panel: sitronix-st7789v: remove unused constants

2023-04-22 Thread Sebastian Reichel
ST7789V_COLMOD_RGB_FMT_18BITS and ST7789V_COLMOD_CTRL_FMT_18BITS are unused in favour of MIPI_DCS_PIXEL_FMT_18BIT, remove them. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel

[PATCH v2 01/13] dt-bindings: vendor-prefixes: add Inanbo

2023-04-22 Thread Sebastian Reichel
Shenzhen INANBO Electronic Technology Co., Ltd. manufacturers TFT/OLED LCD panels. Acked-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH v2 03/13] drm/panel: sitronix-st7789v: add SPI ID table

2023-04-22 Thread Sebastian Reichel
SPI device drivers should also have a SPI ID table. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c

[PATCH v2 00/13] Add Inanbo T28CP45TN89 panel support

2023-04-22 Thread Sebastian Reichel
/ * Apply DT binding changes requested by Krzysztof Kozlowski and his Ack * I changed the driver patches to avoid code duplication and splitted the code a bit more -- Sebastian Sebastian Reichel (13): dt-bindings: vendor-prefixes: add Inanbo dt-bindings: display: st7789v: add Inanbo

[PATCHv1 5/7] drm/panel: sitronix-st7789v: make reset GPIO optional

2023-03-17 Thread Sebastian Reichel
The reset pin might not be software controllable from the SoC, so make it optional. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers

[PATCHv1 2/7] dt-bindings: display: st7789v: add Inanbo T28CP45TN89

2023-03-17 Thread Sebastian Reichel
Add compatible value for Inanbo t28cp45tn89 and make reset GPIO non mandatory, since it might not be connected to the CPU. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/display/panel/sitronix,st7789v.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCHv1 4/7] drm/panel: sitronix-st7789v: remove unused constants

2023-03-17 Thread Sebastian Reichel
ST7789V_COLMOD_RGB_FMT_18BITS and ST7789V_COLMOD_CTRL_FMT_18BITS are unused in favour of MIPI_DCS_PIXEL_FMT_18BIT, remove them. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel

[PATCHv1 6/7] drm/panel: sitronix-st7789v: prepare for additional panels

2023-03-17 Thread Sebastian Reichel
Prepare the driver for additional panels with different initialization. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 110 +++--- 1 file changed, 67 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b

[PATCHv1 3/7] drm/panel: sitronix-st7789v: add SPI ID table

2023-03-17 Thread Sebastian Reichel
SPI device drivers should also have a SPI ID table. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c

[PATCHv1 7/7] drm/panel: sitronix-st7789v: add Inanbo T28CP45TN89 support

2023-03-17 Thread Sebastian Reichel
has been seen on the device. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 137 ++ 1 file changed, 137 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index

[PATCHv1 0/7] Add Inanbo T28CP45TN89 panel support

2023-03-17 Thread Sebastian Reichel
e, but did not want to delay getting some review feedback :) [0] https://lore.kernel.org/all/20230314115644.3775169-1-gerald.loac...@wolfvision.net/ -- Sebastian Sebastian Reichel (7): dt-bindings: vendor-prefixes: add Inanbo dt-bindings: display: st7789v: add Inanbo T28CP45TN89 drm/panel

[PATCHv1 1/7] dt-bindings: vendor-prefixes: add Inanbo

2023-03-17 Thread Sebastian Reichel
Shenzhen INANBO Electronic Technology Co., Ltd. manufacturers TFT/OLED LCD panels. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-03-01 Thread Sebastian Reichel
rrors in examples were exposed and fixed. > > Signed-off-by: Rob Herring > --- Acked-by: Sebastian Reichel # for power-supply -- Sebastian ... > .../devicetree/bindings/power/supply/bq2415x.yaml | 2 +- > .../devicetree/bindings/power/supply/bq24190.yaml | 2 +- > .../de

Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

2023-01-29 Thread Sebastian Reichel
ternProperties: >'^(ac|usb)$': > type: object > +additionalProperties: false > description: USB/AC charging parameters > properties: >charger-type: Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls

2023-01-26 Thread Sebastian Reichel
NTDUMP | VM_DONTEXPAND; > + set_vm_flags(vma, VM_IO | VM_DONTDUMP | VM_DONTEXPAND); > vma->vm_ops = _char_vm_ops; > vma->vm_private_data = file->private_data; > Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] drm/imx: ipuv3-plane: Fix overlay plane width

2022-11-08 Thread Sebastian Reichel
Hi, On Tue, Nov 08, 2022 at 03:14:20PM +0100, Philipp Zabel wrote: > ipu_src_rect_width() was introduced to support odd screen resolutions > such as 1366x768 by internally rounding up primary plane width to a > multiple of 8 and compensating with reduced horizontal blanking. > This also caused

Re: [PATCH 2/2] power: supply: Add Lenovo Yoga C630 EC driver

2022-09-13 Thread Sebastian Reichel
Hi, [+Cc Lee Jones, DRI devel] On Tue, Aug 09, 2022 at 10:05:00PM -0500, Bjorn Andersson wrote: > The Qualcomm Snapdragon-based Lenovo Yoga C630 has some sort of EC > providing AC-adapter and battery status, as well as USB Type-C altmode > notifications for Displayport operation. > > The Yoga

Re: [PATCH v5 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver

2022-07-16 Thread Sebastian Reichel
Hi, On Fri, Jul 15, 2022 at 07:26:04PM +0800, ChiaEn Wu wrote: > From: ChiaEn Wu > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > driver, display bias voltage supply, one general purpose LDO,

Re: [PATCH v2 3/3] drm/panel: sony-acx565akm: Use backlight helpers

2022-06-17 Thread Sebastian Reichel
hanges since v1: removed the last remaining .fb_blank reference > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/panel/panel-sony-acx565akm.c | 12 ++-- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/panel/pa

Re: [PATCH v2 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-17 Thread Sebastian Reichel
Signed-off-by: Stephen Kitt > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org > --- > Changes since v1: removed unnecessary parentheses > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm

Re: [PATCH 3/3] drm/panel: sony-acx565akm: Use backlight helpers

2022-06-09 Thread Sebastian Reichel
evel@lists.freedesktop.org > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/panel/panel-sony-acx565akm.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm.c > b/drivers/gpu/drm/pan

Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-09 Thread Sebastian Reichel
ANK | BL_CORE_SUSPENDED; > + backlight_disable(backlight); > } The brackets can be removed now. Otherwise: Reviewed-by: Sebastian Reichel -- Sebastian > - > - backlight_update_status(backlight); > } > > static void hw_guard_start(struct panel_drv_data

Re: [PATCH] dt-bindings: Fix properties without any type

2022-05-23 Thread Sebastian Reichel
s/serial/8250.yaml| 1 + > .../devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++ > .../devicetree/bindings/sound/imx-audio-hdmi.yaml | 3 +++ > Documentation/devicetree/bindings/usb/smsc,usb3503.yaml | 1 + > 25 files changed, 55 insertions(+), 8 del

Re: [PATCH 40/48] ARM: pxa: tosa: use gpio lookup for battery

2022-04-20 Thread Sebastian Reichel
Hi, On Tue, Apr 19, 2022 at 06:38:02PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The battery driver uses a lot of GPIO lines, hardcoded from a > machine header file. > > Change it to use a gpiod lookup table instead. > > Reviewed-by: Sebastian Reiche

Re: [PATCH] drm: panel: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Sebastian Reichel
t; drivers/gpu/drm/panel/panel-dsi-cm.c:271: WARNING: use scnprintf or sprintf. > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > > Signed-off-by: Qing Wang > --- The patch subject could be more specific (this updates just one panel driver). Otherwise

Re: [PATCH v2 28/34] power: supply: ab8500: Migrate to aggregate driver

2021-10-13 Thread Sebastian Reichel
device with respect to all > the component devices that make up the aggregate device. > > Cc: Sebastian Reichel > Cc: > Cc: Daniel Vetter > Cc: "Rafael J. Wysocki" > Cc: Rob Clark > Cc: Russell King > Cc: Saravana Kannan > Signed-off-by: Stephen Boyd >

[PATCHv1] drm/omap: get fbdev working for manually updated display

2021-05-01 Thread Sebastian Reichel
more legacy applications working. Delay frequency settings have been taken over from drm_fb_helper_generic_probe(). Reported-by: Carl Philipp Klemm Tested-by: Carl Philipp Klemm Signed-off-by: Sebastian Reichel --- Hi, I still need to fix my Droid 4, so I only compile tested this myself

[PATCHv2 0/5] Support for GE B1x5v2 and B1x5Pv2

2021-04-28 Thread Sebastian Reichel
/20200910162831.321556-1-sebastian.reic...@collabora.com/ -- Sebastian Sebastian Reichel (5): rtc: m41t80: add support for fixed clock drm/imx: Add 8 pixel alignment fix dt-bindings: vendor-prefixes: add congatec dt-bindings: arm: fsl: add GE B1x5pv2 boards ARM: dts: imx6: Add GE B1x5v2 .../devicetree

[PATCHv2 5/5] ARM: dts: imx6: Add GE B1x5v2

2021-04-28 Thread Sebastian Reichel
This adds device tree files for the General Electric Healthcare (GEHC) B1x5v2 series. All models make use of Congatec's QMX6 module, which is described in its own device tree include, so that it can also be used by other boards. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/Makefile

[PATCHv2 1/5] rtc: m41t80: add support for fixed clock

2021-04-28 Thread Sebastian Reichel
the bootloader enables it in case an something (e.g. an unpatched kernel) disabled this incorrectly. A workaround for this issue is describing the square wave pin as fixed-clock, which is registered early and basically how this pin is used on the i.MX6. Suggested-by: Saravana Kannan Signed-off-by: Sebastian

[PATCHv2 2/5] drm/imx: Add 8 pixel alignment fix

2021-04-28 Thread Sebastian Reichel
from the blank time. In order to expose the correct display size to userspace, the stride is increased without increasing the width. Without this patch systems with this display resolution hang indefinitely during boot up. Suggested-by: Boris Brezillon Signed-off-by: Sebastian Reichel

[PATCHv2 3/5] dt-bindings: vendor-prefixes: add congatec

2021-04-28 Thread Sebastian Reichel
Document binding for congatec. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index

[PATCHv2 4/5] dt-bindings: arm: fsl: add GE B1x5pv2 boards

2021-04-28 Thread Sebastian Reichel
Document the compatible for GE B1x5pv2 boards. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/arm/fsl.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml

Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Sebastian Reichel
ers > - elaborated commit message (Luis) > - collected given tags (incl. Andrew's SoB, see below) > > I added Andrew's SoB since part of the fixes I took from him. Andrew, > feel free to amend or tell me how you want me to do. > > [...] > drivers/power/reset/ltc295

Re: [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT

2021-03-23 Thread Sebastian Reichel
i > --- Reviewed-by: Sebastian Reichel Also maybe add this, so that it is properly backported. OTOH old code did not have IRQF_ONESHOT either. Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core") -- Sebastian > Change in v2: > -Modify the fourth parameter

Re: [PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-03-08 Thread Sebastian Reichel
Hi, On Sat, Mar 06, 2021 at 11:56:45AM -0800, Rob Herring wrote: > On Tue, Feb 23, 2021 at 02:26:57AM +0100, Sebastian Reichel wrote: > > On Mon, Feb 22, 2021 at 10:26:26PM +0100, Alexandre Belloni wrote: > > > On 22/02/2021 22:20:47+0100, Alexandre Belloni wrote: > > &g

[PATCH] drm/panel: panel-dsi-cm: disable TE for now

2021-02-27 Thread Sebastian Reichel
From: Sebastian Reichel Disable TE for Droid 4 panel, since implementation is currently broken. Also disable it for N950 panel, which is untested. Reported-by: Tony Lindgren Reported-by: Tomi Valkeinen Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core")

Re: [PATCHv1 5/6] dt-bindings: mtd: jedec,spi-nor: add sst25vf032b

2021-02-22 Thread Sebastian Reichel
Hi, On Mon, Feb 22, 2021 at 06:15:11PM -0600, Rob Herring wrote: > On Mon, Feb 22, 2021 at 11:13 AM Sebastian Reichel > wrote: > > > > The binding is already used by the driver. Update documentation > > accordingly. > > > > Signed-off-by: Sebastian Reichel &

Re: [PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-02-22 Thread Sebastian Reichel
Hi, On Mon, Feb 22, 2021 at 10:26:26PM +0100, Alexandre Belloni wrote: > On 22/02/2021 22:20:47+0100, Alexandre Belloni wrote: > > On 22/02/2021 18:12:42+0100, Sebastian Reichel wrote: > > > Congatec's QMX6 system on module (SoM) uses a m41t62 as RTC. The > > > module

[PATCHv1 2/6] drm/imx: Add 8 pixel alignment fix

2021-02-22 Thread Sebastian Reichel
from the blank time. In order to expose the correct display size to userspace, the stride is increased without increasing the width. Suggested-by: Boris Brezillon Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/imx/imx-drm-core.c | 19 ++- drivers/gpu/drm/imx/imx-ldb.c

[PATCHv1 4/6] dt-bindings: arm: fsl: add GE B1x5pv2 boards

2021-02-22 Thread Sebastian Reichel
Document the compatible for GE B1x5pv2 boards. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/arm/fsl.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml

[PATCHv1 5/6] dt-bindings: mtd: jedec,spi-nor: add sst25vf032b

2021-02-22 Thread Sebastian Reichel
The binding is already used by the driver. Update documentation accordingly. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt b/Documentation

[PATCHv1 0/6] Support for GE B1x5v2

2021-02-22 Thread Sebastian Reichel
for the problem. https://lore.kernel.org/dri-devel/20200910162831.321556-1-sebastian.reic...@collabora.com/ -- Sebastian Sebastian Reichel (6): rtc: m41t80: add support for protected clock drm/imx: Add 8 pixel alignment fix dt-bindings: vendor-prefixes: add congatec dt-bindings: arm: fsl: add GE

[PATCHv1 6/6] ARM: dts: imx6: Add GE B1x5v2

2021-02-22 Thread Sebastian Reichel
This adds device tree files for the General Electric Healthcare (GEHC) B1x5v2 series. All models make use of Congatec's QMX6 module, which is described in its own device tree include, so that it can also be used by other boards. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/Makefile

[PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-02-22 Thread Sebastian Reichel
/clock-bindings.txt. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/rtc/rtc-m41t80.txt | 1 + drivers/rtc/rtc-m41t80.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/rtc/rtc-m41t80.txt b/Documentation

[PATCHv1 3/6] dt-bindings: vendor-prefixes: add congatec

2021-02-22 Thread Sebastian Reichel
Document binding for congatec. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index

Re: [PATCH v4] MAINTAINERS: move Milo Kim to credits

2021-02-12 Thread Sebastian Reichel
5x backlight driver, > - TI LP8727 charger driver, > - TI LP8788 MFD (ADC, LEDs, charger and regulator) drivers. > > Signed-off-by: Krzysztof Kozlowski > Cc: Mark Brown > Cc: Jonathan Cameron > Cc: Jingoo Han > Cc: Lee Jones > Cc: Pavel Machek > Cc: Thierry Red

Re: [PATCH] drm/omap: dsi: fix unreachable code in dsi_vc_send_short()

2021-01-26 Thread Sebastian Reichel
, and the one line summary. Do not split the tag across multiple lines, tags are exempt from the "wrap at 75 columns" rule in order to simplify parsing scripts. Otherwise: Reviewed-by: Sebastian Reichel -- Sebastian > Signed-off-by: Menglong Dong > --- > drivers/gpu/drm/omapdrm/

omapfb removal (was: Re: [PATCHv1] video: omapfb2: Make standard and custom DSI command mode panel driver mutually exclusive)

2021-01-13 Thread Sebastian Reichel
[dropped linux-next from Cc] Hi, On Tue, Jan 12, 2021 at 03:10:56PM +0200, Tomi Valkeinen wrote: > >> But why is it it we need omapfb at all when we have omapdrm? > > > > I think there are two reasons omapfb has not been killed yet. One > > reason was missing support for manually updated DSI

Re: [PATCHv1] video: omapfb2: Make standard and custom DSI command mode panel driver mutually exclusive

2021-01-13 Thread Sebastian Reichel
[replace Tomi's TI mail address with something working] Hi, On Fri, Jan 08, 2021 at 08:58:39PM +0100, Sam Ravnborg wrote: > Hi Sebastian, > > On Fri, Jan 08, 2021 at 12:24:41PM +0100, Sebastian Reichel wrote: > > Standard DRM panel driver for DSI command mode panel used by

[PATCHv1] video: omapfb2: Make standard and custom DSI command mode panel driver mutually exclusive

2021-01-09 Thread Sebastian Reichel
Signed-off-by: Sebastian Reichel --- Laurent introduced and fixed the same issue for the other panels and this simply replicates the same solution for DSI command mode panel. --- drivers/video/fbdev/omap2/omapfb/displays/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/om

Re: [PATCH v4 39/80] drm/panel: Move OMAP's DSI command mode panel driver

2021-01-09 Thread Sebastian Reichel
Hi, On Fri, Jan 08, 2021 at 01:23:54PM -0800, Dixit, Ashutosh wrote: > On Tue, 24 Nov 2020 04:44:57 -0800, Tomi Valkeinen wrote: > > > > From: Sebastian Reichel > > > > The panel driver is no longer using any OMAP specific APIs, so > > let's move it

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-05 Thread Sebastian Reichel
r/supply/bq25980.yaml | 1 + > [...] Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 27/29] drm/omap: dsi: remove ulps support

2020-12-14 Thread Sebastian Reichel
Hi, On Mon, Dec 14, 2020 at 08:55:36PM +0200, Tomi Valkeinen wrote: > On 14/12/2020 19:39, Sebastian Reichel wrote: > > Hi, > > > > On Tue, Dec 08, 2020 at 02:28:53PM +0200, Tomi Valkeinen wrote: > >> ULPS doesn't work, and I have been unable to get it to work.

Re: [PATCH v5 27/29] drm/omap: dsi: remove ulps support

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:53PM +0200, Tomi Valkeinen wrote: > ULPS doesn't work, and I have been unable to get it to work. As ULPS > is a minor power-saving feature which requires substantial amount of > non-trivial code, and we have trouble just getting and > keeping DSI working at all,

Re: [PATCH v5 29/29] drm/omap: dsi: allow DSI commands to be sent early

2020-12-14 Thread Sebastian Reichel
() cannot > be used to send DSI commands. > > This patch fixes the issue by making it possible to enable the DSI > interface any time a command is about to be sent. Disabling the > interface is be done via delayed work. > > Signed-off-by: Tomi Valkeinen > --- Reviewed-by:

Re: [PATCH v5 28/29] drm/omap: dsi: fix DCS_CMD_ENABLE

2020-12-14 Thread Sebastian Reichel
els > too. > > Fix this by skipping the set for video mode. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(

  1   2   3   4   5   6   7   >