Re: [PATCH 3/3] drm/i915: Don't use __func__ as prefix for drm_dbg_printer

2024-05-17 Thread Jani Nikula
On Fri, 17 May 2024, Michal Wajdeczko wrote: > Updated code of drm_dbg_printer() is already printing symbolic > name of the caller like drm_dbg() does. > > Signed-off-by: Michal Wajdeczko Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/gt/intel_reset.c | 2 +- >

Re: [PATCH 2/3] drm/print: Improve drm_dbg_printer

2024-05-17 Thread Jani Nikula
On Fri, 17 May 2024, Michal Wajdeczko wrote: > With recent introduction of a generic drm dev printk function, we > can now store and use location where drm_dbg_printer was invoked > and output it's symbolic name like we do for all drm debug prints. > > Signed-off-by: Michal Wajdeczko > Cc: Jani

Re: [PATCH 1/3] drm/print: Add generic drm dev printk function

2024-05-17 Thread Jani Nikula
, prefix, vaf); > + else > + if (origin) > + printk("%s" "[" DRM_NAME ":%ps]%s%s %pV", > +level, origin, prefix_pad, prefix, vaf); > + else > + printk("%

[PATCH 3/3] drm/i915: Don't use __func__ as prefix for drm_dbg_printer

2024-05-17 Thread Michal Wajdeczko
Updated code of drm_dbg_printer() is already printing symbolic name of the caller like drm_dbg() does. Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/intel_reset.c | 2 +- drivers/gpu/drm/i915/gt/selftest_context.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 2/3] drm/print: Improve drm_dbg_printer

2024-05-17 Thread Michal Wajdeczko
With recent introduction of a generic drm dev printk function, we can now store and use location where drm_dbg_printer was invoked and output it's symbolic name like we do for all drm debug prints. Signed-off-by: Michal Wajdeczko Cc: Jani Nikula --- drivers/gpu/drm/drm_print.c | 3 +--

[PATCH 1/3] drm/print: Add generic drm dev printk function

2024-05-17 Thread Michal Wajdeczko
We already have some drm printk functions that need to duplicate a code to get a similar format of the final result, for example: [ ] :00:00.0: [drm:foo] bar [ ] :00:00.0: [drm] foo bar [ ] :00:00.0: [drm] *ERROR* foo Add a generic __drm_dev_vprintk() function that can format

[PATCH 0/3] Improve drm printer code

2024-05-17 Thread Michal Wajdeczko
We already have some drm printk functions that need to duplicate a code to get a similar format of the final result, for example: [ ] :00:00.0: [drm:foo] bar [ ] :00:00.0: [drm] foo bar [ ] :00:00.0: [drm] *ERROR* foo Add a generic __drm_dev_vprintk() function that can format

Re: [PATCH] drm/buddy: Merge back blocks in bias range function

2024-05-17 Thread Matthew Auld
On 17/05/2024 13:38, Arunpravin Paneer Selvam wrote: In bias range allocation, when we don't find the required blocks (i.e) on returning the -ENOSPC, we should merge back the split blocks. Otherwise, during force_merge we are flooded with warn on's due to block and its buddy are in same clear

Re: [PATCH] drm/edid: add non-desktop quirk to Bigscreen Beyond HMD

2024-05-17 Thread Jani Nikula
On Fri, 17 May 2024, Sefa Eyeoglu wrote: > The Bigscreen Beyond VR headset is a non-desktop output and should be > marked as such using an EDID quirk. I'd appreciate a bug being filed at [1], attaching the EDID of the panel there, maybe dmesg with drm.debug=14 enabled too, and referencing the

Re: [PATCH] drm/buddy: Merge back blocks in bias range function

2024-05-17 Thread Paneer Selvam, Arunpravin
Hi Matthew, Could you help review this patch quickly. Hi Dave This patch just fixes the unnecessary warn on's triggered during the force_merge call. Regards, Arun. On 5/17/2024 6:08 PM, Arunpravin Paneer Selvam wrote: In bias range allocation, when we don't find the required blocks (i.e

Re: [PATCH] drm/i915/selftests: Set always_coherent to false when reading from CPU

2024-05-17 Thread Nirmoy Das
On 5/17/2024 1:53 PM, Jani Nikula wrote: On Fri, 17 May 2024, Nirmoy Das wrote: Hi Jani, On 5/17/2024 9:39 AM, Jani Nikula wrote: On Thu, 16 May 2024, Nirmoy Das wrote: The previous commit 'commit 8d4ba9fc1c6c ("drm/i915/selftests: Pick "previous commit" is a fairly vague reference once

[PATCH] drm/buddy: Merge back blocks in bias range function

2024-05-17 Thread Arunpravin Paneer Selvam
In bias range allocation, when we don't find the required blocks (i.e) on returning the -ENOSPC, we should merge back the split blocks. Otherwise, during force_merge we are flooded with warn on's due to block and its buddy are in same clear state (dirty or clear). Hence, renamed the force_merge

Re: [PATCH] drm/i915/selftests: Set always_coherent to false when reading from CPU

2024-05-17 Thread Jani Nikula
On Fri, 17 May 2024, Nirmoy Das wrote: > Hi Jani, > > On 5/17/2024 9:39 AM, Jani Nikula wrote: >> On Thu, 16 May 2024, Nirmoy Das wrote: >>> The previous commit 'commit 8d4ba9fc1c6c ("drm/i915/selftests: Pick >> "previous commit" is a fairly vague reference once this gets >> committed. It's not

[PATCH 2/2] drm/i915: Don't treat FLR resets as errors

2024-05-17 Thread Andi Shyti
If we timeout while waiting for an FLR reset, there is nothing we can do and i915 doesn't have any control on it. In any case the system is still perfectly usable and the function returns void. We don't need to be alarmed, therefore, print the timeout expiration as a debug message instead of an

[PATCH 1/2] drm/i915: Increase FLR timeout from 3s to 9s

2024-05-17 Thread Andi Shyti
Following the guidelines it takes 3 seconds to perform an FLR reset. Let's give it a bit more slack because this time can change depending on the platform and on the firmware Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10955 Signed-off-by: Andi Shyti ---

[PATCH 0/2] Don't be alarmed at FLR timeouts

2024-05-17 Thread Andi Shyti
Hi, often, on new platforms or firmware updates, we receive reports of FLR timeout expiration and we shift the timeout we wait for the reset to complete. Let's not be alarmed if we reach a timeout while waiting for FLR resets and print debugs rather than errors. The function is anyway a void

Re: [PATCH 1/2] drm/buddy: stop using PAGE_SIZE

2024-05-17 Thread Matthew Auld
On 17/05/2024 12:00, Christian König wrote: Am 17.05.24 um 10:53 schrieb Matthew Auld: On 17/05/2024 02:11, Dave Airlie wrote: On Thu, 29 Feb 2024 at 23:48, Arnd Bergmann wrote: On Thu, Feb 29, 2024, at 11:51, Matthew Auld wrote: The drm_buddy minimum page-size requirements should be

[PATCH] drm/nouveau/disp: Fix missing backlight control on Macbook 5, 1

2024-05-17 Thread Takashi Iwai
Macbook 5,1 with MCP79 lost its backlight control since the recent change for supporting GFP-RM; it rewrote the whole nv50 backlight control code and each display engine is supposed to have an entry for IOR bl callback, but it didn't cover mcp77. This patch adds the missing bl entry

[PATCH] drm/edid: add non-desktop quirk to Bigscreen Beyond HMD

2024-05-17 Thread Sefa Eyeoglu
The Bigscreen Beyond VR headset is a non-desktop output and should be marked as such using an EDID quirk. Signed-off-by: Sefa Eyeoglu --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

Re: [PATCH 1/2] drm/buddy: stop using PAGE_SIZE

2024-05-17 Thread Christian König
Am 17.05.24 um 10:53 schrieb Matthew Auld: On 17/05/2024 02:11, Dave Airlie wrote: On Thu, 29 Feb 2024 at 23:48, Arnd Bergmann wrote: On Thu, Feb 29, 2024, at 11:51, Matthew Auld wrote: The drm_buddy minimum page-size requirements should be distinct from the CPU PAGE_SIZE. Only restriction

[PATCH v3 1/3] gpu: ipu-v3: pre: move state into struct

2024-05-17 Thread Lucas Stach
Move the variables tracking the current dynamic state into a struct to separate it a bit better from the static device properties. Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel --- v2/v3: no changes --- drivers/gpu/ipu-v3/ipu-pre.c | 27 +++ 1 file changed, 15

[PATCH v3 2/3] gpu: ipu-v3: pre: add dynamic buffer layout reconfiguration

2024-05-17 Thread Lucas Stach
imx-drm doesn't mandate a modeset when the framebuffer modifier changes, but currently the tile prefetch and resolve (TPR) configuration of the PRE is only set up on the initial modeset. As the TPR configuration is double buffered, same as all the other PRE states, we can support dynamic

[PATCH v3 3/3] gpu: ipu-v3: pre: don't use fixed timeout when waiting for safe window

2024-05-17 Thread Lucas Stach
, so time spent away from the CPU is not accounted against the timeout budget. Signed-off-by: Lucas Stach --- v3: new patch --- drivers/gpu/ipu-v3/ipu-pre.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-pre.c b/drivers/gpu/ipu-v3

Re: [PATCH v9] drm/bridge: it6505: This patch fixes hibernate to resume no display issue

2024-05-17 Thread AngeloGioacchino Del Regno
Il 17/05/24 04:16, kuro ha scritto: From: Kuro Chung This patch added a FIFO reset bit for input video. When system power resume, the TTL input of it6505 may get some noise before video signal stable and the hardware function reset is required. But the input FIFO reset will also trigger error

Re: [PATCH] drm/i915/selftests: Set always_coherent to false when reading from CPU

2024-05-17 Thread Andi Shyti
Hi Nirmoy, On Thu, May 16, 2024 at 05:14:03PM +0200, Nirmoy Das wrote: > The previous commit 'commit 8d4ba9fc1c6c ("drm/i915/selftests: Pick > correct caching mode.")' was not complete as for non LLC sharing platforms > cpu read can happen from LLC which probably doesn't have the latest >

Re: [PATCH v6, 19/24] media: mediatek: vcodec: disable wait interrupt for svp mode

2024-05-17 Thread 胡俊光

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Takashi Iwai
On Thu, 16 May 2024 19:34:54 +0200, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.10 and submit it then. Hopin

Re: [PATCH v4 3/3] drm/mediatek: Implement OF graphs support for display paths

2024-05-17 Thread Michael Walle
so paving the > way to share the same mtk_mmsys_driver_data between multiple SoCs, > making it more straightforward to add support for new chips. paths might be optional, see comment in mtk_drm_kms_init(). But with this patch, you'll get an -EINVAL with a disabled path. See my proposals how to

[PATCH v10] drm/bridge: it6505: fix hibernate to resume no display issue

2024-05-17 Thread kuro
From: Kuro Chung This patch added a FIFO reset bit for input video. When system power resume, the TTL input of it6505 may get some noise before video signal stable and the hardware function reset is required. But the input FIFO reset will also trigger error interrupts of output module rising

Re: [PATCH 2/2] drm/mgag200: Add an option to disable Write-Combine

2024-05-17 Thread Thomas Zimmermann
Hi, just nits below. Am 16.05.24 um 18:17 schrieb Jocelyn Falempe: Unfortunately, the G200 ioburst workaround doesn't work on some servers like Dell poweredge XR11, XR5610, or HPE XL260 In this case completely disabling WC is the only option to achieve low-latency. So this adds a new Kconfig

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Rafael J. Wysocki
On Thu, May 16, 2024 at 7:35 PM Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.10 and submit it then. Hoping >to keep t

[PATCH v2 6/6] drm/ci: update xfails for the new testlist

2024-05-17 Thread Vignesh Raman
Now the testlist is used from IGT build, so update xfails with the new testlist. Set the timeout of all i915 jobs to 1h30m since some jobs takes more than 1 hour to complete. Signed-off-by: Vignesh Raman --- v2: - Set the timeout of all i915 jobs to 1h30m and updated expectations file. ---

[PATCH v2 4/6] drm/ci: uprev IGT

2024-05-17 Thread Vignesh Raman
-by: Vignesh Raman --- v2: - Split IGT uprev to seperate patch. --- drivers/gpu/drm/ci/build-igt.sh | 4 drivers/gpu/drm/ci/gitlab-ci.yml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ci/build-igt.sh b/drivers/gpu/drm/ci/build-igt.sh index e62244728613

[PATCH v2 5/6] drm/ci: skip driver specific tests

2024-05-17 Thread Vignesh Raman
Skip driver specific tests and skip kms tests for panfrost driver since it is not a kms driver. Signed-off-by: Vignesh Raman --- v2: - Skip xe tests for amdgpu and virtio. --- .../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt | 15 ++- drivers/gpu/drm/ci/xfails/i915-amly-skips.txt

[PATCH v2 2/6] drm/ci: generate testlist from build

2024-05-17 Thread Vignesh Raman
Stop vendoring the testlist into the kernel. Instead, use the testlist from the IGT build to ensure we do not miss renamed or newly added tests. Signed-off-by: Vignesh Raman --- v2: - Fix testlist generation for arm and arm64 builds. --- drivers/gpu/drm/ci/build-igt.sh | 34 +

[PATCH v2 3/6] drm/ci: build virtual GPU driver as module

2024-05-17 Thread Vignesh Raman
With latest IGT, the tests tries to load the module and it fails. So build the virtual GPU driver for virtio as module. Signed-off-by: Vignesh Raman --- v2: - No changes. --- drivers/gpu/drm/ci/build.sh | 1 - drivers/gpu/drm/ci/igt_runner.sh | 6 +++---

[PATCH v2 1/6] drm/ci: uprev mesa version

2024-05-17 Thread Vignesh Raman
zlib.net is not allowing tarball download anymore and results in below error in kernel+rootfs_arm32 container build, urllib.error.HTTPError: HTTP Error 403: Forbidden urllib.error.HTTPError: HTTP Error 415: Unsupported Media Type Uprev mesa to latest version which includes a fix for this issue.

[PATCH v2 0/6] drm/ci: uprev mesa/IGT and generate testlist

2024-05-17 Thread Vignesh Raman
Uprev mesa and IGT to the latest version and stop vendoring the testlist into the kernel. Instead, use the testlist from the IGT build to ensure we do not miss renamed or newly added tests. Update the xfails with the latest testlist run. Also build virtual GPU driver for virtio as module. The

Re: [PATCH 1/2] Revert "drm/mgag200: Add a workaround for low-latency"

2024-05-17 Thread Thomas Zimmermann
Am 16.05.24 um 18:17 schrieb Jocelyn Falempe: This reverts commit bfa4437fd3938ae2e186e7664b2db65bb8775670. This workaround doesn't work reliably on all servers. I'll replace it with an option to disable Write-Combine, which has more impact on performance, but fix the latency issue on all

[PATCH] arch: Fix name collision with ACPI's video.o

2024-05-17 Thread Thomas Zimmermann
Commit 2fd001cd3600 ("arch: Rename fbdev header and source files") renames the video source files under arch/ such that they do not refer to fbdev any longer. The new files named video.o conflict with ACPI's video.ko module. Modprobing the ACPI module can then fail with warnings about missing

Re: [PATCH 1/2] drm/buddy: stop using PAGE_SIZE

2024-05-17 Thread Matthew Auld
On 17/05/2024 02:11, Dave Airlie wrote: On Thu, 29 Feb 2024 at 23:48, Arnd Bergmann wrote: On Thu, Feb 29, 2024, at 11:51, Matthew Auld wrote: The drm_buddy minimum page-size requirements should be distinct from the CPU PAGE_SIZE. Only restriction is that the minimum page-size is at least

Re: [PATCH] drm/i915/selftests: Set always_coherent to false when reading from CPU

2024-05-17 Thread Nirmoy Das
Hi Jani, On 5/17/2024 9:39 AM, Jani Nikula wrote: On Thu, 16 May 2024, Nirmoy Das wrote: The previous commit 'commit 8d4ba9fc1c6c ("drm/i915/selftests: Pick "previous commit" is a fairly vague reference once this gets committed. It's not going to be "previous" in any meaningful sense.

[PATCH -next] drm/amd/display: Update optc35_set_odm_combine doc to match kernel-doc spec

2024-05-17 Thread Yang Li
This patch updates the function documentation comment for optc35_set_odm_combine to conform to the kernel-doc specification. Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Re: [PATCH] drm/etnaviv: switch devcoredump allocations to GFP_NOWAIT

2024-05-17 Thread Philipp Zabel
On Do, 2024-05-16 at 19:20 +0200, Lucas Stach wrote: > Am Freitag, dem 26.01.2024 um 17:46 +0100 schrieb Lucas Stach: > > The etnaviv devcoredump is created in the GPU reset path, which > > must make forward progress to avoid stalling memory reclaim on > > unsignalled dma fences. The currently

Re: [PATCH] drm/i915/selftests: Set always_coherent to false when reading from CPU

2024-05-17 Thread Jani Nikula
On Thu, 16 May 2024, Nirmoy Das wrote: > The previous commit 'commit 8d4ba9fc1c6c ("drm/i915/selftests: Pick "previous commit" is a fairly vague reference once this gets committed. It's not going to be "previous" in any meaningful sense. Please just start with: Commit 8d4ba9fc1c6c

Re: [PATCH v8 0/6] Break out as separate driver and add BOE nv110wum-l60 IVO t109nw41 MIPI-DSI panel

2024-05-17 Thread Neil Armstrong
Hi, On Thu, 16 May 2024 15:20:33 +0800, Cong Yang wrote: > Discussion with Doug and Linus in V1, we need a > separate driver to enable the hx83102 controller. > > So this series this series mainly Break out as separate driver > for Starry-himax83102-j02 panels from boe tv101wum driver. > > Then

Re: (subset) [PATCH v7 0/7] Break out as separate driver and add BOE nv110wum-l60 IVO t109nw41 MIPI-DSI panel

2024-05-17 Thread Neil Armstrong
Hi, On Wed, 15 May 2024 09:46:36 +0800, Cong Yang wrote: > Discussion with Doug and Linus in V1, we need a > separate driver to enable the hx83102 controller. > > So this series this series mainly Break out as separate driver > for Starry-himax83102-j02 panels from boe tv101wum driver. > > Then

Re: [PATCH v8 0/6] Break out as separate driver and add BOE nv110wum-l60 IVO t109nw41 MIPI-DSI panel

2024-05-17 Thread neil . armstrong
: - Neil think need sent separately to ARM SoC maintainer with "arm64: defconfig: Enable HIMAX_HX83102 panel patch ", so remove it. - PATCH 1/6: No change. - PATCH 2/6: Fix Doug comment "return ret" change to "goto poweroff". - PATCH 3/6: No change. - PATCH 4/6: No

Re: [PATCH 0/3] HW layer refactor

2024-05-17 Thread Jacek Lawrynowicz
Applied to drm-misc-next On 15.05.2024 13:30, Jacek Lawrynowicz wrote: > The NPU device consists of two parts: NPU buttress and NPU IP. > Buttress is a platform specific part that integrates the NPU IP with > the CPU. > NPU IP is the platform agnostic part that does the inference. > > This

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Christian König
Am 16.05.24 um 19:57 schrieb Tim Van Patten: From: Tim Van Patten The following commit updated gmc->noretry from 0 to 1 for GC HW IP 9.3.0: commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") This causes the device to hang when a page fault occurs, until the device is

Re: [PATCH v12 00/10] Improve test coverage of TTM

2024-05-16 Thread Somalapuram, Amaranath
: Fix a warning in ttm_bo_unreserve_bulk" patch to extend ttm_bo_kunit_init() helper to accept a dma_resv object and update calls to that helper (Christian) - Update drm_buddy_free_list() calls with an extra argument v11: - Delete CONFIG_DRM_KUNIT_TEST_HELPERS from .kunitcon

Re: [PATCH v3 3/6] dt-bindings: display: simple: Add Microtips & Lincolntech Dual-LVDS Panels

2024-05-16 Thread Liu Ying
On 5/16/24 20:36, Neil Armstrong wrote: > On 16/05/2024 13:06, Aradhya Bhatia wrote: >> Hi Liu, >> >> Thanks for reviewing the patch. >> >> On 16/05/24 07:49, Liu Ying wrote: >>> On 5/15/24 17:51, Aradhya Bhatia wrote: >>>> Add the Microtips T

[PATCH v9] drm/bridge: it6505: This patch fixes hibernate to resume no display issue

2024-05-16 Thread kuro
From: Kuro Chung This patch added a FIFO reset bit for input video. When system power resume, the TTL input of it6505 may get some noise before video signal stable and the hardware function reset is required. But the input FIFO reset will also trigger error interrupts of output module

Re: [PATCH 1/2] drm/buddy: stop using PAGE_SIZE

2024-05-16 Thread Dave Airlie
On Thu, 29 Feb 2024 at 23:48, Arnd Bergmann wrote: > > On Thu, Feb 29, 2024, at 11:51, Matthew Auld wrote: > > The drm_buddy minimum page-size requirements should be distinct from the > > CPU PAGE_SIZE. Only restriction is that the minimum page-size is at > > least 4K. > > > > Signed-off-by:

Re: [PATCH v4 6/8] drm/xe: Cache data about user-visible engines

2024-05-16 Thread Umesh Nerlige Ramappa
On Thu, May 16, 2024 at 02:52:01PM -0500, Lucas De Marchi wrote: On Thu, May 16, 2024 at 11:33:54AM GMT, Umesh Nerlige Ramappa wrote: On Wed, May 15, 2024 at 02:42:56PM -0700, Lucas De Marchi wrote: gt->info.engine_mask used to indicate the available engines, but that is not always true

Re: [PATCH v2 3/3] drm/panthor: Enable fdinfo for memory stats

2024-05-16 Thread Adrián Larumbe
al > > size. > > How is that relevant to this patch? Or to put it differently: how are your > words describing your code change here? I think I wrote this as a throw-back to the time when we handled RSS calculations for Panfrost objects, because heap BO's would be mapped on demand

Re: [PATCH v2 1/1] drm: Add ioctl for querying a DRM device's list of open client PIDs

2024-05-16 Thread Adrián Larumbe
> > descriptors. This is inefficient and time-consuming. > > > > This patch adds a new DRM ioctl that allows users to obtain a list of PIDs > > for clients who have opened the DRM device. Output from the ioctl isn't > > human-readable, and it's meant to be retrieved only by GPU pro

[PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-16 Thread Tim Van Patten
From: Tim Van Patten The following commit updated gmc->noretry from 0 to 1 for GC HW IP 9.3.0: commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") This causes the device to hang when a page fault occurs, until the device is rebooted. Instead, revert back to gmc->noretry=0 so

[PATCH] drm/komeda: remove unused struct 'gamma_curve_segment'

2024-05-16 Thread linux
From: "Dr. David Alan Gilbert" 'gamma_curve_segment' looks like it has never been used. Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/arm/display/komeda/komeda_color_mgmt.c | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [PATCH v4 6/8] drm/xe: Cache data about user-visible engines

2024-05-16 Thread Lucas De Marchi
On Thu, May 16, 2024 at 11:33:54AM GMT, Umesh Nerlige Ramappa wrote: On Wed, May 15, 2024 at 02:42:56PM -0700, Lucas De Marchi wrote: gt->info.engine_mask used to indicate the available engines, but that is not always true anymore: some engines are reserved to kernel and some may be exposed as

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-16 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 16, 2024 at 3:46 PM Tim Van Patten wrote: > > From: Tim Van Patten > > The following commit updated gmc->noretry from 0 to 1 for GC HW IP > 9.3.0: > > commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") > > This causes the device to hang when

Re: [PATCH v4 8/8] drm/xe/client: Print runtime to fdinfo

2024-05-16 Thread Umesh Nerlige Ramappa
On Wed, May 15, 2024 at 02:42:58PM -0700, Lucas De Marchi wrote: Print the accumulated runtime for client when printing fdinfo. Each time a query is done it first does 2 things: 1) loop through all the exec queues for the current client and accumulate the runtime, per engine class.

Re: [PATCH v4 7/8] drm/xe: Add helper to return any available hw engine

2024-05-16 Thread Umesh Nerlige Ramappa
On Wed, May 15, 2024 at 02:42:57PM -0700, Lucas De Marchi wrote: Get the first available engine from a gt, which helps in the case any engine serves as a context, like when reading RING_TIMESTAMP. Signed-off-by: Lucas De Marchi Reviewed-by: Umesh Nerlige Ramappa ---

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-05-16 Thread Andrew Halaney
: > > > > writel(42, DEVICE_REGISTER_0); // Arrives at the device... > > readl(DEVICE_REGISTER_0); > > udelay(1); > > writel(42, DEVICE_REGISTER_1); // ...at least 1us before this. > > Yes, udelay orders only with rea

Re: [PATCH v4 6/8] drm/xe: Cache data about user-visible engines

2024-05-16 Thread Umesh Nerlige Ramappa
On Wed, May 15, 2024 at 02:42:56PM -0700, Lucas De Marchi wrote: gt->info.engine_mask used to indicate the available engines, but that is not always true anymore: some engines are reserved to kernel and some may be exposed as a single engine (e.g. with ccs_mode). Runtime changes only happen

Re: [PATCH] drm/print: Kill ___drm_dbg()

2024-05-16 Thread Jani Nikula
On Thu, 16 May 2024, Michal Wajdeczko wrote: > There is no point in maintaining a separate print function, while > there is __drm_dev_dbg() function that can work with a NULL device. > > Signed-off-by: Michal Wajdeczko > Cc: Jani Nikula Reviewed-by: Jani Nikula > --- >

[PATCH] drm/probe-helper: Call drm_mode_validate_ycbcr420() before connector->mode_valid()

2024-05-16 Thread Ville Syrjala
From: Ville Syrjälä Make life easier for drivers by filtering out unwanted YCbCr 4:2:0 only modes prior to calling the connector->mode_valid() hook. Currently drivers will still see YCbCr 4:2:0 only modes in said hook, which will likely come as a suprise when the driver has declared no support

Re: [PATCH] drm/etnaviv: switch devcoredump allocations to GFP_NOWAIT

2024-05-16 Thread Lucas Stach
Am Freitag, dem 26.01.2024 um 17:46 +0100 schrieb Lucas Stach: > The etnaviv devcoredump is created in the GPU reset path, which > must make forward progress to avoid stalling memory reclaim on > unsignalled dma fences. The currently used __GFP_NORETRY does not > prohibit sleeping on direct

Re: [PATCH v2 2/3] drm/etnaviv: Turn etnaviv_is_model_rev() into a function

2024-05-16 Thread Lucas Stach
> headers. For newer hardware, the GC names are not the correct model > names anyway. For example, model 0x8000 NPUs are called VIPNano-QI/SI(+) > by VeriSilicon. > > Signed-off-by: Philipp Zabel I've applied the series to the etnaviv/next branch. I had to alter $subject p

Re: [PATCH v2] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core

2024-05-16 Thread Conor Dooley
On Wed, May 15, 2024 at 08:27:44AM +0200, Marek Vasut wrote: > The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property, > move the property description into the DW HDMI common DT schema too, so this > property can be used on all devices integrating the DW HDMI core.

Re: [PATCH] drm/etnaviv: drop driver owner assignment

2024-05-16 Thread Lucas Stach
Am Montag, dem 01.04.2024 um 12:26 +0200 schrieb Christian Gmeiner: > > > > Core in platform_driver_register() already sets the .owner, so driver > > does not need to. Whatever is set here will be anyway overwritten by > > main driver calling platform_driver_register(). > > > > Signed-off-by:

Re: [PATCH 0/8] dma-buf: heaps: Support carved-out heaps and ECC related-flags

2024-05-16 Thread John Stultz
On Thu, May 16, 2024 at 5:22 AM Maxime Ripard wrote: > On Wed, May 15, 2024 at 11:42:58AM -0700, John Stultz wrote: > > I apologize as my worry is mostly born out of seeing vendors really > > push opaque feature flags in their old ion heaps, so in providing a > > flags argument, it was mostly

Re: [PATCH 0/8] dma-buf: heaps: Support carved-out heaps and ECC related-flags

2024-05-16 Thread John Stultz
eally about the ability for the driver to access the type of memory. If ECC is just an attribute of the type of memory (as in this patch series), it being on or off won't necessarily affect compatibility of the buffer with the device. Similarly "uncached" seems more of an attribute of memory t

RE: [PATCH] drm/i915/selftests: Set always_coherent to false when reading from CPU

2024-05-16 Thread Cavitt, Jonathan
-Original Message- From: Das, Nirmoy Sent: Thursday, May 16, 2024 8:14 AM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Das, Nirmoy ; Andi Shyti ; Janusz Krzysztofik ; Cavitt, Jonathan Subject: [PATCH] drm/i915/selftests: Set always_coherent to false when

[PATCH 0/2] drm/mgag200: Add an option to disable Write-Combine

2024-05-16 Thread Jocelyn Falempe
Unfortunately, the G200 ioburst workaround doesn't work on some servers like Dell poweredge XR11, XR5610, or HPE XL260 In this case completely disabling WC is the only option to achieve low-latency. It's probably useless to maintain two workarounds for this, so I reverted commit bfa4437fd3938

[PATCH 1/2] Revert "drm/mgag200: Add a workaround for low-latency"

2024-05-16 Thread Jocelyn Falempe
This reverts commit bfa4437fd3938ae2e186e7664b2db65bb8775670. This workaround doesn't work reliably on all servers. I'll replace it with an option to disable Write-Combine, which has more impact on performance, but fix the latency issue on all hardware. Signed-off-by: Jocelyn Falempe ---

[PATCH 2/2] drm/mgag200: Add an option to disable Write-Combine

2024-05-16 Thread Jocelyn Falempe
Unfortunately, the G200 ioburst workaround doesn't work on some servers like Dell poweredge XR11, XR5610, or HPE XL260 In this case completely disabling WC is the only option to achieve low-latency. So this adds a new Kconfig option, to disable WC mapping of the G200 Signed-off-by: Jocelyn

[PATCH] drm/print: Kill ___drm_dbg()

2024-05-16 Thread Michal Wajdeczko
There is no point in maintaining a separate print function, while there is __drm_dev_dbg() function that can work with a NULL device. Signed-off-by: Michal Wajdeczko Cc: Jani Nikula --- drivers/gpu/drm/drm_print.c | 19 --- include/drm/drm_print.h | 8 +++- 2 files

[PATCH] drm/i915/selftests: Set always_coherent to false when reading from CPU

2024-05-16 Thread Nirmoy Das
The previous commit 'commit 8d4ba9fc1c6c ("drm/i915/selftests: Pick correct caching mode.")' was not complete as for non LLC sharing platforms cpu read can happen from LLC which probably doesn't have the latest changes made by GPU. Cc: Andi Shyti Cc: Janusz Krzysztofik Cc: Jonathan Cavitt

Re: [PATCH] ACPI: video: Fix name collision with architecture's video.o

2024-05-16 Thread Hans de Goede
Hi, On 5/16/24 5:11 PM, Thomas Zimmermann wrote: > Hi > > Am 16.05.24 um 17:03 schrieb Hans de Goede: >> Hi, >> >> On 5/16/24 3:04 PM, Rafael J. Wysocki wrote: >>> CC Hans who has been doing the majority of the ACPI video work. >>> >>> On Thu, May 16, 2024 at 2:43 PM Thomas Zimmermann >>>

Re: [PATCH 2/2] MAINTAINERS: update Xe driver maintainers

2024-05-16 Thread Lucas De Marchi
On Wed, May 15, 2024 at 07:22:22PM GMT, Oded Gabbay wrote: Because I left Intel, I'm removing myself from the list of Xe driver maintainers. Signed-off-by: Oded Gabbay Acked-by: Lucas De Marchi thanks Lucas De Marchi --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH] ACPI: video: Fix name collision with architecture's video.o

2024-05-16 Thread Thomas Zimmermann
Hi Am 16.05.24 um 17:03 schrieb Hans de Goede: Hi, On 5/16/24 3:04 PM, Rafael J. Wysocki wrote: CC Hans who has been doing the majority of the ACPI video work. On Thu, May 16, 2024 at 2:43 PM Thomas Zimmermann wrote: Commit 2fd001cd3600 ("arch: Rename fbdev header and source files")

Re: [PATCH 3/3] drm/loongson: Refactor lsdc device initialize and the output port

2024-05-16 Thread Sui Jingfeng
Hi, On 5/16/24 14:26, Markus Elfring wrote: … fullfill the implement under the new framework. fulfil the implementation? Please improve your change descriptions another bit. OK, despite has a few typos. but the quality of the patch itself can be guaranteed. The first version is mainly

Re: [PATCH] ACPI: video: Fix name collision with architecture's video.o

2024-05-16 Thread Hans de Goede
Hi, On 5/16/24 3:04 PM, Rafael J. Wysocki wrote: > CC Hans who has been doing the majority of the ACPI video work. > > On Thu, May 16, 2024 at 2:43 PM Thomas Zimmermann wrote: >> >> Commit 2fd001cd3600 ("arch: Rename fbdev header and source files") >> renames the video source files under arch/

[PATCH v5] drm/mediatek: dpi/dsi: fix possible_crtcs calculation

2024-05-16 Thread Michael Walle
mtk_find_possible_crtcs() assumes that the main path will always have the CRTC with id 0, the ext id 1 and the third id 2. This is only true if the paths are all available. But paths are optional (see also comment in mtk_drm_kms_init()), e.g. the main path might not be enabled or available at all.

RE: [PATCH v4 6/8] drm/xe: Cache data about user-visible engines

2024-05-16 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Lucas De Marchi Sent: Wednesday, May 15, 2024 2:43 PM To: intel...@lists.freedesktop.org Cc: Tvrtko Ursulin ; Nerlige Ramappa, Umesh ; dri-devel@lists.freedesktop.org; De Marchi, Lucas Subject: [PATCH v4 6/8] drm/xe: Cache data about user

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-05-16 Thread Akhil P Oommen
ediately read > back with readX() and udelay(1) is called prior to the second > writeX(): > > writel(42, DEVICE_REGISTER_0); // Arrives at the device... > readl(DEVICE_REGISTER_0); > udelay(1); > writel(42, DEVICE_REGIS

Re: [PATCH] drm/amdgpu: Remove duplicate amdgpu_umsch_mm.h header

2024-05-16 Thread Alex Deucher
Applied. Thanks! On Thu, May 16, 2024 at 4:47 AM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/amdgpu/amdgpu.h: amdgpu_umsch_mm.h is included more > than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9063 > Signed-off-by: Jiapeng Chong > --- >

Re: [PATCH 1/2] drm: print top commit sha after loading the driver

2024-05-16 Thread Farah Kassabri
ivers that come with it. > > And again, why should xe be a special snowflake in this respect? If it > were fine for xe to add this, why wouldn't it be fine for absolutely all > drivers? I think you're right, we'll keep this change internally, no need to upstream it. Thanks, Farah >

Re: [PATCH v4 8/8] drm/xe/client: Print runtime to fdinfo

2024-05-16 Thread Lucas De Marchi
xe_force_wake_put(gt_to_fw(gt), XE_FW_GT); + break; + } Runtime pm get/put could be just around this block, right? yes, I will update just this patch moving the xe_pm_runtime_put() if there are no other changes for next version. thanks Lucas De

Re: [PATCH v8 0/6] Break out as separate driver and add BOE nv110wum-l60 IVO t109nw41 MIPI-DSI panel

2024-05-16 Thread Doug Anderson
romium.org/ > > Changes in v8: > - Neil think need sent separately to ARM SoC maintainer with "arm64: > defconfig: Enable HIMAX_HX83102 panel patch ", so remove it. > - PATCH 1/6: No change. > - PATCH 2/6: Fix Doug comment "return ret" change to "goto

Re: [PATCH v2 0/5] Add support for GE SUNH hot-pluggable connector (was: "drm: add support for hot-pluggable bridges")

2024-05-16 Thread Daniel Vetter
Apologies for missing v1 ... On Fri, May 10, 2024 at 09:10:36AM +0200, Luca Ceresoli wrote: > DRM hotplug bridge driver > = > > DRM natively supports pipelines whose display can be removed, but all the > components preceding it (all the display controller and any bridges)

[PATCH 3/3] drm/vkms: Add support for XRGB2101010

2024-05-16 Thread Louis Chauvet
Thanks to the WRITE_LINE macro, adding the format XRGB210101010 is trivial. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_formats.c | 12 drivers/gpu/drm/vkms/vkms_writeback.c | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git

[PATCH 2/3] drm/vkms: Add a macro for write_line functions

2024-05-16 Thread Louis Chauvet
As stated in [2], the write_line functions are very similar and force code duplication. This patch add a macro to avoid code repetition. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_formats.c | 107 ++ drivers/gpu/drm/vkms/vkms_writeback.c | 4

[PATCH 0/3] drm/vkms: Reimplement line-per-line pixel conversion for writeback

2024-05-16 Thread Louis Chauvet
This series re-introduce the line-by-line algorithm. This is simpler than the read part because no rotation/translations are involved. PATCH 1/2 is the re-introduction itself PATCH 2/2 is a proposition to avoid code repetition using a "big" macro. This series depends on [1]. [

[PATCH 1/3] drm/vkms: Re-introduce line-by-line algorithm for writeback

2024-05-16 Thread Louis Chauvet
on performance, and it was merged. This patch is almost a revert of [2], but with some effort to avoid code duplication. Now only the loop is repeated, but it is required to have good performances. The performance gain is around 5 to 10%. [1]: https://lore.kernel.org/all/20211005201637.58563-7-igormtorre

[PATCH 4/5] drm/vkms: Add support for RGB565 formats

2024-05-16 Thread Louis Chauvet
The format RGB565 was already supported. Add the support for: - BGR565 Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_formats.c | 25 - drivers/gpu/drm/vkms/vkms_plane.c | 1 + 2 files changed, 25 insertions(+), 1 deletion(-) diff --git

[PATCH 3/5] drm/vkms: Add support for ARGB16161616 formats

2024-05-16 Thread Louis Chauvet
The formats XRGB16161616 and ARGB16161616 were already supported. Add the support for: - ABGR16161616 - XBGR16161616 Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_formats.c | 7 ++- drivers/gpu/drm/vkms/vkms_plane.c | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-)

[PATCH 5/5] drm/vkms: Add support for RGB888 formats

2024-05-16 Thread Louis Chauvet
Add the support for: - RGB888 - BGR888 Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_formats.c | 7 +++ drivers/gpu/drm/vkms/vkms_plane.c | 2 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/vkms/vkms_formats.c b/drivers/gpu/drm/vkms/vkms_formats.c index

[PATCH 1/5] drm/vkms: Create helpers macro to avoid code duplication in format callbacks

2024-05-16 Thread Louis Chauvet
The callback functions for line conversion are almost identical for some format. The generic READ_LINE macro generate all the required boilerplate to process a line. Two overrides of this macro have been added to avoid duplication of the same arguments every time. Signed-off-by: Louis Chauvet

<    1   2   3   4   5   6   7   8   9   10   >