Re: [PATCH] drm/i915: change node clearing from memset to initialization

2022-04-16 Thread Tom Rix
On 4/16/22 2:04 PM, Joe Perches wrote: On Sat, 2022-04-16 at 13:48 -0700, Tom Rix wrote: On 4/16/22 11:33 AM, Joe Perches wrote: On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote: In insert_mappable_node(), the parameter node is cleared late in node's use with memset. insert_mappable_node()

Re: [PATCH] drm/i915: change node clearing from memset to initialization

2022-04-16 Thread Joe Perches
On Sat, 2022-04-16 at 13:48 -0700, Tom Rix wrote: > On 4/16/22 11:33 AM, Joe Perches wrote: > > On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote: > > > In insert_mappable_node(), the parameter node is > > > cleared late in node's use with memset. > > > insert_mappable_node() is a singleton, called

Re: [PATCH] drm/i915: change node clearing from memset to initialization

2022-04-16 Thread Tom Rix
On 4/16/22 11:33 AM, Joe Perches wrote: On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote: In insert_mappable_node(), the parameter node is cleared late in node's use with memset. insert_mappable_node() is a singleton, called only from i915_gem_gtt_prepare() which itself is only called by

Re: [PATCH] drm/i915: change node clearing from memset to initialization

2022-04-16 Thread Joe Perches
On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote: > In insert_mappable_node(), the parameter node is > cleared late in node's use with memset. > insert_mappable_node() is a singleton, called only > from i915_gem_gtt_prepare() which itself is only > called by i915_gem_gtt_pread() and >

[PATCH] drm/i915: change node clearing from memset to initialization

2022-04-16 Thread Tom Rix
In insert_mappable_node(), the parameter node is cleared late in node's use with memset. insert_mappable_node() is a singleton, called only from i915_gem_gtt_prepare() which itself is only called by i915_gem_gtt_pread() and i915_gem_gtt_pwrite_fast() where the definition of node originates.