Re: [PATCH] staging: fb_tinylcd Alignment to open parenthesis

2024-05-04 Thread Dan Carpenter
On Fri, May 03, 2024 at 04:20:24PM +, Ashok Kumar wrote: > > Is there a list of exceptions to the checkpatch information that we can > ignore in general. > For Greg's subsystems ignore the warning about extra parentheses. You can search on lore for if a patch has been patch has been sent

Re: [PATCH] staging: fb_tinylcd Alignment to open parenthesis

2024-05-03 Thread Ashok Kumar
On Thursday, May 2, 2024 at 11:54:58 PM PDT, Julia Lawall wrote: On Thu, 2 May 2024, Ashok Kumar wrote: > Corrected coding style CHECK: Alignment should match open parenthesis Ashok, I think the code is nicer as is, because it has all the constant numbers lined up. julia Thanks for

Re: [PATCH] staging: fb_tinylcd Alignment to open parenthesis

2024-05-03 Thread Julia Lawall
On Thu, 2 May 2024, Ashok Kumar wrote: > Corrected coding style CHECK: Alignment should match open parenthesis Ashok, I think the code is nicer as is, because it has all the constant numbers lined up. julia > > Signed-off-by: Ashok Kumar > --- > drivers/staging/fbtft/fb_tinylcd.c | 2 +- >

Re: [PATCH] staging: fb_tinylcd Alignment to open parenthesis

2024-05-02 Thread Dan Carpenter
On Thu, May 02, 2024 at 06:52:16PM -0700, Ashok Kumar wrote: > Corrected coding style CHECK: Alignment should match open parenthesis > The original author was aligned it deliberately to improve readability. Just ignore checkpatch on this. regards, dan carpenter

[PATCH] staging: fb_tinylcd Alignment to open parenthesis

2024-05-02 Thread Ashok Kumar
Corrected coding style CHECK: Alignment should match open parenthesis Signed-off-by: Ashok Kumar --- drivers/staging/fbtft/fb_tinylcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c index