Re: [PATCH v2 5/8] drm/client: Convert drm_client_buffer_addfb() to drm_mode_addfb2()

2023-08-31 Thread Thomas Zimmermann
Hi Am 24.08.23 um 17:22 schrieb Geert Uytterhoeven: Hi Daniel, On Thu, Aug 24, 2023 at 5:12 PM Daniel Stone wrote: On Thu, 24 Aug 2023 at 16:09, Geert Uytterhoeven wrote: struct drm_client_dev *client = buffer->client; - struct drm_mode_fb_cmd fb_req = { }; - const

Re: [PATCH v2 5/8] drm/client: Convert drm_client_buffer_addfb() to drm_mode_addfb2()

2023-08-29 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert and Daniel, > Hi Daniel, > > On Thu, Aug 24, 2023 at 5:12 PM Daniel Stone wrote: >> On Thu, 24 Aug 2023 at 16:09, Geert Uytterhoeven >> wrote: >> > struct drm_client_dev *client = buffer->client; >> > - struct drm_mode_fb_cmd fb_req = { };

Re: [PATCH v2 5/8] drm/client: Convert drm_client_buffer_addfb() to drm_mode_addfb2()

2023-08-24 Thread Geert Uytterhoeven
Hi Daniel, On Thu, Aug 24, 2023 at 5:12 PM Daniel Stone wrote: > On Thu, 24 Aug 2023 at 16:09, Geert Uytterhoeven wrote: > > struct drm_client_dev *client = buffer->client; > > - struct drm_mode_fb_cmd fb_req = { }; > > - const struct drm_format_info *info; > > +

Re: [PATCH v2 5/8] drm/client: Convert drm_client_buffer_addfb() to drm_mode_addfb2()

2023-08-24 Thread Daniel Stone
Hi Geert, On Thu, 24 Aug 2023 at 16:09, Geert Uytterhoeven wrote: > struct drm_client_dev *client = buffer->client; > - struct drm_mode_fb_cmd fb_req = { }; > - const struct drm_format_info *info; > + struct drm_mode_fb_cmd2 fb_req = { }; > int ret; > > -

[PATCH v2 5/8] drm/client: Convert drm_client_buffer_addfb() to drm_mode_addfb2()

2023-08-24 Thread Geert Uytterhoeven
Currently drm_client_buffer_addfb() uses the legacy drm_mode_addfb(), which uses bpp and depth to guess the wanted buffer format. However, drm_client_buffer_addfb() already knows the exact buffer format, so there is no need to convert back and forth between buffer format and bpp/depth, and the