Re: [PATCH] i915: Remove racy delayed vblank swap ioctl.

2008-11-04 Thread Owain Ainsworth
On Tue, Nov 04, 2008 at 06:46:09PM -0800, Eric Anholt wrote: > When userland detected that this ioctl was supported (by version number > check), > it used it in a racy way -- dispatch delayed swap, wait for vblank, continue > rendering. As there was no mechanism for it to wait for the swap to fini

[PATCH] drm: Remove infrastructure for supporting i915's vblank swapping.

2008-11-04 Thread Eric Anholt
It's not used in any other drivers, and doesn't look like it will be from drm.git master. Signed-off-by: Eric Anholt <[EMAIL PROTECTED]> --- drivers/gpu/drm/drm_irq.c | 80 drivers/gpu/drm/drm_lock.c |9 - drivers/gpu/drm/drm_stub.c |1 -

[PATCH] i915: Remove racy delayed vblank swap ioctl.

2008-11-04 Thread Eric Anholt
When userland detected that this ioctl was supported (by version number check), it used it in a racy way -- dispatch delayed swap, wait for vblank, continue rendering. As there was no mechanism for it to wait for the swap to finish, sometimes it would render before the swap and garbage would be dis

Re: [PATCH] i915: Remove racy delayed vblank swap ioctl.

2008-11-04 Thread Owain Ainsworth
On Tue, Nov 04, 2008 at 12:54:03PM -0800, Eric Anholt wrote: > When userland detected that this ioctl was supported (by version number > check), > it used it in a racy way -- dispatch delayed swap, wait for vblank, continue > rendering. As there was no mechanism for it to wait for the swap to fini

Re: [Intel-gfx] [PATCH] Manage PIPESTAT pending interrupt values to unblock vblank interrupts

2008-11-04 Thread Eric Anholt
On Tue, 2008-11-04 at 02:03 -0800, Keith Packard wrote: > The pipestat fields affect reporting of all vblank-related interrupts, so we > have to reset them during the irq_handler, and while enabling vblank > interrupts. > > This patch adds i915_enable_pipestat and i915_disable_pipestat to abstract

[PATCH] i915: Remove IMR masking during interrupt handler, and restart it if needed.

2008-11-04 Thread Eric Anholt
The IMR masking was a technique recommended for avoiding getting stuck with no interrupts generated again in MSI mode. It kept new IIR bits from getting set between the IIR read and the IIR write, which would have otherwise prevented an MSI from ever getting generated again. However, this caused

[PATCH] i915: Remove racy delayed vblank swap ioctl.

2008-11-04 Thread Eric Anholt
When userland detected that this ioctl was supported (by version number check), it used it in a racy way -- dispatch delayed swap, wait for vblank, continue rendering. As there was no mechanism for it to wait for the swap to finish, sometimes it would render before the swap and garbage would be dis

[PATCH] Manage PIPESTAT pending interrupt values to unblock vblank interrupts

2008-11-04 Thread Keith Packard
The pipestat fields affect reporting of all vblank-related interrupts, so we have to reset them during the irq_handler, and while enabling vblank interrupts. This patch adds i915_enable_pipestat and i915_disable_pipestat to abstract out the steps needed to change the reported interrupts. Signed-o

[Bug 18335] [855GM regression] broken DRI with newer drivers

2008-11-04 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=18335 Eric Anholt <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolu