Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780 (was: Re: Linux 2.6.34-rc3)

2010-04-04 Thread Clemens Ladisch
Rafael J. Wysocki wrote: > From: Clemens Ladisch > Subject: PCI quirk: RS780/RS880: disable MSI completely > > The missing initialization of the nb_cntl.strap_msi_enable does not > seem to be the only problem that prevents MSI, so that quirk is not > sufficient to enable MSI on

Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780

2010-04-01 Thread Clemens Ladisch
Linus Torvalds wrote: > On Thu, 1 Apr 2010, Alex Deucher wrote: > > Clemems' "PCI quirk: RS780/RS880: disable MSI completely" patch is the > > right approach I think. Note that it's only devices hung off the int > > gfx pci to pci bridge that have broken MSI (gfx and audio). MSI works > > fine on

Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780 (was: Re: Linux 2.6.34-rc3)

2010-04-01 Thread Clemens Ladisch
I quirk: RS780/RS880: disable MSI completely The missing initialization of the nb_cntl.strap_msi_enable does not seem to be the only problem that prevents MSI, so that quirk is not sufficient to enable MSI on all machines. To be safe, unconditionally disable MSI for the internal graphics and HDMI audio

[PATCH] PCI quirks: RS780/RS880: work around missing MSI initialization

2010-03-22 Thread Clemens Ladisch
e BIOS has locked down the configuration registers, so we have to manually disable MSI for the affected devices. This fixes the codec communication errors in the HDA driver when accessing the HDMI audio device, and allows us to get rid of the overcautious quirk in radeon_irq_kms.c. Signed-off-b

[PATCH] drm/kms: fix spelling of "CLOCK"

2010-01-19 Thread Clemens Ladisch
From: Pavel Roskin Signed-off-by: Pavel Roskin [clem...@ladisch.de: merged into drm_fb_helper] Signed-off-by: Clemens Ladisch --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -694,7 +694,7 @@ int drm_fb_helper_set_par(struct fb_info int i; if

Re: [Linux-fbdev-devel] drm_fb_helper: Impossible to change video mode

2009-11-20 Thread Clemens Ladisch
Paulius Zaleckas wrote: > On drivers using drm_fb_helper's in fb_ops it is not possible to change > video mode, because of different var->pixclock evaluation: ... patch: http://www.mail-archive.com/dri-devel@lists.sourceforge.net/msg44369.html > P.S. check CLCOK spelling :) This patch got lost d

[PATCH v3 3/3] drm/kms: allocate framebuffer cmap

2009-11-04 Thread Clemens Ladisch
Without an allocated colormap, FBIOGETCMAP fails. This would make programs restore an all-black colormap ("links -g") or fail to work altogether ("mplayer -vo fbdev2"). Signed-off-by: Clemens Ladisch --- v3: bugfix by James Simmons drivers/gpu/drm/drm_fb_helper.c | 7 +++

[PATCH v3 2/3] drm: set the type of the drm_framebuffer::fbdev field

2009-11-04 Thread Clemens Ladisch
The fbdev field of the drm_framebuffer structure is always used to store a pointer to a fb_info, so there is no reason for it to be void*. Signed-off-by: Clemens Ladisch --- Needed for the next patch; no changes from v2. include/drm/drm_crtc.h |2 +- 1 file changed, 1 insertion

[PATCH v3 0/3] DRM/KMS framebuffer fixes

2009-11-04 Thread Clemens Ladisch
James Simmons wrote: > > @@ -905,6 +905,9 @@ int drm_fb_helper_single_fb_probe(struct > > > > if (new_fb) { > > info->var.pixclock = 0; > > + ret = fb_alloc_cmap(&info->cmap, crtc->gamma_size, 0); > > + if (ret) > > + return ret; > > >

[PATCH v3 1/3] drm/fb: fix FBIOGET/PUT_VSCREENINFO pixel clock handling

2009-11-04 Thread Clemens Ladisch
register_framebuffer() and userspace programs. This patch allows X.org's fbdev driver to work. Signed-off-by: Clemens Ladisch --- No changes from v1. drivers/gpu/drm/drm_fb_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-2.6/drivers/gpu/drm/drm_fb_helper.c +++ linu

[PATCH v2 3/3] drm/kms: allocate framebuffer cmap

2009-11-03 Thread Clemens Ladisch
Without an allocated colormap, FBIOGETCMAP fails. This would make programs restore an all-black colormap ("links -g") or fail to work altogether ("mplayer -vo fbdev2"). Signed-off-by: Clemens Ladisch --- v2: implemented suggestions by James Simmons drivers/gpu/drm/d

[PATCH v2 1/3] drm/fb: fix FBIOGET/PUT_VSCREENINFO pixel clock handling

2009-11-03 Thread Clemens Ladisch
register_framebuffer() and userspace programs. This patch allows X.org's fbdev driver to work. Signed-off-by: Clemens Ladisch --- No changes from v1. drivers/gpu/drm/drm_fb_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-2.6/drivers/gpu/drm/drm_fb_helper.c +++ linu

[PATCH v2 2/3] drm: set the type of the drm_framebuffer::fbdev field

2009-11-03 Thread Clemens Ladisch
The fbdev field of the drm_framebuffer structure is always used to store a pointer to a fb_info, so there is no reason for it to be void*. Signed-off-by: Clemens Ladisch --- Needed for the next patch. include/drm/drm_crtc.h |2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 0/3] DRM/KMS framebuffer fixes

2009-11-03 Thread Clemens Ladisch
James Simmons wrote: >> Without an allocated colormap, FBIOGETCMAP fails. This would make >> programs restore an all-black colormap ("links -g") or fail to work >> altogether ("mplayer -vo fbdev2"). >> >> --- linux-2.6/drivers/gpu/drm/i915/intel_fb.c >> +++ linux-2.6/drivers/gpu/drm/i915/intel_fb

[PATCH 3/3] drm/i915: allocate framebuffer cmap

2009-11-02 Thread Clemens Ladisch
Without an allocated colormap, FBIOGETCMAP fails. This would make programs restore an all-black colormap ("links -g") or fail to work altogether ("mplayer -vo fbdev2"). Signed-off-by: Clemens Ladisch --- Untested. --- linux-2.6/drivers/gpu/drm/i915/intel_fb.c +++ linux-2.6/

[PATCH 2/3] drm/radeon/kms: allocate framebuffer cmap

2009-11-02 Thread Clemens Ladisch
Without an allocated colormap, FBIOGETCMAP fails. This would make programs restore an all-black colormap ("links -g") or fail to work altogether ("mplayer -vo fbdev2"). Signed-off-by: Clemens Ladisch --- linux-2.6/drivers/gpu/drm/radeon/radeon_fb.c +++ linux-2.6/dr

[PATCH] drm/kms: fix spelling of "CLOCK"

2009-11-02 Thread Clemens Ladisch
From: Pavel Roskin Signed-off-by: Pavel Roskin [clem...@ladisch.de: merged into drm_fb_helper] Signed-off-by: Clemens Ladisch --- linux-2.6/drivers/gpu/drm/drm_fb_helper.c +++ linux-2.6/drivers/gpu/drm/drm_fb_helper.c @@ -676,7 +676,7 @@ int drm_fb_helper_set_par(struct fb_info int i

[PATCH 0/3] DRM/KMS framebuffer fixes

2009-11-02 Thread Clemens Ladisch
These patches make the KMS framebuffer work with various programs like links, mplayer and X. drivers/gpu/drm/drm_fb_helper.c|6 +++--- drivers/gpu/drm/i915/intel_fb.c|5 + drivers/gpu/drm/radeon/radeon_fb.c |5 + 3 files changed, 13 insertions(+), 3 deletions(-) -

[PATCH 1/3] drm/fb: fix FBIOGET/PUT_VSCREENINFO pixel clock handling

2009-11-02 Thread Clemens Ladisch
register_framebuffer() and userspace programs. This patch allows X.org's fbdev driver to work. Signed-off-by: Clemens Ladisch --- linux-2.6/drivers/gpu/drm/drm_fb_helper.c +++ linux-2.6/drivers/gpu/drm/drm_fb_helper.c @@ -583,7 +583,7 @@ int drm_fb_helper_check_var(struct fb_va s