Re: drivers/gpu/drm/radeon: move a dereference below a NULL test

2009-12-25 Thread Julien Cristau
On Thu, Dec 24, 2009 at 23:44:30 +1100, Darren Jenkins wrote: > If a NULL value is possible, the dereference should only occur after the > NULL test. > > Signed-off-by: Darren Jenkins > diff --git a/drivers/gpu/drm/radeon/radeon_irq.c > b/drivers/gpu/drm/radeon/radeon_irq.c > index b79ecc4..2f34

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-11 Thread Julien Cristau
On Mon, Jan 11, 2010 at 22:04:36 +0100, Rafael J. Wysocki wrote: > Hmm, are you trying to say radeon is better at that? > > My experience is quite the opposite to be honest. > radeon kms is in staging, doesn't pretend to be stable and force all users to the experimental paths. So yes, I would s

[PATCH 2/3] libdrm_nouveau requires libdrm

2010-02-26 Thread Julien Cristau
nouveau_drmif.h includes xf86drm.h. Signed-off-by: Julien Cristau --- nouveau/libdrm_nouveau.pc.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/nouveau/libdrm_nouveau.pc.in b/nouveau/libdrm_nouveau.pc.in index 7ef49e5..6ae6287 100644 --- a/nouveau

[PATCH 3/3] Install headers to $(includedir)/libdrm

2010-02-26 Thread Julien Cristau
Avoids conflicts with kernel headers. Signed-off-by: Julien Cristau --- This was suggested by Eric so distros can let the kernel install drm headers, but provide updated headers from libdrm so we can build new drivers regardless of the kernel version. include/drm/Makefile.am |2

[PATCH 1/3] libdrm_intel.pc: don't include ${includedir}/drm

2010-02-27 Thread Julien Cristau
intel_bufmgr.h is installed in ${includedir} directly, and the other headers are taken care of by libdrm.pc's Cflags. Signed-off-by: Julien Cristau --- intel/libdrm_intel.pc.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/intel/libdrm_intel.pc.in b/

Re: [PATCH 2/3] libdrm_nouveau requires libdrm

2010-02-27 Thread Julien Cristau
On Fri, Feb 26, 2010 at 13:38:59 -0500, Kristian Høgsberg wrote: > On Fri, Feb 26, 2010 at 1:07 PM, Julien Cristau wrote: > > nouveau_drmif.h includes xf86drm.h. > > If it's a source level dependency it should be a regular Requires: in > the .pc. Requires.private: is onl

Re: [PATCH] DRM: fix headers_check warnings

2010-03-02 Thread Julien Cristau
On Sat, Feb 27, 2010 at 14:57:36 +0530, Jaswinder Singh Rajput wrote: > > Fixed following headers_check warnings: > CHECK include/drm (14 files) > include/drm/drm_mode.h:84: found __[us]{8,16,32,64} type without #include > > include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type withou

Re: [PATCH 3/3] Install headers to $(includedir)/libdrm

2010-03-10 Thread Julien Cristau
On Fri, Feb 26, 2010 at 19:07:24 +0100, Julien Cristau wrote: > Avoids conflicts with kernel headers. > > Signed-off-by: Julien Cristau > --- > This was suggested by Eric so distros can let the kernel install drm > headers, but provide updated headers from libdrm so we can b

Re: [Intel-gfx] [PATCH 1/2] libdrm: Move intel_atomic.h to libdrm core for sharing.

2010-03-11 Thread Julien Cristau
> On Wed, Mar 10, 2010 at 11:20 AM, Pauli Nieminen wrote: > > intel_atomic.h includes very usefull atomic operations for > > lock free parrallel access of variables. Moving these to > > core libdrm for code sharing with radeon. > > > > Signed-off-by: Pauli Nieminen > > --- > >  Makefile.am      

Re: [PATCH] tests/ programs need -lrt too since they use clock_gettime.

2010-04-10 Thread Julien Cristau
On Fri, Apr 9, 2010 at 16:46:46 +0300, Török Edwin wrote: > When using the binutils gold linker, even if libdrm.so is already linked > against > -lrt you still need to link your app against -lrt if your app needs symbols > from > it. > > Signed-off-by: Török Edwin > --- > tests/Makefile.am |

Re: [Mesa3d-dev] Mesa 7.1 rc 4

2008-08-17 Thread Julien Cristau
On Sat, Aug 16, 2008 at 10:20:12 -0600, Brian Paul wrote: > Yet another Mesa 7.1 release candidate is at http://www.mesa3d.org/beta/ > > This includes the latest GLSL fixes/features plus other assorted fixes > from the past 2-3 weeks. > This also includes the drm-gem merge, which means that it

Re: Please provide a way to get software rendering

2008-11-16 Thread Julien Cristau
On Mon, Nov 17, 2008 at 00:03:43 +0100, Philipp Klaus Krause wrote: > I think it would be useful if one could choose software rendering > without having to uninstall hardware drivers. Maybe a driconf option or > an environment variable would be the way to go. This could be useful for > trying new

Re: intel text mode restore problem

2008-12-14 Thread Julien Cristau
On Fri, 2008-12-12 at 20:14 +0100, Norbert Preining wrote: > Where can I get this intel_reg_dumper from? Is there a tree to check > out, or a ready made binary from x86_64 (Debian/unstable)? > you can install the xserver-xorg-video-intel-dbg package, or build the reg dumper from the xf86-video-int

Re: [PATCH] radeon_cp: use request_firmware

2008-12-22 Thread Julien Cristau
On Sun, Dec 21, 2008 at 20:58:28 +, Dave Airlie wrote: > > > > > Is available at > > http://git.infradead.org/users/jaswinder/firm-jsr-2.6.git?a=commit;h=3a911a216742e4ab998f3281409d46a62f252716 > > > > > > Please let me know, should I need to resend this patch for : > > 1. git kernel.org:

Re: [PATCH 2/6] libdrm: Add missing string.h include

2009-07-05 Thread Julien Cristau
On Sat, Jul 4, 2009 at 02:18:50 +0300, Pauli Nieminen wrote: > --- > libdrm/xf86drm.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/libdrm/xf86drm.h b/libdrm/xf86drm.h > index c1d173c..a7f9763 100644 > --- a/libdrm/xf86drm.h > +++ b/libdrm/xf86drm.h > @@ -37,6 +3

Re: [PATCH 4/6] libdrm: Request for _XOPEN_SOURCE to get full posix headers including extensions (XSH: mknod)

2009-07-06 Thread Julien Cristau
On Mon, Jul 6, 2009 at 09:46:40 -0700, Ian Romanick wrote: > Here's an alterate patch the puts _XOPEN_SOURCE and _GNU_SOURCE in config.h > via configure.ac. Comments? > maybe use AC_USE_SYSTEM_EXTENSIONS instead? Cheers, Julien -

Re: [Intel-gfx] [PATCH] Make xorg.conf NoAccel/DRI options work under KMS

2009-07-08 Thread Julien Cristau
On Wed, Jul 8, 2009 at 12:04:44 -0700, Jesse Barnes wrote: > On Wed, 8 Jul 2009 11:50:38 -0700 > Keith Packard wrote: > > > KMS mode does not call I830AccelMethodInit as that does a ton of > > random device initialization, but that means that the NoAccel and DRI > > options were ignored. Split

Re: [Intel-gfx] [PATCH] Make xorg.conf NoAccel/DRI options work under KMS

2009-07-10 Thread Julien Cristau
On Thu, Jul 9, 2009 at 09:36:21 -0700, Jesse Barnes wrote: > I wonder if fbdev could fill the "get something on the screen when the > driver is busted" hole. Is it good enough to rely on for that? > IIRC that won't currently work well, because probe_devices_from_device_sections will claim the p

Re: libdrm: Fixing compilers warnings

2009-07-21 Thread Julien Cristau
On Mon, Jul 20, 2009 at 19:17:01 +0300, Pauli Nieminen wrote: > >From b7e77b71d1f2d8ff6741e534911e09f10e3f3d4e Mon Sep 17 00:00:00 2001 > From: Pauli Nieminen > Date: Mon, 20 Jul 2009 14:39:57 +0300 > Subject: [PATCH 01/15] libdrm: Add function attribute for debug > functions to let gcc check par

[PATCH] Only install libdrm_intel.pc if we build libdrm_intel

2009-10-31 Thread Julien Cristau
--- Makefile.am |4 ++-- configure.ac|4 ++-- libdrm/intel/Makefile.am|2 ++ libdrm/intel/libdrm_intel.pc.in | 10 ++ libdrm_intel.pc.in | 10 -- 5 files changed, 16 insertions(+), 14 deletions(-) create

Re: RFC: libdrm repo

2009-11-08 Thread Julien Cristau
On Fri, Nov 6, 2009 at 22:23:46 +0100, Jerome Glisse wrote: > I think Joe user will install the kernel-header package of its > distribution, and libdrm should detect at configure time kernel > header version and people should take care to only enable new > libdrm stuff when libdrm find the proper

Re: RFC: libdrm repo

2009-11-18 Thread Julien Cristau
On Tue, Nov 17, 2009 at 18:54:40 +0100, Stephane Marchesin wrote: > Yes, but the positive side is that distros using a standard/old (about > a year) kernel don't need to crawl the old libdrm repo and find the > right version (in your case they have to do this ° backport stuff) ... > I think that p

Re: [PATCH 3/5] drm/edid: Add DMT modes to the pool if the monitor is GTF-capable

2009-11-25 Thread Julien Cristau
On Tue, Nov 24, 2009 at 17:36:19 -0500, Adam Jackson wrote: > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index e655916..ee84ffe 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -481,16 +481,17 @@ static struct drm_display_mode drm_dmt_mo

Re: drm: Branch 'master'

2010-08-27 Thread Julien Cristau
On Fri, Aug 27, 2010 at 11:26:59 +0200, Zdenek Kabelac wrote: > Why keeping different name for C++ and C ? > Because changing the name for C means breaking API for existing users, which is not a nice thing to do. Cheers, Julien ---