Re: [rfc][patch 3/3] xfs: use new vmap API

2008-08-04 Thread Lachlan McIlroy
Okay. When the time comes will you push the XFS changes to mainline or would you like us to? Nick Piggin wrote: > Thanks for taking a look. I'll send them over to -mm with patch 1, > then, for some testing. > > On Monday 04 August 2008 16:28, Lachlan McIlroy wrote: &g

Re: [rfc][patch 3/3] xfs: use new vmap API

2008-08-03 Thread Lachlan McIlroy
Looks good to me. Nick Piggin wrote: > Implement XFS's large buffer support with the new vmap APIs. See the vmap > rewrite patch for some numbers. > > Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> > --- > > Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c > ==

Re: [rfc][patch 2/3] xfs: remove vmap cache

2008-08-03 Thread Lachlan McIlroy
Nick Piggin wrote: > XFS's vmap batching simply defers a number (up to 64) of vunmaps, and keeps > track of them in a list. To purge the batch, it just goes through the list and > calls vunamp on each one. This is pretty poor: a global TLB flush is still > performed on each vunmap, with the most ex