[PATCH] drm_handle_t type

2010-04-11 Thread Matthew W. S. Bell
On Mon, 2010-04-05 at 17:46 +1000, Dave Airlie wrote: > Its probably not documented well anywhere, though I think the handles are > 32-bit is written down somewhere. Ah sorry, I missed some. From a92f45396cd13f91ffd0bd1ea27250e5606184f8 Mon Sep 17 00:00:00 2001 From: Matthew W. S. Bell

[PATCH] drm_handle_t type

2010-04-08 Thread Matthew W. S. Bell
5c6815e0276 Mon Sep 17 00:00:00 2001 From: Matthew W. S. Bell Date: Fri, 9 Apr 2010 02:58:42 +0100 Add a comment about content of void* variable exchanged with kernel. Add casts to silence warnings about pointer to integer of a different size assignment. --- include/drm/drm.h |2 ++

Re: [PATCH] typdef uintptr_t drm_handle_t; unsigned int is wrong on 64-bit.

2010-04-04 Thread Matthew W. S. Bell
On Sat, 2010-04-03 at 08:49 +0100, Dave Airlie wrote: > No, its "designed" as is. We can't change it now as its ABI. We make sure > we only use 32-bit handles anyways. OK, is this documented anywhere, as I'd like to pull some of that into a comment? (It appears, on a casual glance, that this type

Re: [PATCH] typdef uintptr_t drm_handle_t; unsigned int is wrong on 64-bit.

2010-04-04 Thread Matthew W. S. Bell
On Sat, 2010-04-03 at 08:49 +0100, Dave Airlie wrote: > No, its "designed" as is. We can't change it now as its ABI. We make sure > we only use 32-bit handles anyways. Sorry, the comment about the ABI is, of course, nonsense, as the assumption is implicit in the kernel ABI. Matthew signature.

[PATCH] typdef uintptr_t drm_handle_t; unsigned int is wrong on 64-bit.

2010-04-03 Thread Matthew W. S. Bell
From d457b05faabde1a51b8e4b8f6fc13af9f07809f8 Mon Sep 17 00:00:00 2001 drm_handle_t appears to be assigned values from void*. As such unsigned int is certainly not the same size on 64-bit. Convert to uintptr_t in all cases as it is defined for this purpose. I fear this patch changes ABI, but I am

Re: [PATCH] libdrm compile warnings fixes

2010-02-06 Thread Matthew W. S. Bell
On Thu, 2010-02-04 at 19:48 -0500, Kristian Høgsberg wrote: > On Thu, Feb 4, 2010 at 2:23 PM, Matthew W. S. Bell > > Additionally, the function libdrm/xf86drmSL.c:drmSLLookupNeighbors() > > appears to be completely broken as it computes on the variable update > > which is unco

[PATCH] libdrm compile warnings fixes

2010-02-04 Thread Matthew W. S. Bell
Message-Id: <605963e604b8d7e3aa5ffa9ed87738bf1a0f0b7d.1265309634.git.matt...@bells23.org.uk> From: Matthew W. S. Bell Date: Sat, 30 Jan 2010 02:14:44 + Subject: [PATCH] Tidy up compile warnings by cleaning up types. --- tests/dristat.c |3 ++- tests/drmtest.c