On Mon, 3 Aug 2009 13:43:59 +0100 ja...@vmware.com wrote: > From: Jakob Bornecrantz <ja...@vmware.com> > > This was caught by Weiss. Also added some comments to the > fb_changed and mode_changed variables to explain what they do. > > Signed-off-by: Jakob Bornecrantz <ja...@vmware.com>
Tested-by: Thomas White <t...@bitwiz.org.uk> I tested this patch in my setup, and it fixes the NULL pointer deference which I was previously seeing. Unless I've missed something, it looks like we were just one compiler optimisation away from seeing this bug earlier, in the following case: drmModeSetCrtc(fd, crtc, 0, 0, 0, NULL, 0, NULL); Patch 3/3 causes the two cases of the "if" statement to differ, otherwise the compiler recognises that the NULL-dereferencing test does not need to be performed at all. In my case, I saw the problem when I added some printks in the same location (again breaking the "symmetry") while testing something completely different. Thanks! Tom ("Weiss") -- Thomas White <t...@bitwiz.org.uk> ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel