Re: [PATCH] DRM/TTM: add NO_EVICTION flag for type manager

2010-02-04 Thread Yuan, Shengquan
On Thu, Feb 4, 2010 at 4:59 PM, Jerome Glisse wrote: > On Thu, Feb 04, 2010 at 04:31:13PM +0800, Yuan, Shengquan wrote: >> The patch still needs some refine, just want to check if it make sense. >> >> >From 104a4800ef8d10fbcc5bd830d0ef0040bd4249e9 Mon Sep 17 00:00:00 2

[PATCH] DRM/TTM: add NO_EVICTION flag for type manager

2010-02-04 Thread Yuan, Shengquan
The patch still needs some refine, just want to check if it make sense. >From 104a4800ef8d10fbcc5bd830d0ef0040bd4249e9 Mon Sep 17 00:00:00 2001 From: Austin Yuan Date: Thu, 4 Feb 2010 16:18:28 +0800 Subject: [PATCH] DRM/TTM: add NO_EVICTION flag for type manager All buffers allocated from this m

Re: [patch] drm/ttm: remove unnecessary save_flags and ttm_flag_masked in ttm_bo_util.c

2010-01-20 Thread Yuan, Shengquan
On Wed, Jan 20, 2010 at 6:48 PM, Thomas Hellstrom wrote: > Yuan, > This looks like an old leftover from a previous cleanup. > > Although, when I look at the code, it seems save_flags should be removed > completely. > Can you take a look at that and respin the patch? Yes. One declaration wasn't rem

[patch] drm/ttm: remove unnecessary save_flags and ttm_flag_masked in ttm_bo_util.c

2010-01-18 Thread Yuan, Shengquan
commit d60326ac977a5e99047b44f9b313ff79cd3a14b4 Author: Austin Yuan Date: Tue Jan 19 11:45:24 2010 +0800 drm/ttm: remove unnecessary save_flags and ttm_flag_masked in ttm_bo_util.c Signed-off-by: Austin Yuan diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_

ttm_flag_masked in ttm_bo_util.c

2010-01-11 Thread Yuan, Shengquan
In function ttm_bo_move_ttm, ttm_bo_move_memcpy, and ttm_bo_move_accel_cleanup, just before function exits, there is: ttm_flag_masked(&save_flags, new_mem->placement, TTM_PL_MASK_MEMTYPE); Is it needed because save_flags is just a local variable? Thanks Austin --