Re: [2.6.33-rc6-git regression] idr fix breaks Xorg

2010-02-11 Thread Tejun Heo
Hello, Can you please test the following patch on top of the current mainline? Thanks. diff --git a/lib/idr.c b/lib/idr.c index 1cac726..0dc7822 100644 --- a/lib/idr.c +++ b/lib/idr.c @@ -156,10 +156,12 @@ static int sub_alloc(struct idr *idp, int *starting_id, struct idr_layer **pa)

Re: [2.6.33-rc6-git regression] idr fix breaks Xorg

2010-02-04 Thread Tejun Heo
On 02/04/2010 10:28 AM, Andy Isaacson wrote: On my Dell Latitude e4300 commit 859ddf0974 (idr: fix a critical misallocation bug) causes Xorg to segfault with the following backtrace: Does the following patch make any difference? diff --git a/lib/idr.c b/lib/idr.c index ba7d37c..a96c604 100644

Re: [2.6.33-rc6-git regression] idr fix breaks Xorg

2010-02-04 Thread Tejun Heo
Hello, On 02/04/2010 04:56 PM, Andy Isaacson wrote: 1265267921.568269 ioctl(8, 0xc020645e, 0x7fffe2196980) = -1 EBADF (Bad file descriptor) Hmm... -EBADF? I suppose it doesn't mean that the fd is invalid in this case but that the mapped object can't be found for some reason? Can anyone more

Re: [2.6.33-rc6-git regression] idr fix breaks Xorg

2010-02-04 Thread Dave Airlie
On Thu, Feb 4, 2010 at 6:16 PM, Tejun Heo t...@kernel.org wrote: Hello, On 02/04/2010 04:56 PM, Andy Isaacson wrote: 1265267921.568269 ioctl(8, 0xc020645e, 0x7fffe2196980) = -1 EBADF (Bad file descriptor) Hmm... -EBADF?  I suppose it doesn't mean that the fd is invalid in this case but

Re: [2.6.33-rc6-git regression] idr fix breaks Xorg

2010-02-04 Thread Tejun Heo
Hello, On 02/04/2010 05:40 PM, Dave Airlie wrote: Hmm at this late stage, maybe revert first? since the old idr code works fine with the subsystems in question. The drm idr code usage isn't anything crazy, the EBADF is the return code from the mmap ioctl when it calls the idr lookup

Re: [2.6.33-rc6-git regression] idr fix breaks Xorg

2010-02-04 Thread Chris Wilson
On Thu, 04 Feb 2010 17:16:56 +0900, Tejun Heo t...@kernel.org wrote: Hello, On 02/04/2010 04:56 PM, Andy Isaacson wrote: 1265267921.568269 ioctl(8, 0xc020645e, 0x7fffe2196980) = -1 EBADF (Bad file descriptor) Hmm... -EBADF? I suppose it doesn't mean that the fd is invalid in this

[2.6.33-rc6-git regression] idr fix breaks Xorg

2010-02-03 Thread Andy Isaacson
On my Dell Latitude e4300 commit 859ddf0974 (idr: fix a critical misallocation bug) causes Xorg to segfault with the following backtrace: ... (II) intel(0): Initializing HW Cursor (II) intel(0): No memory allocations Backtrace: 0: /usr/bin/X11/X(xorg_backtrace+0x26) [0x4f00c6] 1:

Re: [2.6.33-rc6-git regression] idr fix breaks Xorg

2010-02-03 Thread Andy Isaacson
On Thu, Feb 04, 2010 at 12:11:41PM +0900, Tejun Heo wrote: On 02/04/2010 10:28 AM, Andy Isaacson wrote: On my Dell Latitude e4300 commit 859ddf0974 (idr: fix a critical misallocation bug) causes Xorg to segfault with the following backtrace: Does the following patch make any difference?

Re: [2.6.33-rc6-git regression] idr fix breaks Xorg

2010-02-03 Thread Andy Isaacson
On Wed, Feb 03, 2010 at 05:28:37PM -0800, Andy Isaacson wrote: On my Dell Latitude e4300 commit 859ddf0974 (idr: fix a critical misallocation bug) causes Xorg to segfault with the following backtrace: ... (II) intel(0): Initializing HW Cursor (II) intel(0): No memory allocations