[Dri-devel] patch for function naming consistency

2003-03-12 Thread Philip Brown
I just noticed that in drivers/ati, every single function related to DRI initialization,etc. is named RADEONDRIXxxxYyyy ... except RADEONPreInitDRI() Here's a patch to fix that, and R128PreInitDRI() I had to make the patch by hand this time, since cvs seems down or something. ---

Re: [Dri-devel] patch for function naming consistency

2003-03-12 Thread Michel Dänzer
On Mit, 2003-03-12 at 19:15, Philip Brown wrote: I just noticed that in drivers/ati, every single function related to DRI initialization,etc. is named RADEONDRIXxxxYyyy ... except RADEONPreInitDRI() Here's a patch to fix that, and R128PreInitDRI() This change doesn't seem obvious to me; the

Re: [Dri-devel] patch for function naming consistency

2003-03-12 Thread Philip Brown
On Wed, Mar 12, 2003 at 10:21:17PM +0100, Michel Dänzer wrote: On Mit, 2003-03-12 at 19:15, Philip Brown wrote: I just noticed that in drivers/ati, every single function related to DRI initialization,etc. is named RADEONDRIXxxxYyyy ... except RADEONPreInitDRI() Here's a patch to fix

Re: [Dri-devel] patch for function naming consistency

2003-03-12 Thread Ian Romanick
Philip Brown wrote: On Wed, Mar 12, 2003 at 10:21:17PM +0100, Michel Dänzer wrote: This change doesn't seem obvious to me; the RADEONDRIxxx() functions are in radeon_dri.c and directly related to the DRI, whereas RADEONPreInitDRI() (along with other RADEONPreInitxxx() functions) is in

Re: [Dri-devel] patch for function naming consistency

2003-03-12 Thread Michel Dänzer
On Mit, 2003-03-12 at 23:14, Philip Brown wrote: On Wed, Mar 12, 2003 at 10:21:17PM +0100, Michel Dänzer wrote: On Mit, 2003-03-12 at 19:15, Philip Brown wrote: I just noticed that in drivers/ati, every single function related to DRI initialization,etc. is named RADEONDRIXxxxYyyy ...

Re: [Dri-devel] patch for function naming consistency

2003-03-12 Thread Jens Owen
Philip Brown wrote: On Wed, Mar 12, 2003 at 10:21:17PM +0100, Michel Dänzer wrote: On Mit, 2003-03-12 at 19:15, Philip Brown wrote: I just noticed that in drivers/ati, every single function related to DRI initialization,etc. is named RADEONDRIXxxxYyyy ... except RADEONPreInitDRI() Here's a patch

Re: [Dri-devel] patch for function naming consistency

2003-03-12 Thread Jens Owen
Jens Owen wrote: Philip Brown wrote: On Wed, Mar 12, 2003 at 10:21:17PM +0100, Michel Dänzer wrote: On Mit, 2003-03-12 at 19:15, Philip Brown wrote: I just noticed that in drivers/ati, every single function related to DRI initialization,etc. is named RADEONDRIXxxxYyyy ... except

Re: [Dri-devel] patch for function naming consistency

2003-03-12 Thread Philip Brown
On Wed, Mar 12, 2003 at 11:56:42PM +, Keith Whitwell wrote: Well, I didn't have much to do with this code when it was written, but I'm happy for it to stay where it is and as it is named for now. If someone wanted to take on a bigger task of comprehensively spring-cleaning the radeon

Re: [Dri-devel] patch for function naming consistency

2003-03-12 Thread Alan Cox
On Thu, 2003-03-13 at 00:20, Philip Brown wrote: On Wed, Mar 12, 2003 at 11:56:42PM +, Keith Whitwell wrote: Well, I didn't have much to do with this code when it was written, but I'm happy for it to stay where it is and as it is named for now. If someone wanted to take on a bigger

Re: [Dri-devel] patch for function naming consistency

2003-03-12 Thread Ian Molton
On 13 Mar 2003 03:24:10 + Alan Cox [EMAIL PROTECTED] wrote: A journey of 1000 miles begins with a single step But not if that step is over a cliff, onto a landmine or down a hole... I like that ;-) --- This SF.net email is sponsored