Re: [PATCH] DRM: add missing pci_enable_device()

2004-09-15 Thread Alan Cox
On Mer, 2004-09-15 at 00:41, Jon Smirl wrote: pci_enable/disable_device are correct in the dyn-minor patch. They also appear to correct in the currently checked in DRM cvs. If fbdev is loaded DRM does not do pci_enable/disable_device. It is assumed that these calls are handled by the fbdev

Re: [PATCH] DRM: add missing pci_enable_device()

2004-09-15 Thread Alan Cox
On Mer, 2004-09-15 at 16:35, Jon Smirl wrote: the video drivers vgacon still owns and is using it. On some devices that needs PCI master enabled because of internal magic (like rendering text modes from the bios via SMM traps) How do I trigger this mode on a card supported by DRM so that

Re: [PATCH] DRM: add missing pci_enable_device()

2004-09-15 Thread Jon Smirl
On Wed, 15 Sep 2004 13:22:48 +0100, Alan Cox [EMAIL PROTECTED] wrote: On Mer, 2004-09-15 at 00:41, Jon Smirl wrote: pci_enable/disable_device are correct in the dyn-minor patch. They also appear to correct in the currently checked in DRM cvs. If fbdev is loaded DRM does not do

Re: [PATCH] DRM: add missing pci_enable_device()

2004-09-14 Thread Alan Cox
On Llu, 2004-09-13 at 23:51, Bjorn Helgaas wrote: Add pci_enable_device()/pci_disable_device. In the past, drivers often worked without this, but it is now required in order to route PCI interrupts correctly. This code is wrong. The DRI is only one user of the video card, disabling the video

Re: [PATCH] DRM: add missing pci_enable_device()

2004-09-14 Thread Bjorn Helgaas
On Monday 13 September 2004 5:28 pm, Dave Airlie wrote: This causes problems when DRI and fb are loaded and you unload dri.. guess what happens your fb??, or it does in theory I might have time to practice later, now the quick fix is to take the stealth/non-stealth code from CVS which we

Re: [PATCH] DRM: add missing pci_enable_device()

2004-09-14 Thread Dave Airlie
OK, I'll assume you understand the issue and will resolve it. In the meantime, users of DRM will have to supply pci=routeirq. is this -mm only or is it mainline kernel stuff now? I'll throw an enable in to the bk tree later on Dave. -- David Airlie, Software Engineer

Re: [PATCH] DRM: add missing pci_enable_device()

2004-09-14 Thread Jon Smirl
It appears that the kernel bk tree is lagging behind the DRM CVS source. Allow more DRM updates into the kernel and these things will be fixed. If you want more up to date drivers get them directly from DRM CVS. pci_enable/disable_device are correct in the dyn-minor patch. They also appear to

[PATCH] DRM: add missing pci_enable_device()

2004-09-13 Thread Bjorn Helgaas
Add pci_enable_device()/pci_disable_device. In the past, drivers often worked without this, but it is now required in order to route PCI interrupts correctly. Evan Paul Fletcher found this problem with 2.6.9-rc1-mm4 and X.org 6.8.0 and verified that this patch fixes it. Signed-off-by: Bjorn

Re: [PATCH] DRM: add missing pci_enable_device()

2004-09-13 Thread Dave Airlie
This causes problems when DRI and fb are loaded and you unload dri.. guess what happens your fb??, or it does in theory I might have time to practice later, now the quick fix is to take the stealth/non-stealth code from CVS which we know works or we wait for Alan to finish his vga device code