Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-12 Thread Eric Anholt
On Sat, 9 Jan 2010 00:45:33 +0100, Rafael J. Wysocki r...@sisk.pl wrote: From: Rafael J. Wysocki r...@sisk.pl Commit cbda12d77ea590082edb6d30bd342a67ebc459e0 (drm/i915: implement new pm ops for i915), among other things, removed the .suspend and .resume pointers from the struct drm_driver

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-12 Thread Rafael J. Wysocki
On Tuesday 12 January 2010, Eric Anholt wrote: On Sat, 9 Jan 2010 00:45:33 +0100, Rafael J. Wysocki r...@sisk.pl wrote: From: Rafael J. Wysocki r...@sisk.pl Commit cbda12d77ea590082edb6d30bd342a67ebc459e0 (drm/i915: implement new pm ops for i915), among other things, removed the .suspend

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-11 Thread Jesse Barnes
On Sun, 10 Jan 2010 07:32:30 +1000 Dave Airlie airl...@gmail.com wrote: I'm in the 2-3 years at a minimum, with at least one kernel with no serious regressions in Intel KMS, which we haven't gotten close to yet. I'm not even sure the Intel guys are taking stable seriously enough yet. So far I

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-11 Thread Dave Airlie
On Tue, Jan 12, 2010 at 2:38 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Sun, 10 Jan 2010 07:32:30 +1000 Dave Airlie airl...@gmail.com wrote: I'm in the 2-3 years at a minimum, with at least one kernel with no serious regressions in Intel KMS, which we haven't gotten close to yet. I'm

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-11 Thread Jesse Barnes
On Tue, 12 Jan 2010 06:12:37 +1000 Dave Airlie airl...@gmail.com wrote: On Tue, Jan 12, 2010 at 2:38 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Sun, 10 Jan 2010 07:32:30 +1000 Dave Airlie airl...@gmail.com wrote: I'm in the 2-3 years at a minimum, with at least one kernel with no

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-11 Thread Rafael J. Wysocki
On Monday 11 January 2010, Dave Airlie wrote: On Tue, Jan 12, 2010 at 2:38 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Sun, 10 Jan 2010 07:32:30 +1000 Dave Airlie airl...@gmail.com wrote: I'm in the 2-3 years at a minimum, with at least one kernel with no serious regressions in

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-11 Thread Rafael J. Wysocki
On Monday 11 January 2010, Julien Cristau wrote: On Mon, Jan 11, 2010 at 22:04:36 +0100, Rafael J. Wysocki wrote: Hmm, are you trying to say radeon is better at that? My experience is quite the opposite to be honest. radeon kms is in staging, doesn't pretend to be stable and force

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-11 Thread Dave Airlie
On Tue, Jan 12, 2010 at 8:22 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Monday 11 January 2010, Julien Cristau wrote: On Mon, Jan 11, 2010 at 22:04:36 +0100, Rafael J. Wysocki wrote: Hmm, are you trying to say radeon is better at that? My experience is quite the opposite to be honest.

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-11 Thread Julien Cristau
On Mon, Jan 11, 2010 at 22:04:36 +0100, Rafael J. Wysocki wrote: Hmm, are you trying to say radeon is better at that? My experience is quite the opposite to be honest. radeon kms is in staging, doesn't pretend to be stable and force all users to the experimental paths. So yes, I would say

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-11 Thread Rafael J. Wysocki
On Tuesday 12 January 2010, Dave Airlie wrote: On Tue, Jan 12, 2010 at 8:22 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Monday 11 January 2010, Julien Cristau wrote: On Mon, Jan 11, 2010 at 22:04:36 +0100, Rafael J. Wysocki wrote: Hmm, are you trying to say radeon is better at that?

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-09 Thread Jerome Glisse
On Fri, Jan 08, 2010 at 06:50:41PM -0800, Jesse Barnes wrote: On Sat, 9 Jan 2010 02:15:41 + (GMT) Dave Airlie airl...@linux.ie wrote: From: Rafael J. Wysocki r...@sisk.pl Commit cbda12d77ea590082edb6d30bd342a67ebc459e0 (drm/i915: implement new pm ops for i915), among other

[PATCH] i915: Always register as a PCI driver (was: Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS)

2010-01-09 Thread Rafael J. Wysocki
On Saturday 09 January 2010, Jesse Barnes wrote: On Fri, 8 Jan 2010 16:50:57 -0800 (PST) Linus Torvalds torva...@linux-foundation.org wrote: On Sat, 9 Jan 2010, Rafael J. Wysocki wrote: Which is functionally equivalent to my patch, because i915_suspend/resume() won't be

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-09 Thread Linus Torvalds
On Sat, 9 Jan 2010, Jerome Glisse wrote: On Fri, Jan 08, 2010 at 06:50:41PM -0800, Jesse Barnes wrote: Linus, can we ever drop those old paths? Maybe after the new bits have been around for awhile? Users of really old userspace stacks would lose 3D support, but they'd still have 2D,

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-09 Thread Dave Airlie
On Sun, Jan 10, 2010 at 4:17 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Sat, 9 Jan 2010, Jerome Glisse wrote: On Fri, Jan 08, 2010 at 06:50:41PM -0800, Jesse Barnes wrote: Linus, can we ever drop those old paths?  Maybe after the new bits have been around for awhile?  

Re: [PATCH] i915: Always register as a PCI driver (was: Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS)

2010-01-09 Thread Dave Airlie
On Sat, Jan 9, 2010 at 11:35 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday 09 January 2010, Jesse Barnes wrote: On Fri, 8 Jan 2010 16:50:57 -0800 (PST) Linus Torvalds torva...@linux-foundation.org wrote: On Sat, 9 Jan 2010, Rafael J. Wysocki wrote: Which is functionally

Re: [PATCH] i915: Always register as a PCI driver (was: Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS)

2010-01-09 Thread Rafael J. Wysocki
On Saturday 09 January 2010, Dave Airlie wrote: On Sat, Jan 9, 2010 at 11:35 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday 09 January 2010, Jesse Barnes wrote: On Fri, 8 Jan 2010 16:50:57 -0800 (PST) Linus Torvalds torva...@linux-foundation.org wrote: On Sat, 9 Jan 2010,

[PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-08 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Commit cbda12d77ea590082edb6d30bd342a67ebc459e0 (drm/i915: implement new pm ops for i915), among other things, removed the .suspend and .resume pointers from the struct drm_driver object in i915_drv.c, which broke resume without KMS on my MSI Wind U100. Fix

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-08 Thread Linus Torvalds
On Sat, 9 Jan 2010, Rafael J. Wysocki wrote: From: Rafael J. Wysocki r...@sisk.pl Commit cbda12d77ea590082edb6d30bd342a67ebc459e0 (drm/i915: implement new pm ops for i915), among other things, removed the .suspend and .resume pointers from the struct drm_driver object in i915_drv.c,

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-08 Thread Jesse Barnes
On Fri, 8 Jan 2010 16:01:46 -0800 (PST) Linus Torvalds torva...@linux-foundation.org wrote: On Sat, 9 Jan 2010, Rafael J. Wysocki wrote: From: Rafael J. Wysocki r...@sisk.pl Commit cbda12d77ea590082edb6d30bd342a67ebc459e0 (drm/i915: implement new pm ops for i915), among other

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-08 Thread Jesse Barnes
On Fri, 8 Jan 2010 16:01:46 -0800 (PST) Linus Torvalds torva...@linux-foundation.org wrote: On Sat, 9 Jan 2010, Rafael J. Wysocki wrote: From: Rafael J. Wysocki r...@sisk.pl Commit cbda12d77ea590082edb6d30bd342a67ebc459e0 (drm/i915: implement new pm ops for i915), among other

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-08 Thread Rafael J. Wysocki
On Saturday 09 January 2010, Jesse Barnes wrote: On Fri, 8 Jan 2010 16:06:59 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: On Fri, 8 Jan 2010 16:01:46 -0800 (PST) Linus Torvalds torva...@linux-foundation.org wrote: On Sat, 9 Jan 2010, Rafael J. Wysocki wrote:

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-08 Thread Rafael J. Wysocki
On Saturday 09 January 2010, Linus Torvalds wrote: On Sat, 9 Jan 2010, Rafael J. Wysocki wrote: From: Rafael J. Wysocki r...@sisk.pl Commit cbda12d77ea590082edb6d30bd342a67ebc459e0 (drm/i915: implement new pm ops for i915), among other things, removed the .suspend and .resume

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-08 Thread Rafael J. Wysocki
On Saturday 09 January 2010, Jesse Barnes wrote: On Fri, 8 Jan 2010 16:01:46 -0800 (PST) Linus Torvalds torva...@linux-foundation.org wrote: On Sat, 9 Jan 2010, Rafael J. Wysocki wrote: From: Rafael J. Wysocki r...@sisk.pl Commit cbda12d77ea590082edb6d30bd342a67ebc459e0

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-08 Thread Jesse Barnes
On Fri, 8 Jan 2010 16:06:59 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: On Fri, 8 Jan 2010 16:01:46 -0800 (PST) Linus Torvalds torva...@linux-foundation.org wrote: On Sat, 9 Jan 2010, Rafael J. Wysocki wrote: From: Rafael J. Wysocki r...@sisk.pl Commit

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-08 Thread Linus Torvalds
On Sat, 9 Jan 2010, Rafael J. Wysocki wrote: Which is functionally equivalent to my patch, because i915_suspend/resume() won't be called by drm_class_suspend/resume() in the KMS case anyway. Ahh, right you are - that class suspend function does a check for DRIVER_MODESET, and only does the

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-08 Thread Jesse Barnes
On Fri, 8 Jan 2010 16:50:57 -0800 (PST) Linus Torvalds torva...@linux-foundation.org wrote: On Sat, 9 Jan 2010, Rafael J. Wysocki wrote: Which is functionally equivalent to my patch, because i915_suspend/resume() won't be called by drm_class_suspend/resume() in the KMS case anyway.

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-08 Thread Dave Airlie
From: Rafael J. Wysocki r...@sisk.pl Commit cbda12d77ea590082edb6d30bd342a67ebc459e0 (drm/i915: implement new pm ops for i915), among other things, removed the .suspend and .resume pointers from the struct drm_driver object in i915_drv.c, which broke resume without KMS on my MSI Wind

Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

2010-01-08 Thread Jesse Barnes
On Sat, 9 Jan 2010 02:15:41 + (GMT) Dave Airlie airl...@linux.ie wrote: From: Rafael J. Wysocki r...@sisk.pl Commit cbda12d77ea590082edb6d30bd342a67ebc459e0 (drm/i915: implement new pm ops for i915), among other things, removed the .suspend and .resume pointers from the struct