Re: [PATCH] drm/r100/kms: Emit cache flush to the end of command buffer. (v2)

2010-02-07 Thread Pauli Nieminen
On Sat, Feb 6, 2010 at 1:54 AM, Paul Menzel wrote: > Am Donnerstag, den 04.02.2010, 19:49 +0200 schrieb Pauli Nieminen: > > […] > >> +/* Who ever call radeon_fence_emit should call ring_lock and ask > > s/ever call/ever calls/ > Too bad you are asking too much from me. I'm probably at the top of

Re: [PATCH] drm/r100/kms: Emit cache flush to the end of command buffer. (v2)

2010-02-05 Thread Paul Menzel
Am Donnerstag, den 04.02.2010, 19:49 +0200 schrieb Pauli Nieminen: […] > +/* Who ever call radeon_fence_emit should call ring_lock and ask s/ever call/ever calls/ > + * for enough space (today caller are ib schedule and buffer move) */ s/caller/callers/ It would be nice to fix those typos wh

[PATCH] drm/r100/kms: Emit cache flush to the end of command buffer. (v2)

2010-02-04 Thread Pauli Nieminen
Cache flush is required in case CPU is accessing rendered data. This fixes glean/readPixSanity test case and random rendering errors in sauerbraten and warzone2100. v2 Fix comment ordering in r100_fence_ring_emit and remove extra defines added in first version. Signed-off-by: Pauli Nieminen