[PATCH] drm: clarify scaling property names

2009-06-30 Thread Jesse Barnes
Now that we're using the scaling property in the Intel driver I noticed that the names were a bit confusing. I've corrected them according to our discussion on IRC, though I've left out potential new additions for a new scaling property with an integer (or two) for the scaling factor. None of the

Re: [PATCH] drm: clarify scaling property names

2009-06-30 Thread Alex Deucher
On Tue, Jun 30, 2009 at 5:33 PM, Jesse Barnes wrote: > Now that we're using the scaling property in the Intel driver I noticed > that the names were a bit confusing.  I've corrected them according to > our discussion on IRC, though I've left out potential new additions for > a new scaling property

Re: [PATCH] drm: clarify scaling property names

2009-06-30 Thread Jesse Barnes
On Tue, 30 Jun 2009 17:51:05 -0400 Alex Deucher wrote: > > -       { DRM_MODE_SCALE_NON_GPU, "Non-GPU" }, > > -       { DRM_MODE_SCALE_FULLSCREEN, "Fullscreen" }, > > -       { DRM_MODE_SCALE_NO_SCALE, "No scale" }, > > -       { DRM_MODE_SCALE_ASPECT, "Aspect" }, > > +       { DRM_MODE_SCALE_NON_

Re: [PATCH] drm: clarify scaling property names

2009-07-01 Thread Maarten Maathuis
DRM_MODE_SCALE_NON_GPU was intended to let the monitor do the scaling, in case you have a CRT or the monitors scalers are better. I think your new name choice is less than ideal. Maarten. -- -- ___

Re: [PATCH] drm: clarify scaling property names

2009-07-01 Thread Alex Deucher
On Wed, Jul 1, 2009 at 5:23 AM, Maarten Maathuis wrote: > DRM_MODE_SCALE_NON_GPU was intended to let the monitor do the scaling, > in case you have a CRT or the monitors scalers are better. > I think your new name choice is less than ideal. Good point. I think we should have: None (sw or monitor

Re: [PATCH] drm: clarify scaling property names

2009-07-01 Thread Jesse Barnes
On Wed, 1 Jul 2009 11:23:50 +0200 Maarten Maathuis wrote: > DRM_MODE_SCALE_NON_GPU was intended to let the monitor do the scaling, > in case you have a CRT or the monitors scalers are better. > I think your new name choice is less than ideal. If that's what it's supposed to be, then yes, it's no

Re: [PATCH] drm: clarify scaling property names

2009-07-01 Thread Alex Deucher
On Wed, Jul 1, 2009 at 12:11 PM, Jesse Barnes wrote: > On Wed, 1 Jul 2009 11:23:50 +0200 > Maarten Maathuis wrote: > >> DRM_MODE_SCALE_NON_GPU was intended to let the monitor do the scaling, >> in case you have a CRT or the monitors scalers are better. >> I think your new name choice is less than

Re: [PATCH] drm: clarify scaling property names

2009-07-01 Thread Alex Deucher
On Wed, Jul 1, 2009 at 12:19 PM, Alex Deucher wrote: > On Wed, Jul 1, 2009 at 12:11 PM, Jesse Barnes wrote: >> On Wed, 1 Jul 2009 11:23:50 +0200 >> Maarten Maathuis wrote: >> >>> DRM_MODE_SCALE_NON_GPU was intended to let the monitor do the scaling, >>> in case you have a CRT or the monitors scale

Re: [PATCH] drm: clarify scaling property names

2009-07-01 Thread Jesse Barnes
On Wed, 1 Jul 2009 12:22:17 -0400 Alex Deucher wrote: > On Wed, Jul 1, 2009 at 12:19 PM, Alex Deucher > wrote: > > On Wed, Jul 1, 2009 at 12:11 PM, Jesse > > Barnes wrote: > >> On Wed, 1 Jul 2009 11:23:50 +0200 > >> Maarten Maathuis wrote: > >> > >>> DRM_MODE_SCALE_NON_GPU was intended to let th

Re: [PATCH] drm: clarify scaling property names

2009-07-01 Thread Jesse Barnes
On Wed, 1 Jul 2009 12:22:17 -0400 Alex Deucher wrote: > On Wed, Jul 1, 2009 at 12:19 PM, Alex Deucher > wrote: > > On Wed, Jul 1, 2009 at 12:11 PM, Jesse > > Barnes wrote: > >> On Wed, 1 Jul 2009 11:23:50 +0200 > >> Maarten Maathuis wrote: > >> > >>> DRM_MODE_SCALE_NON_GPU was intended to let th

Re: [PATCH] drm: clarify scaling property names

2009-07-01 Thread Alex Deucher
On Wed, Jul 1, 2009 at 1:04 PM, Jesse Barnes wrote: > On Wed, 1 Jul 2009 12:22:17 -0400 > Alex Deucher wrote: > >> On Wed, Jul 1, 2009 at 12:19 PM, Alex Deucher >> wrote: >> > On Wed, Jul 1, 2009 at 12:11 PM, Jesse >> > Barnes wrote: >> >> On Wed, 1 Jul 2009 11:23:50 +0200 >> >> Maarten Maathuis