Re: [PATCH] libdrm compile warnings fixes

2010-02-06 Thread Matthew W. S. Bell
On Thu, 2010-02-04 at 19:48 -0500, Kristian Høgsberg wrote: > On Thu, Feb 4, 2010 at 2:23 PM, Matthew W. S. Bell > > Additionally, the function libdrm/xf86drmSL.c:drmSLLookupNeighbors() > > appears to be completely broken as it computes on the variable update > > which is unconditionally undefined.

Re: [PATCH] libdrm compile warnings fixes

2010-02-04 Thread Kristian Høgsberg
On Thu, Feb 4, 2010 at 2:23 PM, Matthew W. S. Bell wrote: > Hi, > > I've fixed up some compile warnings in the attached patch; I think a > couple of cases may actually have been bugs. One case I have not touched > is converting between void * (64 bit here) and drm_handle_t (32 bit > here), as I do

[PATCH] libdrm compile warnings fixes

2010-02-04 Thread Matthew W. S. Bell
Hi, I've fixed up some compile warnings in the attached patch; I think a couple of cases may actually have been bugs. One case I have not touched is converting between void * (64 bit here) and drm_handle_t (32 bit here), as I don't understand the issues here; it would be nice if no warnings were e