[PATCH 2/2] drm/radeon: Add asic hook for dma copy to r200 cards.

2010-02-11 Thread Pauli Nieminen
r200 cards have dma engine which can be used to tranfer data between vram and system memory. r300 dma engine registers match r200 dma engine. Enabling dma copy for r200 is simple as hooking r200 asic to already existing function r300_copy_dma. Rename r300_dma_copy to r200_dma_copyto reflect that

Re: [PATCH 2/2] drm/radeon: Add asic hook for dma copy to r200 cards.

2010-02-11 Thread Alex Deucher
On Thu, Feb 11, 2010 at 6:51 AM, Jerome Glisse wrote: > On Thu, Feb 11, 2010 at 12:40:45AM +0100, Maarten Maathuis wrote: >> What happens if you have two cards, one RS200 and one RV280 (just an >> example). I think you shouldn't change values in a static struct. >> > > Yeah good catch, it's best t

Re: [PATCH 2/2] drm/radeon: Add asic hook for dma copy to r200 cards.

2010-02-11 Thread Jerome Glisse
On Thu, Feb 11, 2010 at 12:40:45AM +0100, Maarten Maathuis wrote: > What happens if you have two cards, one RS200 and one RV280 (just an > example). I think you shouldn't change values in a static struct. > Yeah good catch, it's best to do a separate asic struct for r200 rather than changing the

Re: [PATCH 2/2] drm/radeon: Add asic hook for dma copy to r200 cards.

2010-02-10 Thread Maarten Maathuis
What happens if you have two cards, one RS200 and one RV280 (just an example). I think you shouldn't change values in a static struct. On Wed, Feb 10, 2010 at 11:10 PM, Pauli Nieminen wrote: > r200 cards have dma engine which can be used to tranfer data > between vram and system memory. > > r300

[PATCH 2/2] drm/radeon: Add asic hook for dma copy to r200 cards.

2010-02-10 Thread Pauli Nieminen
r200 cards have dma engine which can be used to tranfer data between vram and system memory. r300 dma engine registers match r200 dma engine. Enabling dma copy for r200 is simple as hooking r200 asic to already existing function r300_copy_dma. Rename r300_dma_copy to r200_dma_copyto reflect that