[PATCH 4/6] drm/i915: Fix lock order reversal in shmem pread path.

2009-03-25 Thread Eric Anholt
Signed-off-by: Eric Anholt --- drivers/gpu/drm/i915/i915_gem.c | 221 ++- 1 files changed, 195 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index bdc7326..010af90 100644 --- a/drivers/gpu/drm/i9

Re: [PATCH 4/6] drm/i915: Fix lock order reversal in shmem pread path.

2009-03-25 Thread Dave Airlie
I've no idea when a fault is likely in the fast case, i.e. will it happen usually on the first page etc, because if it happens on the last page and you fallback and restart the whole copy, I would think that would be sub-optimal, granted it could get ugly quick, but this code has already hit a

Re: [PATCH 4/6] drm/i915: Fix lock order reversal in shmem pread path.

2009-03-25 Thread Keith Packard
On Wed, 2009-03-25 at 23:30 +, Dave Airlie wrote: > > I've no idea when a fault is likely in the fast case, i.e. will it happen > usually on the first page etc, because if it happens on the last page and > you fallback and restart the whole copy, I would think that would be > sub-optimal, gr

Re: [PATCH 4/6] drm/i915: Fix lock order reversal in shmem pread path.

2009-03-26 Thread Jesse Barnes
On Wed, 25 Mar 2009 14:45:08 -0700 Eric Anholt wrote: > Signed-off-by: Eric Anholt Same comments as 3/6... Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center -- -- __