[PATCH modesetting-101] move map removal to after unload

2007-11-13 Thread Jesse Barnes
Since the driver unload will probably want to use the register map we shouldn't unmap it until after the unload callback returns. This allows load/unload to work again with i915. Does this look ok? If so, I'll push it into modesetting-101. Jesse diff --git a/linux-core/drm_drv.c b/linux-core

Re: [PATCH modesetting-101] move map removal to after unload

2007-11-13 Thread Dave Airlie
NAK... I already fixed this, we have a driver mapping.. otherwise we leak mappings if userspace dies.. Dave. -- David Airlie, Software Engineer http://www.skynet.ie/~airlied / airlied at skynet.ie Linux kernel - DRI, VAX / pam_smb / ILUG On Tue, 13 Nov 2007, Jesse Barnes wrote: > Since the

Re: [PATCH modesetting-101] move map removal to after unload

2007-11-14 Thread Jesse Barnes
On Tuesday, November 13, 2007 10:25 pm Dave Airlie wrote: > NAK... > > I already fixed this, we have a driver mapping.. otherwise we leak > mappings if userspace dies.. I don't see the fix, the latest tree gives an oops on unload with something like this... I guess somehow the i915_load isn't us

Re: [PATCH modesetting-101] move map removal to after unload

2007-11-14 Thread Jesse Barnes
On Wednesday, November 14, 2007 8:11 am Jesse Barnes wrote: > On Tuesday, November 13, 2007 10:25 pm Dave Airlie wrote: > > NAK... > > > > I already fixed this, we have a driver mapping.. otherwise we leak > > mappings if userspace dies.. > > I don't see the fix, the latest tree gives an oops on un