Re: [Patch VIA UniChrome DRM][2/5 Ver1] Add support for video command flush and interface for V4L kernel module

2009-10-08 Thread Thomas Hellstrom
brucech...@via.com.tw wrote: > Hello Thomas: > > >> If I understand the code correctly, the user-space application prepares >> command buffers directly in AGP, and asks the >> drm module to submit them. We can't allow this for security reasons. The >> user-space application could for example f

RE: [Patch VIA UniChrome DRM][2/5 Ver1] Add support for video command flush and interface for V4L kernel module

2009-10-08 Thread BruceChang
Chen; Joseph Chan Subject: Re: [Patch VIA UniChrome DRM][2/5 Ver1] Add support for video command flush and interface for V4L kernel module Dear Bruce, On Thu, Oct 08, 2009 at 05:35:51PM +0800, brucech...@via.com.tw wrote: > > If I understand the code correctly, the user-space appli

RE: [Patch VIA UniChrome DRM][2/5 Ver1] Add support for video command flush and interface for V4L kernel module

2009-10-08 Thread BruceChang
Welte; Benjamin Chen Subject: RE: [Patch VIA UniChrome DRM][2/5 Ver1] Add support for video command flush and interface for V4L kernel module On Thu, 2009-10-08 at 02:35 -0700, brucech...@via.com.tw wrote: > Hello Thomas: > > > If I understand the code correctly, the user-space

Re: [Patch VIA UniChrome DRM][2/5 Ver1] Add support for video command flush and interface for V4L kernel module

2009-10-08 Thread Harald Welte
Dear Bruce, On Thu, Oct 08, 2009 at 05:35:51PM +0800, brucech...@via.com.tw wrote: > > If I understand the code correctly, the user-space application prepares > > command buffers directly in AGP, and asks the > > drm module to submit them. We can't allow this for security reasons. The > > user

RE: [Patch VIA UniChrome DRM][2/5 Ver1] Add support for video command flush and interface for V4L kernel module

2009-10-08 Thread Keith Whitwell
On Thu, 2009-10-08 at 02:35 -0700, brucech...@via.com.tw wrote: > Hello Thomas: > > > If I understand the code correctly, the user-space application prepares > > command buffers directly in AGP, and asks the > > drm module to submit them. We can't allow this for security reasons. The > > user-sp

RE: [Patch VIA UniChrome DRM][2/5 Ver1] Add support for video command flush and interface for V4L kernel module

2009-10-08 Thread BruceChang
Hello Thomas: > If I understand the code correctly, the user-space application prepares > command buffers directly in AGP, and asks the > drm module to submit them. We can't allow this for security reasons. The > user-space application could for example fill the buffer with > commands to textur

Re: [Patch VIA UniChrome DRM][2/5 Ver1] Add support for video command flush and interface for V4L kernel module

2009-10-08 Thread Thomas Hellstrom
brucech...@via.com.tw wrote: Bruce, Others. The v4l interfaces look ok to me. However, the double-buffer flush mechanism does not. If I understand the code correctly, the user-space application prepares command buffers directly in AGP, and asks the drm module to submit them. We can't allow this

[Patch VIA UniChrome DRM][2/5 Ver1] Add support for video command flush and interface for V4L kernel module

2009-10-08 Thread BruceChang
Hello All: This is patch 2 of the 5 patches. It's based on 2.6.32-rc3+patch1 and for the support of video command flush(using double buffer to improve performance) and interfaces for communication with v4l kernel module. 5 files has been modified for this patch. Sign-off by Bruce C. Chan