Re: Bad test in IRQ Control IOCTL?

2004-08-29 Thread Dave Airlie
/* if we haven't dma then no need for this control */ if (!(dev-driver_features DRIVER_HAVE_DMA)) return -EINVAL; Shouldn't this be DRIVER_HAVE_IRQ ? the old code was #if __HAVE_IRQ || __HAVE_DMA [DRM_IOCTL_NR(DRM_IOCTL_CONTROL)] = { DRM(control), 1, 1 },

Bad test in IRQ Control IOCTL?

2004-08-28 Thread Thomas Hellstrom
Hi! The following lines are in the IRQ Control IOCTL: /* if we haven't dma then no need for this control */ if (!(dev-driver_features DRIVER_HAVE_DMA)) return -EINVAL; Shouldn't this be DRIVER_HAVE_IRQ ? BTW, sorry Erdi for attributing this to your patch. /Thomas