Re: Radeon DRM GART mapping bogosity

2005-05-08 Thread Benjamin Herrenschmidt
On Sun, 2005-05-08 at 18:23 +0100, Dave Airlie wrote: > > > > Ok, here's the candidate for submission to Linus if no other comment by > > tomorrow. David, will you take care of adapting it to DRI CVS ? > > > > Will do.. it'll be a few days.. still on the road.. Ok, I want to double check someth

RE: Radeon DRM GART mapping bogosity

2005-05-05 Thread Benjamin Herrenschmidt
On Thu, 2005-05-05 at 09:48 +1000, Benjamin Herrenschmidt wrote: > On Wed, 2005-05-04 at 09:35 -0400, Hui Yu wrote: > > > I don't know an exception for it being a non-power of 2, but it can be > > zero on some M6 chips. In these cases, set it to 8M. > > Yup, I know about that case, I'll send a fi

RE: Radeon DRM GART mapping bogosity

2005-05-04 Thread Benjamin Herrenschmidt
On Wed, 2005-05-04 at 09:35 -0400, Hui Yu wrote: > I don't know an exception for it being a non-power of 2, but it can be > zero on some M6 chips. In these cases, set it to 8M. Yup, I know about that case, I'll send a fixed patch later today, thanks ! Ben. ---

RE: Radeon DRM GART mapping bogosity

2005-05-04 Thread Hui Yu
Title: RE: Radeon DRM GART mapping bogosity >-Original Message- >From: Michel Dänzer [mailto:[EMAIL PROTECTED]] >Sent: Tuesday, May 03, 2005 11:38 PM >To: Benjamin Herrenschmidt >Cc: dri-devel@lists.sourceforge.net; Hui Yu; Dave Airlie; Paul Mackerras >Subject: R

Re: Radeon DRM GART mapping bogosity

2005-05-04 Thread Benjamin Herrenschmidt
> > drm_radeon_private_t *dev_priv = dev->dev_private;; > > DRM_DEBUG( "\n" ); > > + u32 gart_loc; > > move the local variable above the DRM_DEBUG line... is u32 enough? > (I've no idea myself ...) Yah, I need to move it. u32 is on purpose as dev_priv->fb_location is u32.

Re: Radeon DRM GART mapping bogosity

2005-05-03 Thread Michel Dänzer
On Wed, 2005-05-04 at 11:41 +1000, Benjamin Herrenschmidt wrote: > > Ok, here's a new patch that I'll send to Linus if you (Michel) acks it. > > I use CONFIG_MEMSIZE, I don't try to max out with CONFIG_APER_SIZE since > I beleive we just don't care, and that avoids putting pressure on the > GART

Re: Radeon DRM GART mapping bogosity

2005-05-03 Thread Benjamin Herrenschmidt
On Wed, 2005-05-04 at 09:48 +1000, Benjamin Herrenschmidt wrote: > > If a conflict can't be avoided, we could fail gracefully upfront > > (suggesting to make the GART aperture smaller, ...) instead of risking > > subtle breakage? > > Well, I don't know of any clean platform independant way to know

Re: Radeon DRM GART mapping bogosity

2005-05-03 Thread Benjamin Herrenschmidt
> If a conflict can't be avoided, we could fail gracefully upfront > (suggesting to make the GART aperture smaller, ...) instead of risking > subtle breakage? Well, I don't know of any clean platform independant way to know if there is a conflict or not, that is to know where RAM is in bus space.

Re: Radeon DRM GART mapping bogosity

2005-05-03 Thread Vladimir Dergachev
On Wed, 4 May 2005, Benjamin Herrenschmidt wrote: Note that with huge VRAM sizes appearing, we also want to make sure that wheverver we put it won't overlap the 32 bits space since CONFIG_MEM_SIZE can be huge nowadays... and if it does, put the GART just _before_ the framebuffer instead. Again, t

Re: Radeon DRM GART mapping bogosity

2005-05-03 Thread Michel Dänzer
On Wed, 2005-05-04 at 00:39 +1000, Benjamin Herrenschmidt wrote: > > > Note that with huge VRAM sizes appearing, we also want to make sure that > > > wheverver we put it won't overlap the 32 bits space since CONFIG_MEM_SIZE > > > can be huge nowadays... and if it does, put the GART just _before_ th

Re: Radeon DRM GART mapping bogosity

2005-05-03 Thread Dave Airlie
> In the meantime, here's a patch against current Linus "git" that I'm > tempted to push asap so that at least 2.6.12 avoids the problem of > overlapping which causes random stuffs to happen with lockups. The > "issue" here is even if you don't have an r300-friendly DRM, it will > still try to init

Re: Radeon DRM GART mapping bogosity

2005-05-03 Thread Benjamin Herrenschmidt
> > Note that with huge VRAM sizes appearing, we also want to make sure that > > wheverver we put it won't overlap the 32 bits space since CONFIG_MEM_SIZE > > can be huge nowadays... and if it does, put the GART just _before_ the > > framebuffer instead. Again, this is all cards space, not bus vie

Re: Radeon DRM GART mapping bogosity

2005-05-03 Thread Benjamin Herrenschmidt
On Tue, 2005-05-03 at 10:41 +0200, Jerome Glisse wrote: > > Now, the setting above has to be done the most intelligently you can > > based on 1) do you need 2 apertures with different swapper settings > > (typical of BE machines) or not, 2) what is your CONFIG_APER_SIZE > > strapping vs. how much V

Re: Radeon DRM GART mapping bogosity

2005-05-03 Thread Michel Dänzer
On Tue, 2005-05-03 at 10:09 +0200, Jerome Glisse wrote: > On 5/3/05, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > Ok, I'm cross posting here because X.org is doing it wrong too. On R300, > > for some reason I don't fully understand, it just goes back to the "old" > > way of putting the FB

Re: Radeon DRM GART mapping bogosity

2005-05-03 Thread Michel Dänzer
On Tue, 2005-05-03 at 15:24 +1000, Benjamin Herrenschmidt wrote: > > The radeon DRM has some interesting bug that paul and I discovered to > cause all sort of problems like crashing the machine on suspend/resume > (go figure ...) etc... > > dev_priv->gart_vm_start = dev_priv->fb_location >

Re: Radeon DRM GART mapping bogosity

2005-05-03 Thread Benjamin Herrenschmidt
On Tue, 2005-05-03 at 10:09 +0200, Jerome Glisse wrote: > Has i still doesn't understand the big pictures of video drivers, i > was wondering > if this could have an impact on bytes swapping on r300. Thus the problem > of bit blit we have on r300 & X driver. I don't think so but as i don't well >

Re: Radeon DRM GART mapping bogosity

2005-05-03 Thread Benjamin Herrenschmidt
On Tue, 2005-05-03 at 15:24 +1000, Benjamin Herrenschmidt wrote: > Hi ! > > The radeon DRM has some interesting bug that paul and I discovered to > cause all sort of problems like crashing the machine on suspend/resume > (go figure ...) etc... > > dev_priv->gart_vm_start = dev_priv->fb_loc