Re: [PATCH 2/2] drm/ttm: don't write to bo->reserved without holding glob->lru_lock

2010-03-01 Thread Thomas Hellstrom
Maarten Maathuis wrote: > - The headerfile says you can't write to it without holding the lock. > NAK. The header-file is incorrect. It should say that the lru_lock needs to be held only when we transition from 0 to 1. That guarantees that if the lru lock is held, and we read 0, we can safel

Re: [PATCH 2/2] drm/ttm: don't write to bo->reserved without holding glob->lru_lock

2010-03-01 Thread Jerome Glisse
On Mon, Mar 01, 2010 at 07:34:40PM +0100, Maarten Maathuis wrote: > - The headerfile says you can't write to it without holding the lock. > > Signed-off-by: Maarten Maathuis NAK, from my POV as we always use atomic_* on reserved it's useless to protect it with spinlock. Cheers, Jerome > --- >