Re: Trivial fixes for drivers/gpu/drm/i915/

2009-06-22 Thread Randy Dunlap
Marcel Holtmann wrote: > Hi Krzysztof, > >> size_t is (some sort of) int on x86-32 and long on x86-64, eliminate >> compiler warnings by casting to long. > > just using %zd or %zu would do the same trick and avoid stupid casts. I.e., using %zd or %zu is the preferred fix. -- ~Randy LPC 2009, S

Re: Trivial fixes for drivers/gpu/drm/i915/ (#1 V2)

2009-06-22 Thread Krzysztof Halasa
size_t is (some sort of) int on x86-32 and long on x86-64, correct format specifiers. Signed-off-by: Krzysztof Halasa diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 39f5c65..cdaa8b6 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i91

Re: Trivial fixes for drivers/gpu/drm/i915/

2009-06-22 Thread Krzysztof Halasa
Randy Dunlap writes: > I.e., using %zd or %zu is the preferred fix. Good to know, thanks. -- Krzysztof Halasa -- Are you an open source citizen? Join us for the Open Source Bridge conference! Portland, OR, June 17-19.

Trivial fixes for drivers/gpu/drm/i915/

2009-06-19 Thread Krzysztof Halasa
size_t is (some sort of) int on x86-32 and long on x86-64, eliminate compiler warnings by casting to long. Signed-off-by: Krzysztof Halasa diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 39f5c65..d5044db 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/dri

Re: Trivial fixes for drivers/gpu/drm/i915/

2009-06-19 Thread Marcel Holtmann
Hi Krzysztof, > size_t is (some sort of) int on x86-32 and long on x86-64, eliminate > compiler warnings by casting to long. just using %zd or %zu would do the same trick and avoid stupid casts. Regards Marcel -- Are