Re: drivers/gpu/drm/radeon: move a dereference below a NULL test

2009-12-25 Thread Julien Cristau
On Thu, Dec 24, 2009 at 23:44:30 +1100, Darren Jenkins wrote: > If a NULL value is possible, the dereference should only occur after the > NULL test. > > Signed-off-by: Darren Jenkins > diff --git a/drivers/gpu/drm/radeon/radeon_irq.c > b/drivers/gpu/drm/radeon/radeon_irq.c > index b79ecc4..2f34

drivers/gpu/drm/radeon: move a dereference below a NULL test

2009-12-24 Thread Darren Jenkins
If a NULL value is possible, the dereference should only occur after the NULL test. Signed-off-by: Darren Jenkins diff --git a/drivers/gpu/drm/radeon/radeon_irq.c b/drivers/gpu/drm/radeon/radeon_irq.c index b79ecc4..2f349a3 100644 --- a/drivers/gpu/drm/radeon/radeon_irq.c +++ b/drivers/gpu/drm/ra