Re: i915: wait for buffer idle before writing relocations

2007-12-10 Thread Keith Whitwell
Keith Packard wrote: On Fri, 2007-12-07 at 11:15 +, Keith Whitwell wrote: Keith, Thomas has just left for two weeks of (well deserved!) holiday, so he may be slow to respond. Thanks for taking the time to have a look while he's away; we're finishing up the 965 TTM work, and it is

Re: i915: wait for buffer idle before writing relocations

2007-12-10 Thread Keith Packard
On Mon, 2007-12-10 at 13:27 +, Keith Whitwell wrote: OK, it sounds like you're talking about situations where the driver is modifying state in buffers *only* through changes to the relocations? Yes, although I also don't expect this to be common. It's probably not surprising the fence

Re: i915: wait for buffer idle before writing relocations

2007-12-10 Thread Keith Whitwell
@lists.sourceforge.net Sent: Monday, December 10, 2007 4:44:44 PM Subject: Re: i915: wait for buffer idle before writing relocations [...] I think the interesting usage that you point out is where the application knows that a wait isn't necessary as the previously referenced data will not be re-used, and only new

Re: i915: wait for buffer idle before writing relocations

2007-12-08 Thread Eric Anholt
On Fri, 2007-12-07 at 11:15 +, Keith Whitwell wrote: Keith, Thomas has just left for two weeks of (well deserved!) holiday, so he may be slow to respond. In the meantime, have you considered how this will interact with userspace buffer pools? I know you guys aren't using them at

Re: i915: wait for buffer idle before writing relocations

2007-12-07 Thread Keith Whitwell
i915: wait for buffer idle before writing relocations When writing a relocation entry, make sure the target buffer is idle, otherwise the GPU may see inconsistent data. diff --git a/shared-core/i915_dma.c b/shared-core/i915_dma.c index 8791af6..42a2216 100644 --- a/shared

Re: i915: wait for buffer idle before writing relocations

2007-12-07 Thread Keith Packard
On Fri, 2007-12-07 at 11:15 +, Keith Whitwell wrote: Keith, Thomas has just left for two weeks of (well deserved!) holiday, so he may be slow to respond. Thanks for taking the time to have a look while he's away; we're finishing up the 965 TTM work, and it is posing some challenges

i915: wait for buffer idle before writing relocations

2007-12-06 Thread Keith Packard
-0800 i915: wait for buffer idle before writing relocations When writing a relocation entry, make sure the target buffer is idle, otherwise the GPU may see inconsistent data. diff --git a/shared-core/i915_dma.c b/shared-core/i915_dma.c index 8791af6..42a2216 100644 --- a/shared-core