Yuan, Shengquan wrote:
> On Wed, Jan 20, 2010 at 6:48 PM, Thomas Hellstrom wrote:
>
>> Yuan,
>> This looks like an old leftover from a previous cleanup.
>>
>> Although, when I look at the code, it seems save_flags should be removed
>> completely.
>> Can you take a look at that and respin the pa
On Wed, Jan 20, 2010 at 6:48 PM, Thomas Hellstrom wrote:
> Yuan,
> This looks like an old leftover from a previous cleanup.
>
> Although, when I look at the code, it seems save_flags should be removed
> completely.
> Can you take a look at that and respin the patch?
Yes. One declaration wasn't rem
4b4
> Author: Austin Yuan
> Date: Tue Jan 19 11:45:24 2010 +0800
>
> drm/ttm: remove unnecessary save_flags and ttm_flag_masked in
> ttm_bo_util.c
>
> Signed-off-by: Austin Yuan
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c
> b/drivers/gpu/drm/ttm/ttm_b
commit d60326ac977a5e99047b44f9b313ff79cd3a14b4
Author: Austin Yuan
Date: Tue Jan 19 11:45:24 2010 +0800
drm/ttm: remove unnecessary save_flags and ttm_flag_masked in ttm_bo_util.c
Signed-off-by: Austin Yuan
diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c
b/drivers/gpu/drm/ttm
On Mon, Jan 11, 2010 at 04:20:00PM +0800, Yuan, Shengquan wrote:
> In function ttm_bo_move_ttm, ttm_bo_move_memcpy, and
> ttm_bo_move_accel_cleanup, just before function exits, there is:
> ttm_flag_masked(&save_flags, new_mem->placement,
> TTM_PL_MASK_MEMTYPE);
>
> Is it needed be
In function ttm_bo_move_ttm, ttm_bo_move_memcpy, and
ttm_bo_move_accel_cleanup, just before function exits, there is:
ttm_flag_masked(&save_flags, new_mem->placement,
TTM_PL_MASK_MEMTYPE);
Is it needed because save_flags is just a local variable?
Thanks
Austin
--
