Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Michel Dänzer
On Mon, 2009-02-16 at 10:42 -0800, Jesse Barnes wrote: On Sunday, February 15, 2009 11:33 pm Michel Dänzer wrote: On Fri, 2009-02-13 at 10:27 -0800, Jesse Barnes wrote: Recall our last discussion where I outlined the cases we'd have to deal with in the modeset ioctl if we didn't use

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Jesse Barnes
On Tuesday, February 17, 2009 9:04 am Michel Dänzer wrote: On Mon, 2009-02-16 at 10:42 -0800, Jesse Barnes wrote: On Sunday, February 15, 2009 11:33 pm Michel Dänzer wrote: On Fri, 2009-02-13 at 10:27 -0800, Jesse Barnes wrote: Recall our last discussion where I outlined the cases we'd

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Michel Dänzer
On Tue, 2009-02-17 at 09:27 -0800, Jesse Barnes wrote: On Tuesday, February 17, 2009 9:04 am Michel Dänzer wrote: On Mon, 2009-02-16 at 10:42 -0800, Jesse Barnes wrote: On Sunday, February 15, 2009 11:33 pm Michel Dänzer wrote: On Fri, 2009-02-13 at 10:27 -0800, Jesse Barnes wrote:

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Jesse Barnes
On Tuesday, February 17, 2009 9:27 am Jesse Barnes wrote: On Tuesday, February 17, 2009 9:04 am Michel Dänzer wrote: On Mon, 2009-02-16 at 10:42 -0800, Jesse Barnes wrote: On Sunday, February 15, 2009 11:33 pm Michel Dänzer wrote: On Fri, 2009-02-13 at 10:27 -0800, Jesse Barnes wrote:

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Michel Dänzer
On Tue, 2009-02-17 at 09:47 -0800, Jesse Barnes wrote: Btw I don't have a problem with keeping this functionality, but we need to fix it (the problem above is the only one I'm aware of atm). That means: 1) removing the last count stuff and providing a disable timer knob 2) changing

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Jesse Barnes
On Tuesday, February 17, 2009 9:43 am Michel Dänzer wrote: On Tue, 2009-02-17 at 09:27 -0800, Jesse Barnes wrote: On Tuesday, February 17, 2009 9:04 am Michel Dänzer wrote: On Mon, 2009-02-16 at 10:42 -0800, Jesse Barnes wrote: On Sunday, February 15, 2009 11:33 pm Michel Dänzer wrote:

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Michel Dänzer
On Tue, 2009-02-17 at 10:34 -0800, Jesse Barnes wrote: On Tuesday, February 17, 2009 9:43 am Michel Dänzer wrote: On Tue, 2009-02-17 at 09:27 -0800, Jesse Barnes wrote: On Tuesday, February 17, 2009 9:04 am Michel Dänzer wrote: On Mon, 2009-02-16 at 10:42 -0800, Jesse Barnes wrote:

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Jesse Barnes
On Tuesday, February 17, 2009 10:49 am Michel Dänzer wrote: On Tue, 2009-02-17 at 10:34 -0800, Jesse Barnes wrote: On Tuesday, February 17, 2009 9:43 am Michel Dänzer wrote: On Tue, 2009-02-17 at 09:27 -0800, Jesse Barnes wrote: On Tuesday, February 17, 2009 9:04 am Michel Dänzer wrote:

[Bug 12705] X200: Brightness broken since 2.6.29-rc4-58-g4c098bc

2009-02-17 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=12705 --- Comment #3 from r...@sisk.pl 2009-02-17 12:14 --- Do you mean the first bad one? -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee

[PATCH] drm: Copy cliprects from user outside struct_mutex.

2009-02-17 Thread krh
From: Kristian Høgsberg k...@redhat.com This fixes a potential dead lock similar to the one where we copy the new buffer offsets back to userspace, fixed in 0e2f967303023f7f82a0963b7f7f3980d4c08f20. In this case the lock order violation occurs when i915_emit_box() copies the cliprects from

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michel Dänzer wrote: On Mon, 2009-02-16 at 10:42 -0800, Jesse Barnes wrote: On Sunday, February 15, 2009 11:33 pm Michel Dänzer wrote: On Fri, 2009-02-13 at 10:27 -0800, Jesse Barnes wrote: Can you think of a case where those frames would matter?

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jesse Barnes wrote: As to your example, I wasn't looking for theoretical issues, but real apps that would depend on this behavior. I haven't played with many video apps, so I'm not sure if what you outlined is common behavior, or if apps

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Jesse Barnes
On Tuesday, February 17, 2009 4:10 pm Ian Romanick wrote: Stepping back, there are two separate axes (Are vblanks happening? Is anyone listening?) that give four separate cases. I think we can derive sensible behavior in all cases. Here is my suggestion: Are vblanks | Is anyone |

[PATCH] drm: Fix lock order reversal between mmap_sem and struct_mutex.

2009-02-17 Thread Eric Anholt
The basic problem was mmap_sem (do_mmap()) - struct_mutex (drm_gem_mmap(), i915_gem_fault()) struct_mutex (i915_gem_execbuffer()) - mmap_sem (copy_from/to_user()) We have plenty of places where we want to hold device state the same (struct_mutex) while we move a non-trivial amount of data

[PATCH 2/3] Move i915 proc files to seq_file

2009-02-17 Thread Ben Gamari
This patch ports the i915 proc files to use the seq_file interface. Also, we move these files into debugfs. Signed-off-by: Ben Gamari bgam...@gmail.com --- drivers/gpu/drm/i915/Makefile |2 +- drivers/gpu/drm/i915/i915_drv.c |6 +- drivers/gpu/drm/i915/i915_drv.h

[PATCH 1/3] Convert proc files to seq_file and introduce debugfs

2009-02-17 Thread Ben Gamari
The old mechanism to formatting proc files is extremely ugly. The seq_file API was designed specifically for cases like this and greatly simplifies the process. Also, most of the files in /proc really don't belong there. This patch introduces the infrastructure for putting these into debugfs and

[PATCH final] DRM proc file handling rework

2009-02-17 Thread Ben Gamari
Hey all, Hopefully this will be the last time I pollute the lists with this patchset. From the look of the diffstat, this cleanup went pretty well. We managed to introduce support for debugfs while both eliminating large portions of code and standardizing the interface for drm proc/debugfs file

[PATCH 3/3] Consolidate gem object list dumping

2009-02-17 Thread Ben Gamari
Here we eliminate a few functions in favor of using a single function to dump from all of the object lists. Signed-Off-By: Ben Gamari bgam...@gmail.com --- drivers/gpu/drm/i915/i915_gem_debugfs.c | 84 ++- 1 files changed, 26 insertions(+), 58 deletions(-) diff

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jesse Barnes wrote: On Tuesday, February 17, 2009 4:10 pm Ian Romanick wrote: Stepping back, there are two separate axes (Are vblanks happening? Is anyone listening?) that give four separate cases. I think we can derive sensible behavior in all

Re: [PATCH 1/2] Remove Intel drivers from linux-core

2009-02-17 Thread Robert C. Noland III
On Mon, 2009-02-16 at 18:39 +, Owain Ainsworth wrote: On Sat, Feb 14, 2009 at 11:24:18PM +0200, Pekka Paalanen wrote: From 29d3f6e9c1258736c3199834b293b8128faef2ad Mon Sep 17 00:00:00 2001 From: Pekka Paalanen p...@iki.fi Date: Sat, 14 Feb 2009 21:49:08 +0200 Subject: [PATCH] Remove

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Jesse Barnes
On Tuesday, February 17, 2009 5:26 pm Ian Romanick wrote: Jesse Barnes wrote: On Tuesday, February 17, 2009 4:10 pm Ian Romanick wrote: Stepping back, there are two separate axes (Are vblanks happening? Is anyone listening?) that give four separate cases. I think we can derive sensible

[Bug 20172] New: [Wine Application Issue]: The game 'stardrone' performs very slow when '3D Acceleration' is enabled

2009-02-17 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20172 Summary: [Wine Application Issue]: The game 'stardrone' performs very slow when '3D Acceleration' is enabled Product: Mesa Version: 7.2 Platform: x86 (IA32) OS/Version: All

[Bug 20172] [Wine Application Issue]: The game 'stardrone' performs very slow when '3D Acceleration' is enabled

2009-02-17 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20172 Chandra chandra.krishnappa@gmail.com changed: What|Removed |Added CC|

Re: [PATCH 1/2] Remove Intel drivers from linux-core

2009-02-17 Thread vehemens
On Tuesday 17 February 2009 05:43:32 pm Robert C. Noland III wrote: On Mon, 2009-02-16 at 18:39 +, Owain Ainsworth wrote: On Sat, Feb 14, 2009 at 11:24:18PM +0200, Pekka Paalanen wrote: From 29d3f6e9c1258736c3199834b293b8128faef2ad Mon Sep 17 00:00:00 2001 From: Pekka Paalanen

[Bug 20176] New: [Wine Application Issue]: X hangs after coming out of game

2009-02-17 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20176 Summary: [Wine Application Issue]: X hangs after coming out of game Product: Mesa Version: 7.2 Platform: x86-64 (AMD64) OS/Version: other Status: NEW

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Michel Dänzer
On Tue, 2009-02-17 at 17:34 -0800, Jesse Barnes wrote: On Tuesday, February 17, 2009 5:26 pm Ian Romanick wrote: Jesse Barnes wrote: On Tuesday, February 17, 2009 4:10 pm Ian Romanick wrote: Stepping back, there are two separate axes (Are vblanks happening? Is anyone listening?) that