Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig

2013-07-25 Thread Xiong Zhou
2013/7/25 Paul Bolle : > On Thu, 2013-07-25 at 15:06 +0800, Xiong Zhou wrote: >> Add BLOCK depends in Kconfig for LUSTRE to fix this: >> drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2: >> error: implicit declaration of function ‘unregister_blkdev’ >> >> Signed-off-by: Xi

[PATCH -next] staging: gdm724x: use GFP_ATOMIC under spin lock

2013-07-25 Thread Wei Yongjun
From: Wei Yongjun A spin lock is taken here so we should use GFP_ATOMIC. Signed-off-by: Wei Yongjun --- drivers/staging/gdm724x/gdm_mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c index f570bc0..7b

RE: [PATCH] staging: comedi: allow ISA and PC/104 drivers on non-ISA systems

2013-07-25 Thread H Hartley Sweeten
On Thursday, July 25, 2013 3:43 AM, Ian Abbott wrote: > On 2013-07-24 19:24, H Hartley Sweeten wrote: >> Embedded systems with a PC/104 bus might have a configuration that >> does not have ISA enabled. This creates a problem in Comedi where >> the PC/104 drivers cannot be enabled. >> >> Introduce a

[PATCH] staging: comedi: usbduxsigma: set *_cmd_running flags before submitting urbs

2013-07-25 Thread H Hartley Sweeten
As pointed out by Ian Abbott, the *_cmd_running flags should be set before submitting the urbs. There is a possible race condition where an urb could complete and the flag is checked in the completion routine before it's set. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

HELLO

2013-07-25 Thread Henri
Good day to you: Please don’t be offended at this mail, and thank you in advance for reading. My name is Henri Ballo; I am 18 years from Côte-d'Ivoire (Ivory Coast). The purpose of this letter is to ask for your kind help. There was a big political crisis in our country in 2011 that caused a

[PATCH 30/30] staging: comedi: usbdux: consolidate usbduxsub_unlink_{in, out}urbs()

2013-07-25 Thread H Hartley Sweeten
These functions are identical other than the which and how many urbs are unlinked. Consolidate the functions into one usbdux_unlink_urbs() function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 28 +++-

[PATCH 29/30] staging: comedi: usbdux: move and rename the bulk transfer commands

2013-07-25 Thread H Hartley Sweeten
For aesthetic reasons, move the defines used for the bulk transfer commands out of the middle of the code and rename them so they are a bit more readable. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 45 ---

[PATCH 28/30] staging: comedi: usbdux: remove unused define

2013-07-25 Thread H Hartley Sweeten
This define is not used, and it's actually incorrect. The usbdux device only has 4 analog output channels. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/driver

[PATCH 24/30] staging: comedi: usbdux: simplify initializing the ao urb transfer_buffer

2013-07-25 Thread H Hartley Sweeten
Remove the ugly casting of datap to the ao urb->transfer_buffer. The format of the data in the buffer is simply. [0] = # of channels to update (s->async->cmd.chanlist.len) [1] = lsb of value for 1st channel to update [2] = msb of value for 1st channel to update [3] = 1st channel to update

[PATCH 26/30] staging: comedi: usbdux: remove unnecessary check in usbdux_ao_cmd()

2013-07-25 Thread H Hartley Sweeten
This check is not necessary. The cmd->chanlist_len will always be less than or equal to the subdevice len_chanlist that was setup during the attach of the device. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 3 --- 1 file

[PATCH 27/30] staging: comedi: usbdux: 'dac_commands' does not need to be kzalloc()'d

2013-07-25 Thread H Hartley Sweeten
The 'dac_commands' buffer is used to pass the ao channel list from usbdux_ao_cmd() to the urb callback, usbduxsub_ao_isoc_irq(). This buffer does not need to be allocated. Change it into a simple array of the correct size. Rename the variable to 'ao_chanlist' to clarify what it actually is. Signe

[PATCH 23/30] staging: comedi: usbdux: cleanup the private data 'outBuffer'

2013-07-25 Thread H Hartley Sweeten
This buffer is used to cache the values that are written to the analog output channels. Currently it only caches the single writes to the channels using the (*insn_write) callback. The async command writes are not cached. The buffer is also being kzalloc'ed during the attach of the driver to a size

[PATCH 21/30] staging: comedi: usbdux: clarify bipolar ai data in usbduxsub_ai_isoc_irq()

2013-07-25 Thread H Hartley Sweeten
Use the comedi_range_is_bipolar() helper instead of checking the 'range' index against a magic number. Also, use the s->maxdata to calculate the value needed to munge the value for bipolar data instead of the magic number. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH 25/30] staging: comedi: usbdux: remove unnecessary check in usbdux_ai_cmd()

2013-07-25 Thread H Hartley Sweeten
This check is not necessary. The cmd->chanlist_len will always be less than or equal to the subdevice len_chanlist that was setup during the attach of the device. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 6 -- 1 fi

[PATCH 19/30] staging: comedi: usbdux: remove some unused defines

2013-07-25 Thread H Hartley Sweeten
These defines are not used by the driver. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/co

[PATCH 20/30] staging: comedi: usbdux: move usbdux_firmware_upload()

2013-07-25 Thread H Hartley Sweeten
For aesthetics, move this function closer to the (*auto_attach). Also, rename some of the defined constants that are used by the firmware upload. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 170 +++---

[PATCH 22/30] staging: comedi: usbdux: rename private data variables

2013-07-25 Thread H Hartley Sweeten
The usbdux and usbduxsigma drivers are _very_ similar. For aesthetic reasons, rename the private data variables in this driver to match the names in the usbduxsigma driver so we can start sharing the common code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- driver

[PATCH 18/30] staging: comedi: usbdux: remove the usb endpoint defines

2013-07-25 Thread H Hartley Sweeten
The endpoint defines are each only used in one place and don't help clarify the code. Remove the defines and just open code the values. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 25 + 1 file chan

[PATCH 17/30] staging: comedi: usbdux: use the stop helpers in the detach

2013-07-25 Thread H Hartley Sweeten
Use the stop helpers instead of duplicating the code in the detach. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/u

[PATCH 15/30] staging: comedi: usbdux: fix usbdux_pwm_start()

2013-07-25 Thread H Hartley Sweeten
Add the missing down/up of the semaphore to prevent other commands from being issued to the usb device while the pwn is being stopped. Rename the local variable used for the private data pointer to the comedi "norm". Use memset() to initialize the urb transfer buffer. Signed-off-by: H Hartley Sw

[PATCH 16/30] staging: comedi: usbdux: tidy up unlink and stop helpers

2013-07-25 Thread H Hartley Sweeten
For aesthetic reasons, pass the comedi_device pointer to the unlink helpers instead of the private data pointer. All the unlink helpers simply call usb_kill_urb() to cancel any pending transfer requests. The usb passed to usb_kill_urb() can be NULL so the extra sanity check is not required. The u

[PATCH 13/30] staging: comedi: usbdux: tidy up usbdux_pwm_stop()

2013-07-25 Thread H Hartley Sweeten
For aesthetic reasons, pass the comedi_device pointer to this function instead of the private data pointer. Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the pri

[PATCH 10/30] staging: comedi: usbdux: tidy up usbdux_dio_insn_bits()

2013-07-25 Thread H Hartley Sweeten
Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the private data was allocated during the attach. Tidy up the exit path using goto to ensure that the semaphore is

[PATCH 14/30] staging: comedi: usbdux: fix usbdux_pwm_cancel()

2013-07-25 Thread H Hartley Sweeten
Add the missing down/up of the semaphore to prevent other commands from being issued to the usb device while the pwn is being stopped. Rename the local variable used for the private data pointer to the comedi "norm". Make sure to check that usbdux_pwm_stop() was successful before sending command

[PATCH 12/30] staging: comedi: usbdux: fix usbdux_counter_write()

2013-07-25 Thread H Hartley Sweeten
Comedi (*insn_write) operations are supposed to write insn->n values. Fix this function to work like the core expects. Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be calle

[PATCH 11/30] staging: comedi: usbdux: fix usbdux_counter_read()

2013-07-25 Thread H Hartley Sweeten
Comedi (*insn_read) operations are supposed to read and return insn->n values. Fix this function to work like the core expects. Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only

[PATCH 09/30] staging: comedi: usbdux: tidy up usbdux_dio_insn_config()

2013-07-25 Thread H Hartley Sweeten
Tidy up this function a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/stag

[PATCH 07/30] staging: comedi: usbdux: tidy up usbdux_ao_inttrig()

2013-07-25 Thread H Hartley Sweeten
Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the private data was allocated during the attach. Tidy up the exit path using goto to ensure that the semaphore is

[PATCH 08/30] staging: comedi: usbdux: tidy up usbdux_ao_cmd()

2013-07-25 Thread H Hartley Sweeten
Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the private data was allocated during the attach. Make sure an ao command is not already running and return -EBUSY

[PATCH 05/30] staging: comedi: usbdux: tidy up usbdux_ao_insn_read()

2013-07-25 Thread H Hartley Sweeten
Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the private data was allocated during the attach. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah

[PATCH 06/30] staging: comedi: usbdux: tidy up usbdux_ao_insn_write()

2013-07-25 Thread H Hartley Sweeten
Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the private data was allocated during the attach. Tidy up the exit path using goto to ensure that the semaphore is

[PATCH 04/30] staging: comedi: usbdux: clarify bipolar ai data

2013-07-25 Thread H Hartley Sweeten
Use the comedi_range_is_bipolar() helper instead of checking the 'range' index against a magic number. Also, use the s->maxdata to calculate the value needed to munge the value for bipolar data instead of the magic number. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH 03/30] staging: comedi: usbdux: tidy up usbdux_ai_insn_read()

2013-07-25 Thread H Hartley Sweeten
Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the private data was allocated during the attach. Tidy up the exit path using goto to ensure that the semaphore is

[PATCH 02/30] staging: comedi: usbdux: tidy up usbdux_ai_cmd()

2013-07-25 Thread H Hartley Sweeten
Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the private data was allocated during the attach. Tidy up the exit path using goto to ensure that the semaphore is

[PATCH 01/30] staging: comedi: usbdux: tidy up usbdux_ai_inttrig()

2013-07-25 Thread H Hartley Sweeten
Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the private data was allocated during the attach. Tidy up the exit path using goto to ensure that the semaphore is

[PATCH 00/30] staging: comedi: usbdux: cleanup driver take 2

2013-07-25 Thread H Hartley Sweeten
Patches 1-32 of [PATCH 00/53] staging: comedi: usbdux: cleanup driver have already be applied to Greg Kroah-Hartman's staging tree. This continues the cleanup of the usbdux comedi driver from that point. Patches 1, 2, 7, 9, and 15 have been updated to address an issue pointed out by Ian Abbott con

Re: [PATCH] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-07-25 Thread Matthijs Kooijman
Hi Paul, > > Furthermore, I wonder about how this scheduler works exactly. What I see > > is: > > - the number usecs needed for a single transfer in a periodic qh is > >calculated > > - When the qh is scheduled, the first of the 8 microframes with enough > >usecs available is picked for

Re: [PATCH v6] staging: New driver: Xillybus generic interface for FPGA

2013-07-25 Thread Greg KH
On Mon, Jun 24, 2013 at 06:55:47PM +0300, Eli Billauer wrote: > This is the driver for Xillybus, which is a general-purpose interface for > data communication with FPGAs (programmable logic). Please refer to the > README included in this patch for a detailed explanation. > > It was previously subm

[PATCH -next] staging: comedi: Add missing #include

2013-07-25 Thread Geert Uytterhoeven
sparc64 allmodconfig: drivers/staging/comedi/drivers/addi_apci_2032.c: In function 'apci2032_auto_attach': drivers/staging/comedi/drivers/addi_apci_2032.c:328:3: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration] drivers/staging/comedi/drivers/addi_apci_203

[PATCH] Staging: olpc_dcon: change to msleep to usleep_range

2013-07-25 Thread Jens Frederich
The resolution of msleep is related to HZ, so with HZ set to 100 any msleep of less then 10ms will become ~10ms. This is not what we want. Use usleep_range to get more control of what is happening here. Signed-off-by: Jens Frederich --- drivers/staging/olpc_dcon/olpc_dcon.c |4 ++-- 1 file c

Re: [PATCH 00/53] staging: comedi: usbdux: cleanup driver

2013-07-25 Thread Greg Kroah-Hartman
On Thu, Jul 25, 2013 at 12:14:44PM -0500, H Hartley Sweeten wrote: > On Thursday, July 25, 2013 10:08 AM, H Hartley Sweeten wrote: > > On Thursday, July 25, 2013 8:25 AM, Ian Abbott wrote: > >> On 2013-07-24 22:05, H Hartley Sweeten wrote: > >>> Move all the usb_driver (*probe) and (*disconnect) op

Re: [PATCH] staging: zcache: fix "zcache=" kernel parameter

2013-07-25 Thread Greg KH
On Thu, Jul 25, 2013 at 12:13:54PM +0200, Bartlomiej Zolnierkiewicz wrote: > From: Piotr Sarna This whole email is base64, making it impossible for me to add the needed Cc: stable@ tag to it... Try it again? It shouldn't be this hard... greg k-h __

RE: [PATCH 00/53] staging: comedi: usbdux: cleanup driver

2013-07-25 Thread H Hartley Sweeten
On Thursday, July 25, 2013 10:08 AM, H Hartley Sweeten wrote: > On Thursday, July 25, 2013 8:25 AM, Ian Abbott wrote: >> On 2013-07-24 22:05, H Hartley Sweeten wrote: >>> Move all the usb_driver (*probe) and (*disconnect) operations into the >>> comedi_driver (*auto_attach) and (*detach). This allo

RE: [PATCH 00/53] staging: comedi: usbdux: cleanup driver

2013-07-25 Thread H Hartley Sweeten
On Thursday, July 25, 2013 8:25 AM, Ian Abbott wrote: > On 2013-07-24 22:05, H Hartley Sweeten wrote: >> Move all the usb_driver (*probe) and (*disconnect) operations into the >> comedi_driver (*auto_attach) and (*detach). This allows the per device >> private data to be kzalloc()'d and removes the

RE: [PATCH 14/14] staging: comedi: ii_pci20kc: reorder subdevices

2013-07-25 Thread H Hartley Sweeten
On Thursday, July 25, 2013 7:18 AM, Ian Abbott wrote: > On 2013-07-24 20:14, H Hartley Sweeten wrote: >> Make the built-on dio subdevice 0 and the three add-on modules >> subdevices 1-3. This allows the driver to consistently use the >> ii20k_module_iobase() helper to get the base address needed to

Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-25 Thread Greg KH
On Thu, Jul 25, 2013 at 02:56:51PM +0900, Won Kang wrote: > Anyway, you are right that endianess matters only when using this SDK. > If you suggest to remove the ioctl because SDK is optional, I will > agree. Thanks, I've now removed it from the driver. greg k-h __

RE: [PATCH 07/13] staging: comedi: pcmuio: make sure input channels stay inputs

2013-07-25 Thread H Hartley Sweeten
On Thursday, July 25, 2013 6:39 AM, Ian Abbott wrote: > On 2013-07-24 19:48, H Hartley Sweeten wrote: >> When updating the output channels make sure the channels configured as >> inputs stay inputs. >> >> Signed-off-by: H Hartley Sweeten >> Cc: Ian Abbott >> Cc: Greg Kroah-Hartman >> --- >> dr

RE: [PATCH 06/13] staging: comedi: pcmuio: pcmuio_handle_asic_interrupt() does not need the subdevice

2013-07-25 Thread H Hartley Sweeten
On Thursday, July 25, 2013 5:50 AM, Ian Abbott wrote: > On 2013-07-24 19:47, H Hartley Sweeten wrote: >> The comedi_subdevice pointer is not used in this function. Its simply >> passed on to pcmuio_handle_intr_subdev(). That function then needs to >> calculate the 'asic' associated with the subdevi

RE: [PATCH 01/13] staging: comedi: pcmuio: fix interrupt requests

2013-07-25 Thread H Hartley Sweeten
On Thursday, July 25, 2013 5:34 AM, Ian Abbott wrote: > On 2013-07-24 19:45, H Hartley Sweeten wrote: >> Legacy (ISA) interrupts are not sharable so this driver should not >> be passing the IRQF_SHARED flag when requesting the interrupts. >> >> This driver supports two board types: >>PCM-UIO48

Re: [PATCH 1/1] Drivers: base: memory: Export symbols for onlining memory blocks

2013-07-25 Thread Dave Hansen
On 07/25/2013 08:15 AM, Kay Sievers wrote: > Complexity, well, it's just a bit of code which belongs in the kernel. > The mentioned unconditional hotplug loop through userspace is > absolutely pointless. Such defaults never belong in userspace tools if > they do not involve data that is only availa

RE: [PATCH 1/1] Drivers: base: memory: Export symbols for onlining memory blocks

2013-07-25 Thread KY Srinivasan
> -Original Message- > From: Dave Hansen [mailto:d...@sr71.net] > Sent: Thursday, July 25, 2013 11:04 AM > To: KY Srinivasan > Cc: Michal Hocko; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > a...@firstfloor.

Re: [PATCH 1/1] Drivers: base: memory: Export symbols for onlining memory blocks

2013-07-25 Thread Kay Sievers
On Thu, Jul 25, 2013 at 5:03 PM, Dave Hansen wrote: > On 07/25/2013 04:14 AM, KY Srinivasan wrote: >> As promised, I have sent out the patches for (a) an implementation of an >> in-kernel API >> for onlining and a consumer for this API. While I don't know the exact >> reason why the >> user mod

Re: [PATCH 00/53] staging: comedi: usbdux: cleanup driver

2013-07-25 Thread Ian Abbott
On 2013-07-24 22:05, H Hartley Sweeten wrote: Move all the usb_driver (*probe) and (*disconnect) operations into the comedi_driver (*auto_attach) and (*detach). This allows the per device private data to be kzalloc()'d and removes the 16 device limitation. Remove all the unnecessary information

Re: [PATCH 47/53] staging: comedi: usbdux: tidy up usbdux_pwm_start()

2013-07-25 Thread Ian Abbott
On 2013-07-24 22:24, H Hartley Sweeten wrote: Rename the local variable used for the private data pointer to the comedi "norm". Use memset() to initialize the urb transfer_buffer. Set the pwm_cmd_running after submitting the pwm urbs so we don't have to clear it if the submit fails. Same prob

Re: [PATCH 40/53] staging: comedi: usbdux: tidy up usbdux_ao_cmd()

2013-07-25 Thread Ian Abbott
On 2013-07-24 22:22, H Hartley Sweeten wrote: Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the private data was allocated during the attach. Make sure an ao

Re: [PATCH 39/53] staging: comedi: usbdux: tidy up usbdux_ao_inttrig()

2013-07-25 Thread Ian Abbott
On 2013-07-24 22:21, H Hartley Sweeten wrote: Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the private data was allocated during the attach. Tidy up the exit

Re: [PATCH 33/53] staging: comedi: usbdux: tidy up usbdux_ai_inttrig()

2013-07-25 Thread Ian Abbott
On 2013-07-25 16:01, Ian Abbott wrote: On 2013-07-24 22:18, H Hartley Sweeten wrote: Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the private data was alloca

Re: [PATCH 33/53] staging: comedi: usbdux: tidy up usbdux_ai_inttrig()

2013-07-25 Thread Ian Abbott
On 2013-07-24 22:18, H Hartley Sweeten wrote: Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the private data was allocated during the attach. Tidy up the exit

Re: [PATCH 1/1] Drivers: base: memory: Export symbols for onlining memory blocks

2013-07-25 Thread Dave Hansen
On 07/25/2013 04:14 AM, KY Srinivasan wrote: > As promised, I have sent out the patches for (a) an implementation of an > in-kernel API > for onlining and a consumer for this API. While I don't know the exact > reason why the > user mode code is delayed (under some low memory conditions), what i

Re: [PATCH 34/53] staging: comedi: usbdux: tidy up usbdux_ai_cmd()

2013-07-25 Thread Ian Abbott
On 2013-07-24 22:19, H Hartley Sweeten wrote: Rename the local variable used for the private data pointer to the comedi "norm". Remove the unnecessary sanity check of the private data pointer. This function can only be called is the private data was allocated during the attach. Tidy up the exit

Re: [PATCH 00/14] staging: comedi: ii_pci20kc: cleanup driver

2013-07-25 Thread Ian Abbott
On 2013-07-24 20:08, H Hartley Sweeten wrote: Tidy up this legacy comedi driver. H Hartley Sweeten (14): staging: comedi: ii_pci20kc: use comedi_alloc_spriv() staging: comedi: ii_pci20kc: remove forward declarations 1 staging: comedi: ii_pci20kc: remove forward declarations 2 staging

Re: [PATCH 14/14] staging: comedi: ii_pci20kc: reorder subdevices

2013-07-25 Thread Ian Abbott
On 2013-07-24 20:14, H Hartley Sweeten wrote: Make the built-on dio subdevice 0 and the three add-on modules subdevices 1-3. This allows the driver to consistently use the ii20k_module_iobase() helper to get the base address needed to access a the registers used by a given subdevice. Signed-off-

Re: [PATCH staging] zcache: fix "zcache=" kernel parameter

2013-07-25 Thread Bartlomiej Zolnierkiewicz
On Wednesday, July 24, 2013 11:02:46 AM Greg KH wrote: > On Wed, Jul 24, 2013 at 07:04:14PM +0200, Bartlomiej Zolnierkiewicz wrote: > > From: Piotr Sarna > > Subject: [PATCH] zcache: fix "zcache=" kernel parameter > > What's with the duplicated Subject: line here? Why? That means the > From: li

Re: [PATCH 00/13] staging: comedi: pcmuio: additional cleanup

2013-07-25 Thread Ian Abbott
On 2013-07-24 19:44, H Hartley Sweeten wrote: Tidy up the interrupt support and the private data usage. Do a bit of additional cleanup to clarify the driver a bit. H Hartley Sweeten (13): staging: comedi: pcmuio: fix interrupt requests staging: comedi: pcmuio: spinlock pcmuio_{write,read}(

Re: [PATCH 07/13] staging: comedi: pcmuio: make sure input channels stay inputs

2013-07-25 Thread Ian Abbott
On 2013-07-24 19:48, H Hartley Sweeten wrote: When updating the output channels make sure the channels configured as inputs stay inputs. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmuio.c | 8 +++- 1 file changed, 7 insert

Re: [PATCH 06/13] staging: comedi: pcmuio: pcmuio_handle_asic_interrupt() does not need the subdevice

2013-07-25 Thread Ian Abbott
On 2013-07-24 19:47, H Hartley Sweeten wrote: The comedi_subdevice pointer is not used in this function. Its simply passed on to pcmuio_handle_intr_subdev(). That function then needs to calculate the 'asic' associated with the subdevice. Just pass on the 'asic' instead and let pcmuio_handle_intr_

Re: [PATCH 01/13] staging: comedi: pcmuio: fix interrupt requests

2013-07-25 Thread Ian Abbott
On 2013-07-24 19:45, H Hartley Sweeten wrote: Legacy (ISA) interrupts are not sharable so this driver should not be passing the IRQF_SHARED flag when requesting the interrupts. This driver supports two board types: PCM-UIO48 with one asic (one interrupt source) PCM-UIO96 with two asics (tw

Re: [PATCH 0/4] staging: comedi: remove addi_apci_1710 driver

2013-07-25 Thread Ian Abbott
On 2013-07-24 19:11, H Hartley Sweeten wrote: This driver is a great example of "bad kernel code"... It greatly abuses the comedi API and will not work without patching the comedi core. It's CodingStyle is terrible. It uses floating point math. And, it's almost impossible to read. A Kconfig opt

Re: [PATCH] staging: comedi: fix subdev_flags for all digital subdevices

2013-07-25 Thread Ian Abbott
On 2013-07-24 21:14, H Hartley Sweeten wrote: The SDF_GROUND and SDF_COMMON flags only apply to analog subdevices. It makes no sense to set these flags for digital subdevices. Possibly. It depends on the device. I suppose the reported flags only matter if the grounding is configurable. Di

RE: [PATCH 1/1] Drivers: base: memory: Export symbols for onlining memory blocks

2013-07-25 Thread KY Srinivasan
> -Original Message- > From: Michal Hocko [mailto:mho...@suse.cz] > Sent: Thursday, July 25, 2013 3:57 AM > To: Dave Hansen > Cc: KY Srinivasan; Dave Hansen; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; a.

Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig

2013-07-25 Thread Paul Bolle
On Thu, 2013-07-25 at 15:06 +0800, Xiong Zhou wrote: > Add BLOCK depends in Kconfig for LUSTRE to fix this: > drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2: > error: implicit declaration of function ‘unregister_blkdev’ > > Signed-off-by: Xiong Zhou > --- > drivers/

Re: [PATCH] staging: ozwpan: Fix coding style.

2013-07-25 Thread Rupesh Gujare
On 25/07/13 11:39, Dan Carpenter wrote: On Thu, Jul 25, 2013 at 10:30:30AM +0100, Rupesh Gujare wrote: Greg, Did you missed this patch ? Or did I made another mistake. :( ? Chillax. It has only been one day. Ask again after two or three weeks. All right Dan, Probably I was getting too

RE: [PATCH V2 4/4] x86: correctly detect hypervisor

2013-07-25 Thread KY Srinivasan
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, July 25, 2013 4:55 AM > To: t...@linutronix.de; mi...@redhat.com; h...@zytor.com; x...@kernel.org; > linux-ker...@vger.kernel.org; pbonz...@redhat.com > Cc: k...@vger.kernel.org; Jason Wang; KY Srinivas

Re: [PATCH] staging: comedi: allow ISA and PC/104 drivers on non-ISA systems

2013-07-25 Thread Ian Abbott
On 2013-07-24 19:24, H Hartley Sweeten wrote: Embedded systems with a PC/104 bus might have a configuration that does not have ISA enabled. This creates a problem in Comedi where the PC/104 drivers cannot be enabled. Introduce a Kconfig option to allow enabling the Comedi ISA and PC/104 drivers

Re: [PATCH] staging: ozwpan: Fix coding style.

2013-07-25 Thread Dan Carpenter
On Thu, Jul 25, 2013 at 10:30:30AM +0100, Rupesh Gujare wrote: > Greg, > > Did you missed this patch ? Or did I made another mistake. :( ? > Chillax. It has only been one day. Ask again after two or three weeks. regards, dan carpenter ___ devel mai

Re: [PATCH] staging: comedi: adv_pci1724: remove ao_range_list_1724

2013-07-25 Thread Ian Abbott
On 2013-07-24 18:03, H Hartley Sweeten wrote: All the AO channels have the same ranges. Remove the subdevice s->range_table_list and just use the s->range_table to setup the ranges. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv

[PATCH] staging: zcache: fix "zcache=" kernel parameter

2013-07-25 Thread Bartlomiej Zolnierkiewicz
From: Piotr Sarna Commit 835f2f5 ("staging: zcache: enable zcache to be built/loaded as a module") introduced an incorrect handling of "zcache=" parameter. Inside zcache_comp_init() function, zcache_comp_name variable is checked for being empty. If not empty, the above variable is tested for bei

Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-25 Thread Won Kang
>> GDM7240 is in LE where as GDM7243 (currently under development) is in BE. > > But why does this information need to be sent to userspace? > GDM724x chips have different endianess because of their internal architecture.The device sends out and accepts LTE protocol information in its own endianes

Re: [PATCH v2] staging: comedi: range: tidy up comedi_check_chanlist()

2013-07-25 Thread Ian Abbott
On 2013-07-24 18:00, H Hartley Sweeten wrote: The only difference in the if() and else if() check of the chanlist is the source of the range table length. Consolidate the checks to make the function a bit more concise. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

Re: [PATCH] staging: ozwpan: Fix coding style.

2013-07-25 Thread Rupesh Gujare
On 24/07/13 15:06, Rupesh Gujare wrote: This patch fixes coding style issues reported by Dan here:- http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-June/027767.html Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozcdev.c | 15 --- 1 file changed,

Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-25 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Jul 25, 2013 at 01:15:07PM +0900, Won Kang wrote: > GDM7240 is in LE where as GDM7243 (currently under development) is in BE. But why does this information need to be sent to userspace? > Use

[PATCH V2 4/4] x86: correctly detect hypervisor

2013-07-25 Thread Jason Wang
We try to handle the hypervisor compatibility mode by detecting hypervisor through a specific order. This is not robust, since hypervisors may implement each others features. This patch tries to handle this situation by always choosing the last one in the CPUID leaves. This is done by letting .det

Re: [PATCH staging] zcache: fix "zcache=" kernel parameter

2013-07-25 Thread Michal Hocko
On Wed 24-07-13 19:04:14, Bartlomiej Zolnierkiewicz wrote: > From: Piotr Sarna > Subject: [PATCH] zcache: fix "zcache=" kernel parameter > > Commit 835f2f5 ("staging: zcache: enable zcache to be built/loaded as > a module") introduced an incorrect handling of "zcache=" parameter. > > Inside zcac

Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-25 Thread Won Kang
GDM7240 is in LE where as GDM7243 (currently under development) is in BE. User space applications needs to discover the endianess to properly encode/decode LTE control protocols. We have existing customers already deploying units in large volume, and want to avoid forcing them to change SDK APIs a

Re: [PATCH v4] staging: usbip: replace pr_warning() with dev_warn().

2013-07-25 Thread navin patidar
On Wed, Jul 24, 2013, Greg KH said: > On Thu, Jun 27, 2013 at 03:34:52PM +0530, navin patidar wrote: >> dev_warn() is preferred over pr_warning(). >> >> container_of() is used to get usb_driver pointer from usbip_device container >> (stub_device or vhci_device), to get device structure required f

[PATCH 1/7] staging: gdm724x: Remove version.h header inclusion in gdm_lte.c

2013-07-25 Thread Sachin Kamat
version.h header inclusion is not necessary as detected by versioncheck. Signed-off-by: Sachin Kamat --- drivers/staging/gdm724x/gdm_lte.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c index 0c33634..c4006f6 100644 --

Re: [PATCH 1/1] Drivers: base: memory: Export symbols for onlining memory blocks

2013-07-25 Thread Michal Hocko
On Wed 24-07-13 14:02:32, Dave Hansen wrote: > On 07/24/2013 12:45 PM, KY Srinivasan wrote: > > All I am saying is that I see two classes of failures: (a) Our > > inability to allocate memory to manage the memory that is being hot added > > and (b) Our inability to bring the hot added memory online

[PATCH 5/7] staging: gdm724x: Remove version.h header inclusion in gdm_tty.h

2013-07-25 Thread Sachin Kamat
version.h header inclusion is not necessary as detected by versioncheck. Signed-off-by: Sachin Kamat --- drivers/staging/gdm724x/gdm_tty.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_tty.h b/drivers/staging/gdm724x/gdm_tty.h index faeaa41..a75be1d 100644 --

[PATCH 3/7] staging: gdm724x: Remove version.h header inclusion in gdm_mux.c

2013-07-25 Thread Sachin Kamat
version.h header inclusion is not necessary as detected by versioncheck. Signed-off-by: Sachin Kamat --- drivers/staging/gdm724x/gdm_mux.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c index f570bc0..2e619d2 100644 --

[PATCH 2/7] staging: gdm724x: Remove version.h header inclusion in gdm_lte.h

2013-07-25 Thread Sachin Kamat
version.h header inclusion is not necessary as detected by versioncheck. Signed-off-by: Sachin Kamat --- drivers/staging/gdm724x/gdm_lte.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_lte.h b/drivers/staging/gdm724x/gdm_lte.h index 90c9d51..9287d31 100644 --

[PATCH 4/7] staging: gdm724x: Remove version.h header inclusion in gdm_tty.c

2013-07-25 Thread Sachin Kamat
version.h header inclusion is not necessary as detected by versioncheck. Signed-off-by: Sachin Kamat --- drivers/staging/gdm724x/gdm_tty.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c index 357daa8..912022b 100644 --

[PATCH 6/7] staging: gdm724x: Remove version.h header inclusion in gdm_usb.c

2013-07-25 Thread Sachin Kamat
version.h header inclusion is not necessary as detected by versioncheck. Signed-off-by: Sachin Kamat --- drivers/staging/gdm724x/gdm_usb.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c index 2e658f8..4b10f238 100644 -

[PATCH 7/7] staging: gdm724x: Remove version.h header inclusion in gdm_usb.h

2013-07-25 Thread Sachin Kamat
version.h header inclusion is not necessary as detected by versioncheck. Signed-off-by: Sachin Kamat --- drivers/staging/gdm724x/gdm_usb.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_usb.h b/drivers/staging/gdm724x/gdm_usb.h index 38f6537..e6486e7 100644 --

Re: [PATCH v4] staging: usbip: replace pr_warning() with dev_warn().

2013-07-25 Thread navin patidar
On Thu, Jul 25, 2013, Greg KH said: > On Thu, Jul 25, 2013 at 10:19:31AM +0530, navin patidar wrote: >> >> -pr_warning("Unable to start control thread\n"); >> >> +struct device *dev; >> >> + >> >> +if (ud->side == USBIP_STUB) >> >> +dev = &container_of(ud, stru

[PATCH 16/16] staging: lustre: obdclass: Remove duplicate header file inclusion

2013-07-25 Thread Sachin Kamat
Removed the header file included twice. Signed-off-by: Sachin Kamat --- .../lustre/lustre/obdclass/linux/linux-sysctl.c|1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysct

[PATCH 06/16] staging: lustre: linux-tcpip: Remove duplicate header file inclusion

2013-07-25 Thread Sachin Kamat
Removed the header files included twice. Signed-off-by: Sachin Kamat --- .../lustre/lustre/libcfs/linux/linux-tcpip.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-tcpip.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-tcpip.c i

[PATCH 03/16] staging: lustre: obd: Remove duplicate inclusion of header file

2013-07-25 Thread Sachin Kamat
Removed the header file included twice. Signed-off-by: Sachin Kamat --- drivers/staging/lustre/lustre/include/obd.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/include/obd.h b/drivers/staging/lustre/lustre/include/obd.h index 094eb96..0034664 100644 --- a

[PATCH 11/16] staging: lustre: Remove duplicate header file inclusion in rw26.c

2013-07-25 Thread Sachin Kamat
Removed the header files included twice. Signed-off-by: Sachin Kamat --- drivers/staging/lustre/lustre/llite/rw26.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/rw26.c b/drivers/staging/lustre/lustre/llite/rw26.c index 97088e6..256ee63 100644 ---

[PATCH 08/16] staging: lustre: Remove duplicate header file inclusion in llite_mmap.c

2013-07-25 Thread Sachin Kamat
Removed the header files included twice. Signed-off-by: Sachin Kamat --- drivers/staging/lustre/lustre/llite/llite_mmap.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/llite_mmap.c b/drivers/staging/lustre/lustre/llite/llite_mmap.c index a4061ee..b

Re: [PATCH v4] staging: usbip: replace pr_warning() with dev_warn().

2013-07-25 Thread Greg KH
On Thu, Jul 25, 2013 at 10:19:31AM +0530, navin patidar wrote: > >> -pr_warning("Unable to start control thread\n"); > >> +struct device *dev; > >> + > >> +if (ud->side == USBIP_STUB) > >> +dev = &container_of(ud, struct stub_device, ud)->udev->dev; > >> +

  1   2   >