Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue

> Thanks you all for suggestions. I'll try finding some other way. If the strings don't fit, you can just go over 80 characters. julia ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev

[PATCH] staging/lustre: lloop depends on BLOCK

From: Xiong Zhou Add a config option for llite/lloop in lustre driver, making it depends on BLOCK to fix this better: drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2: error: implicit declaration of function ‘unregister_blkdev' Also, remove the wrapper ll_unregister_blk

Re: [PATCH v2] staging/lustre: lloop depends on BLOCK

On Fri, Aug 02, 2013 at 10:20:28AM +0800, Xiong Zhou wrote: > > > On Wed, 31 Jul 2013, Greg Kroah-Hartman wrote: > > > On Wed, Jul 31, 2013 at 10:30:41AM +0800, Xiong Zhou wrote: > > > From: Xiong Zhou > > > > > > First version of this patch makes LUSTRE_FS depends on BLOCK. Second > > > vers

Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue

On Thursday 01 August 2013 10:27 AM, Jiany Wu wrote: I have the same idea with julia. It is more difficult to check the log if we use MACRO instead of the strings. If we search in the system log, according to the string, we will find out the macro first. later we also need to find out where the

Re: [PATCH v2] staging/lustre: lloop depends on BLOCK

On Wed, 31 Jul 2013, Greg Kroah-Hartman wrote: > On Wed, Jul 31, 2013 at 10:30:41AM +0800, Xiong Zhou wrote: > > From: Xiong Zhou > > > > First version of this patch makes LUSTRE_FS depends on BLOCK. Second > > version makes only lloop depends on BLOCK with a config option for this > > depend

Re: [PATCH] Staging: wlags49_h2: fixed 80 line character and white space issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pl tool

On Fri, 2013-08-02 at 06:28 +0800, Greg KH wrote: > On Thu, Aug 01, 2013 at 03:08:21PM -0700, Evan Ng wrote: > > Thanks for the reply, > > > > Being this is my first patch that I have submitted, I want to clarify a few > > things: > > > > My *corrected* subject should read something like this?

Re: [PATCH] Staging: wlags49_h2: fixed 80 line character and white space issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pl tool

On Thu, Aug 01, 2013 at 03:08:21PM -0700, Evan Ng wrote: > Thanks for the reply,  > > Being this is my first patch that I have submitted, I want to clarify a few > things: > > My *corrected* subject should read something like this?  > > "Subject: [PATCH] Staging: wlags49_h2: fixed 80 line charac

Re: [PATCH] Staging: wlags49_h2: fixed 80 line character and white space issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pl tool

On Wed, Jul 31, 2013 at 01:44:25PM -0700, Evan Ng wrote: > From: esn89 I need a real name here, odds are "esn89" isn't yours :) Also, look at the subject you created, it's not correct, you need to add a newline after a short description, followed by the longer description, for git to pick this u

Re: [PATCH] staging: dgnc - adds dgnc digi driver

On Thu, Aug 1, 2013 at 3:23 PM, Greg KH wrote: > On Thu, Aug 01, 2013 at 02:03:13PM -0400, lidza.lou...@gmail.com wrote: >> This patch adds the DGNC driver. This is a TTY Serial Port >> Driver for the Digi International Neo and Classic PCI based product >> line by Digi International

Re: [PATCH v2] staging/lustre: lloop depends on BLOCK

On 2013/08/01 2:45 AM, "Christoph Hellwig" wrote: >On Tue, Jul 30, 2013 at 08:29:51AM +0800, Xiong Zhou wrote: >> From: Xiong Zhou >> >> In the lustre client driver, lloop depends on BLOCK. Add an >> option for this dependence. Last version of this patch makes >> LUSTRE_FS depends on BLOCK. >>

Re: [PATCH] staging: dgnc - adds dgnc digi driver

On Thu, Aug 01, 2013 at 02:03:13PM -0400, lidza.lou...@gmail.com wrote: > This patch adds the DGNC driver. This is a TTY Serial Port > Driver for the Digi International Neo and Classic PCI based product > line by Digi International . > > Signed-off-by: Lidza Louina Looks goo

Re: [PATCH 2/6] staging: ozwpan: Mark string as const

On Thu, 2013-08-01 at 18:40 +0100, Rupesh Gujare wrote: > Make sure that we mark const string so that it does not get modified. [] > diff --git a/drivers/staging/ozwpan/ozproto.h > b/drivers/staging/ozwpan/ozproto.h [] > -void oz_binding_add(char *net_dev); > -void oz_binding_remove(char *net_dev)

[PATCH 5/6] staging: ozwpan: Increase farewell report size.

Farewell report size can be bigger than one byte, increase array size to accomodate maximum 32 bytes of farewell report. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozpd.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozpd.h b/drivers/s

[PATCH 6/6] staging: ozwpan: Set farewell report length.

Fixes a bug where we were not setting length field causing wrong report size to be copied. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozproto.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozproto.c index ec60286..0

[PATCH 3/6] staging: ozwpan: Use kernel strncmp function.

Use kernel's strncmp() function instead of defining same within driver. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozproto.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozproto.c in

[PATCH 4/6] staging: ozwpan: Drop oldest ISOC frame instead of dropping latest.

In case of ISOC transfer, if TX queue is full then we start dropping latest frame, instead we should drop oldest frame & add latest frame to TX queue. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozpd.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[PATCH 0/6] staging: ozwpan: Use Kernel API & Bug fixes

This patch series removes duplicate code, & replaces it with kernel library functions, and few bug fixes. Rupesh Gujare (6): staging: ozwpan: Use kernel list function for managing interface list. staging: ozwpan: Mark string as const staging: ozwpan: Use kernel strncmp function. stagin

[PATCH 1/6] staging: ozwpan: Use kernel list function for managing interface list.

Managing interface list, is easier if we use kernel list_* API than managing it on our own. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozproto.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/staging/ozwpan/ozproto.c b/d

[PATCH 2/6] staging: ozwpan: Mark string as const

Make sure that we mark const string so that it does not get modified. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozproto.c |6 +++--- drivers/staging/ozwpan/ozproto.h |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ozwpan/ozproto.c b/d

Re: [PATCH v2] staging/lustre: lloop depends on BLOCK

On Tue, Jul 30, 2013 at 08:29:51AM +0800, Xiong Zhou wrote: > From: Xiong Zhou > > In the lustre client driver, lloop depends on BLOCK. Add an > option for this dependence. Last version of this patch makes > LUSTRE_FS depends on BLOCK. > Remove unnecessary jdb head files which depends on BLOCK.

Re: [PATCH] staging: imx-drm: add missing MFD_SYSCON dependency for LDB

Am Donnerstag, den 01.08.2013, 09:32 +0900 schrieb Jingoo Han: > Added missing MFD_SYSCON dependency for LVDS display bridge > in order to fix the following link error. > > drivers/staging/imx-drm/imx-ldb.c:484: undefined reference to > `syscon_regmap_lookup_by_phandle' > > Signed-off-by: Jingoo

Re: [PATCH v2] staging/lustre: lloop depends on BLOCK

On Wed, Jul 31, 2013 at 10:30:41AM +0800, Xiong Zhou wrote: > From: Xiong Zhou > > First version of this patch makes LUSTRE_FS depends on BLOCK. Second > version makes only lloop depends on BLOCK with a config option for this > dependence, and remove unnecessary jdb header files which depends on

Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue

On Wed, Jul 31, 2013 at 10:26:15PM +0200, Julia Lawall wrote: > On Wed, 31 Jul 2013, Kumar Gaurav wrote: > > > Fixed String splitted into multiple line issue using macro > > I'm not an expert on this kind of style issue, but I prefer strings that > look like strings. > Yeah. This patch makes