We set this using:
devs_closed |= (0x1 bdev-minor)
Since 0x1 is an int then only the lower 32 bits are usable before we hit
a shift wrapping bug. There are some static checkers which complain
about this. I've silenced the warning by making devs_closed a 32 bit
number.
32 bits should
Smatch complains that there is a missing break statement here.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
This looks correct to me, but please double check.
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index 35251e7..03a0989
The error handling is messy and not in kernel style. On some paths it
frees mux_dev twice.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/staging/gdm724x/gdm_mux.c
b/drivers/staging/gdm724x/gdm_mux.c
index 9e217ff..5b1ef40 100644
---
map needs to be signed for the error handling to work. In the success
case then it holds a small non-negative value.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c
b/drivers/staging/imx-drm/ipu-v3/ipu-dc.c
index 59f03f9..21bf1c8
On Wed, Aug 21, 2013 at 11:30:08AM +0300, Dan Carpenter wrote:
map needs to be signed for the error handling to work. In the success
case then it holds a small non-negative value.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Acked-by: Sascha Hauer s.ha...@pengutronix.de
Sascha
On Wed, 21 Aug 2013, wei_w...@realsil.com.cn wrote:
From: Wei WANG wei_w...@realsil.com.cn
The default phase can meet most cards' requirement, but it is not the
optimal one. In some extreme situation, the rx phase point produced by
the following tuning process will drift quite a distance.
On 2013-08-21 09:28, Dan Carpenter wrote:
Smatch complains that there is a missing break statement here.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
This looks correct to me, but please double check.
diff --git a/drivers/staging/comedi/drivers/pcl812.c
On 2013-08-21 09:27, Dan Carpenter wrote:
We set this using:
devs_closed |= (0x1 bdev-minor)
Since 0x1 is an int then only the lower 32 bits are usable before we hit
a shift wrapping bug. There are some static checkers which complain
about this. I've silenced the warning by making
On 2013-08-21 11:44, Ian Abbott wrote:
On 2013-08-21 09:28, Dan Carpenter wrote:
Smatch complains that there is a missing break statement here.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
This looks correct to me, but please double check.
diff --git
On Wed, Aug 21, 2013 at 11:50:22AM +0100, Ian Abbott wrote:
On 2013-08-21 09:27, Dan Carpenter wrote:
We set this using:
devs_closed |= (0x1 bdev-minor)
Since 0x1 is an int then only the lower 32 bits are usable before we hit
a shift wrapping bug. There are some static checkers
On Wed, Aug 21, 2013 at 12:35:22PM +0100, Ian Abbott wrote:
Acked-by: Ian Abbott abbo...@mev.co.uk
Reviewed-by: Ian Abbott abbo...@mev.co.uk
(whichever is appropriate)
To me Acked-by is more emphatic. Since you're the maintainer it's
appropriate. I normally use Reviewed-by because I
This patch removes trailing whitespace in
the dgnc_driver.c file.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_driver.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
This patch removes trailing whitespace in
the dpacompat.h file.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dpacompat.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dpacompat.h b/drivers/staging/dgnc/dpacompat.h
This patch removes trailing whitespace in
the dgnc_cls.c file.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_cls.c | 48 -
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.c
This patch removes trailing whitespace in
the dgnc_tty.c file.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_tty.c | 178
1 file changed, 89 insertions(+), 89 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c
This patch removes trailing whitespace in
the kcompat.h file.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_kcompat.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_kcompat.h
This patch removes trailing whitespace in
the sysfs.c file.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_sysfs.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
This patch removes trailing whitespace in
the digi.h file.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/digi.h | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/dgnc/digi.h
This patch removes trailing whitespace in
the dgnc_mgmt.c file.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_mgmt.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_mgmt.c
This patch removes trailing whitespace in
the dgnc_trace.c file.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_trace.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_trace.c
This patch removes trailing whitespace in
the neo.h file.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_neo.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
This patch fixes the error code indent should use
tabs where possible in dgnc_neo.c.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_neo.c | 46 -
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git
This patch fixes the error code indent should use
tabs where possible in dgnc_driver.c.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_driver.c | 70 +++---
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git
This patch removes the code supporting CVS
from its files.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_cls.c| 2 --
drivers/staging/dgnc/dgnc_driver.c | 2 --
drivers/staging/dgnc/dgnc_mgmt.c | 1 -
drivers/staging/dgnc/dgnc_neo.c| 2 --
This patch fixes the error: open brace '{'
following struct go on the same line.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_driver.h | 3 +--
drivers/staging/dgnc/digi.h| 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git
Hi Paul,
@@ -365,6 +366,7 @@ struct dwc2_hsotg {
u8 otg_port;
u32 *frame_list;
dma_addr_t frame_list_dma;
+ int next_sched_frame;
This variable is still not really used, I think. Most of the mentions in
the patch are assignments, except for these two:
+
Yes,
I added the next_sched_frame to track the next uframe that there is
anything to do in the periodic schedule. The SOF interrupt is then
disabled until that uframe (although the FIQ still runs each uframe to
decide whether to trigger the USB interrupt)
Gordon
On 21/08/2013 22:24, Matthijs
This patch fixes this error: invalid type
argument of ‘-’ (have ‘struct ktermios’).
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgap/dgap_tty.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git
The declaration for the ioctl function has changed. The previous version
of this declaration took struct file *file as a parameter and the new
one does not. This patch removes that parameter.
It also removes cases for the commands TIOCGETP
TCGETS and TCGETA.
Signed-off-by: Lidza Louina
This patch removes the unused variable page
in mgmt.c.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgap/dgap_mgmt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap_mgmt.c b/drivers/staging/dgap/dgap_mgmt.c
index 1147f1d..dce33d4 100644
---
This patch fixes the error: incompatible types
when assigning to type ‘struct ktermios *’ from
type ‘struct ktermios’
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgap/dgap_fep5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This patch removes references to proc code in this
driver. It still has proc.c, proc.h and a board
state called NEEDS_PROC_CREATION. All three of
these will be removed in another patch.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgap/Makefile | 2 +-
This patch adds the dgap driver to the kernel build process.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/Kconfig | 2 +-
drivers/staging/Makefile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
This patch fixes the error: incompatible types when
assigning to type ‘struct ktermios *’ from type
‘struct ktermios’
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgap/dgap_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Wed, Aug 21, 2013 at 09:48:31PM -0400, Lidza Louina wrote:
From: Scott_Kilau at digi dot com
I need a real email address, no at or dot please.
I'll edit it by hand this time, but in the future, please don't do that.
thanks,
greg k-h
___
devel
This patch removes the HAVE_UNLOCKED_IOCTL conditional
statements from driver.c, mgmt.c and mgmt.h. This was
used to support older kernels. It isn't needed now.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgap/dgap_driver.c | 4
drivers/staging/dgap/dgap_mgmt.c
This commit adds files hal/odm_RTL8188E.c, hal/odm_RegConfig8188E.c,
hal/rtl8188e_cmd.c, and hal/rtl8188e_dm.c.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 399 +++
drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 130
This commit adds files os_dep/usb_intf.c, os_dep/usb_ops_linux.c,
and os_dep/xmit_linux.c.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 892 +++
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 288
This commit adds files include/autoconf.h, include/basic_types.h,
include/cmd_osdep.h, include/drv_types.h, include/drv_types_linux.h,
include/ethernet.h. include/h2clbk.h, include/hal_com.h, and include/hal_intf.h.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
This commit adds files include/rtw_security.h, include/rtw_sreset.h,
include/rtw_version.h, and include/rtw_xmit.h.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/include/rtw_security.h | 383 ++
This commit adds files hal/HalHWImg8188E_BB.c, hal/HalHWImg8188E_MAC.c,
hal/HalHWImg8188E_RF.c, and
hal/hal_com.c.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/hal/HalHWImg8188E_BB.c | 721 ++
The configuration options include those to add code needed for
AP mode, and peer-to-peer mode.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/Kconfig | 2 ++
drivers/staging/rtl8188eu/Kconfig | 29 +
2 files changed, 31
This patch fixes errors with the tty function calls
tty_buffer_request_room, tty_insert_flip_string_flags,
tty_insert_flip_string and tty_flip_buffer_push.
They now take struct tty_port as a parameter instead
of tty_struct.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
43 matches
Mail list logo