Include version.h header file as detected by versioncheck.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8188eu/include/usb_ops.h |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/include/usb_ops.h
Removed the header files included twice.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
Buffer depth of 50 units is not sufficient when there is considerable delay
occuring on air due to interference, increase ISOC IN buffer depth to 100 units.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozhcd.c |2 +-
1 file changed, 1 insertion(+), 1
Incorrect error number was returned here (EPERM), ENXIO is more
appropriate.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozcdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozcdev.c
Return error if we receive write(), while PD is not connected.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozcdev.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c
index
On 08/28/2013 12:35 AM, Sachin Kamat wrote:
Include version.h header file as detected by versioncheck.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8188eu/os_dep/xmit_linux.c |1 +
1 file changed, 1 insertion(+)
diff --git
Fixed 3 instances of user-visible string being broken into two string.
Fixed 2 instances of illegal whitespace.
---
drivers/staging/crystalhd/crystalhd_cmds.c |3 +--
drivers/staging/crystalhd/crystalhd_hw.c |7 +++
drivers/staging/crystalhd/crystalhd_lnx.c |3 +--
3 files
Consolidate the boilerplate code used to mask and set the output channels
of DIO and DO subdevices.
H Hartley Sweeten (11):
staging: comedi: core: introduce comedi_dio_insn_bits()
staging: comedi: skel: use comedi_dio_insn_bits()
staging: comedi: usbdux drivers: use comedi_dio_insn_bits()
Convert this driver to use the comedi_dio_insn_bits() helper function.
Tidy up the comments to reflect the new code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use comedi_dio_insn_bits() to handle the boilerplate code to update
the subdevice s-state.
These drivers always need to update the hardware in order to update
the i/o configuration regardless of if the state has changed.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian
Use comedi_dio_insn_bits() to handle the boilerplate code to update
the subdevice s-state for DIO and DO subdevices.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Make sure only the state of the channels configured as outputs is updated
by comedi_dio_insn_bits().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers.c | 2 +-
1
Use comedi_dio_insn_bits() to handle the boilerplate code to update
the subdevice s-state for DIO subdevices.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use the subdevice 'state' to hold the digital output state instead
of carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adq12b.c | 9
Use comedi_dio_insn_bits() to handle the boilerplate code to update
the subdevice s-state.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ssv_dnp.c | 51
Use comedi_dio_insn_bits() to handle the boilerplate code to update
the subdevice s-state.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adq12b.c | 22
The (*insn_bits) functions for DIO and DO subdevices typically use
the subdevice 's-state' to hold the current state of the output
channels. The 'insn' passed to these functions, INSN_BITS, specifies
two parameters passed in the 'data'.
data[0] = 'mask', the channels to update
data[1] =
Rename the register map defines to better describe the hardware.
Add defines for the control register bits that enable the irq and
change the direction of the data register. This gets rid of the
magic numbers.
Remove PARPORT_SIZE, it's only used when requesting the i/o region
with
Use the subdevice s-state to hold the current state of the data register
outputs instead of carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This is the (*insn_config) function for a DIO subdevice. It should be
using the data[0] value as the instruction to perform on the subdevice.
Use the comedi_dio_insn_config() helper to properly handle instructions.
Also, rename the function to better describe it's use.
Signed-off-by: H Hartley
Rename this function to better describe it's use.
Use comedi_dio_insn_bits() to handle the boilerplate code to update
the subdevice s-state.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The enabled state of the interrupt can be checked by reading the control
register.
Remove 'enabled_irq' from the private data.
Since the private data is now empty, remove it completely and remove the
allocation of it in parport_attach().
Signed-off-by: H Hartley Sweeten
Interrupt support in this driver is optional. Don't fail the attach of the
board if the request_irq() fails.
Only allocate and setup the subdevice for the interrupt if the request_irq()
was successful.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Add some whitespace to tidy up the subdevice init.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/comedi_parport.c | 64 +
1 file changed,
For aesthetic reasons, reorder the #include list.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/comedi_parport.c | 3 ++-
1 file changed, 2 insertions(+), 1
Tidy up the multi-line comments to follow the CodingStyle.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/comedi_parport.c | 136 +++-
1 file
Use the dev-read_subdev to get the comedi_subdevice instead of accessing
the dev-subdevices array directly.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
For aesthetic reasons, rename this function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/comedi_parport.c | 9 +
1 file changed, 5 insertions(+), 4
The current code would attempt to negotiate a different protocol version if
the current negotiation timed out. This triggers an assert in the host (on debug
builds). Avoid this by negotiating a newer version only if the host properly
rejects the current version being negotiated.
Signed-off-by: K.
Use the core provided helper function instead of duplicating it as
a private function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmad.c | 8 +---
1 file
On Wed, Aug 28, 2013 at 10:35:46AM +0530, Sachin Kamat wrote:
Include version.h header file as detected by versioncheck.
Cc: Lidza Louina lidza.lou...@gmail.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/dgap/dgap_kcompat.h |2 ++
1 file changed, 2
On Wed, Aug 28, 2013 at 12:57 AM, Greg KH gre...@linuxfoundation.org wrote:
On Tue, Aug 27, 2013 at 10:13:28PM -0400, Lidza Louina wrote:
This patch removes the dgnc_driver_kzmalloc function from
driver.c and driver.h. A previous patch replaced all
dgnc_driver_kzmalloc function calls with
On Wed, Aug 28, 2013 at 6:34 PM, Lidza Louina lidza.lou...@gmail.com wrote:
On Wed, Aug 28, 2013 at 12:57 AM, Greg KH gre...@linuxfoundation.org wrote:
On Tue, Aug 27, 2013 at 10:13:28PM -0400, Lidza Louina wrote:
This patch removes the dgnc_driver_kzmalloc function from
driver.c and driver.h.
On Wed, Aug 28, 2013 at 06:50:44PM -0400, Lidza Louina wrote:
On Wed, Aug 28, 2013 at 6:34 PM, Lidza Louina lidza.lou...@gmail.com wrote:
On Wed, Aug 28, 2013 at 12:57 AM, Greg KH gre...@linuxfoundation.org
wrote:
On Tue, Aug 27, 2013 at 10:13:28PM -0400, Lidza Louina wrote:
This patch
Rename this function to better describe it's use.
Tidy it up to follow the normal comedi (*insn_bits) for DI subdevices.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use the new comedi_dio_insn_bits() and comedi_dio_insn_config() helpers
to tidy up the digital subdevices in this driver.
Remove the need for the kzalloc'd private data.
H Hartley Sweeten (15):
staging: comedi: comedi_parport: tidy up the register map
staging: comedi: comedi_parport: remove
The control register for the parallel port is readable so there is no need
to cache the current value in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use the core provided helper function instead of duplicating it as
a private function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_labpc.c | 10 ++
1
On Wed, Aug 28, 2013 at 12:54 AM, Greg KH gre...@linuxfoundation.org wrote:
I'll take this for now, but all of these casts of the kzalloc() call
need to go away, as they are pointless (kzalloc() returns a void *,
which automatically can be assigned to any pointer type, no need to be
explicit
On Wed, Aug 28, 2013 at 4:30 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Tue, Aug 27, 2013 at 10:13:27PM -0400, Lidza Louina wrote:
@@ -501,7 +501,7 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
/* get the board structure and prep it */
brd =
On 29 August 2013 03:45, Greg KH gre...@linuxfoundation.org wrote:
On Wed, Aug 28, 2013 at 10:35:46AM +0530, Sachin Kamat wrote:
Include version.h header file as detected by versioncheck.
Cc: Lidza Louina lidza.lou...@gmail.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
41 matches
Mail list logo
