[PATCH staging] Staging: Convert uses of compare_ether_addr to ether_addr_equal

2013-09-01 Thread Joe Perches
Preliminary to removing compare_ether_addr altogether: Use the new bool function ether_addr_equal to add some clarity and reduce the likelihood for misuse of compare_ether_addr for sorting. Additionally: Used is_zero_ether_addr, removed now unused variable Converted uses of foo[0] to foo Done

Re: [staging] Staging: Convert uses of compare_ether_addr to ether_addr_equal

2013-09-01 Thread Wang Shilong
Hello, Using checkpatch.pl, i get the following warnings(errors): WARNING: Avoid CamelCase: pstats-bHwError #124: FILE: drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1875: +(!pstats-bHwError) (!pstats-bCRC) (!pstats-bICV)); WARNING: Avoid CamelCase: pstats-bCRC #124: FILE:

[PATCH staging-next] staging: vt6655: Remove commented out block with compare_ether_addr

2013-09-01 Thread Joe Perches
compare_ether_addr is being removed so remove even the commented out code referring to it. Signed-off-by: Joe Perches j...@perches.com --- drivers/staging/vt6655/vntwifi.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/staging/vt6655/vntwifi.c

[PATCH 0/4] [media] Make lirc_bt829 a well-behaved PCI driver

2013-09-01 Thread Ben Hutchings
I noticed lirc_bt829 didn't have a module device ID table, so I set out to fix that and ended up with this series. It still appears to do everything else wrong (like reinventing i2c-algo-bit) though... This is compile-tested only. Ben. Ben Hutchings (4): [media] lirc_bt829: Make it a proper

[PATCH 1/4] [media] lirc_bt829: Make it a proper PCI driver

2013-09-01 Thread Ben Hutchings
Replace static variables with a device structure and pass pointers to this into all the functions that need it. Fold init_module(), do_pci_probe() and atir_init_start() into a single probe function. Use dev_err() to provide context for logging. This also fixes a device reference leak, as the

[PATCH 4/4] [media] lirc_bt829: Enable and disable memory BAR

2013-09-01 Thread Ben Hutchings
We must not assume that the PCI device is already enabled. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_bt829.c

[PATCH 3/4] [media] lirc_bt829: Fix iomap leak

2013-09-01 Thread Ben Hutchings
We must call iounmap() when removed from a device. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_bt829.c

[PATCH 2/4] [media] lirc_bt829: Fix physical address type

2013-09-01 Thread Ben Hutchings
Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_bt829.c b/drivers/staging/media/lirc/lirc_bt829.c index c277bf3..8c5ba2a 100644 ---

Re: [PATCH 2/4] [media] lirc_bt829: Fix physical address type

2013-09-01 Thread Fabio Estevam
On Sun, Sep 1, 2013 at 9:39 PM, Ben Hutchings b...@decadent.org.uk wrote: pci_addr_phys = pdev-resource[0].start; - dev_info(pdev-dev, memory at 0x%08X\n, -(unsigned int)pci_addr_phys); + dev_info(pdev-dev, memory at 0x%08llX\n, +(unsigned

Re: [PATCH 2/4] [media] lirc_bt829: Fix physical address type

2013-09-01 Thread Fabio Estevam
On Sun, Sep 1, 2013 at 10:41 PM, Ben Hutchings b...@decadent.org.uk wrote: On Sun, 2013-09-01 at 22:37 -0300, Fabio Estevam wrote: On Sun, Sep 1, 2013 at 9:39 PM, Ben Hutchings b...@decadent.org.uk wrote: pci_addr_phys = pdev-resource[0].start; - dev_info(pdev-dev, memory at