Re: [PATCH v2 net-next 0/9] set addr_assign_type when inheriting a dev_addr

2013-09-03 Thread Bjørn Mork
David Miller da...@davemloft.net writes: From: Bjørn Mork bj...@mork.no Date: Fri, 30 Aug 2013 18:08:43 +0200 Copying the dev_addr from a parent device is an operation common to a number of drivers. The addr_assign_type should be updated accordingly, either by reusing the value from the

Re: [PATCH 03/12] staging: dgnc: driver.h: adds struct dgnc_board

2013-09-03 Thread Lidza Louina
On Sun, Sep 1, 2013 at 8:07 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, Aug 31, 2013 at 06:19:11PM -0400, Lidza Louina wrote: This patch adds the dgnc_board struct to driver.h. This struct will replace board_t in this driver. So on this one patches 3, 4 and 5 should just be one

Re: [PATCH 06/12] staging: dgnc: removes kzalloc error statements

2013-09-03 Thread Lidza Louina
On Sun, Sep 1, 2013 at 8:14 PM, Dan Carpenter dan.carpen...@oracle.com wrote: The point I was trying to make earlier was that I don't like knee jerk error messages. Some people put an error message after every line without thinking about it. It's a very common source of bugs is to have a

Re: [PATCH 02/12] staging: dgnc: replaces generic struct from sizeof calls

2013-09-03 Thread Dan Carpenter
On Tue, Sep 03, 2013 at 01:26:05PM -0400, Lidza Louina wrote: And: memcpy(ch-ch_digi, new_digi, sizeof(struct digi_t)); becomes memcpy(ch-ch_digi, new_digi, sizeof(*ch-ch_digi)); Nope. ch-ch_digi is not a pointer so this will generate a compile error. That one should be:

[PATCH V2 1/1] X86: Hyper-V: Get the local APIC timer frequency from the hypervisor

2013-09-03 Thread K. Y. Srinivasan
Hyper-V supports a mechanism for retrieving the local APIC frequency.Use this and bypass the calibration code in the kernel. This would allow us to boot the Linux kernel as a modern VM on Hyper-V where many of the legacy devices (such as PIT) are not emulated. I would like to thank Olaf Hering

[PATCH V2 4/4] staging: et131x: Removing some unecessary braces

2013-09-03 Thread Mark Einon
Remove braces from a few single line if statements. Signed-off-by: Mark Einon mark.ei...@gmail.com --- Fair enough Dan, I wouldn't argue with that, I was eager to reduce lines. Removing those multi-line changes... drivers/staging/et131x/et131x.c | 12 +--- 1 file changed, 5

Re: [PATCH v2 net-next 0/9] set addr_assign_type when inheriting a dev_addr

2013-09-03 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Tue, 03 Sep 2013 09:38:10 +0200 But it doesn't look like it ended up in net-next? Or am I missing something (again)? I forgot to push it out from my workstation before going away for the holiday weekend, this has now been fixed :-)