Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-11 Thread Jürgen Beisert
On Tuesday 10 September 2013 22:54:44 Dan Carpenter wrote: On Tue, Sep 10, 2013 at 09:36:14AM +0200, Jürgen Beisert wrote: This patch seems to combine two things -- register access rework AND adjustment of the driver for MX23 touchscreen. It reworks the register access to avoid the

[PATCH 1/6] Staging/iio/adc/touchscreen/MXS: distinguish i.MX23's and i.MX28's LRADC

2013-09-11 Thread Juergen Beisert
The LRADC units in i.MX23 and i.MX28 differ and we need to distinguish both SoC variants in order to make the touchscreen work on i.MX23 Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC:

[PATCH 4/6] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC touchscreen driver

2013-09-11 Thread Juergen Beisert
Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least for the 4 wire touchscreen. Note: support for the remaining LRADC channels is not tested on an i.MX23 yet. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC:

[RFCv4] staging/iio/adc: change the MXS touchscreen driver implementation

2013-09-11 Thread Juergen Beisert
The following series replaces the current busy loop touchscreen implementation for i.MX28/i.MX23 SoCs by a fully interrupt driven implementation. Since i.MX23 and i.Mx28 silicon differs, the existing implementation can be used for the i.MX28 SoC only. So, the first two patches of this series

[PATCH 6/6] Staging/iio/adc/touchscreen/MXS: Remove old touchscreen detection implementation

2013-09-11 Thread Juergen Beisert
Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC: Jonathan Cameron ji...@cam.ac.uk --- drivers/staging/iio/adc/mxs-lradc.c | 165

Re: [HELP] mediabuttons drivers on MSI GE60 laptop

2013-09-11 Thread Dan Carpenter
On Wed, Sep 11, 2013 at 10:46:37AM +0700, Vadim A. Misbakh-Soloviov wrote: P.S. is it correct maillist for such help requests at all? :) You would probably have better luck asking on linux-in...@vger.kernel.org. Specify exactly which laptop you are using, btw. It may be a known thing. Also

Re: [PATCH] staging: dgnc: fix potential format string flaw

2013-09-11 Thread Joe Perches
On Tue, 2013-09-10 at 21:41 -0700, Kees Cook wrote: Make sure that format strings cannot leak into printk() calls from the msgbuf string. printf(string); vs printf(%s, string); How does this help? ___ devel mailing list

Re: [HELP] mediabuttons drivers on MSI GE60 laptop

2013-09-11 Thread Vadim A. Misbakh-Soloviov
Hi, Dan! 11.09.2013 15:30, Dan Carpenter пишет: On Wed, Sep 11, 2013 at 10:46:37AM +0700, Vadim A. Misbakh-Soloviov wrote: P.S. is it correct maillist for such help requests at all? :) You would probably have better luck asking on linux-in...@vger.kernel.org. Can I just add it as CC, or

[PATCH] Drivers: hv: vmbus: fix error return code in vmbus_connect()

2013-09-11 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -EINVAL in the version check error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/hv/connection.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [PATCH 3/4] staging: et131x: Whitespace changes, cat some spilt lines

2013-09-11 Thread Dan Carpenter
On Wed, Sep 11, 2013 at 01:29:49PM +0100, Mark Einon wrote: On Wed, Sep 04, 2013 at 12:19:16PM +0300, Dan Carpenter wrote: Sorry, this is still in my postponed messages folder. I meant to send it earlier. On Mon, Sep 02, 2013 at 10:23:21PM +0100, Mark Einon wrote: Ignoring checkpatch

[PATCH 1/4 RESEND] staging: et131x: Remove unused spinlock

2013-09-11 Thread Mark Einon
phy_lock is no longer used in any useful code, it's all been moved into a phy_device. Remove the lock definition and init. Signed-off-by: Mark Einon mark.ei...@gmail.com --- drivers/staging/et131x/et131x.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/et131x/et131x.c

[PATCH 4/4] staging: et131x: Add some items to the TODO list

2013-09-11 Thread Mark Einon
Adding some trivial formatting suggestions made by Dan Carpenter to the TODO. Signed-off-by: Mark Einon mark.ei...@gmail.com --- drivers/staging/et131x/README |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/et131x/README

[PATCH 2/4 RESEND] staging: et131x: Remove unused rcv_pend_lock spinlock

2013-09-11 Thread Mark Einon
The rcv_pend_lock spinlock isn't used anymore. remove it. Signed-off-by: Mark Einon mark.ei...@gmail.com --- drivers/staging/et131x/et131x.c |2 -- 1 file changed, 2 deletions(-) create mode 100644 drivers/staging/et131x/Module.symvers diff --git a/drivers/staging/et131x/Module.symvers

[PATCH 02/11] staging: usbip: Add support for client authentication

2013-09-11 Thread Dominik Paulus
This patch adds support for authenticating both client and server using a pre-shared passphrase using SRP (Secure Remote Password) over TLS (see RFC 5054) using GnuTLS. Both usbip and usbipd now accept a shared secret as a command line argument. Currently, the established TLS connection is only

[PATCH 11/11] staging: usbip: Increment version to 1.2.0

2013-09-11 Thread Dominik Paulus
Signed-off-by: Dominik Paulus dominik.pau...@fau.de Signed-off-by: Tobias Polzer tobias.pol...@fau.de --- drivers/staging/usbip/userspace/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/userspace/configure.ac

[PATCH 01/11] staging: usbip: Fix IPv6 support in usbipd

2013-09-11 Thread Dominik Paulus
getaddrinfo() leaves the order of the returned addrinfo structs unspecified. On systems with bindv6only disabled (this is the default), PF_INET6 sockets bind to IPv4, too. Thus, IPv6 support in usbipd was broken when getaddrinfo returned first IPv4 and then IPv6 addrinfos, as the IPv6 bind failed

[PATCH 10/11] staging: usbip: Separate protocol/program version

2013-09-11 Thread Dominik Paulus
Not all new program versions necessarily introduce non-backwards-compatible protocol changes. We thus move the definition of the protocol version from configure.ac to usbip_network.h, where it logically belongs to. Signed-off-by: Dominik Paulus dominik.pau...@fau.de Signed-off-by: Tobias Polzer

[PATCH 03/11] staging: usbip: Add kernel support for client ACLs

2013-09-11 Thread Dominik Paulus
This patch adds the possibility to stored ACLs for allowed clients for each stub device in sysfs. It adds a new sysfs entry called usbip_acl for each stub device, containing a list of CIDR masks of allowed clients. This file will be used by usbip and usbipd to store the ACL. Signed-off-by: Kurt

[PATCH 04/11] staging: usbip: Add CIDR matching helper functions

2013-09-11 Thread Dominik Paulus
This patch adds a few utility functions to match IP addresses against CIDR masks. Signed-off-by: Dominik Paulus dominik.pau...@fau.de Signed-off-by: Tobias Polzer tobias.pol...@fau.de --- drivers/staging/usbip/userspace/src/utils.c | 84 +

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-11 Thread Christoph Hellwig
On Wed, Sep 11, 2013 at 10:51:50AM +0800, Peng Tao wrote: I'm not fighting against removing the piece of code. But if there is a strong reason to keep the functionality, we need to find a way to implement it. The convenience of using environment variables is that job scheduler can set the

Re: [PATCH] staging: dgnc: fix potential format string flaw

2013-09-11 Thread Kees Cook
On Wed, Sep 11, 2013 at 12:09 PM, Joe Perches j...@perches.com wrote: On Wed, 2013-09-11 at 11:19 -0700, Kees Cook wrote: On Wed, Sep 11, 2013 at 2:31 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Sep 10, 2013 at 10:19:17PM -0700, Kees Cook wrote: In the former case, format

Re: [PATCH] staging: dgnc: fix potential format string flaw

2013-09-11 Thread Kees Cook
On Wed, Sep 11, 2013 at 12:22 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Wed, Sep 11, 2013 at 11:19:11AM -0700, Kees Cook wrote: On Wed, Sep 11, 2013 at 2:31 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Sep 10, 2013 at 10:19:17PM -0700, Kees Cook wrote: In the former

RE: [PATCH] Drivers: hv: vmbus: fix error return code in vmbus_connect()

2013-09-11 Thread KY Srinivasan
-Original Message- From: Wei Yongjun [mailto:weiyj...@gmail.com] Sent: Wednesday, September 11, 2013 4:20 AM To: KY Srinivasan; Haiyang Zhang Cc: yongjun_...@trendmicro.com.cn; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org Subject: [PATCH] Drivers: hv: vmbus: fix

Re: [PATCH] staging: speakup: kobjects.c: Use correct values when changing voice.

2013-09-11 Thread Samuel Thibault
Christopher Brannon, le Tue 10 Sep 2013 18:21:18 -0700, a écrit : When a new voice is selected, we set volume and pitch appropriate for the voice. We need to use the numeric index corresponding to the voice when indexing into the volume and pitch tables, rather than the raw user input that

[PATCH] Staging: lustre: fix formatting mistake in Kconfig

2013-09-11 Thread Jon Bernard
Signed-off-by: Jon Bernard jbern...@tuxion.com --- drivers/staging/lustre/lustre/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig index 4e898e4..f949728 100644 ---

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-11 Thread Dilger, Andreas
On 2013/09/11 10:29 AM, Christoph Hellwig h...@infradead.org wrote: Talking about nasty code, the whole linux-curproc.c is highly questionable: - cfs_curproc_groups_nr: unused and should be removed This is already removed in the upstream Lustre code, it just hasn't made it into the

Re: [PATCH] staging: lustre: clean up format string usages

2013-09-11 Thread Dilger, Andreas
On 2013/09/10 10:37 PM, Kees Cook keesc...@chromium.org wrote: This fixes up the usage of snprintf, strncpy, and format strings in the call to kthread_run to avoid ever accidentally allowing a format string into the thread name. Signed-off-by: Kees Cook keesc...@chromium.org No objection, though

Re: [PATCH] staging: dgnc: fix potential format string flaw

2013-09-11 Thread Joe Perches
On Wed, 2013-09-11 at 12:25 -0700, Kees Cook wrote: On Wed, Sep 11, 2013 at 12:09 PM, Joe Perches j...@perches.com wrote: On Wed, 2013-09-11 at 11:19 -0700, Kees Cook wrote: On Wed, Sep 11, 2013 at 2:31 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Sep 10, 2013 at 10:19:17PM

Re: [RFC PATCH] vsnprintf: Remove use of %n and convert existing uses

2013-09-11 Thread Kees Cook
On Wed, Sep 11, 2013 at 4:22 PM, Joe Perches j...@perches.com wrote: Using vsnprintf or its derivatives with %n can have security vulnerability implications. Prior to commit fef20d9c1380 (vsprintf: unify the format decoding layer for its 3 users), any use of %n was ignored. Reintroduce

[RFC PATCH] vsnprintf: Remove use of %n and convert existing uses

2013-09-11 Thread Joe Perches
Using vsnprintf or its derivatives with %n can have security vulnerability implications. Prior to commit fef20d9c1380 (vsprintf: unify the format decoding layer for its 3 users), any use of %n was ignored. Reintroduce this feature and convert the existing uses of %n to use the return length from

Re: [PATCH] Drivers: hv: vmbus: fix error return code in vmbus_connect()

2013-09-11 Thread Wei Yongjun
On 09/12/2013 04:03 AM, KY Srinivasan wrote: -Original Message- From: Wei Yongjun [mailto:weiyj...@gmail.com] Sent: Wednesday, September 11, 2013 4:20 AM To: KY Srinivasan; Haiyang Zhang Cc: yongjun_...@trendmicro.com.cn; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org

Re: [PATCH] Staging: fwserial: wrap a line that exceeds 80 characters

2013-09-11 Thread Peter Hurley
On 09/10/2013 06:00 PM, Jon Bernard wrote: This is a patch to fwserial.c that wraps a line which previously exceeded the 80 character limit warning found by checkpatch.pl. This driver is now warning and error free, according to checkpatch.pl Signed-off-by: Jon Bernard jbern...@tuxion.com Ok

RE: [PATCH] Drivers: hv: vmbus: fix error return code in vmbus_connect()

2013-09-11 Thread KY Srinivasan
-Original Message- From: Wei Yongjun [mailto:weiyj...@gmail.com] Sent: Wednesday, September 11, 2013 5:26 PM To: KY Srinivasan Cc: Haiyang Zhang; yongjun_...@trendmicro.com.cn; de...@linuxdriverproject.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH] Drivers: hv: vmbus: fix

Re: [RFC PATCH] vsnprintf: Remove use of %n and convert existing uses

2013-09-11 Thread Al Viro
On Wed, Sep 11, 2013 at 05:04:17PM -0700, Joe Perches wrote: On Thu, 2013-09-12 at 08:40 +0900, Tetsuo Handa wrote: Joe Perches wrote: - seq_printf(m, %s%d%n, con-name, con-index, len); + len = seq_printf(m, %s%d, con-name, con-index); Isn't len always 0 or -1 ? Right. Well

Re: [RFC PATCH] vsnprintf: Remove use of %n and convert existing uses

2013-09-11 Thread Joe Perches
On Thu, 2013-09-12 at 01:19 +0100, Al Viro wrote: On Wed, Sep 11, 2013 at 05:04:17PM -0700, Joe Perches wrote: On Thu, 2013-09-12 at 08:40 +0900, Tetsuo Handa wrote: Joe Perches wrote: - seq_printf(m, %s%d%n, con-name, con-index, len); + len = seq_printf(m, %s%d,