On Fri, Sep 20, 2013 at 04:45:08PM +0200, Iker Pedrosa wrote:
On Tue, 17 Sep 2013 12:43:26 +0300
Dan Carpenter dan.carpen...@oracle.com wrote:
On Tue, Sep 17, 2013 at 02:29:22PM +0530, Adil Mujeeb wrote:
Hi,
- PowerData = (1 31) | (0 30) | (24 24) |
Need use 'ccflags-y' instead of EXTRA_CFLAGS, or compiling issue will
be occurred with EXTRA_CFLAGS=-W.
Also can reference scripts/checkpatch.pl (1755..1766) to know about it.
Signed-off-by: Chen Gang gang.c...@asianux.com
---
drivers/staging/dgap/Makefile |2 +-
1 files changed, 1
On Sat, Sep 21, 2013 at 07:12:36PM +0800, Chen Gang wrote:
Need use 'ccflags-y' instead of EXTRA_CFLAGS, or compiling issue will
be occurred with EXTRA_CFLAGS=-W.
Just add it to drivers/staging/dgap/dgap_driver.c and delete it from the
Makefile.
regards,
dan carpenter
On 09/21/2013 07:22 PM, Dan Carpenter wrote:
On Sat, Sep 21, 2013 at 07:12:36PM +0800, Chen Gang wrote:
Need use 'ccflags-y' instead of EXTRA_CFLAGS, or compiling issue will
be occurred with EXTRA_CFLAGS=-W.
Just add it to drivers/staging/dgap/dgap_driver.c and delete it from the
Makefile.
The device tree list has moved, so I've changed the cc.
Few comments inline. Basically I'd go for longer more
descriptive names when the abreviation isn't a really
well known common one.
Note I'm not all that familiar with device tree conventions
so may be barking up the wrong tree ;)
On
Normally, the macros from command line are system specific macros (e.g
__linux, __KERNEL__ ...), and module own macros are usually defined in
their header files.
DG_NAME and DG_PART are driver 'dgap' owned macros which are used by
multiple files within driver, and need be defined in the driver
The function cmpk_message_handle_tx() is called only in r8192U_dm.c in two
places. The first call resides outside an #ifdef RTL8192U guard, and since
RTL8192U is defined this call can be removed. At the other site this function
is called, there is no check on its return value. Since
This patch removes the unused code inside #ifdef RTL8190P header guard,
since RTL8190P is not defined.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/staging/rtl8192u/r8190_rtl8256.h | 4
1 file changed, 4 deletions(-)
diff --git
This patch removes the unused code that resides inside #ifdef RTL8190P since
RTL8190P is not defined.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/staging/rtl8192u/r819xU_firmware.c | 15 ---
1 file changed, 15 deletions(-)
diff --git
This patch removes the unused code that resides inside #ifdef RTL8190P
header guard since RTL8190P is not defined.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 137 +++
1 file changed, 12 insertions(+), 125
This patch removes the code that resides outside #ifdef RTL8192U,
since RTL8192U is defined in r8192U.h and removes, also, the header
guard itself.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/staging/rtl8192u/r819xU_firmware.c | 6 --
1 file changed, 6 deletions(-)
This patch removes #ifdef RTL8192U header guard and the code that falls
outside it, since RTL8192U is defined.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/staging/rtl8192u/r8192U.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U.h
The file r819xU_cmdpkt.c includes header r8192U.h which defines RTL8192U.
This patch removes from cmpk_message_handle_tx() the part of the code that
is never used because it resides outside the header guard #ifdef RTL8192U.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
This patch removes #ifdef RTL8192U header guards from r8192U_dm.c, since
RTL8192U is defined in the included r8192U.h header.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 4
1 file changed, 4 deletions(-)
diff --git
This patch removes dm_check_rfctrl_gpio() because it does nothing when
RTL8192U is defined.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 42
1 file changed, 42 deletions(-)
diff --git
This patch removes #ifndef RTL8190P header guard since RTL8190P is not
defined anywhere in rtl8192u code.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.c
This patch removes the unused code inside #ifndef RTL8192U header guard
and the guard itself, since RTL8192U is defined.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 8
1 file changed, 8 deletions(-)
diff --git
The variable execute_shutdown is only assigned the values true and
false. Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
The variable ownbit_flag is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
The variables bMultiBand and bKeyTableFull are only assigned the
values true and false. Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b =
The variable Trigger is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by:
On Sun, Sep 22, 2013 at 12:27:47AM +0200, Peter Senna Tschudin wrote:
The variable ownbit_flag is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
Mike,
We don't need to go through staging. If the dm-writeboost target is
designed well and provides a tangible benefit it doesn't need
wide-spread users as justification for going in. The users will come if
it is implemented well.
OK.
The benefit of introducing writeboost will be
23 matches
Mail list logo
