On Tue, Oct 01, 2013 at 01:21:28AM +, Paul Zimmerman wrote:
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Monday, September 30, 2013 6:09 PM
Yeah. I guess it's fine... I was going to suggest adding the + 1 in a
different place but actually it doesn't matter.
The
On Tue, Oct 01, 2013 at 10:05:17AM +0300, Dan Carpenter wrote:
On Tue, Oct 01, 2013 at 01:21:28AM +, Paul Zimmerman wrote:
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Monday, September 30, 2013 6:09 PM
Yeah. I guess it's fine... I was going to suggest adding the
On Tue, Oct 01, 2013 at 09:51:07AM +0200, Matthijs Kooijman wrote:
On Tue, Oct 01, 2013 at 10:05:17AM +0300, Dan Carpenter wrote:
On Tue, Oct 01, 2013 at 01:21:28AM +, Paul Zimmerman wrote:
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Monday, September 30, 2013 6:09
On 10/01/13 10:28, Jürgen Beisert wrote:
Hi Jonathan,
On Tuesday 01 October 2013 11:25:46 Jonathan Cameron wrote:
a couple of the patch descriptions say that they are untested on i.MX28.
On Monday 23 September 2013 16:36:35 Juergen Beisert wrote:
For battery driven systems it is a very
On 09/23/13 15:36, Juergen Beisert wrote:
The LRADC units in i.MX23 and i.MX28 differ and we need to distinguish both
SoC variants in order to make the touchscreen work on i.MX23
Signed-off-by: Juergen Beisert j...@pengutronix.de
CC: linux-arm-ker...@lists.infradead.org
CC:
On 09/23/13 15:36, Juergen Beisert wrote:
Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least
for the 4 wire touchscreen.
Note: support for the remaining LRADC channels is not tested on an
i.MX23 yet.
Signed-off-by: Juergen Beisert j...@pengutronix.de
CC:
On 09/23/13 15:36, Juergen Beisert wrote:
Replace the individual register access by a few shared access function to
make the
code easier to read and in order to add the i.MX23 SoC in the next step.
Signed-off-by: Juergen Beisert j...@pengutronix.de
CC: linux-arm-ker...@lists.infradead.org
On 09/23/13 15:36, Juergen Beisert wrote:
This is an RFC for the new touchscreen properties.
Signed-off-by: Juergen Beisert j...@pengutronix.de
CC: linux-arm-ker...@lists.infradead.org
CC: linux-in...@vger.kernel.org
CC: de...@driverdev.osuosl.org
CC: Marek Vasut ma...@denx.de
CC: Fabio
On 09/23/13 15:36, Juergen Beisert wrote:
Some things have still to be done to the LRADC driver.
Signed-off-by: Juergen Beisert j...@pengutronix.de
CC: linux-arm-ker...@lists.infradead.org
CC: linux-in...@vger.kernel.org
CC: de...@driverdev.osuosl.org
CC: Marek Vasut ma...@denx.de
CC:
On 10/01/13 12:14, Jonathan Cameron wrote:
On 09/23/13 15:36, Juergen Beisert wrote:
Some things have still to be done to the LRADC driver.
Signed-off-by: Juergen Beisert j...@pengutronix.de
CC: linux-arm-ker...@lists.infradead.org
CC: linux-in...@vger.kernel.org
CC:
On 10/01/13 12:21, Jonathan Cameron wrote:
On 10/01/13 12:14, Jonathan Cameron wrote:
On 09/23/13 15:36, Juergen Beisert wrote:
Some things have still to be done to the LRADC driver.
Signed-off-by: Juergen Beisert j...@pengutronix.de
CC: linux-arm-ker...@lists.infradead.org
CC:
On 2013-10-01 01:55, H Hartley Sweeten wrote:
Each analog output channel is individually configurable. The current
analog output 'range_table' selection in this driver assumes that all
the channels are configured as either bipolar or unipolar. User option[2]
is then used during the attach to
Hi Dinh,
Somehow I assumed that was fixed by the hardware, but I see now that you
are right. Yes, making the definition larger is better than moving the
+ 1.
This was my original fix to the problem, but I thought that it would
be confusing when reading the code. I also thought about the +1
Dear Jonathan Cameron,
I'm looking for some Tested-by: or Acks on this before applying the series.
I got the impression from the comments on the previous version that the
series has now been reasonably thoroughly tested on both i.MX28 and i.MX23
boards. This is not yet reflected in the sign
Hi Matthijs,
On 10/1/13 6:08 AM, Matthijs Kooijman wrote:
Hi Dinh,
Somehow I assumed that was fixed by the hardware, but I see now that you
are right. Yes, making the definition larger is better than moving the
+ 1.
This was my original fix to the problem, but I thought that it would
be
Hi Matthijs,
On 10/1/13 6:08 AM, Matthijs Kooijman wrote:
Hi Dinh,
Somehow I assumed that was fixed by the hardware, but I see now that you
are right. Yes, making the definition larger is better than moving the
+ 1.
This was my original fix to the problem, but I thought that it would
be
On Tue, Oct 01, 2013 at 06:26:29AM -0500, Dinh Nguyen wrote:
[resend]: previous reply didn't include Matthijs
He sets his Mail-Followup-To: so that we don't CC him on replies. I
assume it's deliberate because he only wants the copy from the mailing
list?
regards,
dan carpenter
Hey Dan, Dinh,
[resend]: previous reply didn't include Matthijs
He sets his Mail-Followup-To: so that we don't CC him on replies. I
assume it's deliberate because he only wants the copy from the mailing
list?
Exactly, I just set that for whatever mailing list I subscribe to.
However,
Resolve all of the 'WARNING: space prohibited before semicolon'
checkpatch warnings for rtl8712.
Signed-off-by: Thomas Cort linuxg...@gmail.com
---
drivers/staging/rtl8712/os_intfs.c| 2 +-
drivers/staging/rtl8712/rtl8712_cmd.c | 4 ++--
This patch removes this smatch warning:
unsigned '--un-un_open_count' is never less than zero
The code decremented the un_open_count variable
and tested to see if it was less than zero. Because
un_open_count is unsigned and can't be below zero,
this test didn't work.
Signed-off-by: Lidza Louina
This patch adds error handling to the
tty_driver allocations in dgap_tty_register.
Now the code handles the possibility of an
alloc_tty_driver, a tty_register_driver, and
a brd-SerialDriver-ttys or brd-PrintDriver-ttys
allocation failure.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
Hi,
Just wondering if anyone tried using a webcam with the DWC2 driver? The
webcam works great when plugged in directly to the USB port, but appears
to have alot of dropped frames when used with a HS hub.
I'll debug it of course, but just wondering if anyone has had a similar
experience?
On Tue, Oct 01, 2013 at 12:00:23PM -0400, Lidza Louina wrote:
@@ -306,7 +316,16 @@ int dgap_tty_register(struct board_t *brd)
DPR_INIT((DGAP REGISTER TTY: MAJORS: %d %d\n,
brd-SerialDriver-major,
brd-PrintDriver-major));
-
You need a return 0; here otherwise we
This patch removes this smatch warning:
unsigned '--un-un_open_count' is never less than zero
The code decremented the un_open_count variable
and tested to see if it was less than zero. Because
un_open_count is unsigned and can't be below zero,
this test didn't work.
Signed-off-by: Lidza Louina
This patch adds error handling to the
tty_driver allocations in dgap_tty_register.
Now the code handles the possibility of an
alloc_tty_driver, a tty_register_driver, and
a brd-SerialDriver-ttys or brd-PrintDriver-ttys
allocation failure.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
On Mon, Sep 30, 2013 at 9:46 PM, Greg KH gre...@linuxfoundation.org wrote:
On Fri, Sep 27, 2013 at 07:11:47AM -0400, Lidza Louina wrote:
On Fri, Sep 27, 2013 at 5:50 AM, Sachin Kamat sachin.ka...@linaro.org
wrote:
This check is not required.
Signed-off-by: Sachin Kamat
On Tuesday, October 01, 2013 3:27 AM, Ian Abbott wrote:
On 2013-10-01 01:55, H Hartley Sweeten wrote:
Each analog output channel is individually configurable. The current
analog output 'range_table' selection in this driver assumes that all
the channels are configured as either bipolar or
On Tue, Oct 01, 2013 at 12:32:06PM -0400, Lidza Louina wrote:
On Tue, Oct 1, 2013 at 12:09 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Tue, Oct 01, 2013 at 12:00:23PM -0400, Lidza Louina wrote:
@@ -306,7 +316,16 @@ int dgap_tty_register(struct board_t *brd)
DPR_INIT((DGAP
On Tue, Oct 01, 2013 at 12:54:21PM -0400, Lidza Louina wrote:
This patch removes this smatch warning:
unsigned '--un-un_open_count' is never less than zero
The code decremented the un_open_count variable
and tested to see if it was less than zero. Because
un_open_count is unsigned and can't
Delete redudant flags parameter.
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
drivers/staging/octeon-usb/cvmx-usb.c | 6 ++
drivers/staging/octeon-usb/cvmx-usb.h | 4 +---
drivers/staging/octeon-usb/octeon-hcd.c | 1 -
3 files changed, 3 insertions(+), 8 deletions(-)
diff --git
Make comments to fit into 80 columns.
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
drivers/staging/octeon-usb/cvmx-usb.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.h
b/drivers/staging/octeon-usb/cvmx-usb.h
Hi,
Some cleanups for octeon-usb. No functional changes. Tested on EdgeRouter
Lite + USB mass storage.
Aaro Koskinen (12):
staging: octeon-usb: delete redundant flags from cvmx_usb_initialize()
staging: octeon-usb: delete cvmx_usb_isochronous_flags
staging: octeon-usb: delete redundant
Eliminate CVMX_PREFETCH_PREF0.
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
drivers/staging/octeon-usb/cvmx-usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.c
b/drivers/staging/octeon-usb/cvmx-usb.c
index c5e680d..d53daf7
Inline CVMX_PREFETCH0 macro.
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
drivers/staging/octeon-usb/cvmx-usb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.c
b/drivers/staging/octeon-usb/cvmx-usb.c
index c57e798..b827e8d
Replace CVMX_CLZ macro with __fls().
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
drivers/staging/octeon-usb/cvmx-usb.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.c
b/drivers/staging/octeon-usb/cvmx-usb.c
index
Delete unused macro.
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
drivers/staging/octeon-usb/cvmx-usb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.c
b/drivers/staging/octeon-usb/cvmx-usb.c
index b827e8d..c5e680d 100644
---
Delete redundant flags parameter.
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
drivers/staging/octeon-usb/cvmx-usb.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.c
b/drivers/staging/octeon-usb/cvmx-usb.c
index f9a6801..54b5c5c 100644
---
Cleanup another comedi driver.
H Hartley Sweeten (22):
staging: comedi: ni_6527: remove DRIVER_NAME define
staging: comedi: ni_6527: remove unused NI6527_*_SIZE defines
staging: comedi: ni_6527: remove unused DEBUG* defines
staging: comedi: ni_6527: remove extra probe noise
staging:
These defines are not used in the driver. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_6527.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
To clarify the digital input subdevice (*insn_config) a bit, factor out the
code that sets the filter interval for deglitching the digital inputs.
Also, rename the CamelCase define used for the filter interval registers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian
The dev_info() showing the board id is just extra noise.
Remove it but make sure the probed id is correct. Rename the CamelCase
define used for the id register.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
To clarify the digital input subdevice (*insn_config) a bit, factor out the
code that sets the filter enables to enable deglitching the digital inputs.
Also, rename the CamelCase define used for the filter enable registers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian
Rename the CamelCase defines used for the interrupt control register.
To clarify the code a bit, add two new defines to enable/disable the
interrupts.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
For aesthetics, use a local variable for the __iomem base address
used to write to the registers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_6527.c | 4 ++--
Handle the instruction (data[0]) with a switch to make it easier
to add additional instructions in the future.
To clarify the code, factor out the code that sets the rising/falling
edge detection.
Rename the CamelCase defines used for the rising/falling edge detection
registers.
Signed-off-by:
The COMEDI_MITE driver is a wrapper for the National Instruments
PCI MITE ASIC. This driver includes the PCI boilerplate used to
remap the resources as well as the support code for bus mastered
DMA.
The ni_6527 does not support DMA and the COMEDI_MITE driver adds
unnecessary complexity.
Remove
Factor the board reset code out of the (*attach). Do the reset as
soon as possible to ensure the interrupts are disabled.
For convienence, use the ni6257_reset() during the (*detach) instead
of just disabling the interrupts.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian
For aesthetics, add some whitespace.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_6527.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
On 10/1/13 4:42 PM, Matthijs Kooijman wrote:
The hardware offers a 4-bit register containing the number of host
channels. However, the values of these register mean 1-16 host channels,
not 0-15. Since the dwc2_hw_params struct stores the actual number of
host channels supported instead of the
Fixed a lot of warnings from checkpatch.pl about the 80 characters per line
limitation.
Signed-off-by: Mathieu Rhéaume math...@codingrhemes.com
---
drivers/staging/android/binder.c | 520 ++-
1 file changed, 353 insertions(+), 167 deletions(-)
diff --git
Do the request_irq() before setting up the subdevices. Only initialize
the interrupt subdevice if the irq is actually available.
Tidy up the whitespace in the subdevice init.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Tidy up the multi-line comments to follow the CodingStyle.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_6527.c | 61
1 file
The comedi_subdevice in the interrupt handler is the dev-read_subdev
that was initialized during the attach. Use that instead of accessing
the dev-subdevices[] array directly.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
On Tue, 2013-10-01 at 21:39 -0400, Mathieu Rhéaume wrote:
Fixed a lot of warnings from checkpatch.pl about the 80 characters per line
limitation.
I'd prefer
s/binder_user_error/binder_user_err/
or
s/binder_user_error/binder_err/
without doing the strange wrapping
checkpatch
On Tue, Oct 01, 2013 at 06:46:44PM -0700, Joe Perches wrote:
On Tue, 2013-10-01 at 21:39 -0400, Mathieu Rhéaume wrote:
Fixed a lot of warnings from checkpatch.pl about the 80 characters per line
limitation.
I'd prefer
s/binder_user_error/binder_user_err/
or
Changes since v2:
* Fixed the indent in the method calls that had too many tab.
8--8
This patch changes seq_printf for seq_puts in binder.c.
It fixes the warnings emitted by checkpatch.pl.
Signed-off-by: Mathieu Rhéaume
56 matches
Mail list logo
