Re: [PATCH 05/11] Staging: bcm: Replace ULONG with unsigned long in Adapter.h

2013-10-27 Thread Dan Carpenter
On Sat, Oct 26, 2013 at 02:15:14AM -0400, Kevin McKinney wrote: > This patch replace "ULONG" with "unsigned > long" in Adapter.h > > Signed-off-by: Kevin McKinney > --- > drivers/staging/bcm/Adapter.h | 42 > - > 1 file changed, 21 insertions(+), 21 del

Re: [PATCH 04/11] Staging: bcm: Replace UCHAR with unsigned char in Adapter.h

2013-10-27 Thread Dan Carpenter
On Sat, Oct 26, 2013 at 02:15:13AM -0400, Kevin McKinney wrote: > This patch replace "UCHAR" with "unsigned > char" in Adapter.h I feel like these should pretty much all be u8 instead of "unsigned char". regards, dan carpenter ___ devel mailing list de

Re: [PATCH 2/2] Staging: vt6656: fix code indenting error in power.c

2013-10-27 Thread Greg Kroah-Hartman
On Thu, Oct 24, 2013 at 07:26:47AM +0200, Johannes Löthberg wrote: > This patch fixes a code indentation error found by checkpatch.pl > where a line was indented with spaces instead of tabs > > Signed-off-by: Johannes Löthberg > --- > drivers/staging/vt6656/power.c | 2 +- > 1 file changed, 1 in

[PATCH] staging:ktap:loader.c fix coding style

2013-10-27 Thread Gokulnath A
fixed the errors and warnings generated by checkpatch.pl script. Signed-off-by: Gokulnath A --- drivers/staging/ktap/interpreter/loader.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/staging/ktap/interpreter/loader.c b/drivers/staging/

[PATCH] staging:ktap:ktap.c: fix coding style

2013-10-27 Thread Gokulnath A
fixed the errors and warnings found by checkpatch.pl script. Signed-off-by: Gokulnath A --- drivers/staging/ktap/interpreter/ktap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ktap/interpreter/ktap.c b/drivers/staging/ktap/interpreter/ktap.c index 18d8

Re: [PATCH 1/3] staging: lustre: lnet: Remove unnecessary spaces in lib-lnet.h

2013-10-27 Thread Lisa Nguyen
On Sat, Oct 26, 2013 at 8:37 PM, Greg KH wrote: > On Fri, Oct 25, 2013 at 01:22:52PM -0700, Lisa Nguyen wrote: >> Remove spaces between function names and open parentheses to >> meet kernel coding style and eliminate extra space warnings >> generated by checkpatch.pl >> >> Signed-off-by: Lisa Nguy

Re: [PATCH 1/4] staging: lustre: Remove typedef and update cfs_hash_bucket struct

2013-10-27 Thread Lisa Nguyen
On Sat, Oct 26, 2013 at 8:36 PM, Greg KH wrote: > On Fri, Oct 25, 2013 at 01:20:18PM -0700, Lisa Nguyen wrote: >> Remove typedef keyword and rename the cfs_hash_bucket_t struct to >> cfs_hash_bucket in libcfs_hash.h. These changes resolve the >> "Do not add new typedefs" warning generated by check

[PATCH] staging:ktap:ktap.c: fix coding style

2013-10-27 Thread Gokulnath A
fixed the errors and warnings found by checkpatch.pl script. Signed-off-by: Gokulnath A --- drivers/staging/ktap/interpreter/ktap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ktap/interpreter/ktap.c b/drivers/staging/ktap/interpreter/ktap.c index 18d8

Re: [PATCH] staging:ktap:loader.c fix coding style

2013-10-27 Thread Greg KH
On Mon, Oct 28, 2013 at 12:43:04AM +0530, Gokulnath A wrote: > fixed the errors and warnings generated by > checkpatch.pl script. > > Signed-off-by: Gokulnath A > --- > drivers/staging/ktap/interpreter/loader.c | 27 +-- > 1 file changed, 13 insertions(+), 14 deletions(-)

[PATCH 2/2 v2] Staging: vt6656: fix code indenting error in power.c

2013-10-27 Thread Johannes Löthberg
This patch fixes a code indentation error found by checkpatch.pl where a line was indented with spaces instead of tabs Signed-off-by: Johannes Löthberg --- drivers/staging/vt6656/power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/power.c b/drivers/

Re: [PATCH 04/11] Staging: bcm: Replace UCHAR with unsigned char in Adapter.h

2013-10-27 Thread Kevin McKinney
On Sun, Oct 27, 2013 at 11:25:55AM +0300, Dan Carpenter wrote: > On Sat, Oct 26, 2013 at 02:15:13AM -0400, Kevin McKinney wrote: > > This patch replace "UCHAR" with "unsigned > > char" in Adapter.h > > I feel like these should pretty much all be u8 instead of "unsigned > char". Yeah, I thought ab

[PATCH] staging: lustre: lnet: Rewrite return statement in socklnd.c

2013-10-27 Thread Lisa Nguyen
Rewrite the return statement in socklnd.c to eliminate the use of a ternary operator. This will prevent the checkpatch.pl script from generating a warning saying to remove () from this particular return statement. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c

Re: [PATCH] staging:ktap:loader.c fix coding style

2013-10-27 Thread Jovi Zhangwei
On Mon, Oct 28, 2013 at 4:58 AM, Greg KH wrote: > On Mon, Oct 28, 2013 at 12:43:04AM +0530, Gokulnath A wrote: >> fixed the errors and warnings generated by >> checkpatch.pl script. >> >> Signed-off-by: Gokulnath A >> --- >> drivers/staging/ktap/interpreter/loader.c | 27 +---

[PATCH 2/2] staging: Add NULL checks against return values of skb_clone() and dev_alloc_skb()

2013-10-27 Thread RUC_SoftSec
When there is no enough memory, functions skb_clone() and dev_alloc_skb() may return NULL pointers, they should be checked against NULL before used. This bug is found by a static analysis tool developed by RUC_SoftSec, supported by China.X.Orion. Signed-off-by: RUC_SoftSec --- drivers/staging/

Re: [PATCH 2/2] staging: Add NULL checks against return values of skb_clone() and dev_alloc_skb()

2013-10-27 Thread Greg Kroah-Hartman
On Mon, Oct 28, 2013 at 11:00:32AM +0800, RUC_SoftSec wrote: > When there is no enough memory, functions skb_clone() and dev_alloc_skb() may > return NULL pointers, they should be checked against NULL before used. > This bug is found by a static analysis tool developed by RUC_SoftSec, > supported

[PATCH 1/1] staging: Add NULL checks to return value of skb_clone() and dev_alloc_skb()

2013-10-27 Thread RUC_SoftSec
Function skb_clone() and dev_alloc_skb() may return NULL pointers if there is no enough memroy, their return values should be checked against NULL before used. This bug is found by a static tool developed by RUC_SoftSec, supported by China.X.Orion. Signed-off-by: RUC_SoftSec --- drivers/stagi

[PATCH 1/1] staging: check return value of dev_alloc_skb() against NULL

2013-10-27 Thread RUC_SoftSec
Function dev_alloc_skb() may return a NULL pointer if there is no enough memory, it should be checked against NULL before used. This bug is found by a static analysis tool developed by RUC_SoftSec, supported by China.X.Orion. Signed-off-by: RUC_SoftSec --- drivers/staging/rtl8192u/r819xU_firmw

[PATCH 1/1] staging: Add a NULL check to return value of dev_alloc_skb()

2013-10-27 Thread RUC_SoftSec
Function dev_alloc_skb() may return a NULL pointer when there is no enough memory, its return value should be checked before used. This bug is found by a static analysis tool developed by RUC_SoftSec, supported by China.X.Orion. Signed-off-by: RUC_SoftSec --- .../staging/rtl8192e/rtl8192e/r819

Re: [PATCH v4 1/2] Staging: zram: Fix variable dereferenced before check

2013-10-27 Thread Minchan Kim
Hello Rashika, On Fri, Oct 25, 2013 at 7:10 PM, Minchan Kim wrote: > Hello Rashika, > > First of all, thanks for looking this! > > On Tue, Oct 22, 2013 at 07:00:57PM +0530, Rashika Kheria wrote: >> This patch fixes the following Smatch warning in zram_drv.c- >> drivers/staging/zram/zram_drv.c:66

[PATCH] staging: sb105x: Remove unneeded semicolon in sb_pci_mp.c

2013-10-27 Thread Lisa Nguyen
Remove unneeded semicolon in sb_pci_mp.c to meet kernel coding style. Signed-off-by: Lisa Nguyen --- drivers/staging/sb105x/sb_pci_mp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sb105x/sb_pci_mp.c b/drivers/staging/sb105x/sb_pci_mp.c index bc53b4e..11c0