Re: [PATCH v2] drivers: staging: speakup: serialio: only use platform specific SERIAL_PORT_DFNS.

2013-11-02 Thread Samuel Thibault
Chen Gang, le Thu 31 Oct 2013 15:27:37 +0800, a écrit : > If SERIAL_PORT_DFNS isn't present by platform, it need be defined to > "nothing", like the 8250 serial driver does it. > > All related macros also need be removed: IRQF_SHARED is defined in > "linux/interrupt.h", others will be defined when

Re: [PATCH v2] drivers: staging: speakup: serialio: only use platform specific SERIAL_PORT_DFNS.

2013-11-02 Thread Chen Gang
On 11/02/2013 05:26 PM, Samuel Thibault wrote: > Chen Gang, le Thu 31 Oct 2013 15:27:37 +0800, a �crit : >> > If SERIAL_PORT_DFNS isn't present by platform, it need be defined to >> > "nothing", like the 8250 serial driver does it. >> > >> > All related macros also need be removed: IRQF_SHARED is

Re: [kconfig] update: results of some syntactical checks

2013-11-02 Thread Paul Bolle
On Sun, 2013-10-20 at 00:03 +0200, Martin Walch wrote: > drivers/media/common/siano/Kconfig:21-26 > > config SMS_SIANO_DEBUGFS > > bool "Enable debugfs for smsdvb" > > depends on SMS_SIANO_MDTV > > depends on DEBUG_FS > > depends on SMS_USB_DRV > > depends on CONFIG_SMS_USB_DRV

Re: [kconfig] update: results of some syntactical checks

2013-11-02 Thread Mauro Carvalho Chehab
Em Sat, 02 Nov 2013 20:20:54 +0100 Paul Bolle escreveu: > On Sun, 2013-10-20 at 00:03 +0200, Martin Walch wrote: > > drivers/media/common/siano/Kconfig:21-26 > > > config SMS_SIANO_DEBUGFS > > > bool "Enable debugfs for smsdvb" > > > depends on SMS_SIANO_MDTV > > > depends on DEBUG_FS > > >

Re: [kconfig] update: results of some syntactical checks

2013-11-02 Thread Paul Bolle
On Sat, 2013-11-02 at 17:40 -0200, Mauro Carvalho Chehab wrote: > Em Sat, 02 Nov 2013 20:20:54 +0100 > Paul Bolle escreveu: > > Those are obvious typos. Still present in v3.12-rc7. Perhaps you'd like > > to send the trivial patch to fix this? > > Yes, it is a typo... > > > > Probably, it was mea

[PATCH] Staging: ft1000: fixed coding style issues

2013-11-02 Thread Aldo Iljazi
Fixed a few coding style issues that checkpatch reported. Specifically: 1. line over 80 characters issue on the lines 9 and 10. 2. space prohibited before open square bracket '[' issue on the lines 31. 3. iserted space after comma on lines to 156 Signed-off-by: Aldo Iljazi --- drivers/staging/

[PATCH] Staging: ft1000: fixed coding style issues

2013-11-02 Thread Aldo Iljazi
Fixed a few coding style issues that checkpatch reported. Specifically: 1. line over 80 characters issue on the lines 9 and 10. 2. space prohibited before open square bracket '[' issue on the lines 31. 3. inserted space after comma on lines 32 to 156. Signed-off-by: Aldo Iljazi --- drivers/sta

[PATCH] Staging: ft1000: fixed coding style issues

2013-11-02 Thread Aldo Iljazi
Fixed a few coding style issues that checkpatch reported. Specifically: 1. line over 80 characters issue on the lines 9 and 10. 2. space prohibited before open square bracket '[' issue on the lines 30 to 155. Signed-off-by: Aldo Iljazi --- drivers/staging/ft1000/ft1000-pcmcia/boot.h | 263

Re: [PATCH] Staging: ft1000: fixed coding style issues

2013-11-02 Thread Aldo Iljazi
Aldo Iljazi wrote: > Fixed a few coding style issues that checkpatch reported. > > Specifically: > > 1. line over 80 characters issue on the lines 9 and 10. > 2. space prohibited before open square bracket '[' issue on the lines > 31. > 3. inserted space after comma on lines 32 to 156. > > Sig

Re: [PATCH] memstick: fix unreachable state in h_msb_read_page() in ms_block.c

2013-11-02 Thread Maxim Levitsky
On Wed, 2013-10-30 at 15:54 +0800, rogera...@realtek.com wrote: > From: Roger Tseng > > In h_msb_read_page() in ms_block.c, flow never reaches case > MSB_RP_RECIVE_STATUS_REG. This causes error when MEMSTICK_INT_ERR is > encountered and status error bits are going to be examined, but the status

Re: [PATCH] Staging: ft1000: fixed coding style issues

2013-11-02 Thread Dan Carpenter
On Sat, Nov 02, 2013 at 11:18:20PM +0200, Aldo Iljazi wrote: > Aldo Iljazi wrote: > > > Fixed a few coding style issues that checkpatch reported. > > > > Specifically: > > > > 1. line over 80 characters issue on the lines 9 and 10. > > 2. space prohibited before open square bracket '[' issue on