Re: [PATCH] net:drivers/net: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

2013-11-07 Thread David Miller
From: Duan Jiong duanj.f...@cn.fujitsu.com Date: Wed, 6 Nov 2013 15:58:13 +0800 This patch fixes coccinelle error regarding usage of IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO. Signed-off-by: Duan Jiong duanj.f...@cn.fujitsu.com Applied. ___

Re: [PATCH] smsc: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

2013-11-07 Thread David Miller
From: Duan Jiong duanj.f...@cn.fujitsu.com Date: Wed, 6 Nov 2013 15:57:17 +0800 This patch fixes coccinelle error regarding usage of IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO. Signed-off-by: Duan Jiong duanj.f...@cn.fujitsu.com Applied. ___

[patch] Staging: comedi: pcl730: fix some bitwise vs logical AND bugs

2013-11-07 Thread Dan Carpenter
These conditions are never true because they use bitwise AND instead of logical ands. Fixes: b3ff824a81e8 ('staging: comedi: drivers: use comedi_dio_update_state() for complex cases') Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/staging/comedi/drivers/pcl730.c

Re: [patch] Staging: comedi: pcl730: fix some bitwise vs logical AND bugs

2013-11-07 Thread Ian Abbott
On 2013-11-07 08:13, Dan Carpenter wrote: These conditions are never true because they use bitwise AND instead of logical ands. Fixes: b3ff824a81e8 ('staging: comedi: drivers: use comedi_dio_update_state() for complex cases') Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git

Re: [PATCH 3/3] vme_user: Remove superfluous bus module parameter

2013-11-07 Thread Aaron Sierra
From: Martyn Welch martyn.we...@ge.com This patch removes the bus parameter since its primary function in practice is to prevent the driver from registering itself with the VME subsystem entirely unless some (any) value is passed via the parameter. The bus module parameter seems to be

Re: [PATCH 3/3] vme_user: Remove superfluous bus module parameter

2013-11-07 Thread Martyn Welch
On 07/11/13 15:25, Aaron Sierra wrote: From: Martyn Welch martyn.we...@ge.com This patch removes the bus parameter since its primary function in practice is to prevent the driver from registering itself with the VME subsystem entirely unless some (any) value is passed via the parameter. The

[PATCH 2/2] Staging: silicom: Remove unnecessary variable from get_bypass_info()

2013-11-07 Thread Rupert Muchembled
Remove unnecessary variable ioctl from get_bypass_info(). As a consequence, this patch removes an assignment to ioctl in an if condition, reported by checkpatch.pl. Signed-off-by: Rupert Muchembled rup...@rmuch.net --- drivers/staging/silicom/bypasslib/bypass.c | 8 1 file changed, 4

[PATCH 1/2] Staging: silicom: Remove unnecessary variable from do_cmd()

2013-11-07 Thread Rupert Muchembled
Remove unnecessary variable ioctl from do_cmd(). As a consequence, this patch removes an assignment to ioctl in an if condition, reported by checkpatch.pl. Signed-off-by: Rupert Muchembled rup...@rmuch.net --- drivers/staging/silicom/bypasslib/bypass.c | 6 +++--- 1 file changed, 3